GitLab

This CL standardizes the kSelection accessibility event for all the
omnibox popup auxiliary buttons.

This also gives the Header collapse button this accessibility event.

Bug: 1078183, 1052522
Change-Id: Ia56b2e15b47c299bb55f74aa16bb1648b47b322c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240298Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777555}

It can take 2-3 minutes to scan a single page at high DPI.  Extend the
timeout to 3 minutes for the specific ScanImage call so that these
requests can complete.

Bug: b:158504381
Test: Scanned a page at 1200 dpi
Change-Id: If7e20f88779059e7b46a56107568bd0cd4b32244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240261Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Benjamin Gordon <bmgordon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777554}

Change-Id: Iefe8522f0aae153dcd896bd4f8334b856370fb70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228056Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777553}

Makes it clear that |kUnspecified| means CookieStoreGetOptions.matchType
is missing.


Bug: 839389
Change-Id: I71a94e7b41a8bbfb12aa64ef9b0e5c0e0a844791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210180Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777552}

This reverts commit 6eda333b.

Reason for revert: speculative to see if it caused http://crbug.com/1093939

Original change's description:
> Add MojoDedicatedThread field trial testing config
> 
> Bug: 1082761
> Change-Id: Ief2b018876f8cb2ad77495c7158db5c53fd8c206
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240407
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#777367}

TBR=rockot@google.com,asvitkine@chromium.org

Change-Id: I61c7c9ed5cd76e77e41f5b934587451e9eb78743
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1082761, 1093939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240908Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777551}

This CL expands
EventListenerMapTest.FilteredEventsOnlyGoToMatchingListeners to also
test that correct listener is fired.

Bug: None
Test: Internal test only cleanup.
Change-Id: Ic353f20aba30e6175e1fe3f524bff951c00d9c46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237988Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777550}

This CL also patches in crrev.com/c/2194176, which is a fix to the original CL.

This is a reland of 652185a0

Original change's description:
> Default enable QUIC in Cronet Android and IOS.
>
> This change introduces no API changes. But API documents need to be updated.
>
> Change-Id: Ibc347df79066de704c5be0683c5b658ba6e1896a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168553
> Commit-Queue: Renjie Tang <renjietang@chromium.org>
> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
> Reviewed-by: Misha Efimov <mef@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#765334}

Change-Id: I37f62746a35d634641febf16f29dfd1608b1e483
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235981Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777549}

A large portion of the UI is only present in the stand-alone PDF Viewer,
and not in Print Preview. This CL makes it such that only strings that
are used in each case are registered for $i18n{} replacements, as
opposed to always registering all of them.

Note that chrome.resourcesPrivate.getStrings() still returns
all of them, since there is no way currently to differentiate between
the two contexts.

Bug: 1091516
Change-Id: I6d12ef310dd74112cd9cc68216b260f0e2c0652e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240017
Commit-Queue: dpapad <dpapad@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777548}

All directional key handling is done via calls to Viewport methods.
Split this handling out of pdf_viewer.js and move it directly to
the viewport. This will also reduce duplicated code when pdf_viewer.js
is forked for Print Preview.

Change-Id: Ia318c3fe83c417b3db0e5f409e9dd200fa092019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238854
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777547}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Id00be11c422a1ff43b6a82d773f99c04aa0b21e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242214Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#777546}

This is a reland of http://crrev.com/c/2209630

Previously, in order to do a hit test for accessibility we'd
send an action to the renderer with the x,y coordinates, and
the renderer would fire an accessibility event on the matching
node.

It'd be more flexible if we had an API that could do a hit
test and call a callback function with the result. That
eliminates the need for keeping track of requests and matching
them up with events.

This patch refactors the way hit testing works so that a
hit testing request may contain a request for an accessibility
event to fire, or a callback function to call, or both.

Existing tests are extended to cover both mechanisms.

Tbr: estark@chromium.org, aleventhal@chromium.org
Bug: 1083834, 1091140
Change-Id: I17596f9a7a850e89d467bb450741865f75407f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233706
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777545}

It turns out that before this CL |SomeTemplate<SomeClass>* ptr_field|
would match the |non_free_standing_tag_type| matcher and therefore would
not get rewritten. :-(

Both the old |non_free_standing_tag_type| matcher, and the old
|hasUniqueTypeLoc| matcher were trying to prevent generating conflicting
replacements (i.e. separate edits of overlapping sections of a source
file).  This CL fixes this problem in a more direct way - by introducing
|overlapsOtherDeclsWithinRecordDecl| matcher for FieldDecls.  The new
matcher replaces both of the old matchers.

The new matcher is a more generic version of the old, removed
|hasUniqueTypeLoc| matcher.  The new matcher:
1) considers all Decls under a RecordDecl (not just FieldDecls)
2) looks for any SourceRange overlap (rather than just considering
   the starting SourceLocation of a field type)

Bug: 1069567
Change-Id: I6392aa84e9e808790be3d84d0ba3079d1cc4ddf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211054Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777544}

cryptotoken used to always get the raw U2F reply. It can do attestation
stripping itself and the dummy certificates that it creates duplicate
the transports from the real certificate.

However, when cryptotoken was rebased atop WebAuthn, the attestation
preference was translated into WebAuthn. Thus stripping happened at the
WebAuthn layer and there was no transport information to use. (Well,
there's the transports array in WebAuthn, but cryptotoken doesn't use
that.)

Thus, since that transition, transport information has been lost in the
non-direct case.

This change always requests direct attestation from the WebAuthn layer
and lets cryptotoken handle the stripping.

BUG=1094002

Change-Id: I7abc7c44c2e386aa97fd98e9d866384b0388adb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241466
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777543}

DumpWithoutCrashing can be correlated with long tasks (see
https://crbug.com/1092465). To make it easier to identify cases where
long tasks happen at the same time as DumpWithoutCrashing, this CL
adds a trace event in DumpWithoutCrashing.

DumpWithoutCrashing is usually invoked when an unexpected situation
occurs. It already causes a report to be uploaded to crash servers.
Therefore, in most performance analysis, traces that contain a
DumpWithoutCrashing event should be discarded. For now, we think it's
still valuable to upload traces that contain a DumpWithoutCrashing
event, as those could be used to diagnose a drop in the number of
traces uploaded or the absence of traces uploaded for a new trigger.

R=gab@chromium.org

Bug: 1092465
Change-Id: Ie1e2b947b476910738e802cdc85569ec4f3cc1a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239928Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777542}

This is a follow-up to this patch:
https://chromium-review.googlesource.com/c/chromium/src/+/2233709

Bug: 582750,1093785,1093780
Change-Id: I8940974cd474a48df7a2970e100caad6e3fab1fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242119Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777541}

The recent change to clear the selection after the user has opened
and closed the panel needs to check if the selection is invalid.
In that case there's no point in clearing the selection and might
clear the user's selection that we cannot handle (like long selections).

Also mark the change reason generated by closing for an invalid
selection.

BUG=1093271

Change-Id: I3c244227b2346b92e936807e5aea7f8f0bdb0d98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242118
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777540}

This fixes the drawinf freezing problem when the user navigates away
from Feed v2 page.

Bug: none
Change-Id: I2d14aa6eac0f03ff51c561ae34a65cdc011d664c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242200Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777539}

This fixes the issue with the loading favicon still appearing when the
group is collapsed.

Bug: 1018230
Change-Id: Ia985cb2fa5d83fdb886a2e3004e7d44909e522e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240450Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777538}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I712f6e244f3399e3b241eae0ac584418b6d315a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242198Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#777537}

NOTRY=true

Change-Id: Ib263b44be73614c7d78b0d52df8c417dae0e7c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242203
Auto-Submit: Katie Dektar <katie@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777536}

Change-Id: Ib3fc3bce00d1d8d457be52aa069c4c9b45114e23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240115
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777535}

<meta name=referrer> supports some unspecified behavior right now:
- it has an effect outside of <head>, which the HTML spec says it
shouldn't
- it parses the "content" attribute as a comma-separated list of
referrer policies (as if it were the value of a Referrer-Policy header),
which the HTML spec also says it shouldn't

In order to analyze whether we can possibly change this behavior---the
<meta name=referrer>, as a whole, is hugely widely used---we add some
more granular UseCounters to measure
(1) how often <meta name=referrer> is used outside of <head>
(2) how often <meta name=referrer>'s value contains multiple tokens (in
other words, how often it contains a comma).

Bug: 1093914, 1092930
Change-Id: Ifd7be938bca08fd5701c10fa45db2e8cf32f7087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241188
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777534}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36a4d5db981c..f512e8752bfc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC huangs@google.com,japhet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1087037,chromium:1091385
Tbr: huangs@google.com,japhet@google.com
Change-Id: I8f943815d267beae7ec73550c0b03d1d0234bff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241926Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#777533}

Bug: 1052476
Change-Id: I84517a018726155240ec17337ee5081fe6488065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089958
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777532}

The test was flaking because sometimes the renderer was not evaluating
the JS code used to block the blink thread until *after* we had already
sent the input event to the frame, and thus the hang detection never
kicked in.

Add explicit synchronization in JSBlocker so that the test thread can
wait until the blink thread is actually blocked before continuing.

Fixed: 1092707
Change-Id: Ib993b32ffc06b49c8015b6c248477ee91079c575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238866Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Auto-Submit: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777531}

https://android.googlesource.com/platform/external/perfetto.git/+log/526424e2cc47..6f714b101dfc

2020-06-11 fmayer@google.com Merge "Roll trace_to_text for heap_profile."
2020-06-11 rslawik@google.com Compute CPU mcycles from time_in_state

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:157216280
Tbr: perfetto-bugs@google.com
Test: Test: tools/diff_test_trace_processor.py
Change-Id: Ic99cb2438981e4f28e51f4f29c59b07c2a20e1c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241563Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#777530}

Generated by //tools/gn/roll_gn.py

https://gn.googlesource.com/gn/+log/d0a6f072..9a0496a7

    9a0496a7 Make data_deps in copy() targets work.
    fa40610a include the missing tuple deps in version.cc
    0ce25e39 [rust-project] switch cfgs to new list schema
    c7bbac32 Don't assert on gn builds without any target.
    d26b346f Specify deps format for actions
    317fdc1d Support specifying required Ninja version
    89483505 Fix incorrect check for expansion of {{bundle_root_dir}}
    981f46c6 Make simple build example runnable on macOS
    0a9affbe Update docs/reference.md
    b175fa5d Add Ihor Karavan to list of authors
    c494b98a Add Oleksandr Motsok to list of authors
    1a34e42d Fix a comment regarding --ide=json builder
    382f5ef9 Divide sources between targets and add include paths to them
    86df3084 Add support escape JSON string to stream for export compile commands
    db57fe08 Revert "Specify deps format for actions"
    d2f5e438 Add new build configuration variable to add an extension to build file names.
    7d9b8111 Specify deps format for actions
    2c801de7 Fixes typo in example
    f4545417 [rust-project] Only list direct dependencies, not transitive deps

TBR=hans

Bug: none
Change-Id: I861b1a83e54863d47b151e907b191bbedd383d44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241508Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777529}

This reverts commit 5bd1f98a.

Reason for revert: ChromeURLDataManagerTestWithWebUIReportOnlyTrustedTypesEnabled.NoTrustedTypesViolationInWebUIGroupA failing on bots (https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/89566)

Original change's description:
> Reland "Group tests of Trusted Types for WebUI"
> 
> This change groups tests of Trusted Types for WebUI into 20 WebUI pages
> per test to minimize the size of the file. This change also fixes a bug
> where `CallJavascriptFunction` might be called before allowing JS.
> See: crrev.com/c/2237534
> 
> Bug: 41905
> Change-Id: I2d99b16c9157d8287d777c9a723457d6d10e4304
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238998
> Reviewed-by: dpapad <dpapad@chromium.org>
> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#777412}

TBR=tommycli@chromium.org,dpapad@chromium.org,Jun.Kokatsu@microsoft.com

Change-Id: Idf900d20a6c1504ac1035fa35fd34b8508512484
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 41905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242372Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777528}

This patch moves the responsibility of creating the bottom sheet's
view to the controller. Glue shouldn't have to know implementation
details about the sheet. Instead, a root view, inflater, and callback
are passed in.

Bug: 1002277
Change-Id: I796f26e4a33b061ebcca9862f9bf19dea6d3aafc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238560
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777527}

The flaky test,
TabSelectionEditorTest.testTabSelectionEditorLayoutCanBeGarbageCollected
is reproduced locally, and noticed a longer timeout is
needed. This CL extends the time out by using the
CriteriaHelper.pollUiThread with
GarbageCollectionTestUtils.canBeGarbageCollected.

Change-Id: Id82312493e52601609ca4cbbd63bd68637f45373
Bug: 1075816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241345
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777526}

This CL updates the unscanned file reason to match the new values (see
bug) It also renames BinaryUploadService::Result::UNSUPPORTED_FILE_TYPE
to DLP_SCAN_UNSUPPORTED_FILE_TYPE, since that's the reason string we
will give. If we add unsupported file types for malware scanning, we'll
need a new BinaryUploadService::Result so that we can distinguish the
two cases.

Fixed: 1088143
Change-Id: Ifc8cdb4244e0f80b781b7dd922ed22226c125913
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236062
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777525}

We no longer need to composite for clipping because the clip can be
applied in the compositor via property trees.

Change-Id: I740cd8e7b247a7f8bcd98562daedaeef7f1efca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235638
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777524}

- Turned out that we can't enable LCD text with transformed
rasterization because the latter will cause translucent pixels along the
edges of the layer on which text may draw. This CL partly reverts
crrev.com/c/2229243 which enabled LCD text with transformed
rasterization.

- When enabling transformed rasterization, we need to not only set
contents_opaque to false, but also need to let RasterSource clear canvas
before drawing because of the translucent pixels at edges.

- Refactor to make contents_opaque() consistent in the main-thread and
impl-side.

Bug: 1077071
Change-Id: Ie08d8d7bdeb46fa6dcc16560369cfd3dfedd14a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238519Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777523}

This reverts commit 46da36e1.

Reason for revert: Still breaking 
HomeToOverviewNudgeControllerTest.NudgeHiddenDuringShowAnimation

Original change's description:
> wm: Reland improve cross fade animation.
> 
> Reland crrev.com/c/2224990, including a fix for failing builders and
> a fix with tablet screenshot related.
> 
> Speculative fix crrev.com/c/2218557 was not enough. I was able to repro
> locally and confirm this fix this time. It seems with certain build args
> we can get into a state where the CrossFadeObserver which observes window
> can be not animating, which is strange as the observer observes window
> and deletes itself on animation end.
> 
> It seems in that test and bot, it can happen perhaps OnWindowDestroying
> is called before the window starts animating, or some other edge case.
> In this case, make sure the window is deleted if not animating.
> 
> Test: none
> Bug: 1088169, 1088039
> Change-Id: Ibe035209e83400921f16cff2bb272a8e186934dc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224023
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#777446}

TBR=oshima@chromium.org,sammiequon@chromium.org

Change-Id: Ib273d1ba96dc26a68cd765917f649230a2bbc0d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1088169, 1088039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242218Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777522}

UKM privacy review: https://docs.google.com/document/d/1ARnhXk3M_hbsRWYjGRf3vg0XWoJkW1_rz0GfrQwdu5Q/edit?usp=sharing

Change-Id: I5529743c3961f28564bf85502391e6c6c592772b
Bug: 1093402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239968
Commit-Queue: Hongbo Song <hbsong@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777521}

This makes the format better match the internal representation.
There are now two distinct types:
. a type for matching anything.
. a type for matching the scheme, host and port.

BUG=1042771
TEST=AwOriginMatcherTest*

Change-Id: I15beac188beab06a977d25b7a58cec6491f0025a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240066Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777520}

This wires ThroughputTracker for metrics of apps grid pagination
animation and folder show/hide animation

Bug: 1021774
Change-Id: If731c8d21f6ffd7c75104d4fe75052ccf6909fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241343Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777519}

This was hit during tracing with:

  run_web_tests.py --enable-tracing='*,disabled-by-default-gpu.*'

Change-Id: I9f2a66f1f2b8279732c66e37793541a22397bff2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242197
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777518}

The VA-API video acceleration layer has the option to support Ozone
pixmaps. However the build system currently has it hardcoded for
Ozone GBM.

Since the layer only uses Ozone's public API, it shouldn't be tied to
a specific platform implementation.

Switch to just checking for `use_ozone` instead.

Test: Build media_unittests with use_ozone=true and ozone_platform_gbm=false
Bug: None
Change-Id: If76ef1c03da336b10a1ff7015edec55664dc81f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231811Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777517}

Prefer using value-based instead of unique_ptr-based APIs where it is
not too intrusive. Use the new representation to more efficiently
translate list and dictionary values (per the documented
recommendations). Replace CreateWithCopiedBuffer with construction from
a span.

base::PickleIterator was augmented with a span-of-bytes ReadData API, to
make this a little cleaner, since this is now preferred over a pair of a
const char* and length.

Bug: 646113
Change-Id: I6361bfffe65e2d84aa8d50390648bb7ac194f205
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241936Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777516}