- 27 Nov, 2018 40 commits
-
-
Shawn Gallea authored
Refactor zaura_shell and wl_output out of server.cc to isolate generic Wayland API implementations from ChromeOS specific ones. This will allow ChromeOS specific APIs to be conditionally compiled on builds that don't need them. This helps port EXO to Chromecast where Ash (ChromeOS' window manager) isn't present. Changes: * Move zaura_shell into its own file since this won't be compiled on Chromecast. * Move Output and WaylandDisplayObserver into their own files since these are shared between zaura_shell, wl_output and Server. * Move wl_output into its own file since all its dependencies have been refactored out of server.cc. Bug: 896710 Test: Run exo_unittests Change-Id: I51b42301b5b7fcf53b1879373a2b50db6e799dd1 Reviewed-on: https://chromium-review.googlesource.com/c/1328233Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#611410}
-
Jimmy Gong authored
- Adds vectors for both discovery and share callbacks. - Solves the race condition in which multiple dialogs of "Add Smb Share" would use a shared instance of each HostLocator. - If a SmbShareFinder::GatherSharesInNetwork call comes in when one is already running, the callbacks are stored and run when the original GatherSharesInNetwork call finishes. - Adds additional unit test to reflect on the changes. Bug: chromium:892287 Test: end-to-end Change-Id: I9551532dc08fd9338803786bdd89f0398f4ce7db Reviewed-on: https://chromium-review.googlesource.com/c/1336435Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#611409}
-
Jamie Madill authored
This adds a win-angle-rel try config to cr-buildbucket.cfg. It also adds dummy no-op builders to luci-scheduler.cfg. This will allow ANGLE to define a set of test distinct from the set of tests run on the GPU FYI bots. Bug: 822310 Change-Id: Ie42166d35ab01ddcce8d0ad637e02ba10629917d Reviewed-on: https://chromium-review.googlesource.com/c/1341216Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#611408}
-
Mounir Lamouri authored
The parameter isn't needed because the other object already carries the key system information. This CL extends the interface so the Blink object can get the key system from the implementation through it. This is needed to reduce the boilerplate in the Media Capabilities Encrypted Media implementation. Bug: 907909 Change-Id: If59a6fc0ef47292696b5538a70b7fd22fbf024ca Reviewed-on: https://chromium-review.googlesource.com/c/1348731 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611407}
-
mrefaat authored
Update TabModelWebStateListDelegate so it doesn't need TabModel object as there is no need to set parentModel for the tab anymore. Bug: 899839, 228575 Change-Id: I68ff2d4672423b36fbbb171d9f183f3506d39be5 Reviewed-on: https://chromium-review.googlesource.com/c/1320792 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#611406}
-
bsheedy authored
Enables VR tests on the standalone vega device on Oreo Phone Tester. These were tested to work locally several months ago, but new issues may have popped up in the meantime, so they are currently marked as experimental. Bug: 876946 Change-Id: Ib3d9054ef265d3290987e819043ddb9477ad32b4 Reviewed-on: https://chromium-review.googlesource.com/c/1347609Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#611405}
-
David Bokan authored
This will be used to allow a kill-switch for the feature post-launch as well as help debugging. Bug: 903263 Change-Id: Icaf0b9ea4f28f9abddfa67f88fc6759aca812ec3 Reviewed-on: https://chromium-review.googlesource.com/c/1349476Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611404}
-
Annie Sullivan authored
Change-Id: I506eacb30f4ca3180f175042aa3e442a728e9584 Reviewed-on: https://chromium-review.googlesource.com/c/1352517 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#611403}
-
Ken Rockot authored
This reverts commit 7fbb7857. Reason for revert: Persistent failures on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/ - see https://crbug.com/909021 Original change's description: > [LayoutNG] Support non-horizontal flows in Flexbox > > Meaning: column containers, ortho children, and non-horizontal > writing modes > > Bug: 845235 > Change-Id: Iba6525752d0c14a77bc9a13cc75a484cdf3a711d > Reviewed-on: https://chromium-review.googlesource.com/c/1332247 > Commit-Queue: David Grogan <dgrogan@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611268} TBR=cbiesinger@chromium.org,dgrogan@chromium.org Change-Id: Ib66afedb725af13acd85a298c4fd565f02b32019 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845235,909021 Reviewed-on: https://chromium-review.googlesource.com/c/1352670Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#611402}
-
Wai Hon Law authored
Create a new API for subscribing to notification or indication smartly based on the availability of both options. Note that notification has higher priority over indication. Bug: internal 118329438 Change-Id: I610477424e2e0a2877e41c3bfd4dd1493e02f8f7 Reviewed-on: https://chromium-review.googlesource.com/c/1352492Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Wai Hon Law <whhone@google.com> Cr-Commit-Position: refs/heads/master@{#611401}
-
Nektarios Paisios authored
This functionality is based on the Selection API draft specification and is already supported in Blink by other types of user initiated selection actions: https://w3c.github.io/selection-api/#selectstart-event Tests are in the following patch: https://chromium-review.googlesource.com/c/chromium/src/+/1350195/ R=dmazzoni@chromium.org Bug: 639340 Change-Id: I5a7793c71b02f2e92fafb7fb9731b6ebf288a412 Tested: with unit tests in another patch Reviewed-on: https://chromium-review.googlesource.com/c/1347214 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#611400}
-
Vikas Soni authored
Added android utility functions to export/import sync FD from/to a vulkan semaphore. Added unittests. Bug: 891060 Change-Id: I2fcac73018fe91afae0ac141fdd5e40244451b15 Reviewed-on: https://chromium-review.googlesource.com/c/1332608Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#611399}
-
rbpotter authored
This improves Web UI load times with Polymer 2 by 11-14%. Bug: 738611 Change-Id: I2bf47a8b72730d019772824f8af9359dad30b364 Reviewed-on: https://chromium-review.googlesource.com/c/1351421 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#611398}
-
Caleb Rouleau authored
This change should be committed right away per go/perfbot-sheriff since this is failing on the waterfall. r610618 didn't work since TYPED_TEST(ObserverListPerfTest, MAYBE_NotifyPerformance) { is preprocessed to something_MAYBE_NotifyPerformance So then the directive #define MAYBE_NotifyPerformance DISABLED_NotifyPerformance is not applied. This will fix both 908490 and 906686. Bug: 906686,908490 Change-Id: Ib2adc016fbef79bb889a076e452534f893fb09b5 Reviewed-on: https://chromium-review.googlesource.com/c/1352481Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#611397}
-
Peng Huang authored
RasterDecoder uses skia to do rendering, and skia can restore texure and sampler bindings by itself. So we don't need use ContextState to do it. Bug: 902904 Change-Id: I5ce2510b4616aab9087cd61bfbfb88368c6e34ab Reviewed-on: https://chromium-review.googlesource.com/c/1338159 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611396}
-
Jonathan Backer authored
SendResults can't be called on GpuMain thread or we crash. This CL calls it from display compositor thread after we've ensured that the appropriate GL context is current. Change-Id: Ifa5c2cffafb5cfa55e5b21b1b93b6f1bc8d6e1e1 Reviewed-on: https://chromium-review.googlesource.com/c/1351577 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#611395}
-
Carlos Caballero authored
Underlying infrastructure might check fail if SetNextDelayedDoWork is called for a run_time in the past. Which should be expected given that we have a ScheduleWork method for that case. ThreadControllerWithMessagePumpImpl checkfails on this. Bug: 891670 Change-Id: I60f5142eba3ff71babe976c749cec4a504408eed Reviewed-on: https://chromium-review.googlesource.com/c/1350960 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#611394}
-
Etienne Bergeron authored
This CL sampling the current process priority and add an instant event to report it. This will be used to figure out some priority inversion related to the GPU process and background renderers. R=oysteine@chromium.org Change-Id: I9e2f9b4b48379ade4d476dd7c7fd2b2fe52639d7 Reviewed-on: https://chromium-review.googlesource.com/c/1350189Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611393}
-
Ryan Hansberry authored
This codepath was using the deprecated CryptAuthDeviceManager, which causes crashes on M71+. R=jhawkins@chromium.org Bug: 908579 Change-Id: I52bd659b43cb851caa696fb77bcf0536396ba214 Reviewed-on: https://chromium-review.googlesource.com/c/1351877Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#611392}
-
Fady Samuel authored
In order to ensure that we're reporting embedding time for all production clients, this CL verifies that the allocation timestamp is not null on serialization/deserialization of CompositorFrameMetadata. Clients that didn't report LocalSurfaceId allocation time have been updated to do so. Change-Id: If4a3f744ec8894932c8b63a2850d76fca37a2300 Bug: 655231 Reviewed-on: https://chromium-review.googlesource.com/c/1327534 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#611391}
-
Xiyuan Xia authored
- Add a equivalent_result_id field to search result; - OmniboxResult uses stripped search url as its id; - AnswerCardResult sets equivalent_result_id to a stripped search url that is used by search-what-user-typed omnibox result; - SearchAnswerCardView use the equivalent_result_id to delete relevant result when the card is loaded; - Remove the unused comparable_id from ChromeSearchResult; Bug: 906890 Test: SearchResultAnswerCardViewTest.RemoveEquivalent Change-Id: I16529724c8a86790ed1b5366095e2701118f9231 Reviewed-on: https://chromium-review.googlesource.com/c/1351714Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611390}
-
Tarun Bansal authored
When the tab is brought to the foreground, preconnect to the origin of the main frame request. This preconnection is done at most once, and is helpful in case user clicks on a link. Bug: 908725 Change-Id: Ic4c35c881e6b1a99bdccaac1bbfd585cfab8cb48 Reviewed-on: https://chromium-review.googlesource.com/c/1352490Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#611389}
-
Kristi Park authored
Show error message for URLs with invalid schemes, and remove leftover function that was removed. Bug: 906607 Change-Id: I6cd5a7267de3d439c1e54c01f846f03fd9247f62 Reviewed-on: https://chromium-review.googlesource.com/c/1343365Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#611388}
-
Sky Malice authored
Bug: 889247 Change-Id: I0c22f77bc254695ae0c9dcaa5cbf70c9cc5e0c04 Reviewed-on: https://chromium-review.googlesource.com/c/1311774 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#611387}
-
Ramya Nagarajan authored
Bug: 905386 Change-Id: I98ab459357dbb9d7043ad5fb5dd0b8084c3f7434 Reviewed-on: https://chromium-review.googlesource.com/c/1351784Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611386}
-
Katie D authored
TBR=dmazzoni@chromium.org Bug: 908942 Change-Id: I46cfb9b916f0d06421dfc159e7aee4e61e818589 Reviewed-on: https://chromium-review.googlesource.com/c/1352266 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#611385}
-
spanicker authored
Change-Id: I85838b853bffdc17edd1418a39a2dd6440aa63b7 Reviewed-on: https://chromium-review.googlesource.com/c/1342775Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Shubhie Panicker <panicker@chromium.org> Cr-Commit-Position: refs/heads/master@{#611384}
-
Danyao Wang authored
There are two changes based on discussion with iOS Chrome team and the security team: 1. Loop in iOS Chrome team on WebKit security bugs so they can monitor status, in case a workaround was landed in iOS Chrome for that bug. 2. Update the mechanism to notify Apple friends per request from ddkilzer@apple.com. Change-Id: I5141a0af8374ee35b2953587bd647cab431600d7 Reviewed-on: https://chromium-review.googlesource.com/c/1337485Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Andrew Whalley <awhalley@chromium.org> Cr-Commit-Position: refs/heads/master@{#611383}
-
David Bertoni authored
This is one step in unifying LazyContextTaskQueue::PendingTask and LazyBackgroundTaskQueue::PendingTask. Change-Id: Icf383aa3a3c91a7b9e371cef7a2ee24c8dd55c1d Reviewed-on: https://chromium-review.googlesource.com/c/1347734 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#611382}
-
Dave Tapuska authored
Assign the derived size after the SECURITY_DCHECKS to make it clear we never expect this to exceed the size reserved. BUG=879657 Change-Id: I1bb9f8724b9605499286935002a45508e58f2b04 Reviewed-on: https://chromium-review.googlesource.com/c/1347577Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#611381}
-
Peter Boström authored
This is done by disabling anti aliasing. As we're painting a single solid rectangle this is equivalent (and probably marginally faster). Bug: chromium:907641 Change-Id: I05dec569b963511ce87f0a24d0f2f443fa0d9889 Reviewed-on: https://chromium-review.googlesource.com/c/1352338Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#611380}
-
Ken Rockot authored
Migrates device service code and tests from deprecated service APIs to new ones. Namely this phases out its use of ServiceContext and ServiceTest in favor of ServiceBinding and plain old unit tests. Bug: 891780,906239 Change-Id: I7677134b5d11e7297b162bbb532dfabb810504d2 Reviewed-on: https://chromium-review.googlesource.com/c/1345124 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#611379}
-
Ted Meyer authored
Using a vector of subsamples and a starting initialization vector, start incrementing the IV based on how large each video frame is. These values are used by accelerators to support encrypted playback. Since subsamples and frames can overlap, we have to cover multiple scenarios: frames & subsamples line up: ┌───────────────────┬────────────────────┐ │ frame 1 │ frame 2 │ ┝━━━━━━━━━━━━━━━━━━━┿━━━━━━━━━━━━━━━━━━━━┥ │ clear1 | cipher 1 │ clear 2 | cipher 2 │ └───────────────────┴────────────────────┘ subsample clear covers all first frame and partial second frame: ┌───────────────────┬────────────────────┐ │ frame 1 │ frame 2 │ ┝━━━━━━━━━━━━━━━━━━━┷━━━━━━━━━━━━━━━━━━━━┥ │ clear1 | cipher 1 │ └────────────────────────────────────────┘ one frame has more than one subsample, and subsamples might not align: ┌─────────────────────────┬────────────────────┐ │ frame 1 │ frame 2 │ ┝━━━━━━━━━━━━━━━━━━━┯━━━━━┷━━━━━━━━━━━━━━━━━━━━┥ │ clear1 | cipher 1 │ clear 2 | cipher 2 │ └───────────────────┴──────────────────────────┘ or: ┌────────────────────────────────────────┬────────────────────┐ │ frame 1 │ frame 2 │ ┝━━━━━━━━━━━━━━━━━━━┯━━━━━━━━━━━━━━━━━━━━┿━━━━━━━━━━━━━━━━━━━━┥ │ clear1 | cipher 1 │ clear 2 | cipher 2 │ clear 3 | cipher 3 │ └───────────────────┴────────────────────┴────────────────────┘ or: ┌─────────────────────────────────────────────┬───────────────┐ │ frame 1 │ frame 2 │ ┝━━━━━━━━━━━━━━━━━━━┯━━━━━━━━━━━━━━━━━━━━┯━━━━┷━━━━━━━━━━━━━━━┥ │ clear1 | cipher 1 │ clear 2 | cipher 2 │ clear 3 | cipher 3 │ └───────────────────┴────────────────────┴────────────────────┘ a cipher section crosses a frame boundary: (this is an error and is caught) ┌───────────────────┬────────────────────┐ │ frame 1 │ frame 2 │ ┝━━━━━━━━━━━━━━━━━━━┷━━━━━━━━━━━━━━━━━━━━┥ │ clear1 | cipher 1 │ └────────────────────────────────────────┘ Bug: 881922 Bug: 836557 Change-Id: I7e69be34221702f77ec67daa8647c1767661bb51 Reviewed-on: https://chromium-review.googlesource.com/c/1307059Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Rintaro Kuroiwa <rkuroiwa@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#611378}
-
Matthew Jones authored
This patch introduces the ActivityTabTabObserver, a TabObserver that only watches the activity tab. When the activity tab changes, the observer automatically moves from the previous tab to the current one. Use of this API is as simple as extending the new class. The ActivityTabTabObserver itself extends the EmptyTabObserver and adds a convenience method for notifications about the observed tab changing (onObservingDifferentTab). Bug: 871279 Change-Id: I5f3358953f5fdc5f9c4f9acd790af0b4d3d2d58a Reviewed-on: https://chromium-review.googlesource.com/c/1347620 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#611377}
-
Philip Rogers authored
This patch changes the touch action rect tests to dump the touch action rects and their associated layer rect instead of dumping node-related information. This is in preparation for making these tests work with slimming paint v2 (SPV2 aka composite-after-paint) which does not have a mapping from cc::Layer to Node and may produce different composited layer decisions. Before patch: normalFlow: #document scrolling (13, 128, 290, 12) With patch: normalFlow: layer(0,0 785x1530) has hit test rect (13,128 290x12) This patch also removes the visualization functionality from the touch action tests. There is an easier way to visualize the touch-action rects: the inspector has a "Scrolling performance issue" visualization under the Rendering tab. Change-Id: I7468bcf1a64fecb72874c93c8b97567c588e3926 Reviewed-on: https://chromium-review.googlesource.com/c/1351789Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611376}
-
Pavel Shmakov authored
Currently the intents to be handled in the foreground instance of CustomTabActivity are delivered via a static reference in BrowserSessionContentUtils, instead of delivering the intent via ordinary Android mechanisms. This means, in particular, that intent flags are lost in the process. This poses a problem for "Single activity" TWA apps, specifically for their ability to forward new incoming View intents to the running TWA. We'd like this forwarding to be possible, and to work "out of the box" with LauncherActivity. Currently it works as follows. LauncherActivity starts a TWA, and keeps running in background - this allows to customize it so that it would continue communicating with TWA via CustomTabConnection. If a new View intent comes in, it starts a new instance of LauncherActivity, which in turn creates ChromeLauncherActivity, so the stack is: LauncherActivity | CTA | LauncherActivity | ChromeLauncherActivity ChromeLauncherActivity calls CTA via a static method, and kills itself, which leaves the second LauncherActivity running. Setting SINGLE_TOP and CLEAR_TOP intent flags on the client won't help, because these flags won't reach CTA. In this CL I make ChromeLauncherActivity launch CTA with SINGLE_TOP and CLEAR_TOP if there is a foreground CTA with matching session. Otherwise, the intent handling is kept the way it was, with all the logic untouched. The fallback solution, in the case this one won't work out, is to just call finish() in LauncherActivity once it has launched a TWA. This would mean it won't be able to both do the intent routing and keep communicating via CustomTabConnection (and probably no client implementation would be able to), which isn't good, but might not be a blocker for MVP release. Companion CL: http://crrev.com/c/1349363 Bug: 907796 Change-Id: I8a2396b325baae2974d6b0dfb73c2ed2fb0519eb Reviewed-on: https://chromium-review.googlesource.com/c/1349653 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#611375}
-
Karandeep Bhatia authored
This CL changes URLRequestFileJob to not suspend file url requests when the system suspends. There is no reason to suspend requests which don't require network activity. This helps solves bugs where extension event listeners are not registered as the request for extension background scripts are aborted on system suspend. BUG=898494 Change-Id: I3ce676fc6dc204c8c58d282d5ed0e81f97b5cc2c Reviewed-on: https://chromium-review.googlesource.com/c/1351730 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#611374}
-
Ian Kilpatrick authored
There should be no behaviour change. Bug: 635619 Change-Id: I0e885c53a27c07a85e64371f3e6edfcbd17d01f8 Reviewed-on: https://chromium-review.googlesource.com/c/1352442Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#611373}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d543f7dfed9b..dab634da93d3 git log d543f7dfed9b..dab634da93d3 --date=short --no-merges --format='%ad %ae %s' 2018-11-27 zoddicus@users.noreply.github.com Ensure that function parameter's type is not void (#2118) 2018-11-27 zoddicus@users.noreply.github.com Restrict capabilities to WebGPU spec (#2113) 2018-11-27 40001162+alelenv@users.noreply.github.com Add precise check for allowing use of gl_InstanceID for specific vulkan raytracing stages . (#2096) 2018-11-27 stevenperron@google.com Add validation for OpArrayLength. (#2117) 2018-11-26 afdx@google.com New spirv-reduce reduction pass: operand to dominating id. (#2099) 2018-11-26 33432579+alan-baker@users.noreply.github.com Prevent diagnostic memory leak (#2110) 2018-11-26 stevenperron@google.com Change HexFloat to work with gcc8. (#2109) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@dab634da93d3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id4dac84b9b212adee52a8f81fca7df90f308357c Reviewed-on: https://chromium-review.googlesource.com/c/1352243Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611372}
-
Ben Pastene authored
R=dpranke, jbudorick Bug: 902468 Change-Id: Id7e4909528758fd24a22e00696e905346a06b950 Reviewed-on: https://chromium-review.googlesource.com/c/1352267Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#611371}
-