- 02 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d029c0e83734..d6db27cfd2f7 git log d029c0e83734..d6db27cfd2f7 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 fmalita@chromium.org Observe SkFont::textToGlyphs() maxGlyphCount 2018-11-02 brianosman@google.com Remove SkPM4f.h, fold contents into SkColorData.h 2018-11-02 mtklein@google.com remove unused SkImageEncoderFns bits 2018-11-02 herb@google.com Move unused fields to bottom 2018-11-02 reed@google.com add pvg experiment Created with: gclient setdep -r src/third_party/skia@d6db27cfd2f7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I97c66610c3b6e9980c8ade49d7acc61bcb50ea9f Reviewed-on: https://chromium-review.googlesource.com/c/1315334Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605085}
-
Bo Liu authored
AddVSyncCompleteCallback is meant to be called from inside BeginFrame and to be called immediately after all observers have been notified. * Make sure all BeginFrame calls are followed by Complete callbacks, not just ones from VSync. * Rename it to AddBeginFrameCompletionCallback to clarify this. * Release CHECK that AddVSyncCompleteCallback is only called from with BeginFrame Bug: 885124 Change-Id: Ib2c5c8e7870a4876da2d3d2742ed396e3e87d941 Reviewed-on: https://chromium-review.googlesource.com/c/1315970 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#605084}
-
Fredrik Hubinette authored
Change-Id: I8ef53be026771a2c0674b6e5cce522b9dce05190 Reviewed-on: https://chromium-review.googlesource.com/c/1309214Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#605083}
-
Caleb Rouleau authored
NOTRY=true TBR=nednguyen@google.com CC=vmiura@chromium.org,sadrul@chromium.org Bug: 901526 Change-Id: I27a98ceea1fd4a007a3ba99e7799584a91053cfb Reviewed-on: https://chromium-review.googlesource.com/c/1316651Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#605082}
-
Jenny Zhang authored
Bug: 901438 Change-Id: Ib56c7db734e9b6b85f077b53ab86cb95665063e4 Reviewed-on: https://chromium-review.googlesource.com/c/1316093Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605081}
-
Harley Li authored
Add an event.target check in SW-from-other-domain's filter, so that an Enter or Space key input in the filter's editor box will not collapse the list of service workers from other domains. However, if the focus is on the div element of the "service worker from other domains" (instead of on the editor box inside the div), an Enter or Space key is still to expand/collapse the list. Bug: 855001 Change-Id: Iaeedd47fefe64bb081cd7cae66fd3eb53b4418b0 Reviewed-on: https://chromium-review.googlesource.com/c/1315356Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#605080}
-
Scott Violet authored
BUG=665965 TEST=none Change-Id: Icf59d9537180eeb11f572d66414e04808be23603 Reviewed-on: https://chromium-review.googlesource.com/c/1316105Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#605079}
-
Tom Anderson authored
Some views have ink drop components that are shaped depending on the view size (eg. IconLabelBubbleView::CreateInkDrop{Ripple,Highlight,Mask}). For these views, it's easiest to just recreate the ink drop components instead of creating special views that adapt their shape depending on the view size. BUG=899104 R=pkasting,mohsen Change-Id: Icffd0d703cb49a366810846789cc22aac79f925e Reviewed-on: https://chromium-review.googlesource.com/c/1308099 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#605078}
-
Avi Drissman authored
BUG=none Change-Id: I5f6812ff98f8a54aae9f538b95c361dd184d25a5 Reviewed-on: https://chromium-review.googlesource.com/c/1311254 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#605077}
-
Christopher Cameron authored
Populate the method to send these events to the browser. Bug: 859152 Change-Id: I47f0ba77340eaa185ad2ac58670d9f9909c7a698 Reviewed-on: https://chromium-review.googlesource.com/c/1315705Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#605076}
-
BUG=762641 TBR=derat@chromium.org Change-Id: I79e7f4adf116aa6c7f14a02fbe1534672d20076e Reviewed-on: https://chromium-review.googlesource.com/c/1316228Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605075}
-
Jered Gray authored
Change-Id: I12818936e2ebd71c43e7ad42df4a3167f8a107b3 Reviewed-on: https://chromium-review.googlesource.com/c/1316249Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Jered Gray <jegray@chromium.org> Cr-Commit-Position: refs/heads/master@{#605074}
-
Wenzhao Zang authored
Happened to see this code that's not used anywhere. Bug: None Change-Id: Iab81d9125bd191d62e8f756ecfa0b4421ce8e312 Reviewed-on: https://chromium-review.googlesource.com/c/1315710Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605073}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: I907098a48072853f16862e0a079d4db8aae2cefa Reviewed-on: https://chromium-review.googlesource.com/c/1316435Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#605072}
-
Tim Volodine authored
AcceptLanguageTests have been updated recently [1] to ensure expanded accept languages header. This patch ensure this also happens in the Network Service code path. Impacted tests (fixed by this patch): - org.chromium.android_webview.test.AcceptLanguageTest#testAcceptLanguage - org.chromium.android_webview.test.AcceptLanguageTest#testAcceptLanguagesWithenUS Note: - verified on android_mojo bot (see tryjobs this patch) - should also fix the [Mojo Android] fyi waterfall bot [2]. [1] https://crrev.com/c/1286936 [2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Android BUG=893561,841556 Change-Id: I638b8ce855fea1a60ccaf623c559f53c1408154d Reviewed-on: https://chromium-review.googlesource.com/c/1314594 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605071}
-
Caleb Rouleau authored
NOTRY=true TBR=nednguyen@google.com CC=ulan@chromium.org Bug: 901510 Change-Id: I80b10cdf9a378f4286425ba16fa4eb4a9eebae7d Reviewed-on: https://chromium-review.googlesource.com/c/1316433Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#605070}
-
Rune Lillesveen authored
We need to clear style invalidation on nodes being disconnected from the document. It was done for various instances of DetachLayoutTree(), but we would like Attach/DetachLayoutTree to be independent from style invalidation and recalc and it is more logical to do this in RemovedFrom on the nodes instead. Change-Id: If8728cc5ca0f02ee83783b6e8614772cf4d4d0ef Reviewed-on: https://chromium-review.googlesource.com/c/1314628Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#605069}
-
Sam Maier authored
This arg was defaulting to false when it should have defaulted to true. TBR=turning off bytecode checks for certain dirs Bug: 874854 Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8 Reviewed-on: https://chromium-review.googlesource.com/c/1309973 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#605068}
-
Ben Chan authored
Upon detecting an out-of-credits scenario on the cellular connection, a notification is shown to inform the user. Clicking the notification currently launches the network settings page, which isn't obvious to the user what they should do next. Instead, this CL changes that by launching the mobile setup dialog, which brings the user to the online payment portal to refill the data plan if needed. launches the mobile setup dialog. Bug: 901482 Test: Manually verify that clicking the out-of-credits notification Change-Id: If276a729395fe9c7c086b98caed6564f67e15bf1 Reviewed-on: https://chromium-review.googlesource.com/c/1315939Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605067}
-
Robert Sesek authored
Bug: none Change-Id: Ie4f051af9df60911cfef9c0a4b539a22ef92eb58 Reviewed-on: https://chromium-review.googlesource.com/c/1316111 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605066}
-
Caleb Rouleau authored
NOTRY=true TBR=nednguyen@google.com CC=wangxianzhu@chromium.org Bug: 901493 Change-Id: Iec05bec384214b2e3aa0fad1ea00687c57636f96 Reviewed-on: https://chromium-review.googlesource.com/c/1316407Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#605065}
-
Robert Sesek authored
This is a reland of dcb738f9 Adds a definition of RaiseProcessToHighPriority() that went missing when launch_posix.cc stoped being linked. Original change's description: > Reimplement GetAppOutput and friends on Mac with posix_spawn. > > Mac no longer uses launch_posix.cc and all process creation goes through > posix_spawn now. > > Bug: 179923 > Change-Id: I5206cace69ea7863a72b58e1a59f2465492d4cbd > Reviewed-on: https://chromium-review.googlesource.com/c/1313334 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604982} Tbr: mark@chromium.org Bug: 179923 Change-Id: I196f406a19a9cbc5f0e29a352062abb8e87638f0 Reviewed-on: https://chromium-review.googlesource.com/c/1315947Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#605064}
-
Vlad Tsyrklevich authored
Allow specifying an allocation alignment to Allocate() that works similarly to the alignment parameter to aligned_alloc(), e.g. the alignment parameter must be a power-of-two smaller than size. Unlike aligned_alloc it doesn't verify that the size is a multiple of alignment since that's not enforced by some functions like posix_memalign. Default alignment behavior stays the same if no alignment is specified. Bug: 896019 Change-Id: I542314aa2405265af03cd6519f5c997ed1e95152 Reviewed-on: https://chromium-review.googlesource.com/c/1310563 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#605063}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I810f83f88644911bcb377850b0c1766903a6a5d0 Reviewed-on: https://chromium-review.googlesource.com/c/1315734Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605062}
-
Mike Wittman authored
This reverts commit c33a38d7. Reason for revert: causing multiple test failures https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/85366 * media/controls-after-reload.html * media/controls-strict.html * media/controls-styling-strict.html * media/controls-styling.html * media/controls-without-preload.html * media/controls/lazy-loaded-style.html * media/controls/paint-controls-webkit-appearance-none-custom-bg.html * media/controls/paint-controls-webkit-appearance-none.html * media/video-controls-rendering.html * media/video-display-toggle.html * media/video-no-audio.html * virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style.html * virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg.html * virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none.html Original change's description: > Re-baseline tests after --enable-display-compositor-pixel-dump > > This CL enabled display compositor pixel dumps by default, which caused > this group of tests to fail due to either a) minor antialiasing artifacts, > or b) known differences in output due to being captured from the browser > side. > > https://chromium-review.googlesource.com/c/chromium/src/+/1213864 > > These bugs should be resolved with this CL: > - crbug.com/881040: Media controls now contain an overflow menu. > - crbug.com/667551: A bunch of tests are listed under this bug, and just > require rebaselining to fix non-material single-pixel > antialiasing failures. > - crbug.com/895556: These tests double their background size when the flag > is enabled. These were already fixed by another CL, > so they are NOT being rebaselined here, just removed > from TestExpectations. > > > Bug: 895912, 881040, 667551, 895556 > Change-Id: I14a1065df604151ed06f2a6be4da7eaa53968705 > Reviewed-on: https://chromium-review.googlesource.com/c/1303179 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605004} TBR=chrishtr@chromium.org,mlamouri@chromium.org,masonfreed@chromium.org Change-Id: Ie9ec56c80e8af1a729479ba28b942913c71f555c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 895912, 881040, 667551, 895556 Reviewed-on: https://chromium-review.googlesource.com/c/1315942Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605061}
-
Oystein Eftevaag authored
This unifies the Perfetto and non-Perfetto TraceEventAgent classes, so that it's possible to use Perfetto directly even when it's not enabled as the default TraceLog backend. Also moved the Mojo bindings of ProducerHost into a StrongBindingSet of PerfettoService so they get cleaned up if the service gets shut down. Already reviewed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1161541 Change-Id: I3070d69e92778de8e3b5e33957ab4f4694b782af Reviewed-on: https://chromium-review.googlesource.com/c/1307998 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#605060}
-
Bo Liu authored
It's called only once. Use move semantics and make that clear. Change-Id: I6f6e41a19a8198b9821c7c17d53d1f2c2ca09fef Reviewed-on: https://chromium-review.googlesource.com/c/1313056Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605059}
-
Martin Kreichgauer authored
Also remove extraneous fido namespace for consistency with the rest of //device/fido. Bug: 898718 Change-Id: I5d44220ade620459a0f82b0446ba585bd62913bd Reviewed-on: https://chromium-review.googlesource.com/c/1313732 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#605058}
-
Tim Volodine authored
Update the SystemWebViewShell to target Android P (API level 28). This is a part of the general effort to update apps to API level 28, see crbug.com/898190 and b/115499280. This patch also ensures that cleartextTrafficPermitted is set to true to ensure backwards compatibility for the SystemWebViewShell (and to allow cleartext traffic, e.g. using unencrypted http protocol). This patch also updates trust-anchors to include system and user certificates. BUG=898190 Change-Id: I7adb7dbfce1baf3e7b2cf4860709d10fe295217e Reviewed-on: https://chromium-review.googlesource.com/c/1296601 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#605057}
-
Alexander Alekseev authored
Bug: 901107 Change-Id: Ieb943ad33a824318ea391b626285e6c4b8a71fc4 Reviewed-on: https://chromium-review.googlesource.com/c/1313929Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#605056}
-
Javier Fernandez authored
In order to identify single leading white-spaces as potential line breaking opportunities we need to know the offset the iterator starts at for the current text to handle. When we landed the change in r596406 we incorrectly assumed that leading white-spaces were always at offset 1. However, this is not valid when such leading white-spaces are generated by previous broken lines. This CL solves the issue by using the stored initial offset to identify such single leading white-spaces as potential breaking opportunities. Bug: 900727 Change-Id: Ibc9dda7632d72ed82a61025015489ec3b70d6919 Reviewed-on: https://chromium-review.googlesource.com/c/1311274 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#605055}
-
mark a. foltz authored
https://chromium.googlesource.com/media_router.git/+log/475baa8b2eb0..29324b698ccd $ git log 475baa8b2..29324b698 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 mfoltz Fix/suppress JSCompiler errors in advance of b/117162687 && b/117162806 2018-09-18 mfoltz Added retry behavior for Slarti calls. 2018-09-06 mfoltz Support mirroring with Mirroring Service behind feature flag. 2018-08-08 mfoltz Added extra logging for GCM activity. Created with: roll-dep src/chrome/browser/resources/media_router/extension/src TBR=jrw@chromium.org Change-Id: I1d88f7f4a6c427183d89de0a79d6636b07a73ec0 Reviewed-on: https://chromium-review.googlesource.com/c/1315695 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605054}
-
Weidong Guo authored
Changes: Update the y positions of child views to target state upon animation start to avoid stale positions. Bug: 901168 Change-Id: I605d20302a7512b82ffe5cf445e7166f64da3280 Reviewed-on: https://chromium-review.googlesource.com/c/1315810 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#605053}
-
Mitsuru Oshima authored
This reverts commit 46a9bbb1. Reason for revert: <INSERT REASONING HERE> Original change's description: > Overview optimizations > > This is 2nd attempt to land: crrev.com/c/1304973 > [2] are the difference from above CL. > > *[2] Added null check in OnStartingAnimationComplete. > * Pause occusion tracker during overview animation > [2] wait 5000ms when exiting overview before resume > because a user may re-enter overview > [2] wait 50ms when entering overview before resume > because it can take 2 frame to finish draing the frame > after animation observer is called. > * Activate the text filter after animation > * [2]Animate shelf after overview animation. > * [2] Improve blur animation: > Use Compositor's AnimationObesrver to drive animation > Progress only by 2 to reduce the frequency. > * Don't animate backdrop window during overview animation. > * Fix the bounds change issue in WindowGrid. It shouldn't change > the parent window's bounds. > > > Bug: 898077, 897387, b/118675936 > Test: no functional change. Manually tested visual change by entering/exiting overview mode > in both clamshell and tabletmode. > The web contents should load after animations without backdrop animation. > No gap at the bottom of the screen after exiting overview mode. > > Change-Id: I5e5dc17afd62d4dc477d87becdeee91c55bd81ca > Reviewed-on: https://chromium-review.googlesource.com/c/1304973 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#604206} > Reviewed-on: https://chromium-review.googlesource.com/c/1312614 > Reviewed-by: Malay Keshav <malaykeshav@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604844} TBR=oshima@chromium.org,sammiequon@chromium.org,malaykeshav@chromium.org Change-Id: Ia07f696386ce2889a1d6344218be355a3515975c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898077, 897387, b/118675936 Reviewed-on: https://chromium-review.googlesource.com/c/1316169Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#605052}
-
Devlin Cronin authored
Adjust a few tests so that they will pass when the RuntimeHostPermissions feature is enabled on ToT. A follow-up will flip the default of the feature. Bug: 869996 Change-Id: I0b677040c228cbd7762330f2f4257d37673fdfe7 Reviewed-on: https://chromium-review.googlesource.com/c/1296814Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605051}
-
Chris Blume authored
Previous, the calls to check IsCleared() were inside a DCHECK(). We want to promote them to always happen. This patch does that. BUG=897263 Change-Id: I385b4bfeb931b94e62cd88258da8873f9ddff8f9 Reviewed-on: https://chromium-review.googlesource.com/c/1315703Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#605050}
-
Kristian H. Kristensen authored
The problem was only observed on Mali and could even be fixed in recent driver versions. For now, at least narrow down the workaround to only apply to Mali GPUs. On other GPUs we observe around 10% improvement in framerate, which we can't leave on the table. Bug: 301988 Change-Id: Iab07a60a74555d6935b53dc30af1b798a1c56e8f Reviewed-on: https://chromium-review.googlesource.com/c/1312158Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605049}
-
Kevin Bailey authored
This change includes 2 fixes: - When text and UI direction don't match, focusing the tab switch button homes the cursor in the Omnibox. Now the cursor remains where it is. (900244) - When there is autocomplete text and a tab switch button showing, right arrow doesn't go to end. Now we check that the selection is entirely at the end before consuming right arrow for the tab switch button. (899597) Bug: 899597, 900244 Change-Id: Ib5c953d22c1b80f6f516a04d8e12e7d8b5b13c19 Reviewed-on: https://chromium-review.googlesource.com/c/1312983 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#605048}
-
Min Qin authored
On Android, we clean up non-resumable interrupted file from the history and download db. However, the actual files may still be on disk. This CL removes those files while cleaning up the database. BUG=899775 Change-Id: I59bdf32c11789448295126b2819d326fedcf54ff Reviewed-on: https://chromium-review.googlesource.com/c/1310499 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605047}
-
Devlin Cronin authored
Tweak the data sent to the extensions page slightly more. Move all runtime host permissions data into a separate field on the developerPrivate.Permissions struct, and unconditionally populate all fields (including specific granted hosts) if the feature is enabled. This simplifies some of the code we need to pass to the RuntimeHostPermissions element, since we can now just pass developerPrivate.RuntimeHostPermissions, and paves the way for adding a separate toggle-able implementation for extensions that request access to specific sites. No observable UI or behavior change is expected in this CL. Update and add tests for the same. Bug: 891803 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id95d3b0a77d8621db811a28fcdcfd705d60ed0f6 Reviewed-on: https://chromium-review.googlesource.com/c/1295271 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#605046}
-