GitLab

According to crbug.com/307827 - the code that used media_galleries_handlers has been removed.

BUG=NONE
NOTRY=true

Review URL: https://codereview.chromium.org/338473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277773 0039d316-1c4b-4281-b951-d872f2087c98

JSONReader produces base::Value objects that share a string buffer. See comment at the JSON_DETACHABLE_CHILDREN option.
Since Remove on a child node was used, this potentially lead to use-after-free. 

BUG=NONE

Review URL: https://codereview.chromium.org/335103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277772 0039d316-1c4b-4281-b951-d872f2087c98

Should be below accounts list, but above list of other profiles.

BUG=372812,372381

Review URL: https://codereview.chromium.org/338093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277771 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/323343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277770 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277762 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org, jochen@chromium.org, jschuh@chromium.org

Review URL: https://codereview.chromium.org/334483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277761 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162827

Review URL: https://codereview.chromium.org/293033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277759 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367221

Review URL: https://codereview.chromium.org/335083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277757 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/331683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277756 0039d316-1c4b-4281-b951-d872f2087c98

The messages will now go trough RF/RFH.
This is in order to make screen orientation lock Frame specific
instead of global to Chromium. The next step is to change the provider
accordingly.

BUG=162827

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277321

Review URL: https://codereview.chromium.org/327573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277755 0039d316-1c4b-4281-b951-d872f2087c98

Failed test:
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/50667/steps/interactive_ui_tests/logs/stdio

The new test appears to be timing out on the bots.

> [Mac] Add interactive App Shim test.
> 
> This test creates shims in the user data dir and actually starts them up and
> expects them to connect to the IPC socket.
> 
> BUG=168080
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276368
> 
> Review URL: https://codereview.chromium.org/316493002

TBR=jackhou@chromium.org

Review URL: https://codereview.chromium.org/333403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277754 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372388
TEST=N/A
NOTRY=true

Review URL: https://codereview.chromium.org/338313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277753 0039d316-1c4b-4281-b951-d872f2087c98

Looks like a 2x multiplier might not be enough for browser_tests. Let's try 3x.
We'll probably want to do the same for TSan once we start running browser_tests
under TSan.

BUG=178409
TBR=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/344433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277751 0039d316-1c4b-4281-b951-d872f2087c98

Followup to https://codereview.chromium.org/316863002/

This CL changes:
- c/b/managed_mode/ to c/b/supervised_user/
- "ManagedMode"/"ManagedUser" to "SupervisedUser" in c/b/supervised_user/

Still missing:
- Some stuff outside of c/b/supervised_user/, mostly (but not only) c/b/chromeos/login/managed/
- JavaScript
- Resource names

The remaining things will come in followup CLs.

TBR=nkostylev@chromium.org (c/b/chromeos)
TBR=noms@chromium.org (c/b/profiles)
TBR=thakis@chromium.org (rest of c/)

All the TBRs are just trivial renames.

BUG=385113

Review URL: https://codereview.chromium.org/335833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277750 0039d316-1c4b-4281-b951-d872f2087c98

This makes the Safe Browsing interstitial unit & browser tests work for both the V2 and V3 versions. For the unit tests, I did this by using typed tests. Typed tests aren't supported for browser tests, so for the browser tests I moved the tests into methods that could be invoked twice.

Also includes a small bugfix in a string that was causing a failure.

BUG=381260

Review URL: https://codereview.chromium.org/330753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277749 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277748 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=176215%3A176254&mode=html

TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/332413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277747 0039d316-1c4b-4281-b951-d872f2087c98

This check was breaking the Android checked builds.

BUG=internal b/15621260
TBR=cjhopman@chromium.org
// Android-only build-only change, builds fine on Android trybots.
NOTRY=true

Review URL: https://codereview.chromium.org/326393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277746 0039d316-1c4b-4281-b951-d872f2087c98

Removing old functions which are not used by Blink anymore, step 4 of the rename. Depends on Blink side change in r176207.

BUG=382411
R=eae,behdad,piman

Review URL: https://codereview.chromium.org/327643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277744 0039d316-1c4b-4281-b951-d872f2087c98

This test creates shims in the user data dir and actually starts them up and
expects them to connect to the IPC socket.

BUG=168080

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276368

Review URL: https://codereview.chromium.org/316493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277743 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277742 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Broke Android tests and Android tests (dbg).

In particular, https://codereview.chromium.org/333633003 broke webkit_unit_tests

Original issue's description:
> Blink roll r176215 - 176281
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=176215%3A176281&mode=html
> 
> TBR=schenney
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277710

TBR=schenney@chromium.org,haraken@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/341483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277741 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380082,234166

TBR=finnur

Review URL: https://codereview.chromium.org/333223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277740 0039d316-1c4b-4281-b951-d872f2087c98

To suppress "unused function" error by Clang when building RLZ enabled binary

BUG=None
TEST=build with RLZ enabled

Review URL: https://codereview.chromium.org/338183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277739 0039d316-1c4b-4281-b951-d872f2087c98

SWProviderHost is associated with SWContextCore which can be purged on
corruption recovery process while the host is still referring to it, so the
host should check the liveness of the context before handling the message from
renderer.


BUG=371675
TEST=content_unittests

Review URL: https://codereview.chromium.org/325173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277738 0039d316-1c4b-4281-b951-d872f2087c98

If the Ime is already showing when the renderer process changes,
it stays open and cannot be used.
Now hiding the Ime when render process is changed

ImeAdapter attach gets called through attachImeAdapter in ContentViewCore onRenderProcessChange

BUG=382863

Review URL: https://codereview.chromium.org/322973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277737 0039d316-1c4b-4281-b951-d872f2087c98

It's been unused since r255987 (which removed the --enable-dcheck flag,
among other things).

Also remove the --silent-dump-on-dcheck flag (because now there's not
even code that pretends to use it).

R=brettw@chromium.org,sky@chromium.org
BUG=352378

Review URL: https://codereview.chromium.org/331143007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277736 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277735 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/336013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277734 0039d316-1c4b-4281-b951-d872f2087c98

When mouse-closing a tab while the strip is in overflow, don't move the New Tab button left if it's not actually at the end of the strip.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/339813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277733 0039d316-1c4b-4281-b951-d872f2087c98

Native title bars make the background color grey. This changes it back
to white.

BUG=382829

Review URL: https://codereview.chromium.org/338773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277732 0039d316-1c4b-4281-b951-d872f2087c98

Update permission in tests.

BUG=343382

Review URL: https://codereview.chromium.org/334283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277731 0039d316-1c4b-4281-b951-d872f2087c98

Depends on
https://codereview.chromium.org/298073009/

BUG=364435

Review URL: https://codereview.chromium.org/306433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277730 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353936

Review URL: https://codereview.chromium.org/313623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277729 0039d316-1c4b-4281-b951-d872f2087c98

On Mac, Python 2.7 gives different results (line 1 column 3 char 2) than
Python 2.6 (line 1 column 2 char 2).

Review URL: https://codereview.chromium.org/335263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345059
TEST=run the test

Review URL: https://codereview.chromium.org/331583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277727 0039d316-1c4b-4281-b951-d872f2087c98

App shortcuts were being created without the shortcut_info parameter,
so web_app::CreateShortcutsForShortcutInfo() was being called with an
empty app ID and shortcut icon. Partially reverted r276419 to load the
app info properly when creating app shortcuts.

BUG=384240

Review URL: https://codereview.chromium.org/337023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277726 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368860

Review URL: https://codereview.chromium.org/326373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277725 0039d316-1c4b-4281-b951-d872f2087c98

getProfileUserInfo returns the email address and obfuscated gaia id of
the user signed into a profile. If the user is not signed in, empty
strings are returned.

This API is different from identity.getAccounts in two ways. The information returned is available offline, and it only applies to the primary account for the profile (even when multiple login is enabled).

BUG=368343

Review URL: https://codereview.chromium.org/327403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277724 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/337313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277722 0039d316-1c4b-4281-b951-d872f2087c98