- 09 Sep, 2015 40 commits
-
-
mostynb authored
s/currebt/current/ TBR=brettw Review URL: https://codereview.chromium.org/1318963007 Cr-Commit-Position: refs/heads/master@{#347900}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/8ee8faa..6bc2409 Sheriffs: In case of breakage, do NOT revert this roll, revert the offending commit in the blink repository instead. NOTRY=true TBR=eae@chromium.org,mkwst@chromium.org Review URL: https://codereview.chromium.org/1327123002 Cr-Commit-Position: refs/heads/master@{#347899}
-
achuith authored
Ran this test 100 times locally with no failures. Didn't fail on bots either BUG=393708 Review URL: https://codereview.chromium.org/1319373003 Cr-Commit-Position: refs/heads/master@{#347898}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/94c04b8..8ee8faa Sheriffs: In case of breakage, do NOT revert this roll, revert the offending commit in the blink repository instead. NOTRY=true TBR=eae@chromium.org,mkwst@chromium.org Review URL: https://codereview.chromium.org/1320333005 Cr-Commit-Position: refs/heads/master@{#347897}
-
rob authored
The responseHeaders that are passed to the webRequest.onHeadersReceived event are generated by the GetResponseHeadersList method. This method enumerates the headers using HttpResponseHeaders::EnumerateHeaderLines, which skips over commas in header values. But the return value of the webRequest.onHeadersReceived handler is parsed by HttpResponseHeaders:EnumerateHeader, which stops at commas. So, if the original response header contains a comma, and the extension returns the response headers in unmodified form, it was still mistakenly flagged as modified. This results in duplication of headers. To fix this, the return value is now parsed using EnumerateHeaderLines. BUG=526367 TEST=unit_tests --gtest_filter=ExtensionWebRequestHelpersTest.* Review URL: https://codereview.chromium.org/1315643005 Cr-Commit-Position: refs/heads/master@{#347896}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/bda1fe3e..94c04b8 Sheriffs: In case of breakage, do NOT revert this roll, revert the offending commit in the blink repository instead. NOTRY=true TBR=eae@chromium.org,mkwst@chromium.org Review URL: https://codereview.chromium.org/1309423005 Cr-Commit-Position: refs/heads/master@{#347895}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/26e7263..bda1fe3e Sheriffs: In case of breakage, do NOT revert this roll, revert the offending commit in the blink repository instead. NOTRY=true TBR=eae@chromium.org,mkwst@chromium.org Review URL: https://codereview.chromium.org/1310163005 Cr-Commit-Position: refs/heads/master@{#347894}
-
akuegel authored
BUG= Review URL: https://codereview.chromium.org/1329243002 Cr-Commit-Position: refs/heads/master@{#347893}
-
william.xie authored
Video quad may be clipped. We need to check that before use overlay BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1311013002 Cr-Commit-Position: refs/heads/master@{#347892}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/fb9c61d..26e7263 Sheriffs: In case of breakage, do NOT revert this roll, revert the offending commit in the blink repository instead. NOTRY=true TBR=eae@chromium.org,mkwst@chromium.org Review URL: https://codereview.chromium.org/1331653002 Cr-Commit-Position: refs/heads/master@{#347891}
-
jbbegue authored
Review URL: https://codereview.chromium.org/1320353003 Cr-Commit-Position: refs/heads/master@{#347890}
-
changwan authored
BUG=481758 Review URL: https://codereview.chromium.org/1320323006 Cr-Commit-Position: refs/heads/master@{#347889}
-
raymes authored
To make it possible to make ContentSettingsTypes no longer an enum we need to remove the occurrences of iterations over it. This CL removes occurences from chrome/browser/ui/content_settings and does some cleanup. Rather than switching on ContentSettingsType, we instead create a list of content settings types that have bubbles and iterate over that. The list of nib paths in content_setting_bubble_cocoa.mm has been updated to include CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC/CAMERA to match the list of bubble types. location_bar_view.cc has been changed not to iterate over entire enum anymore because it only needed to iterate over the list of types that have bubbles. BUG=526932 Review URL: https://codereview.chromium.org/1312053006 Cr-Commit-Position: refs/heads/master@{#347888}
-
rouslan authored
BUG=428087 Review URL: https://codereview.chromium.org/1304923002 Cr-Commit-Position: refs/heads/master@{#347887}
-
tapted authored
The failure doesn't reproduce with --enable-pixel-output-in-tests, so I don't really know what's going on. But I suspect that since ChromeOS only checks the *target* visibility, it's possible for the app list to not be fully shown. One case this could happen is on official/buildspec builders which have more icons to load, and so the delayed-icon-load steps used for ChromeOS via AppListMainView::ShowAppListWhenReady() end up taking longer. Explicitly showing the app list ensures the app list is visible before the event generator tries to use it to generate mouse coordinates. BUG=525128 Review URL: https://codereview.chromium.org/1308663007 Cr-Commit-Position: refs/heads/master@{#347886}
-
olli.raula authored
Remove use of deprecated function DeprecatedRead from chrome/common/extensions/api/common_extension_api_unittest.cc BUG=523194 Review URL: https://codereview.chromium.org/1321313004 Cr-Commit-Position: refs/heads/master@{#347885}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/9e49999..fb9c61d Sheriffs: In case of breakage, do NOT revert this roll, revert the offending commit in the blink repository instead. NOTRY=true TBR=alph@chromium.org,eae@chromium.org Review URL: https://codereview.chromium.org/1318113006 Cr-Commit-Position: refs/heads/master@{#347884}
-
jaekyun authored
On Android, we assume dead RenderWidgetHost to be invisible to correctly keep the priority of a restored renderer. Instead, we set the correct visibility when it is restored. BUG=522795 Review URL: https://codereview.chromium.org/1308623003 Cr-Commit-Position: refs/heads/master@{#347883}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ab6f1f01..242115ba Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1312193005 Cr-Commit-Position: refs/heads/master@{#347882}
-
leilei authored
issue/1303993003 renames Media Router route "title" field to "description". BUG= Review URL: https://codereview.chromium.org/1305163009 Cr-Commit-Position: refs/heads/master@{#347881}
-
maxbogue authored
This CL doesn't touch ModelTypeProcessorImpl in DataTypeController because ModelTypeProcessor doesn't have the functionality for it. Those uses will be removed in a separate refactor. Also fixes a bunch of incorrect variable names. BUG=517953 Review URL: https://codereview.chromium.org/1321613003 Cr-Commit-Position: refs/heads/master@{#347880}
-
dbeam authored
R=tommycli@chromium.org BUG=526577 Review URL: https://codereview.chromium.org/1328263004 Cr-Commit-Position: refs/heads/master@{#347879}
-
nhiroki authored
This is a quick fix for http://crbug.com/507110 BUG=507110 Review URL: https://codereview.chromium.org/1325143004 Cr-Commit-Position: refs/heads/master@{#347878}
-
loyso authored
We have a situation with DeprecatedPaintLayerCompositor where it will never be in "compositingMode" (for a page with SVGImageChromeClient/EmptyClient) BUG=394777 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1322853003 Cr-Commit-Position: refs/heads/master@{#347877}
-
jbudorick authored
This is a reland of https://codereview.chromium.org/1328093006 BUG= Review URL: https://codereview.chromium.org/1328303004 Cr-Commit-Position: refs/heads/master@{#347876}
-
jochen authored
Just ignore the call (which is what would happen anyways), and upload a minidump BUG=516690 R=creis@chromium.org,dbeam@chromium.org,estade@chromium.org Review URL: https://codereview.chromium.org/1332513002 Cr-Commit-Position: refs/heads/master@{#347875}
-
sergeyu authored
Previously android app was using key code when sending keyboard events. That approach doesn't work well with physical keyboard when using layout other than QWERTY. Fixed the client to use scan codes, so that the events are always send correctly and layout mapping is applied only on the client. BUG=475713 Review URL: https://codereview.chromium.org/1321223003 Cr-Commit-Position: refs/heads/master@{#347874}
-
bshe authored
BUG=524291 Review URL: https://codereview.chromium.org/1315233006 Cr-Commit-Position: refs/heads/master@{#347873}
-
treib authored
BUG=516618 Review URL: https://codereview.chromium.org/1314493013 Cr-Commit-Position: refs/heads/master@{#347872}
-
rtenneti authored
packets are lost) for 4 consecutive crypto handshakes. For a session, during crypto handshake if there is a bad packet loss rate, then we mark that QUIC is recently broken for that host/port. We disable QUIC and close that connections if 4 consecutive handshakes have bad packet loss rate. QUIC was disabled for 0.002% of the time. We have been running the above experiment in M45 (in Canary, Dev and Beta). In M45 Beta, Net.HttpJob.TotalTimeNotCached.Quic's mean is faster by 4.4% (for data aggreagted for 28 days) when this experiment was enabled. R=rch@chromium.org Review URL: https://codereview.chromium.org/1326763007 Cr-Commit-Position: refs/heads/master@{#347871}
-
fukino authored
paste command's hidden property is set true when one directory is focused. However, it will not be reset when an input is focused just after on directory is focused, because different handler (forceDefaultHandler) handles canExecute event when inputs are focused. All cut/copy/paste/delete commands should be shown in input element, so this CL reset the hidden property of them. BUG=528843 TEST=manually tested on rename input, search input, and filename input on save-as dialog. Review URL: https://codereview.chromium.org/1312583009 Cr-Commit-Position: refs/heads/master@{#347870}
-
tedchoc authored
BUG=529543 Review URL: https://codereview.chromium.org/1310663007 Cr-Commit-Position: refs/heads/master@{#347869}
-
rch authored
When channel IDs are deleted, QUIC sessions need to be close to avoid reusing the old channel ID. Review URL: https://codereview.chromium.org/1320423011 Cr-Commit-Position: refs/heads/master@{#347868}
-
tapted authored
views::Combobox currently does its own menu-building rather than using a ui::MenuModel. However, the only thing missing from MenuModel is the ability to set a minimum menu width. (Combobox currently does this by adding an invisible SubmenuView with a given width.) Moving the menu building out of Combobox allows Mac to build a native menu instead, which gives a much nicer menu experience there. In particular, Comboboxes on Mac center the menu over the button vertically, and have fancy scrolling/repositioning mechanisms when the menu is shown near the edge of the screen. This CL adds an Adapter class that adapts a ui::ComboboxModel to the ui::MenuModel interface, allowing views:Comboxbox to be simplified elsewhere. MenuRunnerImplCocoa will be extended to support comboboxes in a follow-up. For the minimum width, MenuController::CalculateMenuBounds() can just use the width of the anchor rectangle for the same effect. Note that TranslateBubbleView is the only user of Combobox::STYLE_ACTION. TranslateBubbleView puts a separator after the first item which Combobox always removes. MenuModel::IsVisibleAt() isn't checked for separators, so simply don't add the separator to keep things simple. BUG=522365 Review URL: https://codereview.chromium.org/1310903004 Cr-Commit-Position: refs/heads/master@{#347867}
-
juncai authored
This patch added webusb notification UI unit tests code. BUG=492204 Review URL: https://codereview.chromium.org/1326003006 Cr-Commit-Position: refs/heads/master@{#347866}
-
afakhry authored
This CL designs a framework for deprecated accelerators. In this CL we deprecate the following accelerators: - Lock Screen: Ctrl+Shift+L --> Search+L - Task Manager: Shift+Esc --> Search+Esc The old accelerators are still enabled, but the user is shown a notification message telling him about the new accelerator. UMA stats are recorded for both old and new accelerators. Keyboard overlay has been updated. BUG=492454,486198,498565,405317,503351 TEST=manually, ash_unittests --gtest_filter=DeprecatedAcceleratorTester.*, ash_unittests --gtest_filter=AcceleratorTableTest.CheckDeprecatedAccelerators Committed: https://crrev.com/c2b81c9fca4abc10cafdc75d2e7b4f15314e2e5b Cr-Commit-Position: refs/heads/master@{#335410} Review URL: https://codereview.chromium.org/1177773002 Cr-Commit-Position: refs/heads/master@{#347865}
-
andresantoso authored
Enhance MaybeCreateHardwareFrame() to be able to create a NV12 hardware frame backed by a YUV_420_BIPLANAR GpuMemoryBuffer. This code path is not enabled yet. BUG=524582 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1307853003 Cr-Commit-Position: refs/heads/master@{#347864}
-
yhirano authored
BUG=523228 Review URL: https://codereview.chromium.org/1310853004 Cr-Commit-Position: refs/heads/master@{#347863}
-
yawano authored
BUG=514853 TEST=unit_tests:SearchMetadataTest.*;SearchMetadataSimpleTest.* Review URL: https://codereview.chromium.org/1321553003 Cr-Commit-Position: refs/heads/master@{#347862}
-
mcasas authored
This format is already supported in the rest of the capture path. Bluefish 444 is the capture card using it. BUG=508413 TEST=Capture using a Bluefish 444 capture card Review URL: https://codereview.chromium.org/1325303004 Cr-Commit-Position: refs/heads/master@{#347861}
-