- 23 Jul, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cde26f18fbf1..c53c2f80508e git log cde26f18fbf1..c53c2f80508e --date=short --no-merges --format='%ad %ae %s' 2019-07-23 fmayer@google.com Merge "Fixes to tracing API README." Created with: gclient setdep -r src/third_party/perfetto@c53c2f80508e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I71fe25e73fbe0d6eadd20daa6fe1759d7bf504a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679959}
-
Ben Kirchman authored
FakeCronetEngine should be used in tests to test apps' uses of CronetEngine. Design Doc: https://docs.google.com/document/d/1IsBwiqR5f6ksvmHPq5skV802C02We8zjK-c552Tp4lE/edit#heading=h.7nki9mck5t64 Bug: 669707 Change-Id: Ide40204e9d0942cc2fc5361f42cefcf56b405fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680733 Commit-Queue: Benjamin Kirchman <kirchman@google.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#679958}
-
Rune Lillesveen authored
Early return to avoid DCHECK and following crash in StyleForPseudoElement(). Bug: 979573 Change-Id: Ib286ccd62193c6b85b910cd8b127c37189aedd53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713532Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#679957}
-
Andrew Grieve authored
Script is often used to test size changes. We don't care about lint failures and also would like it to build faster. Change-Id: I19f30d6a2aca0619e27ee43ebef515fc9e0f7a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710510 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#679956}
-
Jan Wilken Dörrie authored
This change renames WebAutofillClient::HasFillData() to TryToShowTouchToFill() and moves the corresponding implementation logic to autofill::AutofillAgent and autofill::PasswordAutofillAgent. As a consequence of this change the kTouchToFillAndroid moves from password features to autofill features. Bug: 957532 Change-Id: I302285e46437bae4682113e451c784f97d0851b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702610Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#679955}
-
Himanshu Jaju authored
Bug: 986264 Change-Id: Id10d11cf9c7c3275edad838cbbcba13fc2ade8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712674Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#679954}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/78011069970f..249e60896429 git log 78011069970f..249e60896429 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 perezju@chromium.org Reland "[Telemetry] Implement new top level parser" Created with: gclient setdep -r src/third_party/catapult@249e60896429 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:928275 TBR=skyostil@google.com Change-Id: I7f1c5b0e86b444674d8b4f13da8eeab37121ba13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679953}
-
Christopher Grant authored
Supersize compares sections sizes between the map and elf files to ensure they match. However, with partitioned libraries, some sections are automatically generated when extracting the partitions from the original combined library, and hence impossible to compare sizes. Similarly, the map file contains duplicate sections for each partition. Since SuperSize currently analyzes the main .elf, we need to ignore sections (eg. .text) for the partitions. In the future, the script can be improved to return section sizes for all partitions (ie. a set of sets of section sizes). Bug: 982334 Change-Id: I240d06bdaa405c9c1984ddf82e4244fc9df5dda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708201 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#679952}
-
stkhapugin authored
This prevents the trialing button from being accessible by voiceover when it's not enabled. Bug: 985763 Change-Id: Ibf1e1270984c76df5c54373beb15f0f222b6ab07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713513 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#679951}
-
Philip Jägenstedt authored
Because `[NoInterfaceObject]` is used, this is essentially an internal rename, but can be observed by scripts in principle by calling `event.toString()` or `Object.getPrototypeOf(event).constructor.name` given an instance. However, this type of dependency is unlikely. This will make unprefixing a smaller change. Bug: 570968 Change-Id: Ib7bba61df2a8b087146b49db81918eaf5950bc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713552Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#679950}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Id65e5d833e4ccf16df6fa5c15f321b7bd38becb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710599 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#679949}
-
Alex Chau authored
- message_id with serial number in Android secondary users: 0:1563805165426489%20#0bb84dcff9fd7ecd - Expected message_id: 0:1563805165426489%0bb84dcff9fd7ecd - As per go/persistent-id, userId# (20#) is optional, and should be stripped when comparing persistent ids. Bug: 986270 Change-Id: I123f0412afcbaaae625a04000aeb7c86770b769b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712881 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#679948}
-
Leo Zhang authored
Change single contact to a group. Extend some important metrics to end of next Q1 Bug: 937152 Change-Id: Iee335114d66b1bc2d7ea37d4720b6e9edbb436cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712953Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Auto-Submit: Leo Zhang <googleo@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#679947}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/02407743bd72..cd369bb8a251 git log 02407743bd72..cd369bb8a251 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 76b75c40a1e2..3855447d93eb (3 commits) Created with: gclient setdep -r src/third_party/angle@cd369bb8a251 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:None Change-Id: I2b5bcc828ac029e5d5cfcded4d10845aa74a0151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714132Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679946}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9b62ca7f. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" ee7626e7 "Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iaab7010cc9bc6bca5b28fe76d5cd77ad631f23bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714280Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679945}
-
Edvard Thörnros authored
This should in theory give performance increases, and has made the code easier to read by moving all GetNextFireTime related computations into the relevant method. This resulted in that one member could be removed. This was purely a refactor commit and no breaking changes should have taken place here. Bug: 981522 Change-Id: Iba72d8ca48e1aaff1ae271033e9d57650ddc1eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710578 Auto-Submit: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#679944}
-
Vladislav Kuzkokov authored
This has been refactored as of crrev.com/daa569a1 Bug: 968109, 714018 Change-Id: I19ae08bb1e4a9df3f541c3456b4c32e9d494be39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710643Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#679943}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2bb2da919352..302fe97e7b02 git log 2bb2da919352..302fe97e7b02 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 cepheus@frii.com Revert "Merge pull request #1792 from Roy-AMD/automapping-opengl-location" 2019-07-23 johnkslang@users.noreply.github.com Merge pull request #1792 from Roy-AMD/automapping-opengl-location 2019-07-23 johnkslang@users.noreply.github.com Merge pull request #1847 from alelenv/member_remap_fix Created with: gclient setdep -r src/third_party/glslang/src@302fe97e7b02 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Change-Id: Ie660d36af70da5723de50c7a4cc6bf0f424f0b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714886Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679942}
-
Henrique Ferreiro authored
After the IdentityManager code restructing into public and internal APIs was fixed in https://crbug.com/952788, this CL fixes both build dependencies and presubmit checks in //components. Bug: 970268 Change-Id: Ie4ecf25fa054c2f2b14dcd115988678494ae007b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710316 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#679941}
-
Yuvanesh Natarajan authored
The function UpdateBaseBackgroundColorRecursively() sets the base background color for the root and all of its subtree in a pre-order manner. Hence removing the call SetBaseBackgroundColor() as it is redundant. Bug: None Change-Id: I811ab6563377a0f52a452aaf14857517b5ea15c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714114Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#679940}
-
Maks Orlovich authored
What's strange is that in-NetworkService BadMessage catchers on desktop doesn't seem to see this check failing. Bug: 983090 Change-Id: I4ddd91909635fb978c7e0675ed48a567de8f0bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713391Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#679939}
-
Jose Dapena Paz authored
PendingRemote has moved to declare its move operator/constructors noexcept. But it requires its members to do that too. We were missing noexcept in PendingRemoteState. Bug: 819294 Change-Id: I95af4c8d96a89c5a7991f414624a2a47d16494e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713527Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#679938}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f9010f590b1d..78011069970f git log f9010f590b1d..78011069970f --date=short --no-merges --format='%ad %ae %s' 2019-07-23 dberris@chromium.org Pinpoint: Set CSS config for autocomplete elements Created with: gclient setdep -r src/third_party/catapult@78011069970f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:986704 TBR=skyostil@google.com Change-Id: I3d5b2ca8879d7016d01dffd4e75d3b40c2ace4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714123Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679937}
-
Yuki Shiino authored
Resolves references to dictionaries (other references are resolved to stubs for the time being), and dumps the database object into a pickle file. 'pickle' only supports top-level classes, so DebugInfo.Location is moved to a top-level class. Also, reference-stubs are temporarily necessary to pickle web_idl.Proxy instances. Bug: 839389 Change-Id: Ifbdca0df8d34d1cad49bca854b32f0524aaff758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713066Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#679936}
-
Pavel Shmakov authored
This CL: - Makes BrowserSessionContentUtils a non-static singleton to facilitate unit-testing of it, and of whoever uses it. - Changes "Utils" to "Holder" in the name: it is stateful, so it's not "Utils". - Cleans it up: it should just be a bridge to the active BrowserSessionContentHandler, and it is the Handler who should do the actual handling of calls and intents. - Adds some unit tests. The next step will be to move the BrowserSessionContentHandler implementation out of CustomTabActivity. Bug: 916542 Change-Id: I22cb94c464af880df133a0c2d5142e5092be8dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660652 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#679935}
-
Christopher Gunadi authored
By default, root access to Crostini is allowed. This experimental user policy and pref will be used to control whether user root access to Crostini is allowed. The functionality for this will be hidden behind a feature flag. This CL only contains initial definition for the policy and pref, along with wiring them together. Bug: 983997, 983998 Change-Id: I629885b0423264b668de577e71c3c396a74c9d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702369 Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#679934}
-
Benoît Lizé authored
From the finch experiment (see linked bug), this saves .7-5MB of memory per renderer on Windows and Android, at a cost of ~0.01% of idle time main thread CPU. As a consequence, enabling it by default. Metrics note: The impact it not expected to be seen in the reported metrics, see the bug for details. This may even be reported as a slight memory regression, which is expected. In this CL: - Enable periodic decommit by default - Update the unit tests accordingly. The feature is not removed yet, to leave the possibility to disable it on the M77 branch. Bug: 942512 Change-Id: Ia673c55a62e0c273645dc783bbde2f9458a72d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712563Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#679933}
-
Jan Wilken Dörrie authored
Provides convenience templates that dispatch to correct type in winrt system, as well as helpers for copy, equality and comparison. BUG=728870 TBR=gab@chromium.org, robliao@chromium.org Change-Id: I3d4f19471778d5a25c13a30ea9203add0aadb4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695407 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#679932}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie723315d2dd022bbb428d5706824f5a33b4622fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679931}
-
Yasmin authored
Bug: 986327 Change-Id: Ia2f987d65a4e09c1d368552a729ada79901c43ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713167Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#679930}
-
Michael van Ouwerkerk authored
Bug: 976311 Change-Id: Ib3dc2d0e3d47ca2452749f912f8ffc2a687b6861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709580 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#679929}
-
danakj authored
R=dcheng Bug: 912193 Change-Id: Ic61fec531ad323dfe174930deb9dc9ec64c46b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713704 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#679928}
-
Stephane Zermatten authored
This change implements AutofillAssistantFacade.createDirectActionHandler based on AA. This implements two direct actions list_assistant_actions and perform_assistant_action. list_assistant_actions lists available direct actions, as returned by Controller:GetUserActions. If needed, it creates a controller and calls Controller::Track to wait for the first set of scripts to be available. perform_assistant_action executes a direct action, which comes down to finding the user action whose name matches and then performing it on the controller. Performing an action with no name triggers the autostart logic in Controller::Start. The implementation takes care of loading the DFM, if necessary, and runs onboarding as necessary or when asked explicitly by the caller. Bug: b/134741524 Change-Id: I29bbc7b535f7007b4552cd523722cd97e47c5a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699607 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#679927}
-
Sergio Villar Senin authored
They're much better placed there than directly under platform/ Bug: 919385 Change-Id: I9583741da31e28217a9f331322ca8246984b94eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713190 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#679926}
-
Yi Su authored
WebFramesManager is a sub component of WebStateImpl, it should be an ivar like NavigationManager instead of WebStateUserData like FindInPageManager. Converting it to ivar will remove unnecessary "static_cast" in WebFramesManagerImpl, improve testabibiliy and decouple it from WebStateImpl. Bug: 956516 Change-Id: Icb3d91c1f7c42350ca5ed22f5a5aab88de9ffabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710310 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#679925}
-
Richard Knoll authored
This makes sure that we clear any existing text of the omnibox icon when switching to a different tab. Bug: 986053 Change-Id: I2036547046edae1d2869ab7d512ade92e8cab9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712670Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#679924}
-
Monica Basta authored
The part of DICE population isn't migrated because they are in an inconsistent state between the chrome and gaia accounts. In this CL, we compute the reason of inconsistency and upload it to UMA. We need this histogram to measure how the population to be migrated to DICE will be affected by the transition. The reason of inconsistency will derive the actions needed to migrate to DICE and how the user will be affected. We only record this metric to UMA if account consistency method is kDiceMigration. Bug: 983983 Change-Id: I85815e4fd18ea1fd86000a186c0e3b29e8cc30a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700209 Commit-Queue: Monica Basta <msalama@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#679923}
-
Juan Antonio Navarro Perez authored
The catapult CL: https://chromium-review.googlesource.com/c/catapult/+/1713628 is changing slightly some messages in run_benchmark's command line interface. This CL adjusts the test expectations so they match the new interface, but keeps these tests disabled for now. After the catapult CL above lands, the tests can be re-enabled. TBR=crouleau@chromium.org Bug: 928275 Change-Id: If2f9f70862a923a67dcc534ab25433fbc4f2f7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713629Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#679922}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0c0d6d8e6b38..f9010f590b1d git log 0c0d6d8e6b38..f9010f590b1d --date=short --no-merges --format='%ad %ae %s' 2019-07-23 dberris@chromium.org Pinpoint: Host Dashboard static files too Created with: gclient setdep -r src/third_party/catapult@f9010f590b1d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:986704 TBR=skyostil@google.com Change-Id: Iffa50f75cba89aec2ce846670afda9e3f2c0d8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679921}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/07b5be3bc5df..4e3b218e9695 git log 07b5be3bc5df..4e3b218e9695 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 cwallez@chromium.org Introduce a format table in the OpenGL 2019-07-23 jiawei.shao@intel.com Fix missing header in OpenGLFunctions.cpp Created with: gclient setdep -r src/third_party/dawn@4e3b218e9695 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: Ife6097ff8a5331e3a0eb6da7bdcca3d33ea1e28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679920}
-