GitLab

Add an explicit method on GLSurface that is to be called while the
GLContext is still current, but before the GLSurface is destroyed.

A step in this direction was taken in https://crrev.com/538387, where
we made the GLContext current again after its decoder had been
destroyed, but that path has proved unstable. In particular, the
GLSurface internals on macOS are created while the decoder is active,
and so destroying them after the decoder is destroyed is precarious.

Bug: 772576, 817830
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3ff1c395c4e9d7ac0b0f1ab54400cde28bdbe298
Reviewed-on: https://chromium-review.googlesource.com/1046046Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557250}

This CL implements tests for a couple of TODOs that arose during the
initial code review for my content layer changes for this feature.

During implementation I found an issue where we weren't clearing
KeyboardLock during navigation, that now works correctly.

A big portion of this change involves codifying the behavior between
iframes and the KeyboardLock feature.  I haven't written many of
these tests before so I'd like to make sure that the tests I have
are set up correctly, testing what I think they are testing, and
the behavior I have codified is reasonable.

BUG=680809

Change-Id: Ief1fbfef48d396f4df72319bb5bb61120033eada
Reviewed-on: https://chromium-review.googlesource.com/1041137Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557249}

Note that this doesn't handle the case where the banner is already open
when entering VR. That's complicated and I'm not going to try to merge
a fix for that back to M67.

(This CL is targeted for M67)

Bug: 840811
Change-Id: I9e4daba4baeed7aeb8f5b841fdb7acb1f7872ff7
Reviewed-on: https://chromium-review.googlesource.com/1052211
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557248}

Small cleanup - there should be no behaviour change.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ife84f116812fc949f039418168b5d005096c46c2
Reviewed-on: https://chromium-review.googlesource.com/1052208Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557247}

Bug: 818331
Change-Id: I811f3f12af9c75e9be2581d38e89093deb023c0a
Reviewed-on: https://chromium-review.googlesource.com/1050877
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#557246}

Used in "<extension name> is debugging this browser" infobar.

Bug: 823194
Change-Id: Iff6627097c020cccca8f7cc3e21a803a41fd8f2c
Reviewed-on: https://chromium-review.googlesource.com/1048064
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557245}

It is suspicious that GetDocument() can be nullptr in
ImageDocumentParser::AppendBytes().
This CL adds an IsDetached() check there, just like
DecodedDataDocumentParser::AppendBytes() does.

Bug: 826198
Change-Id: I297fe5bbe609a380ce8a175529d1216a88d1c1ee
Reviewed-on: https://chromium-review.googlesource.com/1050697Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557244}

downloadTotal is a field that can be set by the developer from the fetch() API, through
BackgroundFetchOptions (https://wicg.github.io/background-fetch/#dictdef-backgroundfetchoptions).

Before this change, the progress bar in the UI showed a percentage based on number of files
downloaded. After this change, the progress bar will use bytes downloaded out of total bytes to be
downloaded to calculate this percentage.

If downloadTotal is set incorrectly (larger than total size of downloads), or not set at all, we
fall back to previous behavior. Additionally, we update the progress bar more often with this
change -- whenever DownloadManager notifies us of more bytes downloaded (~500 ms) instead of only
updating when a download is completed or aborted.

Bug: 813565
Change-Id: Ia704ea99b9ee3966aabb3f64a4ccd2112e36ab80
Reviewed-on: https://chromium-review.googlesource.com/998105
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557243}

Bug: 837446
Change-Id: I8e2d61e50fe9bf800a1577642a458791fb777057
Reviewed-on: https://chromium-review.googlesource.com/1048401Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557242}

Using wpt-import in Chromium 737f592b.
With Chromium commits locally applied on WPT:
04a79336 "Send boundary events rightaway after pointerup"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17191

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
alexander.shalamov@intel.com, kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com:
  external/wpt/web-nfc
chcunningham@chromium.org, wolenetz@chromium.org:
  external/wpt/media-source
chongz@chromium.org:
  external/wpt/pointerlock
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
mlamouri@chromium.org:
  external/wpt/screen-orientation
panicker@chromium.org:
  external/wpt/page-visibility
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=danyao

No-Export: true
Change-Id: I31bec31c54e422553a77d31ec8d9af1c0a031422
Reviewed-on: https://chromium-review.googlesource.com/1052427
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557241}

https://chromium.googlesource.com/catapult.git/+log/718dbe7d3244..483449aa724f

$ git log 718dbe7d3..483449aa7 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 dtu [pinpoint] Use Telemetry Quests for the `performance_test_suite` isolate.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:822008


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I3e19c0f6b0d2e62388a2495c7ca32fd2e2bfac27
Reviewed-on: https://chromium-review.googlesource.com/1052221
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557240}

Details of when APIs should be called described in bug.

Note: This CL also removes an auto dismiss timer that was previously
added when there was no other way to exit. Removing it now that
keyboard shortcuts have been wired up.

Bug: b:79369258
Change-Id: I41f2c4b24a44a1ee55ca134b8f51cc19e1020b8d
Reviewed-on: https://chromium-review.googlesource.com/1048386
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557239}

We are trying to show SignedExchange related information in DevTools.
https://bit.ly/2HXVbCU

This CL introduces a new DevTools event “signedExchangeReceived".
SignedExchange related information (SignedExchangeInfo) will be sent to
DevTools in this event.
SignedExchangeInfo will contain:
- The outer response not to show the internally generated redirect response.
- The signed exchange header information.
- The certificate information.
- The error messages if error occured.
This CL only introduces SignedExchangeInfo.outerResponse.

When the signed exchange request is a navigation request,
|devtools_navigation_token| can be used to find the matching request in
SDK.NetworkManager.
But when the signed exchange request is a prefetch request, the browser process
doesn't know the request id used in DevTools. So SDK.NetworkManager uses
|_inflightRequestsByURL| to find the matching request.

For navigation case, |devtools_navigation_token|, |url| and |report_raw_headers|
flags are passed from NavigationRequest through NavigationRequestInfo,
WebPackageRequestHandler, WebPackageLoader, SignedExchangeDevToolsProxy,
RenderFrameDevToolsAgentHost, NetworkHandler to SDK.NetworkManager in DevTools.
For prefetch case |url| and |report_raw_headers| are passed from
PrefetchURLLoader through WebPackagePrefetchHandler and WebPackageLoader.

Bug: 830505
Change-Id: I186debe50c283b1cdfb9ae268a06fea143edcc6d
Reviewed-on: https://chromium-review.googlesource.com/1027554
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557238}

Bug: None
Test: trybot
Change-Id: Icc705f01e2742f02fa58cd2107efdbb0733860c0
Reviewed-on: https://chromium-review.googlesource.com/1052380Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#557237}

Create a cc::Layer directly in LinkHighlightImpl instead, and wrap it
in a WebLayer.

R=pdr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I74d40aab18600f9970e1a9e356d93fde2e793b6a
Reviewed-on: https://chromium-review.googlesource.com/1047950
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557236}

https://pdfium.googlesource.com/pdfium.git/+log/5f7c5be8b707..27924e6c9d43

$ git log 5f7c5be8b..27924e6c9 --date=short --no-merges --format='%ad %ae %s'
2018-05-09 rharrison Do not build TIFF when codec is disabled

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If379eb62256ee620710aaa3b9b0950e9ae0a5e26
Reviewed-on: https://chromium-review.googlesource.com/1052368
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557235}

Bug: 636993
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8ef71a1012af008b9cafc497aba7802be23a2880
Reviewed-on: https://chromium-review.googlesource.com/1051548Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557234}

https://skia.googlesource.com/skia.git/+log/a2595f925596..97c110860758

$ git log a2595f925..97c110860 --date=short --no-merges --format='%ad %ae %s'
2018-05-09 egdaniel Revert "SkAdvancedTypefaceMetrics: factor out GlyphToUnicode"
2018-05-09 skcms-skia-autoroll Roll skia/third_party/skcms 289cedc..f771d23 (1 commits)
2018-05-09 mtklein clean up some SkDebugf()
2018-05-09 csmartdalton ccpr: Cleanup on-flush path stats
2018-05-09 robertphillips Cleanup SK_IGNORE_BLUR_IMAGE_FILTER_FIX (since Chrome no longer uses it)
2018-05-09 fmalita [skottie] Null value crash in json::ValueRef::toString()
2018-05-09 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ d4e488eb6..0641aebe3 (1 commit)
2018-05-09 brianosman When validating transfer fns, allow D > 1
2018-04-10 halcanary SkAdvancedTypefaceMetrics: factor out GlyphToUnicode

Created with:
  roll-dep src/third_party/skia
BUG=chromium:841110


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I7ba86504e42883b6f8243a89fad3b3db2ebdf181
Reviewed-on: https://chromium-review.googlesource.com/1052225Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557233}

As part of our User Activation v2 work (to replace old
UserGestureIndicator-based code), we are moving all
activation consumption calls to the browser side to
avoid possible double consumptions with OOPIFs.  This
CL replaces one consumption call with a fixed inactivate
state.

Bug: 780556
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idef304c1d58ccab3d981084c48e61c3d1b6a1ef9
Reviewed-on: https://chromium-review.googlesource.com/1045272
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557232}

Own a cc::PictureLayer directly in GraphicsLayer and LinkHighlightImpl
and expose it instead of WebContentLayer*. Wrap it in a WebLayer for
interactions that require one of those for now.

R=chrishtr@chromium.org, jbroman@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5486b58337987dbfa13e2048dcdf10ae059beea5
Reviewed-on: https://chromium-review.googlesource.com/1048545
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557231}

Got rid of cc::OrderedSimpleTaskRunner dependency and slightly
cleaned TaskQueueManagerImpl unittests while adjusting the code.

Bug: 783309
Change-Id: Ibc31281b1dcdf6750b2fcc9e07bc7d7dfe1e85af
Reviewed-on: https://chromium-review.googlesource.com/1037144
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557230}

This is a small cleanup to use the size directly, if available, rather
than creating the rect and then just getting the size. Found while
working on https://crbug.com/838111

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I678fc42b76bcda168b8e5f68fd9c357ad57dca42
Reviewed-on: https://chromium-review.googlesource.com/1050969
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557229}

- Don't depend on external resources for presentation URLs. Changed
the url in the test from https://google.com to a local page.
- One-UA no-receiver tests need to fire up a EmbeddedTestServer in order
for presentation URLs to resolve to https: scheme.

Bug: 840059
Change-Id: If5c4bc7e00b75a37d5df94e05b1ebad49e7cdd67
Reviewed-on: https://chromium-review.googlesource.com/1050885Reviewed-by: Adam Parker <amp@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557228}

Change-Id: Ife4a5f712ad0f054ffa7dbe3681142a6da94326e
Reviewed-on: https://chromium-review.googlesource.com/1042532Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557227}

LUCI Chromium Trybots seem to work fine with the change. This will
unblock ANGLE and other projects that might want to test their
changes with Chromium, which is the main use case.

Bug: 643346
Change-Id: I1649fda2773e4346cf48bdc6b364fe884a0e4e5e
Reviewed-on: https://chromium-review.googlesource.com/1050802Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557226}

This could be useful during debugging.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idddc32b00128a46ae2db2cabbdc69a4ed5e2fcbe
Reviewed-on: https://chromium-review.googlesource.com/1050442
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557225}

https://webrtc.googlesource.com/src.git/+log/c6c44268bcb5..a29b148557b0

$ git log c6c44268b..a29b14855 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:826914,chromium:841193,chromium:851187,chromium:839860


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia175141797bf07db2094a2b43e74a71db4377ecc
Reviewed-on: https://chromium-review.googlesource.com/1052216
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557224}

Adds SmbUrl class which is used to represent Smb URLs. Includes unit
tests.

Bug: 757625
Change-Id: I2105f08a0df55dbaa0d50b1637d419a6cf5335f7
Reviewed-on: https://chromium-review.googlesource.com/1048745Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557223}

Merege internal change 195881570

R=rch@chromium.org

Bug: 840734
Change-Id: I2002111d42876e8c2b0d66850be67dea3c67cfdb
Reviewed-on: https://chromium-review.googlesource.com/1051728Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557222}

This allows the config server to send an empty config in order to
effectivly turn off DataSaver if needed.

Bug: 840978
Change-Id: I7b5e57728737401c286da29ccbd7cc4564c73732
Reviewed-on: https://chromium-review.googlesource.com/1050805
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557221}

This CL introduces RequestNewLocalSurfaceId API to LayerTreeHost so that
LocalSurfaceIds can be allocated on the compositor thread. A request will
be only made once for a given commit.

This request is plumbed from LayerTreeHost to the pending tree and active
tree on the impl thread and then onto the LayerTreeFrameSink.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I68ad2e9092f68e17033aa81dc4f1e392149bc720
Reviewed-on: https://chromium-review.googlesource.com/1050735
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557220}

This patch extracts code to display an avatar with an email and an
optional name from IdentityPickerView into IdentityView.

This code can be share between IdentityPickerView and the identity
chooser dialog in this mock:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQNtxfU4ytJv/files/MCHtA7U1iMGr62Mmhjs3q0iDhQHgIuNdWV0

Bug: 827072
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib7df934aa678c35b42b8a37c71dfac6fd52ca5c4
Reviewed-on: https://chromium-review.googlesource.com/1044373
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557219}

Re-implements NodeFilter based on CallbackInterfaceBase.

Major changes are the followings:

a) Custom implementation V8NodeFilterCondition is gone in
this patch as we have auto-generated V8NodeFilter.

b) NodeFilter.h is also gone.  V8NodeFilter provides
IDL constants directly.

c) The old implementation didn't perform any type check.
Passing 0 (zero) as NodeFilter was okay and it was
treated as if |null|.  With this patch, the generated
code performs a regular type check.

Bug: 778580

Change-Id: Ifb95aa78ead36081ece9bd6616ffb23d0704b67b
Reviewed-on: https://chromium-review.googlesource.com/1011864
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557218}

BUG=799180
R=gayane@chromium.org

Change-Id: I83d0a362b9f52cfdf0db4e9eba48c6494dfcdad7
Reviewed-on: https://chromium-review.googlesource.com/1050978Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557217}

BUG=838970

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I28a0a55d4fb1d248a53ced7f721df128d470c34f
Reviewed-on: https://chromium-review.googlesource.com/1041164
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557216}

The bulk of these tests depend on having a Cocoa browser window and the
related infrastructure.

Bug: 834754
Change-Id: I304222489cf28fb8e69914f24ae646198aeca352
Reviewed-on: https://chromium-review.googlesource.com/1050194
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557215}

Use network-service-reviews@chromium.org to watch for network service CL reviews.

Change-Id: I4894e393a8933be05dd8e10021346b328598ba3d
Reviewed-on: https://chromium-review.googlesource.com/1052309Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557214}

Bug: 839981, 656015
Change-Id: I086a8c448c4192317538d4994ccceb65ba20ef0a
Reviewed-on: https://chromium-review.googlesource.com/1050249Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557213}

Bug: 838328
Change-Id: I3b0ba96d4351bdd48467e58a2a58d6dbfe11b163
Reviewed-on: https://chromium-review.googlesource.com/1052167Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557212}

This reverts commit f3f89493.

Reason for revert: Causing failures

Original change's description:
> [Perf] Enable system_health.* for histogram uploads
> 
> This CL switches all system_health benchmarks to the histogram pipeline.
> 
> Bug: 744736
> Change-Id: Icb97397ec417d27220e489651cc51591757d8c9e
> Reviewed-on: https://chromium-review.googlesource.com/1048626
> Reviewed-by: Emily Hanley <eyaich@chromium.org>
> Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556842}

TBR=eakuefner@chromium.org,eyaich@chromium.org

Change-Id: I53f1788cc1f488b207a0718e8fbe14e2899af5b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 744736
Reviewed-on: https://chromium-review.googlesource.com/1052407Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557211}