- 23 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d257440b81e5..55ae76d9fed9 2020-06-23 thestig@chromium.org Change enum CPDF_IconFit::ScaleMethod to follow the style guide. 2020-06-22 thestig@chromium.org Change some XFA enums to follow the style guide. 2020-06-22 thestig@chromium.org Add experimental FORM_SelectAllText() API. 2020-06-22 thestig@chromium.org Use std::vector in CFX_SkiaDeviceDriver::PaintStroke(). 2020-06-22 thestig@chromium.org Fix some nits in dash drawing code. 2020-06-22 thestig@chromium.org Minor improvements for FXGC code. 2020-06-22 thestig@chromium.org Remove nullptr checks in FreeType deleters. 2020-06-22 thestig@chromium.org Fix typo preventing FXGC_Release() from running. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I2d233361d7502ac90bbcb618b510d8a03d5b9fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781200}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7db2dceccdad..9daab8cbffb7 2020-06-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 74ed6cfd05c1 to 71c1a611fdbb (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I8e1c736d85efc8f39e596fa94b32f691118b5f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259594Reviewed-by:
-
Toni Barzic authored
When drag from app list to shelf is started, the dragged item is pinned to shelf. Currently, items added due to user action (e.g. pinning) are scrolled to visible when added. This is undesirable behavior for drag and drop. The item is initially added at the end of the shelf view, before moving the item to the hovered index. This means that the shelf would scroll to the end when starting drag from app list, making it hard to target the beginning of the shelf view when the shelf does not fit in the available space. BUG=1097629 Change-Id: I0f04853bf31a80fd7c90d532fc0f4d5e7c761938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259475 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781198}
-
Peter Kasting authored
* GetOpacity(), PaintDownloadComplete(), and PaintDownloadInterrupted() can be combined into a single block and inlined into the callers. * At this point making PaintDownloadProgress() a const member avoids the need to pass in the theme provider. * Passing in the bounds instead of translating the canvas is simpler. Bug: none Change-Id: I9e64969731dc8b440e943bf7823620c282b67124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256364 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#781197}
-
Hayato Ito authored
This reverts commit 953a91e2. Reason for revert: This CL might be culprit for MSAN test failures. Please see https://bugs.chromium.org/p/chromium/issues/detail?id=1098172#c2 I'm not 100% sure, but let me revert the CL as a sheriff. Original change's description: > Add OnReady callback to the speech recognition client > > This CL adds a callback to the speech recognition client that is called > when all of the mojo pipes are bound, indicating that the speech > recognition service is available. > > Bug: 1096632 > Change-Id: I153685c95be5d3de818de9ed06b51e039dae8573 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252566 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Abigail Klein <abigailbklein@google.com> > Commit-Queue: Evan Liu <evliu@google.com> > Cr-Commit-Position: refs/heads/master@{#781059} TBR=sky@chromium.org,dalecurtis@chromium.org,abigailbklein@google.com,evliu@google.com Change-Id: I475cdfdad47c38dbcd5c17b45612168913fea224 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1096632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259697Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#781196}
-
Mitch McDermott authored
Previously when we encountered an error during SaveCopy, we would sometimes just pass the error name and miss out on a lot of useful information. This CL removes that handling and just lets the error object propagate through the app. Other half of this change is http://cl/317591265. Bug: b/152809763 Change-Id: I65017f6b5359a8f22a7e9a33952b980f547833d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256115Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Mitchell McDermott <mcdermottm@google.com> Cr-Commit-Position: refs/heads/master@{#781195}
-
Colin Blundell authored
Followup from discussion on https://chromium-review.googlesource.com/c/chromium/src/+/2247894 Bug: 1093846 Change-Id: I074b3c42bd1e381dbc707f809158acdeb9a1dcab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257185 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#781194}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4cf65bcab596..8ab3719fc486 2020-06-23 enga@chromium.org Fix validation of multisampled BGL bindings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1097501,chromium:1097514 Tbr: cwallez@google.com Change-Id: I2f7f56d61805f80e2b3a9953016017d9ddc88e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259712Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3231e4267bf8..58d0c5d57da6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1093359,chromium:1093380,chromium:1097670,chromium:927487 Tbr: hayato@google.com Change-Id: If31d6db04ee5052f9cf4a7e3bd00cc6e7c7ceb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259372Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781192}
-
Joel Hockey authored
PluginVm is now at paths: /app-management/pluginVm/sharedPaths /app-management/detail I determined the hash values by loading these pages and then looking at chrome://histograms ChromeOS.Settings.PathVisisted. Also see crrev.com/c/1089716. Bug: 1094921 Change-Id: I6e8d6495be7d146545504daa0be2ce806315d053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257662 Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#781191}
-
Julie Jeongeun Kim authored
This CL moves the build configuration for ax files from //ui/accessibility/platform to //ui/accessibility/platform/BUILD.gn. It introduces test_ax_node_helper.{cc,h} to support a test helper for //ui/accessibility and avoid including TestAXNodeWrapper. AX-Relnotes: n/a. Bug: 1080478 Change-Id: Icb8e8b0ede3f22c7aafd0b19bf9edecaef9206a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251860 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#781190}
-
Timothy Loh authored
Change-Id: Ic5d4b1ac561c5c64df51010671ca92e04153604d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259692 Commit-Queue: Timothy Loh <timloh@chromium.org> Commit-Queue: Daniel Ng <danielng@google.com> Auto-Submit: Timothy Loh <timloh@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#781189}
-
Andrew Xu authored
Enable app scaling feature by default. It should be landed after approval from UX. Bug: 1097503 Change-Id: I35dd5a7d0fc60a1fbe98cee76d5851ec942c99ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248168Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781188}
-
Matt Falkenhagen authored
Allows cancelling queued prefetch jobs, for parity with preconnect manager. Bug: 1092329 Change-Id: I1bb227fe9b0a0efe5abb7ec6279a5b8c91073818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255947 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#781187}
-
Hayato Ito authored
TBR=skobes@chromium.org Bug: 1098148 Change-Id: Ibc578fa86a0e79a119436b1b33146d10d24038f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259394Reviewed-by:
-
Songtao Xia authored
Reland 2246182 https://chromium-review.googlesource.com/c/chromium/src/+/2220809 disabled web_tests for the frontend to be checked in. Bug: crbug.com/1066595 Change-Id: I48284ea715d7a50a46ac301106171c4cbc57839a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255878Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Commit-Queue: Songtao Xia <soxia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#781185}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4150b9e6e16d..f5d86efdf299 2020-06-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0c9593f1fd233b141d74304805e0d002a69a370e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259592Reviewed-by:
-
Matt Falkenhagen authored
This refactoring simplifies some manual bookkeeping. It also is helpful for adding the Stop() function, in the next commit. Bug: 1092329 Change-Id: I34494155ea161d3e2a0358b6b3d09b40aef85fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257089Reviewed-by:
-
Hayato Ito authored
TBR=beverloo@google.com, csharp@chromium.org Bug: 1098136 Change-Id: I335a87a449713dc4f7b2d5712a0fdd09657b5810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259695Reviewed-by:
-
Eric Willigers authored
This is the second reland, reverting commit 1c38d210. https://chromium-review.googlesource.com/c/chromium/src/+/2252934 The CL was reverted when there were MSAN failures in AssistiveWindowControllerTest. TBR=agawronska@chromium.org Bug: 1096592 Change-Id: I55d64cac604c5befebe6d35a5cbbde60749f2826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253578 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#781181}
-
Curt Clemens authored
Based on Nearby Sharing Server protos located at https://source.corp.google.com/piper///depot/google3/google/internal/location/nearby/sharing/v1/ Change-Id: Ia2b20570a48eb293fc4c485e97c5f0c044c9fbde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228987Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#781180}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592870283-bd2e27d217e9cf585a262d4149273abf7da557f4.profdata to chrome-win64-master-1592873891-9aa969659841cd452b955e25c2ad23336423bfca.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae25ac90044446456f9c14f38ec4a25f4668ea6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259593Reviewed-by:
-
Kenichi Ishibashi authored
The purpose of introducing the method is to remove GetAllOriginsInfo() calls from ServiceWorkerQuotaClient. ServiceWorkerQuotaClient called GetAllOriginsInfo() to check if there are registrations for an origin. As explained in [1], GetAllOriginsInfo() could be very expensive when there are many origins that have service worker registrations. Instead of calling GetAllOriginsInfo(), we can use |registered_origins_| in ServiceWorkerContextWrapper to provide origins that have registrations. Using |registered_origins_| should be much faster than GetAllOriginsInfo() because we don't need to read all registrations from the database. Performance comparison: It seems that ServiceWorkerQuotaClient::GetOriginsForHost() is called for each origin which has registrations when chrome://settings is opened. In my local environment with 15k origins/registrations, time to finish getting all origins when chrome://settings is opened are: * with this CL: ~4 secs * without this CL: ~44 mins [1] https://docs.google.com/document/d/1iaQGQzovFVL3LxDiyIvVgEUFWMhzrXpdf_6TmuwIICA/edit?usp=sharing Bug: 807440 Change-Id: I804adf45292e9191482ff7f3c412ce03a0eb7bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253259 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#781178}
-
Hiroki Sato authored
Recent changes simplified AXTreeSourceArc::NotifyAccessibilityEvent, but some code comments were not updated. This change updates them. Bug: none Test: build passes. Change-Id: I3da87a03700c96c15f94b439266935dbfd8fbb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259532 Auto-Submit: Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#781177}
-
Christopher Lam authored
This CL adds an option to generate a single mode in CSS rather than outputting all modes. This will allow the Media App, which only has a dark mode, to use generated colors. Bug: 1018654 Change-Id: Iee488b02086f0a27651f4b5fffe68e3e5e0f94ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251419 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#781176}
-
Jimmy Gong authored
Bug: 1053704 Change-Id: Ib6bae83a172b0085abe0061592830929dc38a7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255740Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#781175}
-
John Budorick authored
also fix run-swarmed.py s.t. it passes task aruguments through to the task rather than to the swarming client binary. Bug: 1097306 Change-Id: Ie77dc360a1a0bb4c6370abc00d46b1dd5672ed98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255029 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#781174}
-
James Vecore authored
This CL adds and verifies Polymer3 support in the Nearby Share subpage. A browser test is used to verify the Polymer3 setup is working correctly. The test suites added are: OSSettingsNearbyShareSubPageTest.* and OSSettingsNearbyShareSubPageV3Test.* Change-Id: I9cc1e64bb08eb58ad9c83c1486191fbf4de78e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251062 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#781173}
-
Nicholas Verne authored
The Linux settings subpage causes a call to crostini::disk::GetDiskInfo This in turn causes the termina image to download, which is not what we wanted - we just wanted to use concierge. Bug: 1096771 Change-Id: I2970121f6f7245083f793d23d03ee8b3356d79f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259673 Commit-Queue: Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#781172}
-
Joe Mason authored
This keeps a record of which commits each version of the Chrome Cleanup Tool is built with. Currently this information is stored in tags on the internal repo, but this approach won't work when the tool is built from the public repo. Goes with commit http://shortn/_zVs7MpRCuC in the internal repo that stores the commit hashes in the protobuf. R=drubery Bug: 1004848 Change-Id: I6ae4073f10f571b6b70d35085291b68720898287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253130Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#781171}
-
Jimmy Gong authored
- Updated fonts and header styling to match the ChromeOS app specs. - Added fonts css class. Before: https://screenshot.googleplex.com/0v5T1E2Uc64 After: https://screenshot.googleplex.com/kQZZEvN7FbO Bug: 1053704 Change-Id: I2886a963d3e3b20435fc7192f9389f27d988dc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258689Reviewed-by:
-
Tetsui Ohkubo authored
This CL adds check to serial numbers passed to StartDrag and SetSelection of DataDevice, so that serial numbers that do not exist or serial numbers of invalid event types are ignored. TEST=manual(Install Crostini and gedit, then confirm copy & paste / drag & drop working) BUG=746111 Change-Id: I914ced53a1d96590e24f4c4cb8ed74a43aac659f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255730Reviewed-by:
Mitsuru Oshima (slow:gardening) <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#781169}
-
Nick Harper authored
Change-Id: Id51dceb772d031e480493297c0538489b134f5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258421 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781168}
-
Bugs Nash authored
Also rolls in changes from crrev/c/2257468: Add a stub for mediaApp.AbstractFileList.addObserver(). This is needed to prevent browser test breakages due to missing API. CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/DdHwDgGvGlyPA2ih4uxWvn5jmuug258Nz1wrbgcJHQ8C Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202006220800_RC00.html Bug: b/155461713, b/157949149, b/156201188, b/158043802, b/159567887, b/153594459 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I66f094fd55fb37e2b62faf72218a94f23d7ae6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257464Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#781167}
-
Jeffrey Cohen authored
Bug: 1093383 Change-Id: Ibf9e52d837b5de473944f38f513bd98860711830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258336Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#781166}
-
Yoshifumi Inoue authored
This patch changes |AXLayoutObject::GetNodeOrContainingBlockNode()| to return <li> element instead of :marker element for |LayoutNG{In,Out}sideListMarker| to |IsEditable()| and |IsRichlyEditable()| to return valid value. Note: This is a preparation of enabling EditingNG. Bug: 707656 Change-Id: I19fc7947566e9b4c0723dfd746101a4c92262f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253819 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Peter Kasting authored
Previously, this exposed several methods parallel to those in SimpleMenuModel::Delegate. Simply subclass that class instead. Eliminate a Mac-specific testing API by testing the menu contract rather than the implementation. This requires exposing TextServicesContextMenu's MenuCommands publicly. Cleans up the touched locations, including shortening code, changing DISALLOW_COPY_AND_ASSIGN, and removing disabled test code (which led to removing TextfieldTest.LookUpItemUpdate entirely since what remained did not test what the test purported to test). Also OOLed the ViewsTextServicesContextMenuMac implementation since it was hard to see which methods were overridden etc. Bug: none Change-Id: I338740ab6c17460e5fdc26b4b04e6ce5b8a71277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252635 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#781164}
-
Bartek Nowierski authored
https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL says: "For pointers (address values), use nullptr, as this provides type-safety." Furthermore, NULL/0 won't compile if we change |SomeClass*| to |CheckedPtr<SomeClass>|. See go/miracleptr for more details. Bug: 1080832 Change-Id: I50f88059092300d67ced70751e611c346301b15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255939 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#781163}
-
Tom Anderson authored
BUG=1066670 R=nickdiego,sky CC=msisov Change-Id: I23f36fd0fc3ac2522fdbd3de6b7b670e11352ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252574 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
-
Hayato Ito authored
Bug: 1098067 Change-Id: Ic59d4a6fa6bec083362e535857449a1a5e2388d5 TBR: beverloo@google.com,csharp@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259533Reviewed-by:
-
