GitLab

Otherwise accidental double or triple clicks result in strange
selections of the icon images.

Bug: 783107, 774391
Change-Id: If0493f3a7546d9bc318c622bab30b36ae1e98547
Reviewed-on: https://chromium-review.googlesource.com/c/1461596
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630595}

https://pdfium.googlesource.com/pdfium.git/+log/1ec1b5c17001..471510ee209e


git log 1ec1b5c17001..471510ee209e --date=short --no-merges --format='%ad %ae %s'
2019-02-08 tsepez@chromium.org Fix logic botch in CJX_Object::SetAttribute().


Created with:
  gclient setdep -r src/third_party/pdfium@471510ee209e

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I1939ab132c928f145f9c49ca81767f4f27ee6348
Reviewed-on: https://chromium-review.googlesource.com/c/1461459Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630594}

https://skia.googlesource.com/skia.git/+log/be39f713e530..706a7cd1e826


git log be39f713e530..706a7cd1e826 --date=short --no-merges --format='%ad %ae %s'
2019-02-08 herb@google.com Clearify code around hasImage and hasPath
2019-02-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7fb0b73b1aa7..9686153413f3 (1 commits)
2019-02-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cd4f1fbaabce..2b0553ce59c3 (7 commits)
2019-02-08 reed@google.com update dox for pathmeasure


Created with:
  gclient setdep -r src/third_party/skia@706a7cd1e826

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: Icfc0f82f3a4b571a5612b84fe9853b91e62262d0
Reviewed-on: https://chromium-review.googlesource.com/c/1461460Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630593}

This CL adds push_proto.py which is a adapted from hrome/browser/safe_browsing/push_file_type_proto.py. It's used to push generated binary protos to the Google Cloud Storage Bucket.

The CL modifies the proto generator to write two copies of the binary proto instead of one. The second copy is put under a versioned directory so that it's easier to copy it to the Google Cloud Storage bucket as a whole.

Bug: 640835
Change-Id: I99c7831ee4117802777180fd67e19ae1d131a8cf
Reviewed-on: https://chromium-review.googlesource.com/c/665967
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630592}

In the authenticator options, the “up” flag doesn't mean that user
presence is required, it means that the authenticator supports obtaining
it. So, firstly, rename that field to correctly reflect the semantics.

Secondly, implement this in the virtual CTAP2 device.

(The purpose of this field is a little unclear: creating a credential
unconditionally requires user-presence in the spec. Therefore an
authenticator that's not capable of testing it can never create any
credentials and would appear to be useless. But there we go.)

Change-Id: I129f825a3732da1e0521182f2dc1bc4c9e26e038
Reviewed-on: https://chromium-review.googlesource.com/c/1450640
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#630591}

This CL renames DedicatedWorkerFactory(Client) to
DedicatedWorkerHostFactory(Client) because of following reasons:

- DedicatedWorkerFactory creates DedicatedWorkerHost, not DedicatedWorker.
- SharedWorkerFactory that creates SharedWorker lives in a renderer process,
  while DedicatedWorkerFactory lives in the browser process.

Bug: 731604, 906991
Change-Id: I451ab85d4e6fc5b492b5a26bec931dd571d50f6c
Reviewed-on: https://chromium-review.googlesource.com/c/1459874Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630590}

Adds network_service_headless_browsertests and headless_python_unittests
to the main set of chromium gtests. These suites are pretty quick to
run, and the headless bot which used to run them is being deleted. This
ensures these tests continue to run.

Also disables a test which fails on ASAN.

Bug: 893662, 930356
Change-Id: Ieebf22d1de013c5f476bccdf1bb1d77090f989e4
Reviewed-on: https://chromium-review.googlesource.com/c/1461093
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630589}

This CL adds an API in NotificationManagerProxy to take
ChromeNotification struct when sending notification, to avoid duplicate
variable used in ChromeNotificationBuilder. Also this will enfore
NotificationManagerProxy code path.

Bug: 898269
Change-Id: I4dac598a56da3bb3b2a647445e1b47fe4ead42ce
Reviewed-on: https://chromium-review.googlesource.com/c/1437774
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630588}

End the 2 week slimnav experiment, revert the feature back to disabled.

Bug: 925617
Change-Id: Ia9cc075676ae47184ec1a8691b2316f65a926510
Reviewed-on: https://chromium-review.googlesource.com/c/1460441Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630587}

When U2F requests that go through the native WebAuthn API on Windows time out,
the modal OS dialog for the request gets dimissed but the JS request promise
never gets resolved because the originating tab fails the focus check in
sendResponseToActiveTabOnly(). This appears to be caused by a race between the
cryptotoken-side focus check racing against Windows dismissing its dialog after
receiving the WebAuthNCancelCurrentOperation() call.

As a workaround, skip the focus check for all register timeouts.

Bug: 930015
Change-Id: I8f44e44a4a26d499e6681331d808af58eabbb573
Reviewed-on: https://chromium-review.googlesource.com/c/1461331
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630586}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I8ad9ac0ce5185d47529a9e24c53c404777bc4492
Reviewed-on: https://chromium-review.googlesource.com/c/1461458Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630585}

This is a reland of dcea6896 once the
headless_browsertests issue in https://crbug.com/929873 has been fixed.

CQ-DEPEND=CL:1460068

Original change's description:
> Add GWP-ASan hook to macOS crashpad handler
>
> Add the GWP-ASan UserStreamDataSource to the macOS crashpad handler.
> The GWP-ASan hook determines when an exception is related to GWP-ASan
> and reports additional debug information.
>
> Bug: 912286
> Change-Id: I1cd0227ca8aade1bd17e25b83832cdb8f3e58d5e
> Reviewed-on: https://chromium-review.googlesource.com/c/1457461
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#629881}

Bug: 912286
Change-Id: I9cac247b9e9b81c97f16da74dc95f21de6f9d6e6
Reviewed-on: https://chromium-review.googlesource.com/c/1460120Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630584}

Removes the about:flag for Contextual Search, and takes ownership
of the other contextual-search related flags that are still in use.

Also some minor cleanup of flag ownership for other projects while
we're here.

Change-Id: I6a728f67cb336875b65ccfc266ea8d792c21284a
Reviewed-on: https://chromium-review.googlesource.com/c/1435964Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630583}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/37a08a2a..b3e709a8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I18bb092404afcc2f687a76cb9d91c2d4bef598fe
Reviewed-on: https://chromium-review.googlesource.com/c/1461309Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630582}

Notifying the observers that we have tried to refresh the value but that
it failed adds some useless complexity.

Bug: 771478
Change-Id: I2f44a115f087fbdad583627b0552ecb466866610
Reviewed-on: https://chromium-review.googlesource.com/c/1461330
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630581}

Fix missing includes pointed out by git cl lint.

Change-Id: Idc50ba106c1fead5729988368ec46f25e9b0290b
Reviewed-on: https://chromium-review.googlesource.com/c/1455467
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630580}

The "grit newgrd" command was found broken from a previous refactor.
This change addresses the error.

R=thestig@chromium.org

Change-Id: Ia3fb3c2d06a43d0f8223ccd14febdb71153972b6
Reviewed-on: https://chromium-review.googlesource.com/c/1461345
Auto-Submit: Kalvin Lee <kdlee@chromium.org>
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630579}

The failing expectations are required because hasEnrolledInstrument()
is not yet turned on by default in Blink. These tests pass when running
Chrome with --enable-features=PaymentRequestHasEnrolledInstrument.

Bug: 915907
Change-Id: I2189bfedad813e7942c7ddbd44aac78d1b895a30
Reviewed-on: https://chromium-review.googlesource.com/c/1461313
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630578}

paper-icon-button-light replacements:
 - action menu button on the bookmarks toolbar
 - action menu button for each bookmark entry
 - cr-expand-button
 - cr-toolbar-selection-overlay X button

In cr-toolbar-search-field, the search icon button was changed from a
a paper-icon-button.

cr-expand-button ripple logic was changed to be consistent with other
controls. The ripple is held when focused using the tab or shift+tab.
The ripple stays until the control is blurred or clicked with a
pointer.

Bug: 736891
Change-Id: Ibe0107a096a967cb72ffef795ec983f1c28d18b2
Reviewed-on: https://chromium-review.googlesource.com/c/1436144Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630577}

And rewrite most HttpProxyClientSocketPool tests in terms of it. The
only remaining tests are for HTTP auth, client certs, socket tagging,
or for cases that return a socket on failure, all of which include
some aspect of testing the socket pool as well, and will be delth with
in future CLs.

This CL also changes type of the |respect_limits| argument to
HttpProxyConnectJob to a bool, from a ClientSocketPool::RespectLimits.
HttpProxyConnectJob is otherwise unchanged.

The HttpProxyClientSocketPool class is going to be merged into the
TransportClientSocketPool class, but we'll still need these tests.

This is part of an effort to flatten the socket pools.
https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit

Bug: 472729
Change-Id: Ic0570a7e48ad012da793723bbecbdf04d3659586
Reviewed-on: https://chromium-review.googlesource.com/c/1446563
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630576}

Exposes get_SelectionRanges and SetSelectionRanges methods on Windows for working with arbitrary selection endpoints

The existing get_selection and SetSelection APIs in IAccessible2 are limited because they can only work with offsets in IA2Hypertext.
This patch adds two additional APIs get_selectionRanges and SetSelectionRanges that enable working with arbitrary selection endpoints, similar to how the DOM selection API works.
R=dmazzoni@chromium.org, thakis@chromium.org

Bug: 916794
Change-Id: Id4db856408e4200f44ee5afa140091156d5f6adc
Reviewed-on: https://chromium-review.googlesource.com/c/1385544Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630575}

https://swiftshader.googlesource.com/SwiftShader.git/+log/7fb0b73b1aa7..9686153413f3


git log 7fb0b73b1aa7..9686153413f3 --date=short --no-merges --format='%ad %ae %s'
2019-02-08 schuffelen@google.com Early exit in es2::Context::drawElements on count=0.


Created with:
  gclient setdep -r src/third_party/swiftshader@9686153413f3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/123716871
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: I03c5d5c98ca3a42c285ae6584f6fa6bdb343ea7d
Reviewed-on: https://chromium-review.googlesource.com/c/1461457Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630574}

Change-Id: I67eb6e51a30747d6d58dd725003769aaf3b3632e
Reviewed-on: https://chromium-review.googlesource.com/c/1455468
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630573}

OverridePercentageResolutionBlockSize is a much better name.

Change-Id: I3600fb4d7b711ec1e69991ca3bbcb671fd67e68d
Reviewed-on: https://chromium-review.googlesource.com/c/1448174
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630572}

For the context menu for suggestions project, this adds the
confirmation bubble for Remove Suggestion (from history).

This bubble is not yet hooked up to anything, but is just the UI.

Screenshots here: go/context-menu-for-suggestions

Bug: 929477
Change-Id: I60b7c481c45bb2d1c61584961ad8f69a86e7f9b1
Reviewed-on: https://chromium-review.googlesource.com/c/1461328Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630571}

We use SetTransform() for scrolling sliding browser controls in tablet mode.

BUG=930021
TEST=covered by test

Change-Id: I8357b66e3feaebc6c61be00fe206cb3811a9b477
Reviewed-on: https://chromium-review.googlesource.com/c/1460113
Commit-Queue: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630570}

https://crrev.com/c/1459634 caused rpath_link to be set unconditionally,
but not used if gcc_target_rpath was set. This led to an "assignment had
no effect" error.

Change-Id: Ic5a2167391d49d008f78fa37fdd62bbaa3704eca
Reviewed-on: https://chromium-review.googlesource.com/c/1461354Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630569}

Change TabLifecycleUnit to consider active --> frozen as a valid state
change if initiated from the renderer. Freezing a page through
ChromeDriver will trigger a renderer-initiated freeze event and cause
this transition. This is necessary for wpt tests to work on
DCHECK-enabled builds outside of web_tests.

Bug: 930270
Change-Id: I335ba03eba6046e397c4917561c556eb72216a99
Reviewed-on: https://chromium-review.googlesource.com/c/1460433Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630568}

As described in crbug.com/779066 even with "contain: strict"
we're visiting the whole layer tree when
PaintLayer::SetNeedsCompositingInputsUpdate() is called.
If we call that inside an element that has "contain: strict"
we should be able to avoid visiting paint layers outside that element
as they are not affected.

Right now we're spending a lot of time in "Update Layer Tree" phase
in this situations, calling CompositingInputsUpdater::UpdateRecursive()
for all the paint layers. We should be able to do something better here
thanks to strict containment.

The perftest is based on an attached example on the bug,
it has a huge DOM with 200x200 cells that have "contain: strict".
We force a call to PaintLayer::SetNeedsCompositingInputsUpdate()
in one of these cells (by changing the value overflow property),
and we're visiting the whole layer tree.

BUG=779066

Change-Id: Iaed26bceb9a270e1989b2dc5a9dafff3d6974f39
Reviewed-on: https://chromium-review.googlesource.com/c/1458299Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#630567}

This CL merges the TransportClientSocketPool used for SOCKS proxies with
the SSLSocketPool above it use for SSL tunnels over SOCKS proxies.

This is part of an effort to flatten the socket pools.
https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit

Bug: 472729
Change-Id: I34a7b575eb7a937adabccfd13d9748edeb170e97
Reviewed-on: https://chromium-review.googlesource.com/c/1449131Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630566}

Bug: None
Change-Id: I3b6693b4c3e6c07806da8899a0f44b46450ff9ee
Reviewed-on: https://chromium-review.googlesource.com/c/1461178Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630565}

The comment says about desktop-linux but the ifdef includes
ChromeOS unexpectedly. Seemingly this hiding actually resolves
gotchas happening on attaching, possibly because it can exclude
the window-to-disappear properly.

Bug: 930004
Test: manually
Change-Id: I2ee10e0cbdfc4b15c168e3c3c2c51b33d0a7b563
Reviewed-on: https://chromium-review.googlesource.com/c/1460859Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630564}

The former non-overloaded variants are deprecated.

This is a mechanical change; there is no intended behavior change.

Bug: 929827
Change-Id: I11213229cc0b41f2f32a5545252d659ceeffe559
Reviewed-on: https://chromium-review.googlesource.com/c/1461377
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#630563}

This reverts commit c8e48580.

Reason for revert: The test is failing as part of non_single_process_mash_browser_tests.

Original change's description:
> Reenable NetworkContextConfigurationBrowserTests on ChromeOS.
> 
> crrev.com/c/1460185 and crrev.com/c/1457478 should have fixed these
> tests on ChromeOS.
> 
> Bug: 927293
> Change-Id: I506f4f5023e431df942797c6820feb7997e514cf
> Reviewed-on: https://chromium-review.googlesource.com/c/1460125
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630415}

TBR=mmenke@chromium.org,rmcelrath@chromium.org

Change-Id: Ib68f2ead09605f798f444f02fcfbc10e699860b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 927293
Reviewed-on: https://chromium-review.googlesource.com/c/1461510Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630562}

Change-Id: I3e14d19bef87a2f91d5cb7749afbd65a1c0323a3
Reviewed-on: https://chromium-review.googlesource.com/c/1452918Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630561}

This CL adds a context menu for suggestions. It currently only contains
a "Remove suggestion..." entry to mirror the Shift+Delete behavior,
but currently doesn't do anything.

In the future, it will be wired to a confirm bubble.

Bug: 929477
Change-Id: If12de2e04c41c4a639fd31a39a80efeac936883c
Reviewed-on: https://chromium-review.googlesource.com/c/1457234
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630560}

https://skia.googlesource.com/skia.git/+log/e59d40e0bcab..be39f713e530


git log e59d40e0bcab..be39f713e530 --date=short --no-merges --format='%ad %ae %s'
2019-02-08 jvanverth@google.com Add Metal context to Viewer.
2019-02-08 bsalomon@google.com Add GrContext::resetGLTextureBindings().
2019-02-08 jvanverth@google.com Manage Mac paint events more directly.
2019-02-08 benjaminwagner@google.com Distinguish DDL in Gold results.
2019-02-08 halcanary@google.com SkQP: make text context outlast gm


Created with:
  gclient setdep -r src/third_party/skia@be39f713e530

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:926017
TBR=fmalita@chromium.org

Change-Id: Ib478b33e1cb433103301aad6a7712c86ccfec242
Reviewed-on: https://chromium-review.googlesource.com/c/1461155Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630559}

Bug: 889819
Change-Id: I102d62cf4a8e050566a17b9796abcbc56e77ea0b
Reviewed-on: https://chromium-review.googlesource.com/c/1458442
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630558}

- This adds the CBOR template impl.

Change-Id: Iff3854e4dda2e912518a96fd21739f0882eca544
Reviewed-on: https://chromium-review.googlesource.com/c/1461300Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630557}

This CL separates resources of oobe.html and md_login.html, so that
they could be cleaned separately.

Bug: 926638
Change-Id: I71708cd7e07e872d80245d77524c7920482979a7
Reviewed-on: https://chromium-review.googlesource.com/c/1455636Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630556}