GitLab

Enable flag: --enable-threaded-gpu-rasterization

This patch enables threaded rasterization in GpuTileTaskWorkerPool.

There are some not yet landed/rolled dependencies:

  InProcessContextProvider Context Lost handling (jbauman@).
  Without this the feature should be considered unstable on WebViews.

BUG=454500

Review URL: https://codereview.chromium.org/916723002

Cr-Commit-Position: refs/heads/master@{#316333}

Was supposed to be added in https://codereview.chromium.org/923463003/, but
missed it.

BUG=458325
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/924143003

Cr-Commit-Position: refs/heads/master@{#316332}

Replace the expensive operation options.CreateParser() with
parser = optparse.OptionParser()

BUG=418375

Review URL: https://codereview.chromium.org/928573003

Cr-Commit-Position: refs/heads/master@{#316331}

A resource throttle and ui manager for the Data Reduction Proxy
bypass interstitials. The intersitial is shown when the user
loads a resource that returns a data reduction proxy bypass on http.
The user can choose to continue loading the page or go back to the
previous page. If the user accepts loading the page, the intertitial
will not be shown again for another 5 minutes.

BUG=428408

Review URL: https://codereview.chromium.org/684223003

Cr-Commit-Position: refs/heads/master@{#316330}

BUG=458684
TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/930463002

Cr-Commit-Position: refs/heads/master@{#316329}

GuestViewManager mapped <owner WebContents, element instance ID> => guest instance ID on attachment. This routed IPCs from a given BrowserPlugin to the appropriate guest.

Element instance IDs are unique per process. This mapping is fine in Chrome Apps where the embedder doesn't navigate but not for when the embedder is capable of cross-process navigation. In that case, element instance IDs of two BrowserPlugins in two different embedder processes of the same WebContents have the same key, and would thus route to the same guest.

This is an issue because the lifetime of the exiting document overlaps with the lifetime of the entering document. Thus, racy behavior can occur. In particular, when navigating from one PDF to another, IPCs for tear down destined for the exiting BrowserPlugin can occasionally get routed to the entering BrowserPlugin. In bug 436339's case, the first step of tear down is to hide the guest content. That IPC ends up going to the entering guest, and so the new PDF is not displayed on screen.

This CL fixes the issue by using <embedder process id, element instance ID> as the key to map to a guest instead of the embedder WebContents as the first component.

BUG=436339

Review URL: https://codereview.chromium.org/921473006

Cr-Commit-Position: refs/heads/master@{#316328}

When splitting the picture pile list on LayerTreeHostImpl up into a
list on each LayerTreeImpl, a bug was introduced in the pair gathering
code.

If a layer is not in the RSLL on the active tree, we need to still
generate a pair for the pending twin if it is in the RSLL, so that we
will raster the layer and block activation on it.

R=enne, vmpstr
BUG=458411
NOTRY=true

Review URL: https://codereview.chromium.org/926023003

Cr-Commit-Position: refs/heads/master@{#316327}

TBR=wez@chromium.org
BUG=458691

Review URL: https://codereview.chromium.org/923923003

Cr-Commit-Position: refs/heads/master@{#316326}

The CHECK helped narrow down the reasons for the failure and we know now
that the sync IPC is failing. It needs more investigation why it happens,
but the check can be removed now.

BUG=397744

Review URL: https://codereview.chromium.org/922373004

Cr-Commit-Position: refs/heads/master@{#316325}

Revert of Roll ANGLE 592ab9dd91e..4085347266. (patchset #1 id:1 of https://codereview.chromium.org/925693002/)

Reason for revert:
Caused all kinds of build issues on the clang/win bots (try/catch are used, a few DISALLOW_COPY_AND_ASSSIGNs are qualified, and something about const params):

http://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/builds/968/steps/compile/logs/stdio

..\..\third_party\angle\src\libANGLE\renderer\d3d\d3d11\Buffer11.cpp(94,5) :  error: expected member name or ';' after declaration specifiers
    DISALLOW_COPY_AND_ASSIGN(Buffer11::BufferStorage);
    ^                        ~~~~~~~~~~~~~~~~~~~~~~~
..\..\third_party\angle\src\common/angleutils.h(25,14) :  note: expanded from macro 'DISALLOW_COPY_AND_ASSIGN'
    TypeName(const TypeName&) = delete;       \
             ^
..\..\third_party\angle\src\libANGLE\renderer\d3d\d3d11\Buffer11.cpp(94,5) :  error: expected ')'

(Probable fix: Drop the qualifier, and move it into the inner class if it's not there already)

..\..\third_party\angle\src\libANGLE\renderer\d3d\d3d11\Buffer11.cpp(124,40) :  error: non-friend class member 'NativeStorage' cannot have a qualified name
    DISALLOW_COPY_AND_ASSIGN(Buffer11::NativeStorage);
                             ~~~~~~~~~~^

..\..\third_party\angle\src\libANGLE\renderer\d3d\d3d11\Buffer11.cpp(124,40) :  error: non-friend class member 'NativeStorage' cannot have a qualified name
    DISALLOW_COPY_AND_ASSIGN(Buffer11::NativeStorage);
                             ~~~~~~~~~~^

Then a few of these:
..\..\third_party\angle\src\libANGLE\renderer\d3d\d3d11\Buffer11.cpp(211,9) :  error: cannot initialize object parameter of type 'const rx::Buffer11::BufferStorage' with an expression of type 'rx::Buffer11::NativeStorage'
    if (stagingBuffer->getDataRevision() > mResolvedDataRevision)
        ^~~~~~~~~~~~~
..\..\third_party\angle\src\libANGLE\renderer\d3d\d3d11\Buffer11.cpp(213,13) :  error: cannot initialize object parameter of type 'const rx::Buffer11::BufferStorage' with an expression of type 'rx::Buffer11::NativeStorage'
        if (stagingBuffer->getSize() > mResolvedData.size())
            ^~~~~~~~~~~~~
..\..\third_party\angle\src\libANGLE\renderer\d3d\d3d11\Buffer11.cpp(215,39) :  error: cannot initialize object parameter of type 'const rx::Buffer11::BufferStorage' with an expression of type 'rx::Buffer11::NativeStorage'
            if (!mResolvedData.resize(stagingBuffer->getSize()))
                                      ^~~~~~~~~~~~~
..\..\third_party\angle\src\libANGLE\renderer\d3d\d3d11\Buffer11.cpp(230,60) :  error: cannot initialize object parameter of type 'const rx::Buffer11::BufferStorage' with an expression of type 'rx::Buffer11::NativeStorage'
        memcpy(mResolvedData.data(), mappedResource.pData, stagingBuffer->getSize());
                                                           ^~~~~~~~~~~~~
..\..\third_party\angle\src\libANGLE\renderer\d3d\d3d11\Buffer11.cpp(234,33) :  error: cannot initialize object parameter of type 'const rx::Buffer11::BufferStorage' with an expression of type 'rx::Buffer11::NativeStorage'
        mResolvedDataRevision = stagingBuffer->getDataRevision();
                                ^~~~~~~~~~~~~
..\..\third_party\angle\src\libANGLE\renderer\d3d\d3d11\Buffer11.cpp(269,13) :  error: cannot initialize object parameter of type 'const rx::Buffer11::BufferStorage' with an expression of type 'rx::Buffer11::NativeStorage'
        if (stagingBuffer->getSize() < requiredSize)
            ^~~~~~~~~~~~~

And a bunch of these:
In file included from ..\..\third_party\angle\src\libANGLE\renderer\d3d\ProgramD3D.cpp:14:
In file included from C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\future:11:
In file included from C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\functional:6:
In file included from C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\xfunctional:7:
C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\xstring(2214,3) :  error: cannot compile this try statement yet
                _TRY_BEGIN
                ^~~~~~~~~~
C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\xstddef(30,21) :  note: expanded from macro '_TRY_BEGIN'
 #define _TRY_BEGIN     try {
                        ^

Sorry about reverting something for an FYI bot, but the bot's been red all day for various reasons, and I'd like it to be green over the long weekend. I'll try a local build with the roll patched in and I'll send you fixes for the issues, to make up for it a bit.

Original issue's description:
> Roll ANGLE 592ab9dd91e..4085347266.
>
> https://chromium.googlesource.com/angle/angle/+log/592ab9dd91e..4085347266
>
> BUG=391957,436191,450257,447419,452587,453543
> R=zmo@chromium.org,bajones@chromium.org
>
> Committed: https://crrev.com/8e556e6de2c40fbf7379056facb6c9fa5f508f3e
> Cr-Commit-Position: refs/heads/master@{#316292}

TBR=bajones@chromium.org,zmo@chromium.org,jmadill@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=391957,436191,450257,447419,452587,453543

Review URL: https://codereview.chromium.org/927753002

Cr-Commit-Position: refs/heads/master@{#316324}

R=mlerman@chromium.org
BUG=457255

Review URL: https://codereview.chromium.org/924783002

Cr-Commit-Position: refs/heads/master@{#316323}

Before this change, fullscreen and mouse lock were allowed on file:// URLs without giving the user a chance to Allow or Deny them and without showing any persistent UI. This change makes it so that users are always prompted with persistent UI on file:// URLs. There is no way to remember the preference to show or hide the persistent permission bubble because file:// URLs lack a clear origin concept.

BUG=455953,455882
TEST=Download http://adrifelt.github.io/demos/all-permissions (right click, Save As). Open the downloaded file in Chrome. Click "Fullscreen": a permissions bubble should have "Dismiss" and "Exit full screen" buttons, where "Dismiss" just dismisses the bubble. If you click Dismiss, the bubble should again show up when you enter fullscreen a second time. For Pointer Lock, the bubble should show Allow and Deny buttons, and the mouse should not be locked until you click Allow. Clicking Allow or Deny should not affect the behavior of the bubble if you press Pointer Lock again.

Review URL: https://codereview.chromium.org/903683005

Cr-Commit-Position: refs/heads/master@{#316322}

The latest <paper-checkbox> matches the Material Design spec. The
MD-Settings page will make use of this button in a follow-up CL.

Since paper-checkbox isn't currently used in Chromium there shouldn't
be any side effects for this change.

BUG=457513
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/913353002

Cr-Commit-Position: refs/heads/master@{#316321}

allocating it's own buffer.  No functional change.

Merge internal change: 85952670

R=rch@chromium.org

Review URL: https://codereview.chromium.org/912163002

Cr-Commit-Position: refs/heads/master@{#316320}

Previously we were installing and using libssl0.9.8:i386
which was actually a miss-match with the 1.0.0 headers
installed by libssl-dev.

TEST=local (remove links and run install-build-deps.sh)

Review URL: https://codereview.chromium.org/913183004

Cr-Commit-Position: refs/heads/master@{#316319}

setValueIgnoreMutation should call setValue so that derived attribute objects
only need to modify setValue to get the desired behavior.

BUG=none
TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/928623002

Cr-Commit-Position: refs/heads/master@{#316318}

Tansaction => Transaction - apparently we were running low on 'R's at
the time.

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/919343003

Cr-Commit-Position: refs/heads/master@{#316317}

Unless we're targeting Android, Linux builders don't have the NDK checked
out.

BUG=452726
NOTRY=true

Review URL: https://codereview.chromium.org/927703002

Cr-Commit-Position: refs/heads/master@{#316316}

This is to prepare for switching rasterize_and_micro_record's
action_name_to_run from empty string to 'RunPageInteractions'.

BUG=418375

Review URL: https://codereview.chromium.org/924133002

Cr-Commit-Position: refs/heads/master@{#316315}

The perf test texture_upload_perftest has been updated to use these new measurements.

BUG=423481

Review URL: https://codereview.chromium.org/893673002

Cr-Commit-Position: refs/heads/master@{#316314}

The Mac valgrind bot started reporting the following after
https://codereview.chromium.org/918533005/ landed:

UninitCondition
Conditional jump or move depends on uninitialised value(s)
x_zone_size
find_registered_purgeable_zone
malloc_make_nonpurgeable
imageio_make_nonpurgeable
cache_get_and_retain
CGImageReadSessionGetCachedImageBlockData
copyImageBlockSetPNG
ImageProviderCopyImageBlockSetCallback
img_blocks_create
img_blocks_extent
img_data_lock
CGSImageDataLock
ripc_AcquireImage
ripc_DrawImage
CGContextDrawImage
__-[NSImageRep drawInRect:fromRect:operation:fraction:respectFlipped:hints:]_block_invoke_1
-[NSImageRep drawInRect:fromRect:operation:fraction:respectFlipped:hints:]
__-[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:]_block_invoke_1
-[NSImage _usingBestRepresentationForRect:context:hints:body:]
-[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:]
-[NSImage hitTestRect:withImageDestinationRect:context:hints:flipped:]
ui::ThreePartImage::HitTestImage(CGPoint, NSImage*, CGRect) const
ui::ThreePartImage::HitTest(CGPoint, CGRect) const
ui::test::ThreePartImageTest_HitTest_Test::TestBody()

I can't see anything wrong, and a very similar stack is already suppressed,
so just suppress the report.

BUG=453996,173779
TBR=andresantoso@chromium.org

Review URL: https://codereview.chromium.org/927733002

Cr-Commit-Position: refs/heads/master@{#316313}

This unifies sources lists between GYP and GN
builds and gets app_shell_unittests building
on GN in most environments.

BUG=

Review URL: https://codereview.chromium.org/922093002

Cr-Commit-Position: refs/heads/master@{#316312}

Review URL: https://codereview.chromium.org/921283002

Cr-Commit-Position: refs/heads/master@{#316311}

BUG=458315
R=dzhioev@chromium.org

Review URL: https://codereview.chromium.org/920223002

Cr-Commit-Position: refs/heads/master@{#316310}

BUG=458397

Review URL: https://codereview.chromium.org/921983004

Cr-Commit-Position: refs/heads/master@{#316309}

Review URL: https://codereview.chromium.org/922383004

Cr-Commit-Position: refs/heads/master@{#316308}

This CL enables webview tags with allowsscaling="on" to respond to
pinch touch gestures.

BUG=453785

Review URL: https://codereview.chromium.org/916363003

Cr-Commit-Position: refs/heads/master@{#316307}

We were computing occlusion twice, once in UpdateDrawProperties
and once in CalculateRenderPasses. Now just do it once in
UpdateDrawProperties, which means we don't have to do that work
at all if we draw again without dirtying the render surface layer
list.

This moves the call to UpdateTiles out of the loop for occlusion,
instead calling it directly on each of the picture layers on the
tree, meaning it does not have to be virtual anymore.

This makes it possible for us to call UpdateTiles on picture layers
that were not part of the RenderSurfaceLayerList. Though for now
I left the behaviour as is with a TODO.

Also removed all the old LayerTreeHostOcclusionTests. Added a few
new ones to ensure occlusion gets saved correctly in layers and
surfaces. The test cases that would be missing, I moved to be
OcclusionTrackerTests.

R=enne, vmpstr
BUG=446751

Review URL: https://codereview.chromium.org/915083004

Cr-Commit-Position: refs/heads/master@{#316306}

5898509 Test top-level Document JS properties.
2543607 Fix JPX image rendering that regressed due to several security fixes.
493f5c6 Fix an error 'Use-of-uninitialized-value in CPDF_Function::Call'
9f93baf Create run_javascript_tests.py
6e7ceb8 CPDF_Object() constructor should set its internal m_Type variable.

BUG=453723,454280
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/928593002

Cr-Commit-Position: refs/heads/master@{#316305}

The DOM is currently not set up well for a background color, making this
really ugly.

I'll get this working in the future, but it'll involve hacking up the
HTML structure a bit.

BUG=458483
R=groby@chromium.org
TEST=visual

Review URL: https://codereview.chromium.org/921273002

Cr-Commit-Position: refs/heads/master@{#316304}

BUG=314221
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/922413003

Cr-Commit-Position: refs/heads/master@{#316303}

As our old friend OriginChip, so the SearchButton too has to bid adieu.
She served well, and we shall miss her.

BUG=424751

Review URL: https://codereview.chromium.org/749693005

Cr-Commit-Position: refs/heads/master@{#316302}

This CL causes the AsyncResourceHandler code to check for temporary zoom
levels for the current view before sending the new zoom level during
navigation. This will allow tabs with per-tab scope zoom settings to
retain their current (temporary) zoom levels during same-origin
navigations.

Review URL: https://codereview.chromium.org/809223006

Cr-Commit-Position: refs/heads/master@{#316301}

Note: This CL will be merged back to M41. Further work is underway
to completely delete the Guest Profile when all browser windows are
closed, but that will be too large to merge.

BUG=445036
TEST=Open a Guest profile from the User Manager. Perform some browsing, set some cookies, etc. (e.g. sign in to your email). Close all guest browsers (via Exit Guest, closing all the browsers, however you like). Navigate to the same page, and your cookies are disappeared!

Review URL: https://codereview.chromium.org/888843005

Cr-Commit-Position: refs/heads/master@{#316300}

Previously ConnectionToClient required stubs to be created before the
client is authenticated. This is no longer necessary. Fixed it so
set_*_stub() methods can be called only after authentication. Also
removed auth input filters from ClientSession as they are no longer
useful.

BUG=448838

Review URL: https://codereview.chromium.org/902613004

Cr-Commit-Position: refs/heads/master@{#316299}

- Add pref to make checkbox sticky
- Implement checkbox as per-card, not per-device
- Implement UI on Views

BUG=448587

Review URL: https://codereview.chromium.org/910043002

Cr-Commit-Position: refs/heads/master@{#316298}

R=phajdan.jr@chromium.org, sheyang@chromium.org
BUG=451020

Review URL: https://codereview.chromium.org/920583004

Cr-Commit-Position: refs/heads/master@{#316297}

Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/3bb4178..d306f16

BUG=none

Review URL: https://codereview.chromium.org/922363003

Cr-Commit-Position: refs/heads/master@{#316296}

There is no point of keeping source_origin as a parameter in postMessageTo* methods. It is not a parameter to expose to the source app in a webview API, and it is not a value that will change from one request to another, so for the simplicity's sake, remove it from java side completely. At the moment, I am not fully sure what a good value is so leaving it as a empty domain for now.

BUG=393291

Review URL: https://codereview.chromium.org/923913004

Cr-Commit-Position: refs/heads/master@{#316295}

Hide implementation details of <webview> attribute state from web_view.js.

We introduce a reset method on methods to be called in onElementDetached that
resets the internal state without exposing the details of what that internal
state is.

BUG=none
TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/926083002

Cr-Commit-Position: refs/heads/master@{#316294}