- 30 Sep, 2019 40 commits
-
-
David Narsiya authored
All search engines are described in prepopulated_engines.json. In template_url_prepopulate_data.cc there was an array kAllEngines consisted of them, created by enumeration. There is a danger of modifying prepopulated_engines.json without modifying this array. This changes contain automatical generation of kAllEngines. Change-Id: Idc78552372f73b07fc7070fff66c000a30c6a6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807312Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#701133}
-
Fernando Serboncini authored
Only request a dispatcher's begin frame if the current frame hasn't been uploaded by AnimationFrameProvider Bug: 995235 Change-Id: I2c6d590d9eed535f4723a65721b3b81dd3f0d449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827741 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#701132}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b07ee652. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I1c8bef1e506e34d09ab9ee6b478cb0fc14e79af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831558Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701131}
-
Sebastien Marchand authored
Change-Id: Ica203bd45637351b602ec55fad5984ab482cbd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827506 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#701130}
-
Julie Jeongeun Kim authored
This CL cleans up MediaParserPtr and FilePatcher from comments since these interfaces has been converted to new mojo types already and mojo::Remote<MediaParser> and mojo::Remote<FilePatcher> has been used instead of MediaParserPtr and FilePatcherPtr from the code. NOTRY=true Bug: 955171 Change-Id: I09d1f15e2c27147361a44a1117f1fd77af4e548d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827108Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#701129}
-
jonross authored
This test is slower when using Vulkan, taking around 9800ms for SkiaRenderer + Vulkan. Vs 2400ms for SkiaRenderer by itself, and 1600ms for neither being enabled. Marking the test as slow. TBR=backer@chromium.org Test=compositing/lots-of-img-layers.html Bug: 994331 Change-Id: If90b8132ae2f9a7ac7af5090a2b2e5be7eb79d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829654Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#701128}
-
Maksim Moskvitin authored
We used to ask Directory itself to provide Nigori node for debugging. With USS implementation enabled we need to change the source to corresponding ModelTypeController. Since Nigori's ModelTypeController not available inside ProfileSyncService, we plumb it through SyncEngine and SyncEngineBackend. There is a side change: when Directory implementation of Nigori is enabled, we start call GetAllNodesForTypeFromDirectory() from sync sequence, instead of UI sequence. It should be safe, since logging already supports plumbing to different sequences and Directory's functions could be called from any sequence (protected by transactions). Bug: 922900 Change-Id: Ifdc5ffb1a5a99e51a0ec88643f9325d1c4a287de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800772 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#701127}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e242d0ea937c..0846d68474fb git log e242d0ea937c..0846d68474fb --date=short --no-merges --format='%ad %ae %s' 2019-09-30 halcanary@google.com experimental/skottie_ios/SkottieMtkView: stopAtEnd option Created with: gclient setdep -r src/third_party/skia@0846d68474fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I0a767e4a8e8cd8df76cf43888ffd56d2e23eddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701126}
-
Fredrik Söderquist authored
This makes InstanceListChanged() not care about whether the instance list that changed was the 'begin' or 'end' list - it just re-evaluates the current interval, if any, or resolves a new interval if needed. This is intended to allow future changes to further merge the "instance time from event" update with the general interval update. Bug: 998526 Change-Id: Ia388934460766b564672da5fd3970292eb849deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831802Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#701125}
-
Mythri A authored
There are some recent changes in the GeneratedCodeCache. So this histogram is required to verify if everything works as expected. Bug: chromium:1004479 Change-Id: Ia0a70c00f97ae114bffbcaa778d4d513205cb236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827429 Auto-Submit: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#701124}
-
Lily Chen authored
This fixes the NetworkContextConfigurationBrowserTests to work under SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure. Bug: 1006816 Change-Id: I6624198b258521ecf7b4b1e5b3fa002a22ab3896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826137Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#701123}
-
Xida Chen authored
Bug: 900581 Change-Id: I9d1c84c30f630eae5001abef60af03d827436512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831261Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701122}
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class, allowing to retrieve the remote implementation from the renderer process without relying on FrameClient's InterfaceProvider. Additionally, this CL also migrates the few usages of the old Mojo types that were still around in the codebase. Bug: 955171, 978694, 936482 Change-Id: I1bfdeaa04d96f03649a8216954ce937a17975edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820739Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#701121}
-
Sergey Poromov authored
TBR=cammie@chromium.org Bug: 999530 Change-Id: Ic813cefbd5d3cdeaaa9f51d98cc65dee7a016436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829705Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#701120}
-
Vladislav Kuzkokov authored
Bug: 964919 Change-Id: I8d8ff498fb54fe07060fdff4c92524c97cea7c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807116Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#701119}
-
Jit Yao Yap authored
This CL adds API tests for the chrome.login API. It covers the launchManagedGuestSession, exitCurrentSession and fetchDataForNextLoginAttempt methods. Change-Id: I741aa5b42c5213ff380a098e075db4c5e7cb6bf2 Bug: 940401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819246 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#701118}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e7314cd4a2ad..45b176fc2289 git log e7314cd4a2ad..45b176fc2289 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 asapersson@webrtc.org Downgrade fps in same step as resolution in initial drop due to size. 2019-09-30 sprang@webrtc.org Revert "Prepares RtpSenderVideo for batch forwarding of generated packets" Created with: gclient setdep -r src/third_party/webrtc@45b176fc2289 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: I6572c6414f762553aebfc53ac567c1bad44489f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832043Reviewed-by:
-
Paul Lewis authored
The Karma tests that run do not currently produce a coverage report. This CL adds local coverage reporting with a view to start exposing the reports at the CQ level eventually. Change-Id: Id374ee34c911a5762ce37ad69799fe00bcf1c29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831760 Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701116}
-
Amr Aboelkher authored
A device policy which controls the autoclick accessibility feature on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_autoclick_enabled policy to True, open System Tray => "Accessibility", check that "Automatic clicks" is displayed with a green check in the login screen. 2. Set the policy to False, open System Tray, check that "Automatic clicks" is not displayed in the login screen. Bug: 552439 Change-Id: I4c58b1e63ed32e2d861a062493a77d1dd09a7d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819439 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#701115}
-
Daniel Nicoara authored
Adds the proto definitions to all the remaining Webview calls. Also implement all the straightforward calls. TODOs: * Javascript message channels, * Navigation delegate, * Clear cache on the renderer side. Bug: b/132811925 Test: Compiled Change-Id: If8cb03e1e26ece586ed841dcdd028a6c5ccf0316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830171Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#701114}
-
Xida Chen authored
Printing requires paint to be done on the main thread, and that's not possible for off-thread paint worklet. So this CL makes off-thread paint worklet fall back to the main thread paint when it is in the printing mode. Bug: 1008375 Change-Id: I3bf4c26d2070edf5e77a3e3b333d6000cdc4066a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828063Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701113}
-
Alex Clarke authored
In the renderer we'd like to prioritize loading and compositing tasks until first contentful paint. That makes the already flaky NestedPopupMenuTest worse. With the new policy we sometimes get a different pop up rect size (80x53 instead of 110x110). This seems to be because there isn't always a layout before the mouse clicks are sent. Adding a call to WaitForHitTestData fixes this. Bug: 971191 Change-Id: I70e89c74ee79cb36854e63e5f2e2c5b7e5fdff58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823865 Auto-Submit: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
Martin Robinson authored
This produces a better experience for users by giving them a general idea of the size of the font without subjecting them to a long decimal number. Bug: 1004771 Change-Id: I83d2ad8a60f2427eefe2ec86e4cdf1a798976c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814931 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#701111}
-
Sergey Poromov authored
Example: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/40963 TBR=wittman@chromium.org Bug: 1009182 Change-Id: Iafb2ba66e6bc5aa57ee5849d2447933401917f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829352Reviewed-by:
-
Stefano Sanfilippo authored
Following updates in the spec, see https://w3c.github.io/webappsec-trusted-types/dist/spec/#should-block-sink-type-mismatch. Change-Id: Ia3622696068aaaa74cca7c1e08e475edd6b75016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829382 Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701109}
-
Rafał Godlewski authored
Removes use of helper enum for interaction with SQL queries that use all columns where not all columns are used. By coincidence the numbers were matching, so it was not a bug. Change-Id: Ia1b4c6b7ccbb362f0fbd66f9bbfed3fed159dbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831765 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Rafał Godlewski <rgod@google.com> Reviewed-by:
-
Sergey Poromov authored
Example: https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/384930 TBR=steimel@chromium.org TBR=beccahughes@chromium.org Bug: 1009356 Change-Id: I438c1e3272eed0bda1672c7e36e1d64372d45595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831907Reviewed-by:
-
Peter Wen authored
Raising ProcessInitException indicates that a fatal issue has occurred. Unless explicitly catching and handling it, in most cases it ends with a call to System.exit which does not create crash reports. Now that PureJavaExceptionHandler exists and we do not need native to create a crash report, we no longer need to handle these startup failures explicitly, they should simply bubble up like any other runtime crash. Bug: 1000651 Tbr: Tree-wide mechanical refactor that includes content/ and net/ Change-Id: I3eb9f71f52d95217a0623271be1d21c7797d8d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825572 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#701106}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6a28e95a8e40..1fab224fb263 git log 6a28e95a8e40..1fab224fb263 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 rsavitski@google.com Merge changes I442d4291,I239ea5e4 2019-09-30 ilkos@google.com Do not set the build ID on the converted profile Created with: gclient setdep -r src/third_party/perfetto@1fab224fb263 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:b/141735056 Change-Id: Ifc1b2829bbaea439060010589523aa85c7194303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830516Reviewed-by:
-
François Beaufort authored
This CL adds a "storage-texture" value to the GPUBindingType enum. Note that this will still raise a WebGPU validation error as it is not yet implemented in Dawn. Bug: 877147 Change-Id: Ib3e3084063fd006b745e3e52b0249a01349e22cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831903Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#701104}
-
Ella Ge authored
This reverts commit 91c87593. Reason for revert: Perf regression crbug/1006810 Original change's description: > Enable scroll resampling on ToT > > \o/ > > Doc: > https://docs.google.com/document/d/1KrlQ0m5Ty9RKE1IorjEXDldYFJvUV_Ww10lnjh-TRN0/ > > Bug: 1000682 > Change-Id: Ia77af76fd530be740d7d7c64706f47a48c248387 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786591 > Commit-Queue: Ella Ge <eirage@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698698} TBR=bokan@chromium.org,eirage@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000682 Change-Id: Id30009dd4bae3dd366460f334b9d44b3d616b609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832141Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#701103}
-
David Van Cleve authored
This change adds an experimental feature to cap referrer granularity to origin on cross-origin requests. This requires making sure that both Blink and the network stack receive the updated referrer, which is a bit challenging on redirects: the networking stack computes some redirect state quite soon after determining that a redirect is happening (in URLRequestJob) and, whenever a deferred redirect gets the go-ahead, happily resumes using that state (cf. URLRequest::Redirect). This patch contains changes to: - //services/network's feature list, to add the feature; - content::Referrer's sanitization method, to perform an additional check when the feature is enabled; - NavigationRequest, to propagate its sanitized referrers to the WebNavigationParams Blink will receive, so that Blink will be able to get the correct referrer on redirects without having to be aware of the flag; and - NetworkContextNetworkDelegate, to truncate the referrer as appropriate on outgoing URLRequests It adds browser tests to make sure the cap overrides more permissive referrer policies, but doesn't override more restrictive ones. R=mmenke r=mmenke cc=kaustubhag Bug: 1004486 Change-Id: I637ffe45fa3f73d775c714e72c1e78dc3d3c5617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816643Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#701102}
-
Xida Chen authored
All test cases are covered by: wpt/css/css-color/animation/color-interpolation.html The last two test cases where -webkit prefix is involved, is already covered in web_tests/animations/interpolation/color-interpolation.html. Bug: None Change-Id: I96379d6005ca81b4d673e05e63d52661009e4a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831263Reviewed-by:
-
Rayan Kanso authored
Pipe the WebContents to the DigitalAssetLinksHandler to add warning messages to the DevTools console where applicable. Bug: 910228 Change-Id: I711c2fe37df3686f00cdbbb6d7f6e1f947868b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824462Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#701100}
-
Xida Chen authored
Bug: 900581 Change-Id: I13e9433c00bf606f4d7258c76609cdb84e8b0b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831264 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Tobias Sargeant authored
Install the java exception filter, and enable the uncaught exception handler. Bug: 1004133 Test: manual Change-Id: I7039dd4ee137600aefc5f9ff17d1964f14dc67e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829198 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
-
Avi Drissman authored
BUG=1009032, 937569 Change-Id: I6bcf68a1b12c4bcc7acf1b3e6d7b966062137db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829484Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Xida Chen authored
Bug: 900581 Change-Id: I996882864b4e4aaf5d1f3e4a4d904d488898a6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830921 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Mark Cogan authored
After crrev.com/c/1796358, some downstream code still needs the old TabModel -initWithSessionService:browserState and -browserStateDestroyed methods. Once the CL removing that usage lands, this CL can land, remove the old APIs. Change-Id: I02f82f79195b524e043c9ea41f3f961197cc9fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827416Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#701095}
-
David Bokan authored
This CL adds metrics to measure occurrences of potential directive delimiters in case the existing one (:~:) turns out to be incompatible. We also measure the occurrence of :~: in the fragment (that isn't being used for targetText=) so that we can determine if it is or is not web compatible. Finally, as an interesting metric that could help catch malfunctions, we also measure how often the fragment directive fails to parse. In summary: - Measure occurrences of ~&~ in the fragment - Measure occurrences of ~@~ in the fragment - Measure occurrences of &directive? in the fragment - Measure occurrences of :~: in the fragment that aren't followed by targetText= - Measure parsing failures of the directive Bug: 1009250 Change-Id: Ie7961346175bef88ce64d71e02d2afbd1b5e6acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831080Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#701094}
-
