GitLab

An anchored widget is repositioned automatically when the top-of-window views bounds change.
This is useful to reposition the fullscreen exit bubble when the bookmark bar is shown / hidden.

Bug=188567
Test=ImmersiveModeControllerAshTest.AnchoredWidgets

Review URL: https://codereview.chromium.org/13866026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194599 0039d316-1c4b-4281-b951-d872f2087c98

Clean up the only presubmit error in the compositor bindings and
turn on cpplint warnings to prevent any future regressions.

Also, clean up cc's presubmit to match now that depot_tools has cpplint
in its input_api.

R=danakj@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/13949005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194598 0039d316-1c4b-4281-b951-d872f2087c98

Got linker error not caught by try servers.

> Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts.
> 
> User is still free to override manually.
> 
> BUG=226994
> TEST=Automated test included.
> 
> Review URL: https://codereview.chromium.org/13044014

TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/14096026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194597 0039d316-1c4b-4281-b951-d872f2087c98

When a part of the layer is visible, then it has a visible_content_rect which
is the best place to expand the prioritized rect from.

If no part of the layer is visible, we use the viewport rect in content space.
However, when the layer clips the viewport, this rect becomes enormous.
Currently the ExpandRectEquallyToAreaBoundedBy function "expands" the viewport
to cover the target area, but if the viewport is huge, it shrinks it instead.
When it shrinks to a rect far away from the layer, the layer is considered too
far from the viewport for prioritization.

Instead, we should only grow the viewport in content space, then intersect with
the tiling's content bounds (as before) to find an appropriate starting rect.

Tests:
PictureLayerTilingIteratorTest.TilesExistGiantViewport
PictureLayerTilingIteratorTest.TilesExistOutsideViewport
PictureLayerTilingIteratorTest.TilesExistLargeViewportAndLayerWithSmallVisibleArea
PictureLayerTilingIteratorTest.TilesExistLargeViewportAndLayerWithLargeVisibleArea

BUG=231521

Review URL: https://codereview.chromium.org/13895005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194596 0039d316-1c4b-4281-b951-d872f2087c98

We don't have this library in the WebView tree, and we don't want to
enable WebAudio on only ARM platforms for consistency reasons in any
case.

BUG=

Review URL: https://codereview.chromium.org/14324003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194595 0039d316-1c4b-4281-b951-d872f2087c98

Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts.

User is still free to override manually.

BUG=226994
TEST=Automated test included.

Review URL: https://codereview.chromium.org/13044014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194594 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/14130007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194593 0039d316-1c4b-4281-b951-d872f2087c98

On Content Settings exceptions dialogs: Replace the placeholder text ("Add a new hostname pattern") of the input field used for adding new exceptions with a string containing a sample pattern ("[*.]example.com")

BUG=232378
TEST= (1) open chrome://settings/contentExceptions#cookies
  (2) Verify that the text in the input field is "[*.]example.com"

Review URL: https://codereview.chromium.org/13865003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194592 0039d316-1c4b-4281-b951-d872f2087c98

Upcoming work for multiple operations, CRC calculation, etc... have made the lifetime of the SimpleEntryImpl more tricky. By adding ref counting, asynchronous operations are guaranteed access to the entry after execution.

R=pasko@chromium.org,felipeg@chromium.org,rvargas@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/13880016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194591 0039d316-1c4b-4281-b951-d872f2087c98

> Add ash SessionStateDelegate
> 
> This CL refactors the ShellDelegate by adding a SessionStateDelegate to
> which methods dealing with the session state can be moved. This cleans up
> the huge ShellDelegate interface and paves the way for further Chrome OS
> multiprofile work which will need to add several new methods related to
> the session state.
> 
> This CL is only the first step. Several other methods should also move to
> SessionStateDelegate but I do not want to overburden a single CL.
> 
> BUG=None
> TEST=Manual and browser/unit tests
> 
> TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi)
> 
> Review URL: https://codereview.chromium.org/14295008

TBR=bartfab@google.com

Review URL: https://codereview.chromium.org/14200034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194589 0039d316-1c4b-4281-b951-d872f2087c98

This pref will also be used by Chrome on Android and iOS,
in addition to ChromeOS.

BUG=226757

Review URL: https://codereview.chromium.org/14066011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194587 0039d316-1c4b-4281-b951-d872f2087c98

Due to a Blink bug (http://crbug.com/231830), the clear button in the
search field is not properly rendered if the <header> element has
its transform style property set to anything other than 'none'.

A simple workaround to make it render properly in 99% of cases is to
set the value of -webkit-transform to 'none' instead of 0px.

BUG=231291
TEST=Open chrome://history, type something in the search field, and
ensure that the clear button (a circle with a "X") is visible.

Review URL: https://codereview.chromium.org/14053006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194586 0039d316-1c4b-4281-b951-d872f2087c98

> Add a virtual keyboard webui at chrome://keyboard/
> 
> This is just the old virtual keyboard that was removed a couple of years
> ago, being used as a temporary stand-in.
> 
> BUG=222801
> 
> Review URL: https://codereview.chromium.org/13652010

TBR=bryeung@chromium.org

Review URL: https://codereview.chromium.org/14031009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194585 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232048

Review URL: https://codereview.chromium.org/14296002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194583 0039d316-1c4b-4281-b951-d872f2087c98

This data type should not be visible in the UI, as it will be configured automatically for managed users.

TBR=atwilson@chromium.org
BUG=229383

Review URL: https://codereview.chromium.org/14053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232048

Review URL: https://codereview.chromium.org/13963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194581 0039d316-1c4b-4281-b951-d872f2087c98

Don't create the virtual keyboard until it is first shown.  This helps
prevent some start-up races.

Also clean-up some of the object ownership between KeyboardController
and KeyboardLayoutManager.  Each pointer exists in only one or the
other object now.

BUG=none

Review URL: https://codereview.chromium.org/13932030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194580 0039d316-1c4b-4281-b951-d872f2087c98

This is just the old virtual keyboard that was removed a couple of years
ago, being used as a temporary stand-in.

BUG=222801

Review URL: https://codereview.chromium.org/13652010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194579 0039d316-1c4b-4281-b951-d872f2087c98

This CL refactors the ShellDelegate by adding a SessionStateDelegate to
which methods dealing with the session state can be moved. This cleans up
the huge ShellDelegate interface and paves the way for further Chrome OS
multiprofile work which will need to add several new methods related to
the session state.

This CL is only the first step. Several other methods should also move to
SessionStateDelegate but I do not want to overburden a single CL.

BUG=None
TEST=Manual and browser/unit tests

TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi)

Review URL: https://codereview.chromium.org/14295008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194578 0039d316-1c4b-4281-b951-d872f2087c98

The leak is due to too much passing around of an IOBuffer via
a raw pointer.

BUG=232345
TBR=rch@chromium.org

Review URL: https://codereview.chromium.org/14087008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194577 0039d316-1c4b-4281-b951-d872f2087c98

This is to avoid skipping "meta viewport" tag processing.

For controlling wide viewport-related behavior, a corresponding
WebSetting has been added into Blink.

Review URL: https://codereview.chromium.org/14234002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194576 0039d316-1c4b-4281-b951-d872f2087c98

BUG=227043
TEST=content_unittests and mish audio tests in Chrome

Review URL: https://codereview.chromium.org/14244005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194573 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178009
TEST=this test

Review URL: https://codereview.chromium.org/13542003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194572 0039d316-1c4b-4281-b951-d872f2087c98

After the Blink roll 148494:148530 that happened in r194534 this test
started failing.

TEST=sanity compilation locally on Linux.
BUG=232340
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/14063013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=173339

Review URL: https://codereview.chromium.org/14322009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194570 0039d316-1c4b-4281-b951-d872f2087c98

Just add new pattern. It will be used to implement DriveFileStreamReader.

BUG=127129
TEST=Ran unit_tests.

Review URL: https://codereview.chromium.org/14235017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194569 0039d316-1c4b-4281-b951-d872f2087c98

Disabling this test again as it has shown to keep being flaky even
after the fix in r193825.

BUG=232330,229700
TEST=sanity compile on Linux.
TBR=asargent@chromium.org

Review URL: https://codereview.chromium.org/13996011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194568 0039d316-1c4b-4281-b951-d872f2087c98

> Complete (but inefficient) implementation of the image retargetting method.
> 
> This CL contains:
> 1. Convolution of arbitrary channel with arbitrary kernel (convolver*).
> 2. Gaussian gradient magnitude implementation.
> 3. Image profile (X and Y projections) computations.
> 4. Otsu-like thresholding of profiles.
> 5. Image decimation.
> 6. The main routine which binds it all together.
> 
> Note: 1 and 2 do work, but remain main sources of suckiness due to performance
> problems. I actively work on this. Still, I'd love to get the current state in
> to establish a baseline and for viewing pleasure of those who are interested.
> 
> BUG=155269
> 
> Review URL: https://codereview.chromium.org/13947013

TBR=motek@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=181502

Review URL: https://codereview.chromium.org/14322012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194566 0039d316-1c4b-4281-b951-d872f2087c98

This CL contains:
1. Convolution of arbitrary channel with arbitrary kernel (convolver*).
2. Gaussian gradient magnitude implementation.
3. Image profile (X and Y projections) computations.
4. Otsu-like thresholding of profiles.
5. Image decimation.
6. The main routine which binds it all together.

Note: 1 and 2 do work, but remain main sources of suckiness due to performance
problems. I actively work on this. Still, I'd love to get the current state in
to establish a baseline and for viewing pleasure of those who are interested.

BUG=155269

Review URL: https://codereview.chromium.org/13947013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194565 0039d316-1c4b-4281-b951-d872f2087c98

Use SpdyBuffer for both SPDY reads and writes. A future
CL will add hooks to SpdyBuffer so that we keep track of
flow control windows properly.

Replace SpdyFrameProducer with SpdyBufferProducer.

Also introduce new SpdyReadQueue class for delegates
of SpdyStream to use.

BUG=176592

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194560

Review URL: https://codereview.chromium.org/13990005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=231331
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/14208014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194563 0039d316-1c4b-4281-b951-d872f2087c98

> [SPDY] Replace SpdyIOBuffer with new SpdyBuffer class
> 
> Use SpdyBuffer for both SPDY reads and writes. A future
> CL will add hooks to SpdyBuffer so that we keep track of
> flow control windows properly.
> 
> Replace SpdyFrameProducer with SpdyBufferProducer.
> 
> Also introduce new SpdyReadQueue class for delegates
> of SpdyStream to use.
> 
> BUG=176592
> 
> Review URL: https://codereview.chromium.org/13990005

TBR=akalin@chromium.org

Review URL: https://codereview.chromium.org/13996009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194562 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194561 0039d316-1c4b-4281-b951-d872f2087c98

Use SpdyBuffer for both SPDY reads and writes. A future
CL will add hooks to SpdyBuffer so that we keep track of
flow control windows properly.

Replace SpdyFrameProducer with SpdyBufferProducer.

Also introduce new SpdyReadQueue class for delegates
of SpdyStream to use.

BUG=176592

Review URL: https://codereview.chromium.org/13990005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=scheib@chromium.org

Review URL: https://codereview.chromium.org/13977013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194559 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232313
TEST=sanity compile and run on Linux and Windows.
TBR=akalin

Review URL: https://codereview.chromium.org/14167014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194558 0039d316-1c4b-4281-b951-d872f2087c98

 - remove quarantine_size, which is too greedy compared to the default value
 (this may result in less UAFs caught by ASan, but is very unlikely. ClusterFuzz uses the default setting)
 - temporarily set malloc_content_size=5 to avoid the enourmous growth of the stack trace repository
 (this will result in less memory footprint and shorter stacks for heap allocations printed in the reports.
 However we don't care much about the quality of ASan reports on the client side right now).

BUG=address-sanitizer:177

Review URL: https://codereview.chromium.org/13932014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230749
TEST=Open Files App, choose the sidebar item, verify the Drive related gear menus (e.g. "Show Google Docs files") are available.

Review URL: https://codereview.chromium.org/13871005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194554 0039d316-1c4b-4281-b951-d872f2087c98

BUG=231795
TEST=unittests,trybots

Review URL: https://codereview.chromium.org/14118008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194553 0039d316-1c4b-4281-b951-d872f2087c98