GitLab

Break a circular reference which was causing FileManagerPrivateComputeChecksumFunction to never be cleaned up.  This, in turn, was holding open one file stream for every file for which a content checksum was requested.

BUG=458624

Review URL: https://codereview.chromium.org/950423003

Cr-Commit-Position: refs/heads/master@{#317997}

Fixed IAccessibleText::TextAtOffset with IA2_TEXT_BOUNDARY_WORD to return text that spans from the start of one word to the start of the next.

BUG=347852
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/660633002

Cr-Commit-Position: refs/heads/master@{#317996}

Before, we were not notifying Files app about such fact, so it was still
thinking that Drive is not available, and showing the banner.

TEST=Tested manually when logging to an empty profile.
BUG=461247

Review URL: https://codereview.chromium.org/953273002

Cr-Commit-Position: refs/heads/master@{#317995}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/614cd2f..341bffc

TBR=hiroshige@chromium.org,arv@chromium.org

Review URL: https://codereview.chromium.org/940153003

Cr-Commit-Position: refs/heads/master@{#317994}

also ask it to restore saved state.

This eliminates the BrowserContentTranslateDriverObserver class in favor of just
implementing this on Browser directly as various other such observer
implementations do -- allowing the code to call the UpdateToolbar() method
instead of BrowserWindow::UpdateToolbar(), whose correct use is slightly less
clear.

BUG=459445
TEST=See steps on bug comment 22.  In step 1, be sure to restart Chrome after changing the language, and then set Chrome to prompt to translate pages in English.

Review URL: https://codereview.chromium.org/949653003

Cr-Commit-Position: refs/heads/master@{#317993}

As the comment in extension_warning_badge_service.h by battre@,
rename ExtensionWarningBadgeService to WarningBadgeService and related class.
And rename the files too.

BUG=458829
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/921423003

Cr-Commit-Position: refs/heads/master@{#317992}

BUG=425444

Review URL: https://codereview.chromium.org/953743003

Cr-Commit-Position: refs/heads/master@{#317991}

BUG=11746

Review URL: https://codereview.chromium.org/904313003

Cr-Commit-Position: refs/heads/master@{#317990}

Sync no longer has a concept of "acknowledged types".

BUG=352818
R=stanisc@chromium.org, maniscalco@chromium.org

Review URL: https://codereview.chromium.org/919383002

Cr-Commit-Position: refs/heads/master@{#317989}

A provider host which hosts a running service worker has its document URL
set to the script's URL now. So check it explicitly to avoid DCHECK fail.

BUG=459244

Review URL: https://codereview.chromium.org/947953003

Cr-Commit-Position: refs/heads/master@{#317988}

Fix test.util.registerRemoteTestUtils so external messages get propagated to all listeners.
Fix notification callback code to open files app in the right location when an import is initiated from a notification click.

BUG=459359

Review URL: https://codereview.chromium.org/959493004

Cr-Commit-Position: refs/heads/master@{#317987}

Now we don't have the integer session_id anymore,
there's no need to have a separate name.
So rename web_session_id to session_id.

BUG=440510

R=xhwang@chromium.org

Review URL: https://codereview.chromium.org/903663002

Cr-Commit-Position: refs/heads/master@{#317986}

R=kbr@chromium.org, vmiura@chromium.org
BUG=459778
TEST=chromote locally with enableVideoDecodeRenderer

Review URL: https://codereview.chromium.org/954073002

Cr-Commit-Position: refs/heads/master@{#317985}

Also compile PPB_CameraDevice_Private and PPB_CameraCapabilities_Private in NACL.

BUG=387547
TEST=Test with a trusted plugin. (Haven't tested on NaCl)

Review URL: https://codereview.chromium.org/944033002

Cr-Commit-Position: refs/heads/master@{#317984}

And reduce my TODO count in the process.

Review URL: https://codereview.chromium.org/955873002

Cr-Commit-Position: refs/heads/master@{#317983}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a7dac35..614cd2f

TBR=hiroshige@chromium.org,arv@chromium.org

Review URL: https://codereview.chromium.org/956783002

Cr-Commit-Position: refs/heads/master@{#317982}

BUG=450508
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/938223002

Cr-Commit-Position: refs/heads/master@{#317981}

Unfortunately, an OEM Lollipop build on an SGX 544 shipped without
fixing the driver bug causing GPU raster to be incorrect, so
unconditionally blacklist PowerVR SGX GPUs.

BUG=461456

Review URL: https://codereview.chromium.org/949423002

Cr-Commit-Position: refs/heads/master@{#317980}

- adds test activity layout into real view hierarchy.
- runs tests after Activity.onCreate() is done.
- doesn't load a default URL when testing.
- enables TouchInputBrowserTest by setting initial scale for Android.
- disables ScreenOrientationBrowserTest because it uses --disable-gpu
- updates expected results of DumpAccessibilityTreeTest

BUG=338011

Review URL: https://codereview.chromium.org/888793002

Cr-Commit-Position: refs/heads/master@{#317979}

File file_stream_reader and local_file_stream_reader was in
storage/browser/blob, move them to storage/browser/fileapi, make it
more understandable.

BUG=456634

Review URL: https://codereview.chromium.org/908833002

Cr-Commit-Position: refs/heads/master@{#317978}

Review URL: https://codereview.chromium.org/951143004

Cr-Commit-Position: refs/heads/master@{#317977}

BUG=11746

Review URL: https://codereview.chromium.org/896203003

Cr-Commit-Position: refs/heads/master@{#317976}

Reland patch from issue 951773002 at patchset 1 (http://crrev.com/951773002#ps1).
Rerecord & upload the wpr file to cloud storage.

To reviewers: to make sure that this doesn't produce the same problem in
https://codereview.chromium.org/952963002/, please wait for
https://codereview.chromium.org/954753002/ to be landed first.

BUG=459646

Review URL: https://codereview.chromium.org/954763002

Cr-Commit-Position: refs/heads/master@{#317975}

The issue where gpu_times would use too much memory has been fixed:
https://codereview.chromium.org/920523002

In order to prepare for future changes where additional metrics
will be added to the TBM module, I have also preemptively added a
filter function which filters out values relating to gpu_times.

R=nednguyen@chromium.org
BUG=455292, 453131
TEST=local runs measuring memory usage shows ~700mb

Review URL: https://codereview.chromium.org/937073003

Cr-Commit-Position: refs/heads/master@{#317974}

BUG=459877

Review URL: https://codereview.chromium.org/952103002

Cr-Commit-Position: refs/heads/master@{#317973}

This CL contains several improvements which are tightly coupled.
 - The method DispatchNotificationsUntilDone is only used by tracing_backend. I
 moved all the logic into tracing_backend. This has several side effects:
   - The exception DispatchNotificationsUntilDone is no longer needed.
   - The method _Receive no longer handles exceptions. It used to handle some,
   but not all exceptions. This change is very important for sane exception
   handling of the Chrome/Telemetry bindings.
   - The method _HandleNotification never has a return value. It used to
   sometimes return a boolean, and sometimes return nothing.
 - I removed the member _error_handler. This member was only used in two
 places: inspector_backend and tracing_backend. Of these two places,
 tracing_backend only used it to emit a not-so-useful log statement.
   - The biggest problem with _error_handler is that it decouples the exception
   handling from the context of the try/catch loop that triggered the
   exception.
   - The _error_handler only was called during _Receive(). This is very
   confusing, since that is not the only method that raises Exceptions. So some
   exceptions get handled by _error_handler, and some do not. :(
 - I removed all exception handling from inspector_page.py and
 inspector_websocket.py. It used to be that some exceptions would be handled in
 inspector_websocket, some would trickle up to inspector_page, and some would
 trickle out past inspector_backend.py. The eventual goal is for
 inspector_backend to catch all exceptions and translate them into
 {Recoverable/Unrecoverable}Exceptions.

BUG=460625

Review URL: https://codereview.chromium.org/942113004

Cr-Commit-Position: refs/heads/master@{#317972}

The new Clang plugin is more picky.

BUG=444089, 459607
TBR=hans,aa

Review URL: https://codereview.chromium.org/954113003

Cr-Commit-Position: refs/heads/master@{#317971}

The MockHttpCache::OpenBackendEntry and CreateBackendEntry functions may
have been making invalid virtual calls if the disk cache backend was not a
MockDiskCache. Fixes HttpCache.RangeGET_LargeValues under -fsanitize=cfi-vptr.

BUG=457523
TEST=net_unittests
R=rdsmith@chromium.org

Review URL: https://codereview.chromium.org/956433002

Cr-Commit-Position: refs/heads/master@{#317970}

The test depends on a bug behavior, and it prevents a Blink change fixing the
bug. Remove the test teporarily, wait for a Blink roll, and will land the test
with a fix again.

The test contains <select> like:
<select required>
  <option value="" disabled>- Select a State -</option>
  <option value="AL">Alabama</option>
  ...
</select>

The initial selection is "- Select a State -" now by a bug though it should be
"Alabama."

BUG=461586
TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/957593003

Cr-Commit-Position: refs/heads/master@{#317969}

This will allow us instantiate default media factory and
renderers

BUG=none

Review URL: https://codereview.chromium.org/956773002

Cr-Commit-Position: refs/heads/master@{#317968}

In doing so, consolidate calls to `SetBounds` for MacViews.

In toolkit-views, a Widget is considered "top-level" if it it doesn't
have the "child" flag set on InitParams. All widgets (both top-level and
not) can have their lifetime controlled by a "parent" window. Parented,
but "non-child", windows are positioned with coordinates relative to the
screen, not relative to the parent window that owns them.

For Aura, the logic that does this is in a wm::ScreenPositionClient.
MacViews is currently missing the logic in
DesktopScreenPositionClient::SetBounds(..). This CL adds the same logic
to BridgedNativeWidget::SetBounds(), and moves tests from
widget/desktop_aura/desktop_screen_position_client_unittest.cc to
widget/desktop_widget_unittest.cc since they are cross-platform.

The initial NSWindow bounds also needs to consider this logic, so bounds
setting for Widgets that specify InitParams::bounds changes to use
SetBounds(). A TODO that checked for a valid (according to OSX) window
size there is resolved by adding a DCHECK to
BridgedNativeWidget::SetBounds().

- Gets the following unit tests passing on MacViews:
DesktopScreenPositionClientTest.PositionDialog
DesktopScreenPositionClientTest.PositionControlWithNonRootParent

BUG=378134

Review URL: https://codereview.chromium.org/927233003

Cr-Commit-Position: refs/heads/master@{#317967}

BUG=

Review URL: https://codereview.chromium.org/952093002

Cr-Commit-Position: refs/heads/master@{#317966}

1) Use seconds-since-epoch in log record keys, instead of full date strings.
2) Add support for inflating/deflating urls.
3) Deflate URLS prior to storaing in log file.
4) Remove obsolete code for reloading history after remote changes.

BUG=461176
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/954583004

Cr-Commit-Position: refs/heads/master@{#317965}

BUG=460655
R=scherkus@chromium.org,DaleCurtis@chromium.org,xhwang@chromium.org,mfoltz@chromium.org

Review URL: https://codereview.chromium.org/954583003

Cr-Commit-Position: refs/heads/master@{#317964}

- getMenuThemeResourceId is always set to the same value to it can be removed.
- OverflowMenuTheme is not extended anywhere so rename OveflowThemeBase.

BUG=None

Review URL: https://codereview.chromium.org/946433003

Cr-Commit-Position: refs/heads/master@{#317963}

InfoBubbleWindow overrides -[NSWindow close] to schedule a fade
animation instead of closing. Currently, BaseBubbleController calls
this, but first removes the bubble from its parent NSWindow. This means
that if the close is due to a click on a browser window, the
parent->child relationship is already gone, and the clicked window is
raised on top of the bubble, making it seem to disappear immediately
rather than fade out.

This changes the flow so that InfoBubbleWindow only removes itself as a
child before calling [super close]; once the animation is complete.

BUG=459881

Review URL: https://codereview.chromium.org/944533004

Cr-Commit-Position: refs/heads/master@{#317962}

We can't enable on the ref build because SW doesn't work on the current ref build (M37).

BUG=442752

Review URL: https://codereview.chromium.org/951883006

Cr-Commit-Position: refs/heads/master@{#317961}

Two fixes were required to work on win8:

1. To determine if a directory is a reparse point, use GetFileInformation() since using WIN32_FIND_DATA.dwFileAttributes doesn't work on Windows 8.  See https://msdn.microsoft.com/en-us/library/windows/desktop/aa363940.aspx

2. Update the PE image tests to use its own binary, change the expectation format, add support for Win 8.1 and re-enable on 64-bit.

BUG=373973,167707

Review URL: https://codereview.chromium.org/946183002

Cr-Commit-Position: refs/heads/master@{#317960}

Shows an empty dialog with only 'OK' and 'Cancel' buttons when the CVC
unmask prompt dialog is requested.

Based on https://crrev.com/13470023

BUG=448572

Review URL: https://codereview.chromium.org/904613006

Cr-Commit-Position: refs/heads/master@{#317959}

MSAA would brake on windows because skia creates a BGRA8 internal format render
buffer, which we didn't support on windows.

We were turning on BGRA8_EXT for render buffers when we had
https://www.opengl.org/registry/specs/EXT/bgra.txt, this is a desktop spec that doesn't mention BGRA8_EXT
for render buffers, but we're assuming that it should support it.

I've added the condition that BGRA8 is supported for ANGLE as well as GL_EXT_bgra, and a couple test
to confirm this.

BUG=460567

Review URL: https://codereview.chromium.org/947653002

Cr-Commit-Position: refs/heads/master@{#317958}