- 04 Dec, 2019 40 commits
-
-
Ted Choc authored
From the failed screenshots, it appears the omnibox is not fully visible before attempting to focus the URL bar. This waits to ensure the URL bar is shown before attempting focus. BUG=1030246 Change-Id: I9f2c4659eca6b70d4d66b73f4abc40a6e2474d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949562Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#721590}
-
Maksym Onufriienko authored
Parent cl - http://crrev/c/1940752 Bug: 1026279 Change-Id: I9e24f6f889ab72c66b800fb307ed775fa171cb21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949292 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721589}
-
Lei Zhang authored
Some platforms have both struct stat and struct stat64. On these platforms, calls to stat() and related functions may fail with EOVERFLOW if struct stat cannot properly represent the information in a struct stat64. Parts of base/ already deals with this correctly by using stat_wrapper_t and wrappers for stat() and related functions. Expose these wrapper functions in base/files/file.h, which defines stat_wrapper_t, and use them throughout base/ in POSIX code that may trigger EOVERFLOW. Change-Id: I201507e440b1c80f6a24a86aad496c4b4793fdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947912 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#721588}
-
David Tseng authored
This is a small partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1947643 The check in desktop_automation_handler.js -> range_automation_handler.js onEventIfInRange helped prevent processing of repeated attribute changes that come from the subtree of ChromeVox's current range. For example, Gmail's threadlist where focus is on a row. Any attribute changes within cells or on individual cells caused output. TBR=dmazzoni@chromium.org Change-Id: I696cd506a2c8d33bfa343d36df76f7551c79bb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951085Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#721587}
-
Maksim Sisov authored
This reverts commit a71959ba. Reason for revert: causes crashes if buffers are submitted twice and Wayland compositor releases the buffer Original change's description: > ozone/wayland: Complete submission of a buffer submitted more than once > > This CL fixes a corner use case that was caught by one of the users > of Ozone/Wayland. > > The problem appeared when the Chromium compositor sent a next frame into > the same buffer that had just been submitted and a OnSubmission callback > had been sent to the viz process located WaylandBufferManager. This > happened only when the remote inspector was attached and the screencast > was enabled. > > In this case, Wayland compositor will not send an OnRelease callback > and we should not wait for that. Instead, we must complete the > submission immediately and set the |WaylandBuffer::released| > member to be false. Once another buffer is committed, Wayland compositor > will release the previous buffer. > > Bug: 1029777 > Change-Id: Ib74c16f41f128298998bc9699f8d9ded3697cd43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946479 > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720878} TBR=rjkroege@chromium.org,msisov@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029777 Change-Id: I14dc61f4dad186a17e5b657d87143cb61a24f48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950972Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#721586}
-
Kevin Marshall authored
Allows for creation of HEADLESS Contexts, for browsing sessions without graphical output. Implements EnableHeadlessRendering() and DisableHeadlessRendering() on Frames, which is used for processing DOM animation events in non-graphical Contexts. Bug: 1025045 Change-Id: I2cd8e428f4b6eadaafe17631b36b6d42b8d4ea25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918036Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#721585}
-
Herb Derby authored
Bug: chromium:625191 Change-Id: Iecad57e6ba8d11db5a9faf0b868d39ed3db3e34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947357 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Herb Derby <herb@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#721584}
-
John Budorick authored
Bug: 1030253 Change-Id: I0f06df54c45523212f7333b3f8e447cefe2ecf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948514 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#721583}
-
Aran Gilman authored
Bug: 1027612 Change-Id: Ic4fe44c88ceac6db749336830c6f0abe15dbc68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931105Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Auto-Submit: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#721582}
-
John Z Wu authored
Change-Id: I823b0892c4eaeac5555b51e4d753311c191b7cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949699Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#721581}
-
Yue Li authored
If all the sequences has been detached, the observer should be notified, otherwise it might wait forever. Also added unit test cases for this scenario. Bug: b/141997678 Test: Run CallbackLayerAnimationObserverTest.* in compositor_unittests Change-Id: I3a025de8e635a383910ef4a3e650683478e8d3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938459Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#721580}
-
Sean Harrison authored
Changes between original submission and reland: 1.) Privacy-page subpages are now in lazy_load.html 2.) Fixed bug that erroneously showed "privacy" in the settings menu of "Guest" mode settings. 3.) Fixed bug where going to chrome://settings/clearBrowsingData didn't work unless the advanced section was expanded when the flag for this change was disabled. 4.) Reordered a few settings rows to match the most current mocks. > Revert "Friendly Privacy Setting Initial Redesign" > This reverts commit 544412a4. > Reason for revert: Performance and functional regressions > https://bugs.chromium.org/p/chromium/issues/detail?id=1024034#c5 > Original change's description: >> Friendly Privacy Setting Initial Redesign >> >> This CL does 3 things: >> 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag. >> 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on. >> 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag. >> >> Bug: 1014143 >> Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088 >> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094 >> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> >> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> >> Cr-Commit-Position: refs/heads/master@{#714287} Change-Id: If3fa33801604491b8648672ff53d37a818f2cd08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929443Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#721579}
-
Arthur Wang authored
R=carlosk@chromium.org, harringtond@chromium.org Bug: 1028976 Change-Id: I63e361cae052c1fb274cfefa9791b20ea9f596cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949449Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721578}
-
Alexander Hendrich authored
The permissions for the chrome.usb API was already removed earlier (https://crrev.com/c/1916860). Bug: 995294 Change-Id: I73468cf202f0d4137744aa5d127e663839569e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949796 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#721577}
-
Ioana Pandele authored
The method called to show the dialog used to take 9 parameters and the list was growing. This CL bundles the parameters into a separate contents object which requires the mandatory values to be passed in the constructor and offers reasonable defaults and setters for the rest of the values. In addition, some properties of the model are not actually meant to be changed on the fly, so they are now marked readonly and set before building the model. This requires a separate initialization step in the coordinator and mediator. Bug: 1028947 Change-Id: I4f121e5fee88d095d6c31add59111639e85faedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948931 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721576}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/576b9e489dca..c4eacc1612b6 git log 576b9e489dca..c4eacc1612b6 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 brgoddar@microsoft.com Coverage: Add title for visualization in coverage tool 2019-12-04 obrufau@igalia.com [css-pseudo] Expose ::marker pseudo-element in devtools tree (front end) 2019-12-04 yangguo@chromium.org Remove outdated extract_module script Created with: gclient setdep -r src/third_party/devtools-frontend/src@c4eacc1612b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:457718,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ica48896b556d628525500cc39608aa3b3cd389d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950845Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721575}
-
rbpotter authored
- Replace CallJavascriptFunctionUnsafe('deleteHistory') with a FireWebUIListener() call. - Remove global deleteHistory function in history.js and forwarding in app.js, and directly listen for the event in history_list.js. - Add a test verifying that the event is correctly handled. Bug: 1022212 Change-Id: If6f2f62dbe1bfa8c94313c32e448f892e8072c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947906 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: -
Daniel McArdle authored
This commit adds -Wno-deprecated to the relevant target's cflags for non-mac builds. If we ever update XCode's bison version to 2.7 or better, we will be able to replace '%pure-parser' with '%define api.pure full' in xpath_grammar.y. Change-Id: Ib0390d7c91828c095a86eb07acb854f09fa13060 Bug: 1028421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948245Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#721573}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6a67c60a. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." 83e4a43b "Refactor VRPose to fit better with WebXr concepts" a93be69b "Update reversing-an-animation test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I84ba940af0ae8a965033238d77b513f6cfe6ae2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950885Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721572}
-
Mikel Astiz authored
This patch is similar in spirit to the desktop equivalent changes in https://chromium-review.googlesource.com/c/chromium/src/+/1924572. The overall idea is that, if encryption keys are missing, the UI needs to display this state as an error, and the user should be able to go through a reauth flow to retrieve the keys. The actual logic to trigger the key retrieval process is deferred to future patches and reflected in TODOs. Bug: 1012659 Change-Id: I0679e47f8c783fdfd2953989205964165b0f8147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930796 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#721571}
-
Raymond Toy authored
Converting media/base to use BindOnce/Repeating as appropriate. Bug: 1007799 Change-Id: Idc4cc28073203337983b87844eb1e5268adcb133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947229Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721570}
-
danakj authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This skips one base::Bind() call because it would require changing the BluetoothAdapterClient::PauseDiscovery() API as well, so we leave it for another CL. R=hansberry@chromium.org, reillyg@chromium.org Bug: 1007760 Change-Id: I6ac8b334a364a791adecbd5d93fe6935c72a9045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944630Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
This addresses a side effect of crrev.com/c/1934836, that stretches all children. Default gravity for linear layout positioned items always on top. Bug: 1030722 Change-Id: I1a981be06feb2126c04f36aa7306b64beb68de9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950856Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#721568}
-
Mikel Astiz authored
Permanent bookmark nodes are created server-side and don't contain a originator client item ID. Hence, they should be filtered out for this histogram, otherwise they contribute to the left-empty bucket which is precisely a problematic bucket that is expected to be practically zero. Bug: 978430 Change-Id: I3bc75145c4ec5fc46489789b538a8ce62be5594f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947645Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#721567}
-
Sorin Jianu authored
Bug: 1027610 Change-Id: I6e2a7914a6f8694185f33e49d59a06cff21ef598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947557Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721566}
-
Richard Knoll authored
This closes SharingDialogViews when the main frame navigates to a different origin. Right now this only affects the SharingDialog and (for CrOS) the IntentPickerBubbleView but will be enabled for all subclasses of LocationBarBubbleDelegateView in a subsequent change. Bug: 1027408 Change-Id: I07ca9ce55042265d85e56a84c5e43efa3cb026d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948839 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#721565}
-
Mikel Astiz authored
The DCHECK was introduced long ago in https://chromiumcodereview.appspot.com/11522009 where it may have been necessary, but in today's implementation the code does not rely on ThreadTaskRunnerHandle. The DCHECK is a proxy for verifying that a global field trial list exists, which can be checked more directly via the value returned by FieldTrialList::AddObserver(). The patch is motivated by DCHECK failures observed recently on ios after the codepath has been triggered from the sync thread, due to https://chromium-review.googlesource.com/c/chromium/src/+/1827368. Bug: 1011088 Change-Id: I075c28f86962c88b9331290c1b57f2da8a3af755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844992 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#721564}
-
Mikel Astiz authored
ios WebView does not integrate with variations, but the actual production code WebView relies on may assume that there an instance, leading to DCHECK failures. This was surfaced by integration tests where, despite base::TestSuite's attempts to instantiate FieldTrialList via FeatureListScopedToEachTest, and due to shared libraries leading to ODR violations affecting FieldTrialList::global_, DCHECKs could fire (mostly prevented landing additional DCHECKs). Bug: 1011088,1018667 Change-Id: I7ff3b356bd246c5f0a9b8776ae6d372bfd4a9df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950518Reviewed-by:
John Wu <jzw@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#721563}
-
Sean Kau authored
It was found that BulkPrintersCalculatorFactory is leaking state between tests and causing flakiness. Change ownership from a singleton to an object owned by chrome_browser_main_parts_chromeos to guarantee that only one ever exists during tests and in production. To accommodate this, adjust users of the factory to handle a null factory which will occur during unit tests and shutdown. Bug: chromium:1015949, chromium:966561 Change-Id: I61eb5bc9e37363e95d26e8b07ae0cb0d5087c275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888517 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#721562}
-
Josh Nohle authored
Ensures test coverage for active CryptAuth v2 Enrollment field trial. See https://chromium.googlesource.com/chromium/src.git/+/master/testing/variations/ See also cl/283612634. Bug: 899080 Change-Id: Ibcee32294949352d48c8281ca793a5a7feb0321b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950666 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#721561}
-
Takumi Fujimoto authored
Disable it on ChromeOS release builds for being flaky. TBR=dmurph Bug: 1030733 Change-Id: I44db0ed9e8fce4c94d5e4833b2a88666c63eb27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951084 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721560}
-
Jonathan Backer authored
This reverts commit b344f6f2, while keeping the buildbot changes which are safe to keep. Bug: 967716 Change-Id: Ie983fb911aaa80f90536df1fd5c50dfc66927692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951146Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#721559}
-
Jan Wilken Dörrie authored
This change adds an IsAffiliationBasedMatch data member to the UiCrendential class. This is intended to be used to determine whether a credential is backed by an Android credential, and intends to replace checking whether the UiCredential's origin_url starts with "android://". This allows changing UiCredential origin_url to be an url::Origin instead of a GURL and update its name to origin. Lastly, this change performs some minor clean-ups and updates effected tests. Bug: 1030230 Change-Id: I3331b29541c88984fe5d17f9f11fd0d0fdb79b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948837 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Azeem Arshad authored
This CL changes the accessibility label for Join Other button in tray menu from "Join other..." to "Join other WiFi networks" to give more context when using screen readers. Fixed: 1027362 Change-Id: Id88e17add4fadd51671ebcfcbd40835a2564a114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949529Reviewed-by:
-
Lan Wei authored
Right now the chromedriver test testActionsMultiTouchPoint is slightly flaky after we wait 100 ms for the page layout loading, we increase the waiting time to 1000 ms to avoid flakiness. Bug: 1011225 Change-Id: I9e8fcdf19522a5775171585af4f16b35fe69c615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951083Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#721556}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b64ff931eb98..0eccc52635b4 git log b64ff931eb98..0eccc52635b4 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 eseckler@google.com processor: Actually propagate string pool size config to TraceStorage Created with: gclient setdep -r src/third_party/perfetto@0eccc52635b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1026682 Tbr: perfetto-bugs@google.com Change-Id: I23a617de1a67cb6d9e3b9d4098434446034ce135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950853Reviewed-by:
-
Esmael El-Moslimany authored
Change-Id: I71a7ae90419fb5da9e5d65e99e59e0fb14d9e069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948051 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#721554}
-
Dominic Mazzoni authored
Plus two other cleanups as a follow-up to http://crrev.com/c/1927974 Bug: 607777 Change-Id: I5633c5e61b4c865b5623759f5ae05371edb66610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949004Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#721553}
-
Ali Juma authored
This adds the file as an EG2 target and updates #includes. Bug: 987646 Change-Id: I10ff2d45efc784f36f2a394bfd75289617a78e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950851Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#721552}
-
Roman Aleksandrov authored
Add Packaged License screen before Login screen if device packaged with license. Bug: 1024809 Change-Id: I8bc6359658e352f1369ecb8ac94a2133a3eba756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924434Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#721551}
-
