- 12 Jul, 2019 40 commits
-
-
Robert Sesek authored
The API allows the creation of executable shared memory, which should be restricted to the sole client (NaCl) until it can be removed entirely. Bug: 982879 Change-Id: Ib89a34da7e20de0ac8e984f0ccf0e8109d6d8338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700114Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#677100}
-
Tatiana Buldina authored
Change-Id: I30357ac8aa6e59501da5280086e52c83a637b369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700383Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#677099}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/71b0b56a4914..9fad38a65ee5 git log 71b0b56a4914..9fad38a65ee5 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 chrome-bot@chromium.org Update config settings by config-updater. 2019-07-12 miahsanchez@google.com vm_unittest: tests for removing and creating directory. 2019-07-12 gbiv@google.com cbuildbot: add toolchain owners for toolchain bits Created with: gclient setdep -r src/third_party/chromite@9fad38a65ee5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ia3c3bf64bf79e288cfa492c82fa044ad403393e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#677098}
-
Bruce Long authored
This change implements native caret browsing. In caret browsing, a moveable cursor is placed on a web page, allowing a user to select and navigate through non-editable text with just a keyboard. The changes on the renderer process side are those needed to make the caret visible and moveable in non-editable text when caret browsing is enabled, move the focus when the caret moves into a focusable element such as an anchor, and move the caret to the active element on initiating navigation if not already there. For the initial landing of caret browsing, no UX is exposed to the user for toggling caret browsing on and off (using F7 as in other browsers e.g.), nor are there any means exposed on about:flags to enable the feature. Instead caret browsing is enabled on browser launch via a command line parameter, similar to the current behavior of the spatial navigation feature: chrome --enable-caret-browsing All new tabs created during the browser session will have caret browsing turned on. To fully land the feature in a later CL would require implementing the following UX elements as well: 1) Adding the F7 (or other appropriate key) as an accelerator to toggle caret browsing on and off. 2) Creating a caret browsing dialog confirming with the user that caret browsing should be toggled on or off. 3) Adding two new browser settings: one indicating if caret browsing is currently enabled, and another that indicates if pressing F7 should trigger a confirmation dialog or just enable/disable caret browsing without confirmation. 4) Plumbing a mechanism for passing the "caret browsing is enabled" setting from the browser process to renderer processes. 5) Adding a flag for this feature to "about:flags", exposing a means for the user to enable or disable the feature without a command line flag. Note that these UX elements were already implemented in earlier patchsets of this CL--see patchset 18 as the last patch before their removal. Separating the feature implementation into multiple CLs allows early experimentation of the renderer side changes and accounts for the possibility that different browsers may opt for a different UX. Bug: 977390 Change-Id: I1906165037c96079d7bec70683f3cc446580f56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666567 Commit-Queue: Bruce Long <brlong@microsoft.com> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#677097}
-
Bryan McQuade authored
This change removes the LayoutInstabilityMoveDistance runtime enabled feature flag, and updates the LayoutShiftTracker to incorporate move distance into the score calculation by default. Change-Id: I5c4e12ed5c3f4a0c710df1fe8c8ec4e73875fe47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694187Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#677096}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/214323b343e9..4d94b5d9ba73 git log 214323b343e9..4d94b5d9ba73 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 rmhasan@google.com Revert "Reland "[Telemetry] Integrate new test expectations format into telemetry benchmark runner"" 2019-07-12 rmhasan@google.com Reland "[Telemetry] Integrate new test expectations format into telemetry benchmark runner" 2019-07-12 brucedawson@chromium.org Improve system tracing failure error message 2019-07-12 dproy@chromium.org Add jpeg-js decoder third party Created with: gclient setdep -r src/third_party/catapult@4d94b5d9ba73 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:97396,chromium:97396,chromium:604301,chromium:980973 TBR=zhanliang@google.com Change-Id: I15fb108ef6c6cad378b4c852adc795b28ab54049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700433Reviewed-by:
-
Gabriel Charette authored
[ScopedTaskEnvironment] Fix UBSan issue calling a member method from ScopedTaskEnvironment's initializer list TBR=fdoray@chromium.org Bug: 946657, 983290 Change-Id: I3e83611141f364b1d7e3a42442d896bdf6956877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700269Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#677094}
-
Kristi Park authored
- Add aria-roles for the sidebar and submenus that indicate these are tab panels. - Use aria-pressed for shortcut options and aria-selected for sidebar buttons to indicate if they are currently selected. - Add aria-labels for submenu and shortcut elements. Bug: 953822 Change-Id: I0a0842378b0d164b5e8610a40d933d792073911f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696763Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#677093}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/851f501318ec..cb26647b6851 Created with: gclient setdep -r src-internal@cb26647b6851 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: Ibcce9940385d3c0551f72c3ac30c59fb5e1af533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700367Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#677092}
-
Mark Pearson authored
This reverts commit f1ddcc97. Reason for revert: The Mac10.13 Tests (dbg) bot been consistently failing webkit_layout_tests since this change/tests were submitted. The first run with the change is this run: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/13007 The failures are all deterministic timeouts to the tests * http/tests/virtual-scroller/find-element-62-10px.html * http/tests/virtual-scroller/find-element-63-10px.html * http/tests/virtual-scroller/find-element-64-0px.html * http/tests/virtual-scroller/find-element-64-10px.html * http/tests/virtual-scroller/find-element-65-10px.html * http/tests/virtual-scroller/find-element-66-10px.html https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/13007/webkit_layout_tests/layout-test-results/results.html Original change's description: > Add a virtual-content element that uses display locking to make content > low cost when off-screen. > > Exposes .mjs files as http-available files for web_tests. This required > adding .mjs to the mime config and various things in BUILD files. > > Add .mjs as javascript to the mime configs for webtest server. > > Delete old virtual-scroller code. > > Bug: 979108 > Change-Id: Idfde0bb23263b571fc3abf98845bb7d0327baf07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680170 > Commit-Queue: Fergal Daly <fergal@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676308} TBR=tkent@chromium.org,tikuta@chromium.org,domenic@chromium.org,fergal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979108 Change-Id: Ib3e2cd9e2deea6859fb716796e1919383915c9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700174Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#677091}
-
Khushal authored
R=dtrainor@chromium.org Bug: 983310 Change-Id: I88d7a60b2938355fb1253707ebf45ab8bffe1c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699422 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#677090}
-
Jeffrey Cohen authored
The previous client of this method was the Send Tab To Self Action Sheet, which has been replaced by a modal dialog. Bug: 970284 Change-Id: I85ca056ef970e515e94a30421d027ca7cae676e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696173Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#677089}
-
Eric Roman authored
This fixes support for --log-net-log when the Network Service is enabled. Bug: 979838 Change-Id: I86f25ce87584e2f318ddaa99012c876974c85745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682887 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#677088}
-
Staphany Park authored
Flakiness resurfaced on Win7 and Win10 build bots, yielding both failures and timeouts. Bug: 827231 Change-Id: I8a56c98a79ee3a5a5ef12c054f344146042cf458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699289 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#677087}
-
Ken MacKay authored
Local sound effects use CastSoundsManager now, so all streams going through CastAudioOutputStream should be "normal" stream type. Change-Id: I7a132a90dab914e1135a533f180174cc3f898049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697373Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#677086}
-
Dan Harrington authored
We were assuming that there is only GCM subtype in play, but this assumption will not hold soon. This change gets the gcm authorization for the prefetch subtype explicitly. This change should unblock https://chromium-review.googlesource.com/c/chromium/src/+/1695346 Change-Id: I275aaeea6c43ee027130c9dbdc0ba10bed698555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699369Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#677085}
-
Mark Pearson authored
This reverts commit 19f78e3e. Reason for revert: consistently fails (via timeout) on the Mac10.11 Tests bot https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests even since it first landed on this run: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/40038 BUG=979170 Original change's description: > Reland: [shapedetection] Add some shapedetection tests > > The original CL has been reverted because the test > external/wpt/shape-detection/detection-HTMLVideoElement-invalid-state.html > is flaky. > > In the previous CL, the way to create a HTMLVideoElement with 'HAVE_METADATA' > state is wrong, because simply loading a video file its readyState should > be >= HAVE_METADATA during loadedmetadata event. Which is the reason of the flaky. > > This reland CL leverages MediaSource API to precisely trigger a transition > to HAVE_METADATA state by invoking `appendBuffer()` with an initialization segment. > > See relevant spec: https://w3c.github.io/media-source/#sourcebuffer-init-segment-received > > Original change's description: > > [shapedetection] Add some shapedetection tests > > > > Cover following two checkpoints: > > - If the ImageBitmapSource is an HTMLVideoElement object whose readyState attribute > > is either HAVE_NOTHING or HAVE_METADATA then reject the Promise with a new > > DOMException whose name is InvalidStateError. > > - If the ImageBitmapSource argument is an HTMLCanvasElement whose bitmap’s origin-clean > > flag is false, then reject the Promise with a new DOMException whose name is SecurityError. > > > > spec: https://wicg.github.io/shape-detection-api/#image-sources-for-detection > > Change-Id: I0522d0340d3cb0291df6be65dfc1ab99037b30f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666766 > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > > Cr-Commit-Position: refs/heads/master@{#671578} > > Bug: 979170 > Change-Id: I963c3b6bce86791f5bedde7849c2e439b28c5481 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688460 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > Cr-Commit-Position: refs/heads/master@{#675956} TBR=reillyg@chromium.org,mcasas@chromium.org,wanming.lin@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979170 Change-Id: Ia07d24517436bf2e45086251cef82441bb966192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700387Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/25abeb83954a..eede75962a10 git log 25abeb83954a..eede75962a10 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 oysteine@google.com Merge "Add ProfiledFrameSymbols to the chrome subset of TracePacket" Created with: gclient setdep -r src/third_party/perfetto@eede75962a10 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia1f1a669cfd44f083142be7c854ecb3fad03f717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700431Reviewed-by:
-
Mohamed Heikal authored
Supersize the tool that is used by the binary size trybot is now able to deobfuscate the resource paths for APKs and AABs that enable resource path shortening. This should allow the binary size trybot to blame resource size diffs on the correct directories. Bug: 753402 Change-Id: I396fd36b284a184bb5b07abf67d6b342920f0bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693172 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#677082}
-
Yuwei Huang authored
The old HostChangeNotificationListener listens to host deletion events from XMPP, which will go away with the gTalk turn down. New hosts rely on FtlHostChangeNotificationListener for getting host deletion events through FTL. This CL deletes the old HostChangeNotificationListener. Bug: 983282 Change-Id: I0d9acb261d3702391f8345a228853d9c4e1af5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700472 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#677081}
-
Raymond Toy authored
If the number of distinct elements in the input array does not match the number of elements in the expected set, an error was thrown trying to read a property from undefined. Instead, check that the lengths match and if they don't fail the test with an appropriate message. Also remove the-convolvernode-interface/active-processing.https.html that should have been removed in https://chromium-review.googlesource.com/c/chromium/src/+/1653924 but wasn't. Bug: 974022, 978372 Test: audit-failures.html Change-Id: Ifa2da978f3c0f67dc444c69ceddb862675908b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659492 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#677080}
-
Raymond Toy authored
Move enum AudioParamType to AudioParamHandler class and update uses appropriately. Remove the unused AudioParam::GetParamName Bug: 982908 Change-Id: I2a16dad7c958082260df7434c02d564d428d665c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700261Reviewed-by:
-
Raymond Toy authored
Replace the offline audio context with a realtime context and an AudioWorklet. Previously, when the source stopped, the channel count change would sometimes get delayed until rendering is done, which is too late for the test. I believe this is because the main thread was previously too busy to process the messages to disable outputs and change the channel count. Using a realtime context makes the main thread less busy because the messages aren't posted as fast as possible, allowing time for them to be handled. I think this is still flaky, but much less so than before. Bug: 974258 Test: the-channelmergernode-interface/active-processing.https.html Change-Id: Id584ebfa5f54ad6870819f5242aafed5f4fc80d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663186Reviewed-by:
-
Nick Harper authored
Bug: 903642, 975114 Change-Id: Id7112697acbb6eff9fe73b0801c2c1063e111267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686691Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#677077}
-
Sophie Chang authored
Bug: 969558 Change-Id: I283b2a04899baba36cf6270bdee12ccba5e7de7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695885Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#677076}
-
Jonah Ryan-Davis authored
The corner case where CopyTexture is called on the same source/target image on different levels is now fixed in ANGLE. Bug: angleproject:2994 Change-Id: I256f1c0978b7635bb58821eb45749b5886b081f8 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700264 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#677075}
-
Erik Chen authored
Previously, base::PostDelayedTask was being called without any explicit task traits. ProcessMemoryMetricsEmitter must be called on the Browser UI thread. Bug: 982646 Change-Id: I1ef67ff4dbbb952a7004622399410e5f9636f2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697433Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#677074}
-
arthursonzogni authored
This fixes the tests: * VrBrowserNativeUiTest#testSecurityTokenOnHttp * VrBrowserNativeUiTest#testSecurityTokenOnHttps * VrBrowserNativeUiTest#testSecurityTokenOnHttpsBadCertificate See https://00e9e64bac97828476a63763ecdce7ef9fbd108cf315c02025-apidata.googleusercontent.com/download/storage/v1/b/chromium-result-details/o/5d2e46349bcedf8908ac942137d3e95a16c0cc06?qk=AD5uMEsZKJaSX55rhfhtfQGjUqSxHo8psOGyv31xUqi96tpf0SWU3yJdbGmozt8kzQ0ECgRK387HluYWOwqUKmksg_fejIr_trH5PLrRjRdRzOAKr9T6iOOGCUsChTtnC-ShtebDtv7fK0ttP8533Tgdfz7NkKHQ0HQEdlECziJUxzA9cu_P7XBz5BjSBD4ISpKMDtct5z69sIe2OORB5jy5biSOH8b8ERvsuPt_7_YABJG5_W9MDEeQTLsXnyZqTptTClt-MZB3ejwuwlZYdplS6KNEsRgBecxFzxqcGzZ_gqtOdl_zLQv7zfhcengUldISPjFgdOzE73js0XS8XU2tX9svzFgz8q8bKIza_AxlzCMPVtl-Dvk_EfkYDt5dIKoyxEJpDjK6jx2e6jTkhkHii11Kka0P7L9-KjKk7AjjSRciXmd-s6IoAojUK1XuNwwCO7DkUWZCoO7rVlM3861Fp6OeXbq-LM7ubVn3zOjbuP3MlDjBz6KXxxFPb3dodIIOW77tHtFi72zlwDDVVMfNi8pkudEw5CG667ilrcx1IMqqKFKGzYsk3yws4hKjrTSoSX12nMieKt_g0M2adCvNyVLqPWNFpowQF0N6iodJ_o6348aVIl9j4qkJv02YCC4OLMeLTEgTai0OtGlzutkgnmbwp95K_3vmKG4CTMrK8iqmC7vCe_KNSBQY0zvQxTb6BcRYWiI_L_SqNqN7G7hmGQnTHWqH0nmIo0eu1RkIV6qMc0fAD35GHfRHR_ZH74jUmYDP16W0DwHrkLLTfmdEyRiH9rxKoDfPTKSjVbldFzfrdng_781f4NakYE_y06OhysZQlf5v Bug: 983569 Change-Id: I9dcc7938ab23e612767277b2ef3902e1246e08d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700047 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#677073}
-
Xida Chen authored
Our current include order should be: c system header, c++ system header, others If it is a .cc file, then its corresponding .h file goes the first. This CL corrects this under for the files under renderer/platform/animation TBR=smcgruer@chromium.org Bug: None Change-Id: Ie73c69ec5770b8d1eb62b39d548cd5498425ddb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699511 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#677072}
-
Vlad Tsyrklevich authored
When GWP-ASan is used with 32-bit address spaces, false positives are much more common because a random bad dereference is much more likely to point into the GWP-ASan region. After several months, the Windows/x86 version of GWP-ASan has not found bugs we couldn't find with the 64-bit only version so disable it to reduce false positives. Bug: 969146 Change-Id: I9beaa01b428c2fa6495c10f634cf9e01c3d170d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696208 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#677071}
-
Mark Pearson authored
This reverts commit 063cdeef. Reason for revert: Likely causes of deterministic failures on linux-chromeos-dbg bot since it was submitted. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/13333 Failing viz_browser_tests item CrSettingsPeoplePageKerberosAccountsTest.All Failure looks like: [ RUN ] CrSettingsPeoplePageKerberosAccountsTest.All [1:1:0711/125719.782650:INFO:hugepage_text.cc(96)] Mlocking text pages failed: Cannot allocate memory (12) [12029:12029:0711/125720.228069:INFO:content_main_runner_impl.cc(981)] Chrome is running in full browser mode. [12029:12029:0711/125721.406902:INFO:remote_commands_service.cc(38)] Fetching remote commands. [12029:12029:0711/125721.407222:WARNING:remote_commands_service.cc(40)] Client is not registered. [12029:12029:0711/125721.408386:INFO:remote_commands_invalidator.cc(34)] Initialize RemoteCommandsInvalidator. [12029:12029:0711/125721.408549:INFO:remote_commands_invalidator.cc(59)] Starting RemoteCommandsInvalidator. [12029:12029:0711/125721.408652:INFO:remote_commands_invalidator.cc(130)] RemoteCommandsInvalidator ReloadPolicyData. [12029:12029:0711/125721.408726:INFO:remote_commands_invalidator.cc(172)] Unregister RemoteCommandsInvalidator. [12029:12029:0711/125721.821717:WARNING:wallpaper_controller_client.cc(328)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [12029:12029:0711/125722.620525:ERROR:gcm_driver_desktop.cc(1094)] Unable to get the InstanceID data: cannot start the GCM Client [12140:12201:0711/125722.698217:WARNING:simple_synchronous_entry.cc(1389)] Could not open platform files for entry. [1:1:0711/125722.911602:ERROR:utility_service_factory.cc(200)] Ignoring request to start unknown service: cups_proxy [12029:12029:0711/125723.200521:ERROR:account_manager_migrator.cc(249)] Could not find a refresh token for the Device Account. [12029:12029:0711/125726.095357:WARNING:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source: (0) [12029:12029:0711/125729.770017:INFO:CONSOLE(1195)] "Running TestCase CrSettingsPeoplePageKerberosAccountsTest.All", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1195) [12029:12029:0711/125731.368557:WARNING:CONSOLE(11)] "Could not find style data in module named action-link", source: chrome://resources/polymer/v1_0/polymer/polymer-extracted.js (11) [12029:12029:0711/125735.550983:ERROR:CONSOLE(155)] "Uncaught (in promise) TypeError: this.$$(...).show is not a function", source: chrome://settings/people_page/kerberos_accounts.js (155) [12029:12029:0711/125735.763001:ERROR:CONSOLE(49)] "Mocha test failed: KerberosAccountsTests RemoveAccountShowsToast AssertionError: expected undefined to be false at Function.assert.isFalse (file:///b/s/w/ir/third_party/chaijs/chai.js:2459:31) at assertFalse (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:788:15) at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/people_page_kerberos_accounts_test.js:257:7) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) [12029:12029:0711/125749.460448:ERROR:web_ui_test_handler.cc(72)] Test Errors: 1/37 tests had failed assertions. [12029:12029:0711/125749.460716:ERROR:web_ui_browser_test.cc(542)] CONDITION FAILURE: encountered javascript console error(s): [12029:12029:0711/125749.460773:ERROR:web_ui_browser_test.cc(544)] JS ERROR: '[12029:12029:0711/125735.550983:ERROR:CONSOLE(155)] "Uncaught (in promise) TypeError: this.$$(...).show is not a function", source: chrome://settings/people_page/kerberos_accounts.js (155) '... For more details, see http://crbug.com/983568 Original change's description: > Restrict CertificateManagementAllowed policy > > This cl restricts CertificateManagementAllowed policy to client > certificates only and renames it to ClientCertificateManagementAllowed. > > This is the first step towards creating a separate > policy that manages user permissions over CA certificates in the Chrome > certificate manager UI. > > Bug:958455 > Test:- manually tested that importing and deleting CA certificates > works regardless of policy settings > - manually tested that importing and deleting client certificates > works according to policy > > Change-Id: Id0aaf44f3bc4e3a22e99904234be3fd5343dce78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690862 > Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676384} TBR=stevenjb@chromium.org,rsleevi@chromium.org,pmarko@chromium.org,acostinas@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 958455 Change-Id: Iffc9c2a3b983d2032a45ccfa80efc6be88712cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699200Reviewed-by:
-
Ben Kelly authored
Bug: 957175 Change-Id: I2b4fee145edc74bd9bba6afd2b3e66a0bd55b77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698127Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#677069}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/24192c267a40..a7e3bcebaedc git log 24192c267a40..a7e3bcebaedc --date=short --no-merges --format='%ad %ae %s' 2019-07-12 mbonadei@webrtc.org Reland "Make new pacer padding more like old one" 2019-07-12 mbonadei@webrtc.org Reland "Pass RtpRtcp::Configuration to RtcpReceiver ctor and initialize ssrcs" 2019-07-12 mbonadei@webrtc.org Reland "Optimize PacketRouter/RTPSender interactions." 2019-07-12 mbonadei@webrtc.org Reland "Add ability to set RTCP sender ssrc at construction time" Created with: gclient setdep -r src/third_party/webrtc@a7e3bcebaedc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2db40fd22705a9266b9099891e5c4d35b98a15ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700422Reviewed-by:
-
Brian Sheedy authored
Makes the Skia Gold version of the GPU pixel tests non-experimental, so any unsuppressed failures will show up as builder-level failures since the tests have been quite stable. Documentation on Gold and how to triage any new images the tests produce can be found at https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gpu/gpu_pixel_testing_with_gold.md Bug: 850107 Change-Id: Ic7187f049f98bad561d8591e04354359fe64e4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698644Reviewed-by:
-
Kevin Bailey authored
Class OfflinePageModel:SavePageParams was using an unset bool. It's now initialized in the constructor. Change-Id: Ie810decf6eb27c5ca0be020b52d5df3f4c43a7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699090Reviewed-by:
-
Miguel Casas authored
This CL extends two LOG(ERROR)s I was hitting on crrev.com/c/1619832: - one because a YUV420_BIPLANAR had an odd dimension - the other because I wanted to track a Mailbox use-after-release. No new functionality intended, only moarrrr debugging info. Change-Id: Ibe12e3e4850bbfc7bad5841f3aa6eea02e412dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699394 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#677065}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a985c42ae65..851f501318ec Created with: gclient setdep -r src-internal@851f501318ec The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: I700336691e6423f19aaae4d0c68c7d52d2d3b4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700421Reviewed-by:
-
Jun Mukai authored
The current test case examines the smoothness for the transition of half-visible search to fullscreen search. The new one does the test of fullscreen app-list to fullscreen search. I think this would verify the animation smoothness within the app-list itself very clearly. With r676512, the performance numbers (on nocturne) are: LauncherAnimations/LauncherAnimationsFullscreenSearchTest.SearchAfterFullscreen/0: Apps.AppListHide.InputLatency: 64, 64, 64, 64, 64 Apps.StateTransition.AnimationSmoothness.Close.ClamshellMode: 93, 86, 86, 86, 86 Apps.StateTransition.AnimationSmoothness.FullscreenSearch.ClamshellMode: 39, 33, 33, 33, 26 LauncherAnimations/LauncherAnimationsFullscreenSearchTest.SearchAfterFullscreen/1: Apps.AppListHide.InputLatency: 63, 55, 64, 63, 64 Apps.StateTransition.AnimationSmoothness.Close.ClamshellMode: 93, 93, 93, 100, 93 Apps.StateTransition.AnimationSmoothness.FullscreenSearch.ClamshellMode: 66, 59, 73, 73, 66 Bug: 961467 Test: runs on nocturne Change-Id: I0246c63db1a327b55a1ee8f0540609613a9c0a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699211Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#677063}
-
Yuwei Huang authored
GTURN and Jingle-based ICE config fetching is not available in FTL world, so this CL removes them and does a few other cleanups. Bug: 983282 Change-Id: I2dba40fabfacd8a214d42c67f3f260267a4bca51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699521 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
-
Alex Cooper authored
This change implements the input related portions of the webxr-test-api and updates internal tests to use those methods/constants/inits. Most of the logic is ported from xr-internal-device-mocking.js and just converted from attributes to a pair of set/clear properties. No tests were actually using the getters, so those were just deleted. Because the webxr-test-api does not yet support gamepads, all of that logic was left in the internal mock. It also forces/fixes a potential bug where a device with no inputs may opt to set the "InputStates" value of the mojom to null rather than an empty array. (The device code typically sets this to an empty array) Rather than risk losing/confusing the diff to the updated tests, future work will move these tests to the external WPTs Bug: 979318 Change-Id: I846831a561217abd66ab841326a5e5472f38afeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699505Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#677061}
-
