- 05 Oct, 2017 40 commits
-
-
Yoshifumi Inoue authored
This patch introduces |FrameSelection::SelectWordAroundCaret()| to move code to "FrameSelection.cpp" from "WebLocalFrameImpl.cpp" as preparation of removing usage of |VisiblePositon| and |VisibleSelection| outside "editing/" for improving code health. Bug: 657237 Change-Id: I75c92513e4fc577bb6336553256fdd69a594277d Reviewed-on: https://chromium-review.googlesource.com/702214Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#506852}
-
kristipark authored
Bug: 772067 Change-Id: Ia18e7aaa8c22a3c401611bc9952d1ab9fa3e01d9 Reviewed-on: https://chromium-review.googlesource.com/703497 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#506851}
-
Will Harris authored
NULL -> nullptr TRUE -> true FALSE -> false Changes that were not purely mechanical: - Move a few functions to anonymous namespace. - Replace some unneeded typedef with declfunc. - CreateEvent returns nullptr for invalid handle not INVALID_HANDLE_VALUE. - CreateFile returns INVALID_HANDLE_VALUE not nullptr. - Add enum for is_broker in filesystem interception. Bug: Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Iff1beaf7bd7433a32ccb15d09298a3244c6700d1 Reviewed-on: https://chromium-review.googlesource.com/698375 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#506850}
-
Weidong Guo authored
Changes: 1. Handle arrow up/down in SearchResultTileItemListView, so that focus could traverse vertically. 2. Move focus to search box when it is moved outside SearchResultPageView during vertical focus traversal. Design Doc: go/applist-focus BUG=766810 TEST=AppListViewFocusTest.* Change-Id: Idcd54e7d7c4f2cd6fe425e80218310581c7bcaaa Reviewed-on: https://chromium-review.googlesource.com/701578 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506849}
-
Devlin Cronin authored
crrev.com/1f2b58d7 removed the old settings page code, but missed cleaning up the strings. Remove some that are no longer used. This covers: IDS_ABOUT_BUTTON -> IDS_CERT_MANAGER_CERT_PARSE_ERROR Bug: 771795 Change-Id: I8b1ad50dcfc2d45e346945a36b62eb6807dac4e1 Reviewed-on: https://chromium-review.googlesource.com/702921Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506848}
-
Danyao Wang authored
restore_session.html is a magic file included in the app bundle that helps WKBasedNavigationManager implement restore. The navigation manager serializes and encodes the session history in the query parameter, and loads restore_session.html to inject the history into the web view. Bug: 734150 Change-Id: Ideaa7239eb3239322e3e72c5599736962962b465 Reviewed-on: https://chromium-review.googlesource.com/698465Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#506847}
-
David Trainor authored
Add the following logs to help us have an idea of what the service behavior is: - Download.Service.Entry.Event - Logs event actions taken on an Entry like start, resume, retry, and suspend. - Download.Service.Entry.RetryCount - At the time of a retry, logs which retry attempt this is. - Download.Service.Entry.ResumptionCount - At the time of resumption, logs which resumption attempt this is. Bug: 769426 Change-Id: I11e5974521c6ba610d9d58940b4dae61ae8c1fbb Reviewed-on: https://chromium-review.googlesource.com/701835 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#506846}
-
Devlin Cronin authored
ExtensionService::extension_registrar_ is constructed at ExtensionService construction time, and is never reset. There's no reason to have it as a std::unique_ptr<> instead of a stack-allocated member variable. Make it the latter. Bug: 770879 Change-Id: I68001b9214b6176fc4703e3c6d2f1cbdcece9dff Reviewed-on: https://chromium-review.googlesource.com/701398Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506845}
-
Morten Stenshorne authored
We already did ignore borders and padding, but forgot about scrollbars. This was quite catastrophic for multicol, if a horizontal scrollbar was actually taller than the columns. We'd end up pushing the scrollbar in front of us (in block direction), column after column. Infinite loop (until OOM). Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5c3038406ccf30eeb0e107b31c6bb783c7089ffd Reviewed-on: https://chromium-review.googlesource.com/702299Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#506844}
-
Steven Holte authored
Bug: 754892 Change-Id: I3498e985e9382aa5149406fcad51a8314f42c43d Reviewed-on: https://chromium-review.googlesource.com/701257Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#506843}
-
Gregory Chatzinoff authored
The prior app store link does not work in iOS11, so use the new link instead. Bug: 771211, 761200 Change-Id: I5b3daff63f4e0f9f78ebe6721aa6497282339eee Reviewed-on: https://chromium-review.googlesource.com/702686 Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#506842}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/09fca0a3600a..400dbc4b2b00 $ git log 09fca0a36..400dbc4b2 --date=short --no-merges --format='%ad %ae %s' 2017-10-05 dtu [pinpoint] Set `updated` on Run(), not using `auto_now` Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic4eec5029d0ad354c0bd4967525973ddd9c36c5b Reviewed-on: https://chromium-review.googlesource.com/702761 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506841}
-
Ken Rockot authored
This reverts commit 12234368. Reason for revert: Looks like a source of these build failures: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM64%20Builder%20%28dbg%29/builds/69753 Original change's description: > Android: Turn on errorprone by default > > BUG=383646 > > Change-Id: Ia87d2dff787ffc5e4a59aca1af81a0ac9b727b4a > Reviewed-on: https://chromium-review.googlesource.com/702574 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506831} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: Ie933459d048c090df574bf45b6e2b644de3e66e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 383646 Reviewed-on: https://chromium-review.googlesource.com/703395Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#506840}
-
Jian Li authored
We used to disable all form control elements when saving a page as MHTML since the form in the MHTML document cannot be worked on due to form submission and script execution disabled. As suggested by Jeffrey Yasskin, we switched to disable form control elements in the loaded MHTML document. Bug: 771786 Change-Id: I44b9c324192be052dd47db3d126a911ab5dd34e3 Reviewed-on: https://chromium-review.googlesource.com/701368 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#506839}
-
MinChen authored
Bug: 763240 Change-Id: Ibe0ce1f0d44dd947154d231769b53d0eda35dc09 Reviewed-on: https://chromium-review.googlesource.com/702722Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#506838}
-
Daniel Bratell authored
"using namespace" in a global scope breaks jumbo builds (and are not allowed in the code style guide). This patch replaces them with explicit namespaces. Bug: 771153 Change-Id: If9c4de9e115c5531708cf06f64cb0088daca2d57 Reviewed-on: https://chromium-review.googlesource.com/697370Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Devlin Cronin authored
chrome_user_metrics_extension.proto imports extension_install.proto, but doesn't need to. This was introduced in https://crrev.com/e94d484908fa0f9472c580e7fb9c4ec9c9c1bf78. Remove the unneeded import. Bug: None Change-Id: I6cb3490cbb3ba6da31420588994664dd123823fc Reviewed-on: https://chromium-review.googlesource.com/699058Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506836}
-
James Cook authored
We have not shipped Windows Ash for years. There is a 1:1 mapping between use_ash and is_chromeos, so consolidate them. Bug: 673826 Test: compiles, gn check for Chrome OS, Linux, Linux Ozone Change-Id: Idc459cbca6b8447ce0f7e7aa9772e38835492234 Reviewed-on: https://chromium-review.googlesource.com/702756Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#506835}
-
Ehsan Chiniforooshan authored
It is flaky. Error: [FATAL:profile_destroyer.cc(56)] Check failed: hosts.empty() || profile->IsOffTheRecord() || content::RenderProcessHost::run_renderer_in_process(). Profile still has 1 hosts 0x7f035e2968ec base::debug::StackTrace::StackTrace() 0x7f035e2bc41c logging::LogMessage::~LogMessage() 0x0000025be6d8 ProfileDestroyer::DestroyProfileWhenAppropriate() 0x0000023da2a0 std::__1::__tree<>::destroy() 0x0000023da1e9 ProfileManager::~ProfileManager() 0x0000023d1ace ProfileManager::~ProfileManager() 0x000002559112 BrowserProcessImpl::StartTearDown() 0x0000022ad6f2 ChromeBrowserMainParts::PostMainMessageLoopRun() 0x000001e0a813 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() 0x7f035a63837a content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ... Bug=772072 Bug: Change-Id: I91391979088148a9857728f5c7b30d397b8335f2 Reviewed-on: https://chromium-review.googlesource.com/703034Reviewed-by:
-
Adithya Srinivasan authored
ScriptWrappableVisitor knows when wrapper tracing is in progress, so when an isolate is provided we can look it up from the visitor directly without trying to access the current ThreadState. Bug: Change-Id: I79ab86ee7ff3774748ba9295b2604de53eaf8db4 Reviewed-on: https://chromium-review.googlesource.com/699067 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506833}
-
Xianzhu Wang authored
The switch enables blink feature SlimmingPaintV175 which is an intermediate step between SlimmingPaintV1 and V2. The command line switch is a short form of --enable-blink-features=SlimmingPaintV175, which will ease flag specific layout test expectations and field trials. Bug: 771643 Change-Id: Iedb050d43380a8a1ab548a649d7f526a8f302066 Reviewed-on: https://chromium-review.googlesource.com/698370 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506832}
-
Peter Wen authored
BUG=383646 Change-Id: Ia87d2dff787ffc5e4a59aca1af81a0ac9b727b4a Reviewed-on: https://chromium-review.googlesource.com/702574Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506831}
-
Ken Rockot authored
The original correct baseline got lost in the shuffle of a series of colliding reverts. This restores the file to its state prior to the (now reverted) r506693. TBR=drott@chromium.org TBR=eae@chromium.org Bug: 707713 Change-Id: I0f15bc1c4b01ad5972d30e86f3d47b13183fffaa Reviewed-on: https://chromium-review.googlesource.com/703354Reviewed-by:
-
Hidehiko Abe authored
BUG=739622 TEST=Build. Change-Id: I196aea8c5d66c020a22c6eceb899783da3b2cd3a Reviewed-on: https://chromium-review.googlesource.com/697047 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
-
Sean O'Brien authored
Extends the wl_pointer protocol using the wayland upstream zwp_pointer_gestures protocol to pass information about pinch gestures. BUG=b:25668308 Change-Id: I9f90ebebec3f8476181e0426401827a3cf1064e4 Reviewed-on: https://chromium-review.googlesource.com/699017 Commit-Queue: Sean O'Brien <seobrien@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506828}
-
Victor Costan authored
This reverts commit 9f9f66ee. Reason for revert: Broke Windows build - https://build.chromium.org/p/chromium/builders/Win/builds/59636 Original change's description: > Roll src/third_party/leveldatabase/src/ 09a3c8e74..4a7e7f50d (11 commits) > > This CL also #defines DeleteFile as DeleteFileW on Windows for all > compilation units that depend on leveldb. This definition impacts > leveldb's API (leveldb::Env::DeleteFile), and is in effect in most of > Chromium, because it is introduced by <windows.h>. After this CL, the > definition is guaranteed to be in effect everywhere, so we don't have to > reason about #include side-effects. > > https://chromium.googlesource.com/external/leveldb.git/+log/09a3c8e74175..4a7e7f50dcf6 > > $ git log 09a3c8e74..4a7e7f50d --date=short --no-merges --format='%ad %ae %s' > 2017-10-04 cmumford Add LEVELDB_EXPORT macro to export public symbols. > 2017-10-04 costan leveldb: Include <algorithm> in util/env_test.cc. > 2017-10-03 costan Fix FD leak in POSIX Env. > 2017-10-03 costan leveldb: Add tests for CL 170769101. > 2017-10-03 costan Remove handling for unused LRUHandle representation special case. > 2017-10-02 sanjay Fix file writing bug in CL 170738066. > 2017-10-02 cmumford Fix use of uninitialized value in LRUHandle. > 2017-10-02 sanjay Fix issue 474: a race between the f*_unlocked() STDIO calls in env_posix.cc and concurrent application calls to fflush(NULL). > 2017-09-26 costan Use portable CRC32C from google/crc32c. > 2017-09-01 costan Remove confusing and unnecessary if. > 2017-09-01 costan Simplify Table::Open() flow and remove a delete call. > > > Created with: > roll-dep src/third_party/leveldatabase/src > > Bug: > Change-Id: I0096e6b863616d14c20994d6cb9696ebc263f138 > Reviewed-on: https://chromium-review.googlesource.com/699018 > Reviewed-by: Chris Mumford <cmumford@chromium.org> > Commit-Queue: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506815} TBR=cmumford@chromium.org,pwnall@chromium.org Change-Id: Ifb074413f4f02289cee7c2535fde1ed516da9ad6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/703316Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#506827}
-
Lei Zhang authored
ResourceBundle became ui::ResourceBundle in r72038 but many callers still refer to it without the namespace. Change-Id: I920e21319041cd0e2a2fa671db709a9d8483fb2e Reviewed-on: https://chromium-review.googlesource.com/701662Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#506826}
-
Dmitry Skiba authored
This is a follow-up to crrev.com/c/667936 which moved MAIN/LAUNCHER handling into separate .LauncherMain activity alias. That CL caused existing Chrome app shortcuts to disappear on update. Turned out that Android launcher creates {MAIN/LAUNCHER, <component>} intents for app shortcuts (i.e. it bakes in the component), and then checks that after each update MAIN/LAUNCHER intent for the app resolves to the shortcut's component. If that check fails, launcher removes the shortcut. This means that MAIN/LAUNCHER intents must continue to be handled by .Main activity alias. This CL does two renamings: 1. Renames .Main activity alias to .IntentDispatcher alias 2. Renames .LauncherMain alias to .Main I.e. MAIN/LAUNCHER intents are now handled by .Main alias, making sure shortcuts won't be removed. Additionally this CL moves more MAIN categories from .IntentDispatcher into .Main alias, so that almost all MAIN intents are handled by .Main (one exception is NOTIFICATION_PREFERENCES, as it needs dispatching). Bug: 761606 Change-Id: I6cb926c4677758190f743260e11a85129c8863bb Reviewed-on: https://chromium-review.googlesource.com/700803 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506825}
-
Jamie Madill authored
Explicitly specifying the GPU driver version in the config will allow us to safely test new driver versions. Because the tests will pick machines of a particular driver version specified in the json, we can ask infra to upgrade a few machines, then run a try job using the new driver version. This modifies the generate script to allow use of wildcards in test dimension set specifiers. Wildcards are only supported as the last character in the dimension. This allows us to more easily match ranges of driver versions. Re-land fixes the driver version for Windows 10 bots. The current NVIDIA driver version used by the bots is 372.54 for the Windows 7 bots and 376.19 for Windows 10. R=kbr@chromium.org BUG=771654 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie06cedefa0e4c4afc598ab7148d192c3f60eca34 Reviewed-on: https://chromium-review.googlesource.com/702855Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#506824}
-
Irmak Kavasoglu authored
Other possible passwords variable of the password form is currently holding all possible passwords. See this cl: https://chromium-review.googlesource.com/c/chromium/src/+/660077 This cl renames the variable accordingly. Bug: 753806 Change-Id: Id6e19b876392039704d1f23a8b42d1ca18e79ea6 Reviewed-on: https://chromium-review.googlesource.com/693014 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#506823}
-
Elly Fong-Jones authored
This change: 1) Moves the MD folder icon into //components 2) Makes the Views TreeView use it in Harmony mode Note that there is no separate "open folder" icon in MD, so the open and close icons are identical. This change was previously reviewed as <https://chromium-review.googlesource.com/c/chromium/src/+/663405>. Bug: 610428 Change-Id: Ife816d911bef2a92497bb687c5aa59345359aa74 Reviewed-on: https://chromium-review.googlesource.com/692817 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#506822}
-
John Budorick authored
This includes: - ensuring that symlinks that CIPD creates for files currently managed by update_third_party_deps.py get removed by that script. - changing switching to copy_ex in process_java_prebuilt s.t. symlinks are correctly handled by that template. Bug: 755920 Change-Id: I1a75ae3acd96ce827401d8d58f8f1127ad09eadb Reviewed-on: https://chromium-review.googlesource.com/701495Reviewed-by:
-
Paul Miller authored
BUG=771783 Change-Id: Iba58f2ebf19d3deb04cda8e6a4d73c7bfbab1efe Reviewed-on: https://chromium-review.googlesource.com/701371Reviewed-by:
-
Scott Violet authored
The flow is: 1. browser requests WindowTreeClient from the RenderWidget of the frame to embed. 2. browser send a message to the parent RenderFrameProxy with the WindowTreeClient. 3. RenderFrameProxy forwards to RendererWindowTreeClient to create the child window and embed the WindowTreeClient in it. BUG=758387 TEST=none Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I0296e802c0f754e463c65492f38ec5a68df30eba Reviewed-on: https://chromium-review.googlesource.com/673066Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506819}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/38d0449a02f4..4ce4f5f8ab0b $ git log 38d0449a0..4ce4f5f8a --date=short --no-merges --format='%ad %ae %s' 2017-10-05 dsinclair Cleanup CPDF_RenderStatus 2017-10-04 dsinclair Remove CPDF_Object friends 2017-10-05 dsinclair Remove friends from CXML_Element 2017-10-04 dsinclair Remove CPDF_CMapParser friends Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I2981fe77ca795854246e66ba3a2d1f34063a4de6 Reviewed-on: https://chromium-review.googlesource.com/702639 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506818}
-
lgcheng authored
We enable Arc package sync datatype when user enables Arc, and call StartModels when Arc app instance is ready and Arc packages get refreshed. But There is a big time gap since we need perform provision for Arc during opt-in. And this may lead to the high config time-out rate for Arc packages. Enable the datatype when provision is successful and reduce the gap between enabling the sync data type and calling startModels. Bug: 771838 Test: Manual test and Arc pacakge related integration test. Change-Id: I4c70c9d7e3c690fc953dac981398424d166ce51f Reviewed-on: https://chromium-review.googlesource.com/702014Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
-
Lei Tian authored
Increase the maximum limit of CCT bottom bar height to display larger view. Bug: None Change-Id: I0b0a8831cbd39f299e0dafd8e0eb314e8fe9b398 Reviewed-on: https://chromium-review.googlesource.com/702687Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Lei Tian <ltian@google.com> Cr-Commit-Position: refs/heads/master@{#506816}
-
Victor Costan authored
This CL also #defines DeleteFile as DeleteFileW on Windows for all compilation units that depend on leveldb. This definition impacts leveldb's API (leveldb::Env::DeleteFile), and is in effect in most of Chromium, because it is introduced by <windows.h>. After this CL, the definition is guaranteed to be in effect everywhere, so we don't have to reason about #include side-effects. https://chromium.googlesource.com/external/leveldb.git/+log/09a3c8e74175..4a7e7f50dcf6 $ git log 09a3c8e74..4a7e7f50d --date=short --no-merges --format='%ad %ae %s' 2017-10-04 cmumford Add LEVELDB_EXPORT macro to export public symbols. 2017-10-04 costan leveldb: Include <algorithm> in util/env_test.cc. 2017-10-03 costan Fix FD leak in POSIX Env. 2017-10-03 costan leveldb: Add tests for CL 170769101. 2017-10-03 costan Remove handling for unused LRUHandle representation special case. 2017-10-02 sanjay Fix file writing bug in CL 170738066. 2017-10-02 cmumford Fix use of uninitialized value in LRUHandle. 2017-10-02 sanjay Fix issue 474: a race between the f*_unlocked() STDIO calls in env_posix.cc and concurrent application calls to fflush(NULL). 2017-09-26 costan Use portable CRC32C from google/crc32c. 2017-09-01 costan Remove confusing and unnecessary if. 2017-09-01 costan Simplify Table::Open() flow and remove a delete call. Created with: roll-dep src/third_party/leveldatabase/src Bug: Change-Id: I0096e6b863616d14c20994d6cb9696ebc263f138 Reviewed-on: https://chromium-review.googlesource.com/699018Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#506815}
-
Aleks Totic authored
Bug: 612962 Change-Id: Idd15d1639defb4bd3cf56795b57b9f3a4f55379d Reviewed-on: https://chromium-review.googlesource.com/702676Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#506814}
-
Tom Sepez authored
Simplify moving sandbox_mac.mm itself out of content/, as it no longer includes content headers. Change-Id: I68e746fb4c003e6a4bc60ee44057b8d1ba0554d1 Reviewed-on: https://chromium-review.googlesource.com/701359Reviewed-by:
-
