- 24 Oct, 2019 15 commits
-
-
Ken Rockot authored
Instead of going through Service Manager to get a Data Decoder instance, this changes the Explore Sites feature to maintain its own lazily spawned Data Decoder instance using the public Content API. This should effectively mirror the old behavior, including the 5-second timeout of the instance used. Bug: 977637 Change-Id: Ic76a472dabffbbce339cde6c3fab21d1f8b9a195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872418 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708857}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4ff1c872045c..c1a8abc0a3e7 git log 4ff1c872045c..c1a8abc0a3e7 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b5030084..510c0ca3 (708640:708742) Created with: gclient setdep -r src/third_party/webrtc@c1a8abc0a3e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I800c9f3a2f0262bf6ef2220a5b6342fc3a95369e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877388Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708856}
-
Andrii Shyshkalov authored
Picks up hopeful workarounds for failure to remove virtual env: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1876802 https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1876638 R=bpastene Bug: 869227 Change-Id: I9d46bb7579e747819d7d82cd3ad06968dd28e7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876471Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#708855}
-
Peter Kasting authored
A whole bunch of miscellaneous small changes. Bug: 1015717 Change-Id: Ia769176e993e46e0adba7993378a575445df7a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874705Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#708854}
-
Xiaoqian Dai authored
Previously with hotseat feature enabled, the MRU window can only be dragged if hotseat is swiped up to show above the shelf first. However, we want the MRU window to be able to be dragged directly from shelf, no matter the hotseat is hidden below the shelf or shown above the shelf. Besides, the MRU window should dragged up along with the hotseat, that means, the window dragging should be part of shelf dragging logic (i.e., DragStatus::kDragInProgress), not part of home launcher dragging logic (i.e., DragStatus::kDragAppListInProgress). So in this CL, move the window dragging logic to shelf dragging. I'll remove the corresponding wiring code in HomeLauncherGestureHandler and migrate the tests in a following CL. Bug: 997885 Change-Id: Idd333286c1fac27f53899104f43ef2956ff20b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876746 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708853}
-
siashah authored
Currently, when the user clicks on the done button on the keyboard with an empty text box, we attempt to save the card on payments backend. With this change, we will perform no action if the name field is not filled. Bug: 1016877 Change-Id: I399e2a46925d9092f28f01703846a4481da86e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873721Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#708852}
-
Garrett Beaty authored
Split up the lint-luci-milo and generate_buildbot_json checks into separate conditions, update the path to luci-milo.cfg to be in the generated subdirectory and trigger the generate_buildbot_json check on changes to luci-milo-dev.cfg. Change-Id: Ideb1ab426619fb39d1ffe1da4ea8b60ecca4d949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877590 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#708851}
-
Robbie McElrath authored
See the design linked in the bug for descriptions of these metrics. This CL also changes the test logic to wait for more of VariationsSeedLoader to finish before checking results. Bug: 1010625 Change-Id: Id77d7b16f4bb3e0ac02e134f0d5ebee4917eeaf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841240Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#708850}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/720447713e24..e8378a666b73 git log 720447713e24..e8378a666b73 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org loas: use encoding=utf-8 for commands 2019-10-23 vapier@chromium.org paygen: replace gspaths._RandomString with cros_build_lib.GetRandomString 2019-10-23 kimjae@chromium.org osutils: CopyDirContent needs to copy symlinks like copytree symlinks 2019-10-23 saklein@chromium.org gen_call_scripts: Add board option. Created with: gclient setdep -r src/third_party/chromite@e8378a666b73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7501664600a8e145ba3cb1fcfdbf4335fc71c431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875659Reviewed-by:
-
Xinghui Lu authored
When performing the full URL lookup, strip out the fragment, username and password components. Fragments are only used for local navigations. Usernames/Passwords are too privacy sensitive. Bug: 1015469 Change-Id: Ib3885a0acc7c479087cb9e5fe55696cd4745b7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872753 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708848}
-
Livvie Lin authored
Renames omnibox_https_invalid.png since the triangle icon will be used for HTTP pages as well as part of crbug.com/1008219. Bug: 1008219 Change-Id: Idca6aec6f38fa393accb64858d87c8c62b8f4543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873958 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708847}
-
Albert Chaulk authored
Cast javascript channels add a window.<foo>.postMessage(message) method to selected RenderFrame instances to allow renderers to push data to the embedder. The usage looks like this: Browser: add interface during init Renderer: bind JsChannelBindingProvider, call Register, provide JsChannelClient Browser: stick the pid/route/channel in a list Embedder: AddJavascriptChannels Browser: lookup current RenderFrame and corresponding channel, call JsChannelClient::CreateChannel, provide JsChannel Renderer: create JS bindings <script>: call function Renderer: JsChannel::PostMessage Browser: send message to embedder Bug: b/141864193 Test: desktop cast_shell build + custom html Change-Id: I1425cb115f679b876a8b9cb75c418b9d2a7a1506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863073Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#708846}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9fb9a722fb28..e8843ab060ac git log 9fb9a722fb28..e8843ab060ac --date=short --no-merges --format='%ad %ae %s' 2019-10-23 treehugger-gerrit@google.com Merge "Remove the call to std::partition, and replace with a readable for loop." Created with: gclient setdep -r src/third_party/perfetto@e8843ab060ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib719ae291a42ec8619516d8b6f141ab37c1c7a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876882Reviewed-by:
-
Peter Kasting authored
* Convert the central loop of CalculateAndDoLayout() to two nested loops. The outer loop iterates once per line, the inner once per view. This allows unifying all existing calls to AdvanceOneLine() to a single one in the outer loop. * At this point AdvanceOneLine() can be inlined and simplified. Bug: 1015717 Change-Id: Iecd4832a7b8eafccd69b50a7951628fded1336f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874825 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
This help ensuring that an old version of chrome_child.dll won't be accidently packaged in the installer. This code should be removed once we drop support for the multi DLL build. Tested manually on a local build. Bug: 1017245, 726150 Change-Id: I49c3885f937d6b034d94340e23cd83341fc3bd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876232 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#708843}
-
- 23 Oct, 2019 25 commits
-
-
Caleb Raitto authored
Change-Id: I23fbfa6a19299275501370180f3ea07136d33902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876552 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#708842}
-
Ionel Popescu authored
This CL updates the UI for datetime-local popup by integrating the new time picker in the popup. Tests are added to validate the new UI and the value submission. Bug: 1016992 Change-Id: Ic2ba800248aa863d9dbf5867e0722f6059da1089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874822Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708841}
-
Darren Shen authored
It seems that RenderWidgetHostViewAura::SetCompositionFromExistingText fails to respect the active widget of the TextInputManager, and since different widgets can have completely separate FrameTrees, getting the correct focused frame relies on routing to the active widget. Bug: 971985, 1013515 Change-Id: If4c4f4e776423bbcb9d3c99dccb5b43e2abfc012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858545 Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#708840}
-
Sebastien Marchand authored
Reason for removing: It's been a while (3 years), this isn't needed anymore. Change-Id: I2e289ebb6fb5e8f3c6786fbfa22697357617b0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875550 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Scott Violet authored
This is a reland. The original path at https://chromium-review.googlesource.com/c/chromium/src/+/1872566 included deleting third_party/blink/web_tests/platform/mac-mac10.10/paint/invalidation/overflow/float-overflow-right-expected.txt That was wrong (not sure why the rebaseline tool did that). Two special cases that carry over from the old code: . LayoutDeprecatedFlexibleBox always started layout at an origin of 0, even when rtl. This gives the same behavior. . When rtl end is treated as start. BUG=1014884 TEST=fast/deprecated-flexbox/017.html Change-Id: Ifdd1dd8581844a1365dfceed5fd316dff7a78fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876073Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#708838}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/376ccc06cd30..9988f9da4047 git log 376ccc06cd30..9988f9da4047 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 jbudorick@chromium.org devil: add support for adb push --sync behind a flag. (RELAND) Created with: gclient setdep -r src/third_party/catapult@9988f9da4047 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:922145,chromium:1015280 Change-Id: I4ff8ed52f2fe5e275d2d51138d50433211f63aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876881Reviewed-by:
-
Clark DuVall authored
Since this superclass is mostly concerned with handling intents, the best name I could come up with is IntentWindowAndroid. Bug: 1017274 Change-Id: Iaadba0d7adbea13dc11bbaf88af1029d7dc4ebbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876729 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708836}
-
James Vecore authored
Added a top level property/attribute to bluetooth_device_list_item for an explicit aria-label and put aria-hidden on the div text to avoid repeating. Bug: 1007100 Change-Id: Ie2b910c3b1652c1929f8c223fc68d94a66ac2d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876910Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#708835}
-
Peter Kasting authored
Indents the main loop in CalculateAndDoLayout() inside another block. That's it. No functional change, just a trivial one. The entire purpose of this CL is to make the next CL's diff actually readable, since otherwise it looks like garbage. TBR=tapted Bug: 1015717 Change-Id: Ieda8fc854c3641bc70e4dd9cff0ae85755451cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874849Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Dale Curtis authored
We're not having any luck debugging these failures locally, so enable VLOG(1) and DVLOG(1) for a few tests to help debug on macOS. BUG=1003761,1014646 R=tmathmeyer Change-Id: Ie14b4c5be287eabb526a91fa6acfa8dcacc97940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876315 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708833}
-
Robert Liao authored
This fixes a build error due to use of std::wstring. BUG= TBR=brucedawson@chromium.org Change-Id: Ibb7c6f3eb856457d5b787976b826ac675117973f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877451Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#708832}
-
Saman Sami authored
Bug: 620927 Change-Id: I3870dd2e6cad2278036dfd484e9410f0bb197572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865653Reviewed-by:
-
Oystein Eftevaag authored
R=ssid@chromium.org BUG=1017462 Change-Id: I22e281df59c29436ac092b9d4c959d9856a6b201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876978 Auto-Submit: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#708830}
-
rbpotter authored
Correctly detect HTML _templates in Polymer 3 files that have been minified (so "_template: html`<div></div>`," becomes "_template:html`<div></div>`,"). This is necessary to correctly replace i18n template expressions for optimized Web UIs using Polymer 3. Bug: 965770 Change-Id: I41112d5fa437964fa079ee5cfa41115324fa2579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877251Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#708829}
-
Jae Hoon Kim authored
For users of DlcserviceClient, the possibliy to observe the download/install of a DLC is added. Bug: b:143098235 Test: autoninja -C out/Default chromeos_unittests && ./out/Default/chromeos_unittests Change-Id: I846f05664e1ff90626ac79af4dcc4e3dbfd7ce23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874815 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
-
Ian Clelland authored
Pushed the expiry out approximately 1 year. Bug: 988768 Change-Id: Iff0f962886eb10678256c481fe9e96327668f989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872464 Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cba64462d266..fbaef603dece git log cba64462d266..fbaef603dece --date=short --no-merges --format='%ad %ae %s' 2019-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-23 fmalita@chromium.org Color filter benchmarks 2019-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-23 csmartdalton@google.com Disable msaa on Pixel3a 2019-10-23 halcanary@google.com [minor] SkRemoteGlyphCache impl: add explicit 2019-10-23 jvanverth@google.com Set Metal rendertargetproxy via drawableSize 2019-10-23 senorblanco@chromium.org Dawn: implement unified UBOs. 2019-10-23 michaelludwig@google.com Revert "hide color filters from blitters" Created with: gclient setdep -r src/third_party/skia@fbaef603dece If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: chromium:b/143074513 Change-Id: I0cd4b61e1b8471e2ccd0a7f638d8e2e8167fb770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877134Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9709599c10ff..e7bf2eba2b5d Created with: gclient setdep -r src-internal@e7bf2eba2b5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:1010713,chromium:b/141127636 Change-Id: If71b02cb4fffa4abec924bd38d245fe818b61051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876919Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708825}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1ae481f7fe3..ea98ebbe654a git log b1ae481f7fe3..ea98ebbe654a --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org chromite_wrapper: modernize a bit 2019-10-23 gbeaty@chromium.org Avoid accessing the None json output on gclient sync failure. Created with: gclient setdep -r src/third_party/depot_tools@ea98ebbe654a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:997354 Change-Id: Ief28ec1a4d00bff25e164ab6927faaa498530fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877133Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d7bf5c56b69b..4ff1c872045c git log d7bf5c56b69b..4ff1c872045c --date=short --no-merges --format='%ad %ae %s' 2019-10-23 mbonadei@webrtc.org Fix RTC_LOCKABLE RTC_EXPORT order for rtc::Thread. Created with: gclient setdep -r src/third_party/webrtc@4ff1c872045c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I96e855ead75938be93abf29ada262e9d4528a471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877132Reviewed-by:
-
David Tseng authored
This is the on-going process to finish up the fork of ChromeVox Classic. Adding a build file will allow us to: - compress the ChromeVox Classic source* - remove deps.js which is a maintenance burden * - share string resources * - migrate all tests only for ChromeVox Classic to ui/accessibility/extensions - delete all Classic only js, assets from mainline ChromeVox * denotes things that happened in this change. Change-Id: I317be0ff2107eeb1f688da8690c38d191a55310b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874256 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#708822}
-
Garrett Beaty authored
This reverts commit f26b6b6d. Reason for revert: Causes presubmit failure due to generate_buildbot_json attempting to read deleted luci-milo-dev.cfg. Original change's description: > Migrate luci-milo-dev.cfg to starlark. > > Bug: 1011908 > Change-Id: Ic7f4fc26d75811f04c9f988866bb479a40e0d0c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869713 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708714} TBR=agable@chromium.org,gbeaty@chromium.org Change-Id: I16fd97a3ccef990cd0d2bc58314f6006a3328f82 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875660Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#708821}
-
Matt Mueller authored
Bug: 635205 Change-Id: I5b5e69ed79d017fcd36110c7ad73d08f8f6adea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876739Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#708820}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17e452a6..f3b63d6f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa9488a1705f6d50070ee7969c2f4942fcf88d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877087Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708819}
-
Jamie Walch authored
We register a handler for Ctrl+Alt+Esc for remote assistance to give a keyboard shortcut for the local user to use if they need to disconnect the remote user in a hurry. Unfortunately, on Catalina this means that the user needs to whitelist the process for "monitor keyboard activity from all process" permission, which is more than we need and quite an alarming thing to ask our users to approve. Since this shortcut is not advertised anywhere, it seems more prudent to remove it, on Mac only for now, but potentially on all platforms in the future. Fixed: 1015242 Change-Id: I72ae4c214eb7d6fcec77bafff91495b07b7b91c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876206 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#708818}
-
