GitLab

Review URL: https://codereview.chromium.org/306893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274169 0039d316-1c4b-4281-b951-d872f2087c98

Prior to this change, the browser compositor allocated
buffers on the UI thread while the buffer allocation for
renderers was done on the IO thread.

This moves all allocation to the UI thread, which makes life
easier for GpuMemoryBuffer implementations and avoids
potentially expensive allocation costs on the IO thread.

BUG=

Review URL: https://codereview.chromium.org/302443008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274168 0039d316-1c4b-4281-b951-d872f2087c98

ShellTestHelper doesn't need to spawn a thread. Nuking the thread
simplifies the view manager tests.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/308053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274167 0039d316-1c4b-4281-b951-d872f2087c98

GetOrDownloadAttachments creates state object that tracks set of attachments
for which requests are still pending. Once AttachmentStore::Read finishes 
AttachmentServiceImpl calls AttachmentDownloader to download attachments that 
were not found locally. 

Once all calls to Downloader finish consumer callback is called with results.

I used AttachmentIdSet in this code but didn't update AttachmentIdList to 
AttachmentIdSet in other places. I'd rather do it in separate change.

R=maniscalco@chromium.org
BUG=376073

Review URL: https://codereview.chromium.org/307783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274164 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes a crash in the StartPageView that was happening because
an observer was not being cleaned up on destruction.

This CL also adds a profile change unit test which serves as a
regression test for this issue.

BUG=378572
TEST=Have experimental app list enabled and switch between signed in profiles repeatedly. There should be no crash.

Review URL: https://codereview.chromium.org/305123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274162 0039d316-1c4b-4281-b951-d872f2087c98

Added UMA constant for counting IDC_SPELLCHECK_SUGGESTION_*.

TBR=asvitkine
BUG=378933

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273817

Review URL: https://codereview.chromium.org/306103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274161 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/301193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274160 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274154 0039d316-1c4b-4281-b951-d872f2087c98

This allows other tests in the same suite to call SetPolicyProviderForTesting.

TBR=pastarmovj@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/303393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274148 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370433
TEST=None
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/307203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274147 0039d316-1c4b-4281-b951-d872f2087c98

> Record RenderViewContextMenu.Used histogram before calling observers.
> 
> BUG=378933
> 
> Review URL: https://codereview.chromium.org/306103002

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/301233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274146 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371530
NOTRY=true
TBR=sievers

Review URL: https://codereview.chromium.org/310603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/292443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274144 0039d316-1c4b-4281-b951-d872f2087c98

- switches::kGoogleBaseURL is moved into the Google component

- The information of whether background networking is enabled is now obtained
  from GoogleURLTrackerClient.

BUG=373222
TBR=thakis

Review URL: https://codereview.chromium.org/301383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274143 0039d316-1c4b-4281-b951-d872f2087c98

This helper method can be used to determine if a policy comes from the
profile cloud policy provider or from another source. It will be used
to determine the source of the Managed Bookmarks policy and set the
folder name accordingly.

BUG=49598

Review URL: https://codereview.chromium.org/304183007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274142 0039d316-1c4b-4281-b951-d872f2087c98

TBR=marja@chromium.org
BUG=379579

Review URL: https://codereview.chromium.org/307213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274141 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379574

Review URL: https://codereview.chromium.org/306053009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274140 0039d316-1c4b-4281-b951-d872f2087c98

It seems to be much more common to have this kind of resources file as a
normal GYP file rather than an *include* GYP file.

$ git ls-files | grep resources.gyp$ | grep -v ash_resources | wc -l
9

vs

$ git ls-files | grep resources.gypi$ | grep -v ash_resources | wc -l
3

BUG=None
TEST=None
R=jamescook@chromium.org
NOTRY=true
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/307993007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274130 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379570

Review URL: https://codereview.chromium.org/308253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379564
NOTRY=True
TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/312473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274127 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366797
TEST=None

Review URL: https://codereview.chromium.org/303233009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274126 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379561
TBR=dtu@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/309623006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274125 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes a couple more changes to accomodate for the implementation
of this policy:

- moved the kManagedBookmarks pref into the bookmarks component, so that
it can be referred to from there;

- moved the strings for the managed bookmarks folder name for the same
reasons;

- updated the policy schema to support child bookmarks;

- updated the ManagedBookmarksPolicyHandler to use the schema validation
code, and added a new unit test for that.

TBR=nyquist@chromium.org
BUG=49598

Review URL: https://codereview.chromium.org/307993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274124 0039d316-1c4b-4281-b951-d872f2087c98

The gyp file has this in OTHER_LDFLAGS.

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/308003010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274123 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274117 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274115 0039d316-1c4b-4281-b951-d872f2087c98

control (whitespace CL) is at https://codereview.chromium.org/305183005

BUG=skia:2610
NOTRY=True

Review URL: https://codereview.chromium.org/309503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274114 0039d316-1c4b-4281-b951-d872f2087c98

When this flag is given, the new surfaces system will be used to display the browser contents.

BUG=

Review URL: https://codereview.chromium.org/307693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377408
R=jar@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/303253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274112 0039d316-1c4b-4281-b951-d872f2087c98

With this CL, the encoded handles will comply with the restriction that
"If handle X is prior to handle Y in the depth-first traversal order and both of
them are valid, then the value of X should be smaller than that of Y."

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/303163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274111 0039d316-1c4b-4281-b951-d872f2087c98

With this the ui/gl target compiles on mac and fails to link with some skia
thingy.

R=brettw@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/303273009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274110 0039d316-1c4b-4281-b951-d872f2087c98

These need to balance out the calls to LoginState::Initialize().

BUG=chromium:379140
TEST=unit tests pass
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/310493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274109 0039d316-1c4b-4281-b951-d872f2087c98

This hasn't been used since we removed the old SRPC-based PPAPI proxy.

BUG=none
TEST=trybots

Review URL: https://codereview.chromium.org/310473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274108 0039d316-1c4b-4281-b951-d872f2087c98

Referring to https://code.google.com/p/chromium/issues/detail?id=379470,
This is causing significant stability on trunk.  reverting.

> Refactor external_install_ui
> 
> Refactors ExternalInstallUI to have determinate lifetimes.
> This is likely the first of multiple patches targeting this area of code; the
> next one will concentrate on pulling the related logic out of ExtensionService.
> 
> BUG=378042
> 
> Review URL: https://codereview.chromium.org/300853008

TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/309483012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274103 0039d316-1c4b-4281-b951-d872f2087c98

Referring to https://code.google.com/p/chromium/issues/detail?id=379472,
This is causing significant stability on trunk.  Reverting.

> Block content scripts from executing until user grants permission
> 
> Prevent extensions with <all_urls> from running content scripts without user
> consent if the scripts-require-action switch is on.
> 
> BUG=362353
> 
> Review URL: https://codereview.chromium.org/288053002

TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/307933008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274102 0039d316-1c4b-4281-b951-d872f2087c98

Referring to https://code.google.com/p/chromium/issues/detail?id=379469
this is causing significant stability on trunk.

> Defer SpdySession destruction to support closing writes
> 
> Replace the STATE_CLOSED availability state with STATE_DRAINING, where:
>  * The read-pump will not run, and no frames can be read.
>  * No new frames may be queued in the sessions's write_queue.
>  * However, the write-pump will continue to run.
> 
> SpdySession's write-pump will destroy the session iff it's draining, the
> write queue is empty and no in-flight writes remain. As this (and
> ~SpdySessionPool()) are now the only locations where SpdySessions may be
> destroyed, session lifetime is more know-able and some WeakPtrs are
> removed.
> 
> Some tests have been updated to include closing RST_STREAMS sent by the
> session. This reflects current behavior. A future CL will add GOAWAY
> frames upon session errors.
> 
> BUG=375033
> 
> Review URL: https://codereview.chromium.org/305823003

TBR=jgraettinger@chromium.org

Review URL: https://codereview.chromium.org/310563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371530
NOTRY=true
TBR=sievers

Review URL: https://codereview.chromium.org/302063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274091 0039d316-1c4b-4281-b951-d872f2087c98

 * Fix a regression so that once again the time range selector combo-box is in focus initially.
 * Clean up the code that determines which controls should be enabled/disabled/hidden on the dialog.
 * Reduce the number of controls that flicker (i.e. change state from disabled->enabled visibly) on opening the dialog in the most likely use-case, i.e., instead of starting with everything disabled, only have the commit button initially disabled.
 * Fix a regression so that once again some checkboxes can be disabled by policies. (I think this was also broken.)

BUG=365206

Review URL: https://codereview.chromium.org/275483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274090 0039d316-1c4b-4281-b951-d872f2087c98

Because we already do necessary checks during the validation stage.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/293983026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274089 0039d316-1c4b-4281-b951-d872f2087c98

> Revert of Properly prioritize the sources of an accessible name on Android. (https://codereview.chromium.org/303113003/)
> 
> Reason for revert:
> Broke android bots it looks like:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/20683
> 
> Original issue's description:
> > Properly prioritize the sources of an accessible name on Android.
> > 
> > This spec covers the right order: http://www.w3.org/TR/wai-aria-implementation
> > 
> > Now Android basically matches Windows, the difference is that Android has
> > to pick just one accessible name while Windows can have both a name and
> > a description.
> > 
> > There were existing cross-platform tests; I updated the Android
> > expectations.
> > 
> > BUG=359216
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274017
> 
> TBR=aboxhall@chromium.org,dmazzoni@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=359216
> 
> Review URL: https://codereview.chromium.org/304293006

TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/302243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274088 0039d316-1c4b-4281-b951-d872f2087c98