- 30 Jan, 2020 40 commits
-
-
Ioana Pandele authored
TBR=johnchen@chromium.org Bug: 1047164 Change-Id: I9f9399ac8f0c4a4a62163e2bb91005f633ebbbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030527Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#736831}
-
Mikel Astiz authored
Bookmarks created before 2015 may run into item ID duplicates across devices, so it's not appropriate to dedup based exclusively on the originator client item ID, unless it's a GUID. Change-Id: Ic338fcea59246f2cf4b1f2d7b43b3c4f69c7a1dc Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030407 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#736830}
-
Jérôme Lebel authored
Moving all enums into: ui/authentication/signin/signin_enums.h Bug: 971989 Change-Id: Ie19d7b5db58a8387c640b2d11e5b63b265bb73c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028130Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736829}
-
Michael Hablich authored
This is a roll-back to 8.1.307. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Change-Id: I85ae6732d8d5869ef68d39aa9481ae6a974d6963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030409Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Auto-Submit: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#736828}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I34af891c79b76867c63adc768e950cb27406d10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030331Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736827}
-
Nicolas Ouellet-payeur authored
The buildbot linux-annotator-rel turned red [1] after this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2012950 extractor.py doesn't like that we use a constant instead of a string-literal in DefinePartialNetworkTrafficAnnotation. This CL simply replaces the constant with a string literal. [1] https://ci.chromium.org/p/chromium/builders/ci/linux-annotator-rel/20744 Bug: 1046794 Change-Id: Iee31bfcdbb2f860b96493a154858cf391b4922ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028288 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#736826}
-
Robert Flack authored
This adds a WPT test verifying that CSS animations are composited in the order of their name within the animation-name property. Bug: 1045835 Change-Id: I8e746e1841cd4f5ca55e3e067762c2ea93e5c101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022616 Auto-Submit: Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#736825}
-
Tim Volodine authored
Add instrumentation tests for web geolocation api in weblayer. This uses the private version of the WebLayer i.e. TestWebLayer. In particular: - Add aidl and the necessary methods to the TestWebLayer in order to mock-out the geolocation provider and related methods (i.e. setMockLocationProvider and isMockLocationProviderRunning). - Use "weblayer-fake-permissions" switch to enable fake permissions delegate. - Add tests for: getCurrentPosition, watchPosition, tab destruction and insecure origins. BUG=1025625 TEST=run_weblayer_private_instrumentation_test_apk -f GeolocationTest* TBR=blundell@chromium.org Change-Id: Id420ca4a64618e62cd85b46d7759a8c4cd760bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017427Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736824}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f5303c91c16a..8d2b593996f3 git log f5303c91c16a..8d2b593996f3 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 fmayer@google.com Fix incorrect comment about kError. Created with: gclient setdep -r src/third_party/perfetto@8d2b593996f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I60ed54210cae4767a80236864053af8d1bf1e875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030129Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736823}
-
Guido Urdaneta authored
This feature is not supported on Android, so it is better not to expose it so that JavaScript-side feature detection works correctly. Bug: 1038244 Change-Id: I3faf65062113e164ef37995bc6a556227f72b5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030466 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#736822}
-
Marko Ivanovich authored
In case of simplest tests RegisterFrom(Un)ControlledDocument, message from service worker about tag being removed, is sent before promise passed to waitUntil is resolved. There is no guarantee that the tag will be removed before test requests list of tags. So this is race condition, that can be easily verified by adding sleep call to WaitUntilObserver::OnPromiseFulfilled, simulating thread interruption by OS scheduler. That is why we should not expect tag to be removed after we have received message about its removal, by actually wait for it. If test times out, it would fail. Similarly we should change some other tests, to make them future proof. Change-Id: I476acc1bececb01acb2d42db670af1a6cb5afa7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022665Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#736821}
-
Ioana Pandele authored
This reverts commit 9c9b70f9. Reason for revert: This CL causes HomescreenDragTest.DraggingPerformance to be flaky. Bug:1047135 Original change's description: > Disable window dragging from top in tablet mode. > > But tab dragging is still kept enabled. However, it will not be visible > to the user from M81 since they have mohnstrudel (#webui-tab-strip) > enabled. If mohnstrudel is disabled from chrome://flags, then the user > should still be able to do tab dragging. > > Bug: 1041928 > Change-Id: I2bfd2cc677ee82d9088006614ecb4f0d21b61cea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025574 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736124} TBR=xiyuan@chromium.org,xdai@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1041928 Change-Id: I9b402bac48834fbbf7cb7f431dc88f6e28f7ebdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030486Reviewed-by:
-
Maksim Sisov authored
The observer is redundant and not needed anymore. Thus, remove it. Also, make GlobalCommandsApiTest.GlobalCommand use a normal path instead of waiting for window mapping. This seems to be working fine like that. Bug: 1043089 Change-Id: I9fc6bd8714f143a8a1ecd3871a70b2041ba940e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018942 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#736819}
-
Bret Sepulveda authored
This patch also fixes a race revealed by the new test. When the extension was uninstalled, ExtensionHostQueue::ProcessOneHost would race with ExtensionHostQueue::Remove (called from ~ExtensionHost), and if the former won it would crash trying to get the missing extension's ID. This patch ensures that ExtensionPopup immediately destroys its owned ExtensionHost when the extension is uninstalled, avoiding the race. Bug: 984654 Change-Id: Ib811a6fca559129f235e00f6091086cf7f2f968f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980613Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#736818}
-
Adam Rice authored
Implement the SendStream interface and OutgoingStream mixin from the WebTransport specification. Implement the QuicTransport createSendStream() method to create a SendStream() object. SendStream is trivial as all interfaces are inherited from OutgoingStream. A new interface, WebTransportCloseProxy acts a bridge between QuicTransport and OutgoingStream. It abstracts away that a single stream_id can be shared between an IncomingStream and OutgoingStream in the case of a bidirectional stream. Also add a browser test for the new API. Bug: 1011392 Change-Id: I68731e606527d5dd94d54f9bfed05a22fde4d59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024393Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#736817}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1cf15bfe55a3..cf0595234cf2 git log 1cf15bfe55a3..cf0595234cf2 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 eshr@google.com Move quality scaler into adaptation module Created with: gclient setdep -r src/third_party/webrtc@cf0595234cf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I52f3482096e2ff2fd279df1a036c5f6415b9ec8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030128Reviewed-by:
-
Adam Rice authored
According to the Fetch Standard, attempting to create a Request object with a body that is a ReadableStream and the keepalive flag set should throw a TypeError exception. Make it do that. Since we don't yet support upload streaming, this doesn't make much functional difference, but it lets us pass the external/wpt/fetch/api/request/request-keepalive.html test. BUG=973659 Change-Id: Ib3919d28a99691cfdde640b2dfb9e695b9e0c8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030349 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
python client is being deprecated. Bug: 984869 Change-Id: I94a7445b903d8806fe520788998e1e0e4b96326c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029566 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#736814}
-
David Roger authored
Before this change, any account added during the extension consent flow was not going through Dice, and thus was not properly added to Chrome. This prevented the account to be properly managed, and in particular it was not possible to refresh the access tokens. This CL attaches Dice headers to requests coming from the extension consent flow, and the account is now added to Chrome. Other guest web views (such as the InlineLoginUI) are still ignored by Dice. It is unclear whether they really need to be ignored, but to minimize the change, this CL doesn't modify this behavior. Change-Id: I869ab5e699b7ee6cb556c17555be502893e3ea67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954387 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736813}
-
Wenbin Zhang authored
From Pinpoint, end user can launch a job by selecting a benchmark together with a story or a story tag. Though, there's no way to run all stories of a benchmark. The reason behind this is that Pinpoint does not have enough devices so it wants to limit the duration of each job. However, some benchmarks are small and it won't be a big load even running all of their stories. Per Blink team's request, this CL adds "all" tag to two of its benchmarks: blink_perf.dom Bug: chromium:1023451 Change-Id: I334e3d3157b3c29c94e3de342d4d5e060948f712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028120Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#736812}
-
Alice Wang authored
This CL added some checks before the personalized bookmark signin promo is shown and refactored some related code. Bug: 1045480 Change-Id: I408e3e9a90c1c188fd77ab8ddd94158d259313ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022786 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#736811}
-
Colin Blundell authored
When Chrome's captive portal detection service is enabled (as it is on Linux), its SSLErrorHandler requires that CaptivePortalTabHelper be available off of WebContents. This CL makes CaptivePortalTabHelper in this context in WebLayer as preparation for sharing //chrome's SSLErrorHandler in //weblayer. Bug: 1030692 Change-Id: Ib5c2fb5ed2fee54204f32c18a146dfad3a45b428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024851 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#736810}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 60fd8cd3. With Chromium commits locally applied on WPT: b292a7b8 "Separated willValidate check in HTMLInputElement::validationMessage" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib5246995770bf8d84f21b559e9362736d0bbefd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028475Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736809}
-
arthursonzogni authored
This correspond to step 1.b from the "Unify CSP" document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao This merges: - content::CSPSourceList - network::mojom::CSPSourceList Only the mojo one remains. Future follow-up will apply do the same CSPDirective and ContentSecurityPolicy. The goal at the end is to have an unique mojo data structure for representing Content-Security-Policy. Bug: 1021462 Change-Id: Ie9f826dec8f6e0f3ec9e8fd38bc606250bd6fc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022948Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
The sole test in this suite exercises dragging an extension into the app menu, which is not a supported feature when the flag is enabled. Bug: 984654 Change-Id: I9d59ea27b80cef4529b6201b8f1be0face7ed7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027847Reviewed-by:
-
Ioana Pandele authored
This reverts commit 6d035d3a. Reason for revert: Broke multiple test targets on Linux CFI Bug:1047150 Original change's description: > Roll src/third_party/swiftshader 6c3dc3581eaf..430def835f9f (7 commits) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/6c3dc3581eaf..430def835f9f > > git log 6c3dc3581eaf..430def835f9f --date=short --first-parent --format='%ad %ae %s' > 2020-01-29 capn@google.com Regres: aways use build output path for ICD json > 2020-01-29 capn@google.com Associate bug IDs with unimplemented functionality > 2020-01-29 amaiorano@google.com Fix memory leak in rr::Optimizer > 2020-01-29 bclayton@google.com Regres: Make it work on windows. > 2020-01-29 amaiorano@google.com Subzero: implement coroutines for Win32 > 2020-01-29 bclayton@google.com SpirvShaderDebugger: Expose builtins in HLSL / GLSL. > 2020-01-29 bclayton@google.com Vulkan/Debug: Add VariableContainer::extend() > > Created with: > gclient setdep -r src/third_party/swiftshader@430def835f9f > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: None > Tbr: swiftshader-team+autoroll@google.com > Change-Id: I02f8c532b33dc934d1f4da0da6eb43dd0b7e174b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029219 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#736686} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: I6721bde098fb6ed88cdaa210ec1168fb1f01712d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030174Reviewed-by:
-
Robbie Gibson authored
With the new dark mode design, the icons no longer change color when they are highlighted. This means that the extra masking is all no longer needed and can be cleaned up. Fixed: 986804 Change-Id: I796a6fa6d4db5f478361823c5e216527bd875f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023658Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#736805}
-
Rushan Suleymanov authored
This CL adds UMA for commit error codes (including NONE) of sharing message data type. Bug: 1044609 Change-Id: I683be2597167a180653f8ad2d29b6da30b47eeba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025110Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#736804}
-
Rune Lillesveen authored
Bitwise operation between enums of different types. Bug: 1035171 Change-Id: Ie82131a9c6d2f0797947893735b5fb193ea54eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030166Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#736803}
-
Ioana Pandele authored
The flags removal CL did not contain updates to flag-metadata.json. The removal CL was reverted at https://chromium-review.googlesource.com/q/I6473fb68d3aac1e937da9ded8138befdd857e762 and merged into release branches. The revert did not include changes to flag-metadata.json causing AboutFlagsTest.EveryFlagHasMetadata to fail on multiple bots. This CL adds metadata for the removed flags, in order to fix the tests. This approach is likely to cause less disruption than a revert of the breaking change. TBR=mcasas@chromium.org Bug: 1047089 Change-Id: Ifb40c3ca8ec826b509c588efb37cf65cf69ef863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030484Reviewed-by:
-
Thibaud Michaud authored
R=ahaas@chromium.org Bug: v8:10165 Change-Id: I2788219581bbbc328c276916aafa2475a51f0a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028087Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#736801}
-
Ioana Pandele authored
TBR=jsbell@chromium.org Bug: 1047126 Change-Id: Ie21b6031591425cf4fa1b80ec14f35836734f5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030465Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b12649462ca2..df2dbba832ad git log b12649462ca2..df2dbba832ad --date=short --first-parent --format='%ad %ae %s' 2020-01-30 leese@chromium.org Check for wasm disassembly before inline script 2020-01-30 szuend@chromium.org Add 'skipFirstWait' argument to breakpoint decoration test helper 2020-01-30 kayce@google.com Update the What's New UI for Chrome 81 Created with: gclient setdep -r src/third_party/devtools-frontend/src@df2dbba832ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1045573,chromium:986998 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If8ee0f39ec0c67488c8f9686e1b68f452beffa78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030041Reviewed-by:
-
tby authored
This is a reland of cbe25387 Original change's description: > [Structured metrics] Rearrange build files > > Currently, the generated classes for each event are created under the > //tools/metrics/structured target. I don't think this is the intended > use of the tools directory, because chrome targets explicitely can't > depend on it, and so can't access the generated events. > > This CL moves the codegen targets to //components/metrics/structured, > which is accessible from chrome (and just makes more sense). > > Bug: 1016655 > Change-Id: I6a295486a3dad094b44db67d70408c8629728bcc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029531 > Commit-Queue: Tony Yeoman <tby@chromium.org> > Auto-Submit: Tony Yeoman <tby@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736753} Bug: 1016655 Change-Id: I16f5ddd85b46d0b3420d7a40421a5cba60063f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030385Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#736798}
-
Fabian Sommer authored
This is in preparation to use the UI for smart cards. Bug: 1001288 Change-Id: I6a2890eaf476a79db68e8bc6898c7e4fb89199c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022770 Commit-Queue: Fabian Sommer <fabiansommer@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736797}
-
Stephen Nusko authored
There was a lot of different uses of getting the SharedMemoryArbiter this unifies them all and makes it consistent. Bug: 1007310 Change-Id: I0a6aba5f739723b46261cb6e0ec174d07ddc2897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026569Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736796}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I996de028a1b2f135003a12bea40d62d24d57f83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030040Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/29e5a1af6c1d..305542ea70b1 git log 29e5a1af6c1d..305542ea70b1 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@305542ea70b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ib29b230275804310d09dd921017d7287c534f531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030035Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6ebcde89ed38..a66ca23b9f26 git log 6ebcde89ed38..a66ca23b9f26 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 fancl@chromium.org Add /subscriptions/list endpoint Created with: gclient setdep -r src/third_party/catapult@a66ca23b9f26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: wenbinzhang@google.com Change-Id: Ic4d526e4674eac67db1d8a4df75ce426321fab08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030039Reviewed-by:
-
Rune Lillesveen authored
Resolved in https://github.com/w3c/csswg-drafts/issues/4608 Pull request: https://github.com/w3c/csswg-drafts/pull/4714 Change-Id: Id902a8f7b920872a3dede346c98c87092a6147e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027418Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#736792}
-
