- 26 Feb, 2019 11 commits
-
-
Katie D authored
Bug: 905419 Change-Id: I67112e7a50fd45f417ab082589a33ca554fcf721 Reviewed-on: https://chromium-review.googlesource.com/c/1484581 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#635330}
-
Oksana Zhuravlova authored
Change-Id: Iad779efca6df4c8b8a2743497b34a7fe84fcc724 Reviewed-on: https://chromium-review.googlesource.com/c/1487592Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#635329}
-
Alan Cutter authored
This CL adds a plus icon to the omnibox that replaces the bookmark star when the active tab's site is considered to be installable by Chrome's PWA standards. This icon is hidden behind the --enable-features=DesktopPWAsOmniboxInstall flag. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=380835&signed_aid=_10PeH93S54eGlcXu2GM7w==&inline=1 Still to come: - Accessibility tool tip - Showing the plus as soon as installability checks pass - Refactoring the installability check out of AppBannerManager - Showing a pop out icon if the site is already installed Bug: 907351 Change-Id: If21ce11cd02ef1138897b35a68ac0f702879a011 Reviewed-on: https://chromium-review.googlesource.com/c/1460203 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#635328}
-
Chris Palmer authored
Add some color and examples. Bug: None Change-Id: Iacd9a21eeaf212d6b553f076bd27db36b544a3d0 Reviewed-on: https://chromium-review.googlesource.com/c/1483696Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#635327}
-
Kalvin Lee authored
Change Ic56fff645c2fbc078559b4dc37b33f589415ef87 landed before Tricium could raise a complaint about a D-Bus (C) header below its recommended position. This change moves it into place. R=stevenjb@chromium.org Bug: 929772 Change-Id: I1282b290fe74320fa991ba70c2da2ff03baf3e6a Reviewed-on: https://chromium-review.googlesource.com/c/1487833Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#635326}
-
Yuwei Huang authored
This commit fixes extra semicolons in gRPC public headers. This CL also removes suppressions on Wextra-semi around gRPC includes. Bug: 933949 Change-Id: I4946ce244f37397bdff71c37efb63b1efb5038bb Reviewed-on: https://chromium-review.googlesource.com/c/1487931 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#635325}
-
Ben Kelly authored
Bug: 933866 Change-Id: I80852f2e446afc1a360f86341d086da8e2cd5e6f Reviewed-on: https://chromium-review.googlesource.com/c/1483692 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#635324}
-
Oystein Eftevaag authored
Previously a repeating timer to request the trace buffer status was started at the same time as tracing was started, rather than waiting for the BeginTracing callback. The http/tests/devtools/tracing/buffer-usage.js web test is relying on the order of the BeginTracing callback happening before any BufferStatus callbacks. This happened to work in the past because the tracing service would multiplex these two along the same message pipes to all of the subprocesses, but this is no longer the case (with Perfetto we get the buffer status from the size of a central buffer, and don't need to query each subprocess). R=caseq@chromium.org Bug: 839084 Change-Id: Ifb110d521d5829c7abf1ec522d0d280029729b7f Reviewed-on: https://chromium-review.googlesource.com/c/1483354 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#635323}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/73f6992d3486..16c7224d7b9b git log 73f6992d3486..16c7224d7b9b --date=short --no-merges --format='%ad %ae %s' 2019-02-25 dgarrett@google.com branch_archive_stages: FactoryArchive includes test image. Created with: gclient setdep -r src/third_party/chromite@16c7224d7b9b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I8cacd7f8f97cf119d3935f49e4ad649c2455dc60 Reviewed-on: https://chromium-review.googlesource.com/c/1487955Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635322}
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=tapted@chromium.org Bug: 714018 Change-Id: I875c9d84c41f43fb1032da0fb906a46f544c41e9 Reviewed-on: https://chromium-review.googlesource.com/c/1486153 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#635321}
-
Noel Gordon authored
Add standard node package.json and add a .gitignore file. Testing will need test images: add images.sh used to fetch the raw images for tests into ./images. To setup the node project and its dependencies, run the 'npm install' command. Bug: 935285 Change-Id: I734482d9a5fd5e16c2c2007d429ceb748899a388 Reviewed-on: https://chromium-review.googlesource.com/c/1485626Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635320}
-
- 25 Feb, 2019 29 commits
-
-
Brad Hall authored
This is needed on the mac bots when xcode isn't in the standard place in order to run otool. Bug: 861357 Change-Id: Idbad0b07afdf1b7b214735b6a7db1371427ef145 Reviewed-on: https://chromium-review.googlesource.com/c/1479293 Commit-Queue: Brad Hall <bradhall@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#635319}
-
Adam Ettenberger authored
1. Implementing ITableProvider::get_RowOrColumnMajor. It looks like Chromium only supports row-major ARIA tables, so returning |RowOrColumnMajor_RowMajor|. 2. IGridProvider was already implemented, but ARIA colcount/rowcount was being ignored; the actual table size was being returned. (a) For UIA, ARIA attributes take precedence over actual size. (b) The value (-1) is significant for ARIA colcount/rowcount, but should result in E_UNEXPECTED for UIA. 3. Adding unit tests for IGridProvider and ITableProvider methods. 4. Fixed an issue where AXTableInfo could calculate the wrong aria-colcount when it was unspecified on the table, but there were cells that specified aria-colindex. 5. Make AXTableInfo |aria_col_count| and |aria_row_count| optional so that callers don't have to worry about the special (-1) case |ax::mojom::kUnknownAriaColumnOrRowCount|, and changed relevant method signatures in the accessibility platform code. Bug: 847971 Change-Id: I7202c59e75351b6de1fb06656c3ad1c9fd08a81e Reviewed-on: https://chromium-review.googlesource.com/c/1476207Reviewed-by: -
Eric Willigers authored
The (unshipped) desktop implementation of Web Share now has access to the method, enctype and files entries in the manifest of each Web Share Target. BUG=903010 Change-Id: Icd0b6daaee71ab9b9412118e1eba3b484438d4a1 Reviewed-on: https://chromium-review.googlesource.com/c/1485693 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635317}
-
Fergus Dall authored
Currently it's possible to open the crostini uninstaller while the installer is still running. While crrev.com/c/1453956 prevents them from actually running at the same time, this can still lead to confusing UI states. This CL prevents the uninstall crostini option from appearing in the settings page and the terminal context menu while the crostini installer is running. Bug: 919153 Change-Id: I424fb8ba625087782fe08b7e8b978242c7465695 Reviewed-on: https://chromium-review.googlesource.com/c/1472013Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#635316}
-
Lukasz Anforowicz authored
Bug: 932766, 933862, 935095, 935705, 935707 Change-Id: I9f7af9a1fca4d791f3eeab761ed5b0810c33c3b9 Reviewed-on: https://chromium-review.googlesource.com/c/1478101Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635315}
-
Yiming Zhou authored
The captured sites test uses Web Page Replay Go (WPR Go) to replay captured sites traffic. The captured sites test bots uses a script in the catapult project to download WPR Go binaries. At the moment these bots are failing to download WPR Go, presumably because bots' gn isolate is missing references to the catapult project. This fix attempts to address this problem by following the example of existing perf/telemetry test targets in src/chrome/test/BUILD.gn and adding a dependency to the telemetry_chrome_test_support target. Bug: 916361 Change-Id: Ie999bc5c64edb6aca180ac98ec68864875e831a1 Reviewed-on: https://chromium-review.googlesource.com/c/1487693 Commit-Queue: Yiming Zhou <uwyiming@google.com> Auto-Submit: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#635314}
-
Xiaocheng Hu authored
NoTry: True Tbr: dtrainor@chromium.org Bug: 932092 Change-Id: Ie1484936cd92f1d48c69d02c7efdeb3c47d6f6b3 Reviewed-on: https://chromium-review.googlesource.com/c/1488054Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635313}
-
Daniel Cheng authored
Change-Id: Id3444dca74b55269c4f07c303f2f9c49cc0e6049 Reviewed-on: https://chromium-review.googlesource.com/c/1485699Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#635312}
-
Anand K. Mistry authored
This is a reland of https://crrev.com/634562. The original change didn't handle failures as expected for the watcher API functions. BUG=934541 Change-Id: I964dc908a35f02e237604bfd18f931d282b3a4d5 Reviewed-on: https://chromium-review.googlesource.com/c/1484965Reviewed-by:
-
Andrew Moylan authored
This CL uses ScopedFeatureList to control the UserActivityPredictionMlService flag to toggle between the ML Service and old TfNative codepath for Smart Dim. Both codepaths are now tested. In order for the ML Service codepath to work in a unit test environment, where there is no real ML Service daemon, we need to inject a fake MlServiceClient implementation. Quite a bit of refactoring was applied to separate the tests that don't apply to both codepaths from the tests that do apply to both codepaths, and to control the different combinations of flags we need to test. Bug: 933638 Test: unit_tests --gtest_filter=SmartDim* Change-Id: I95f19c1fcc925422effef1ec4221a76cbe1fc8e6 Reviewed-on: https://chromium-review.googlesource.com/c/1478666 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#635310}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I9517216cc228282085f0676ec676ea5157c46360 Reviewed-on: https://chromium-review.googlesource.com/c/1486877Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#635309}
-
Xiaocheng Hu authored
[Sheriff] Mark two more external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/ tests as failure on Mac Tbr: xiaochengh@chromium.org NoTry: True Bug: 935689 Change-Id: Ic831b15257501a092f9e33610165f6a3d0baa5e1 Reviewed-on: https://chromium-review.googlesource.com/c/1488014Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f78131dac076..fe14b2e503a5 git log f78131dac076..fe14b2e503a5 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 ynovikov@chromium.org Revert "Add system util to execute app and retrieve its output" 2019-02-25 tobine@google.com Vulkan:Adding custom pool allocator 2019-02-23 syoussefi@chromium.org Add system util to execute app and retrieve its output Created with: gclient setdep -r src/third_party/angle@fe14b2e503a5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I4e9aec9815b57f6262abff44cc86175dacf4faac Reviewed-on: https://chromium-review.googlesource.com/c/1487845Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8c1e8f1fb771..9b433073ba38 git log 8c1e8f1fb771..9b433073ba38 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 hliatis@google.com Fix minor issue in vkCreateInstance extension loop Created with: gclient setdep -r src/third_party/swiftshader@9b433073ba38 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/125943360 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I4d09db4a8744991c5d852f5ae0ac8d404ca9bf38 Reviewed-on: https://chromium-review.googlesource.com/c/1487136Reviewed-by:
-
Ryan Sturm authored
I am targetting fixing one test before moving on to other tests. By calling the UI thread version of the method (instead of the general one) we guarantee a more synchronous interaction, and by disabling the hints installer from sending actual hints, we guarantee that nothing overrides the test hints. This fix is motivated by two facts: the installer and the test both might try to install hints that override each other, and the PreviewsOptimizationGuide starts observing after the HintCache is fully initialized (meaning a DB is read). Bug: 932913 Change-Id: I9f0dc5ef85c9ac1d2e099e7227182890e2114338 Reviewed-on: https://chromium-review.googlesource.com/c/1487174Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#635305}
-
Jacques Newman authored
Also removed xy test to avoid being dependant on scrollbar width. Bug: 935256 Change-Id: Id0436cd2f9654ee7dd121a65eefcdf5b6d458fb7 Reviewed-on: https://chromium-review.googlesource.com/c/1486875 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
-
Karan Bhatia authored
Protect requests made by the local NTP by treating the chrome-search://local-ntp as sensitive. BUG=931013 Change-Id: I6480bfa606be837295daff9d7fd5c906cd7dd98f Reviewed-on: https://chromium-review.googlesource.com/c/1483874Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e322313..a32d20ab Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5dbd2cecbf000818991f0806ff6ea531f5d732e9 Reviewed-on: https://chromium-review.googlesource.com/c/1487803Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635302}
-
Karandeep Bhatia authored
We don't correctly handle patterns beginning/ending with wildcards and an anchor. Fix this. Also disallow patterns starting with a wildcard and having a subdomain anchor, since it's not clear how these should be matched. This also necessitates a scheme update. BUG=932958 Change-Id: I2cf249b7de1ec238044c293f5dcc1168bb3e1d8e Reviewed-on: https://chromium-review.googlesource.com/c/1484828 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#635301}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b92fa105572a..9b8d2b0bbfad git log b92fa105572a..9b8d2b0bbfad --date=short --no-merges --format='%ad %ae %s' 2019-02-25 cwallez@chromium.org Instance: Only discover default adapters once. Created with: gclient setdep -r src/third_party/dawn@9b8d2b0bbfad The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I80465621e490fc10f78d360c6013f64c3ca40572 Reviewed-on: https://chromium-review.googlesource.com/c/1487836Reviewed-by:
-
Xiaocheng Hu authored
[Sheriff] Disable ProfileWindowBrowserTest.OpenBrowserWindowForProfileWithSigninRequired on Win and Linux Bug: 935746 Tbr: droger@chromium.org NoTry: True Change-Id: Ibf25dfaa3136e06501faaab14e3e54d9a30341a8 Reviewed-on: https://chromium-review.googlesource.com/c/1488031Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: I63b4eae1090eb0c8622ac3b1e6e0d177ca91b69d Reviewed-on: https://chromium-review.googlesource.com/c/1487877 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#635298}
-
Sergey Ulanov authored
viewsv1 dependencies have been removed from topaz, so WebComponent doesn't need to support it anymore. Bug: 899348 Change-Id: Icd666bcbd00b8bbb52ccd1948b4d977e83bab40b Reviewed-on: https://chromium-review.googlesource.com/c/1487848 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#635297}
-
dpapad authored
Bug: 933062 Change-Id: Id7865e5d14ae505a590d7b14da45e24dfb31f81d Reviewed-on: https://chromium-review.googlesource.com/c/1475208 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#635296}
-
Tommy Steimel authored
This CL adds a new component to interface with MPRemoteCommandCenter: https://developer.apple.com/documentation/mediaplayer/mpremotecommandcenter?language=objc This is used to receive media key presses instead of using an event tap so that we avoid an issue where the OS prompts the user for extra privileges when the event tap is created. Bug: 930180 Change-Id: I3877499a49529c88427590cc013700b2e5e985ee Reviewed-on: https://chromium-review.googlesource.com/c/1480702Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635295}
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 714018 Change-Id: I7aea860addd894f1c0b0895ae474c5e52dfb23ee Reviewed-on: https://chromium-review.googlesource.com/c/1486155 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635294}
-
Wenzhao Zang authored
In order to support country-level customization for Demo Mode, there's a newly added |device_owner| field, which is an email address. (https://critique.corp.google.com/#review/235043138) DM server will directly enroll the device into the corresponding sub organization based on its value. Bug: 888733 Change-Id: I86fee12c5b76e28f50f6329b76cb73893b596483 Reviewed-on: https://chromium-review.googlesource.com/c/1461777Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#635293}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ac25a05e. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" 3685447d "[WPT] Move subresource_path from generator to referrer-policy-test-case.js" 4ea68472 "Creates an ICE transport object at DTLS transport initialization." 9e55e3db "[css-flexbox] Shrink-to-fit sizing needs to take margins into account" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org: external/wpt/css/css-namespaces kojii@chromium.org: external/wpt/css/CSS2/text external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ib777ee8b5d9132218f144b9f8b2e11ea37352041 Reviewed-on: https://chromium-review.googlesource.com/c/1487199Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635292}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a4323c9b818b..85a76645b4e4 git log a4323c9b818b..85a76645b4e4 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 rmhasan@google.com Adds new method to serially executed browser test case API Created with: gclient setdep -r src/third_party/catapult@85a76645b4e4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902 TBR=sullivan@chromium.org Change-Id: I08ff76ec1f77cc0e6ec5a1e5ed64a781913fe8b8 Reviewed-on: https://chromium-review.googlesource.com/c/1487708Reviewed-by:
-
