- 06 Mar, 2020 40 commits
-
-
Dana Fried authored
This reverts commit cb8fbfbf. Reason for revert: 3P file had fallen out of TSAN whitelist when it was renamed, it has since been added back. See: https://chromium-review.googlesource.com/c/chromium/src/+/2076278 Original change's description: > Revert "Create field trial for hover card images." > > This reverts commit 9ba868cd. > > Reason for revert: <INSERT REASONING HERE> > interactive_ui_tests failed on > Builder Linux TSan Tests > https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests > > Original change's description: > > Create field trial for hover card images. > > > > This is required to deploy a finch configuration. > > See cr/296239960 for WIP Finch config. > > > > Bug: 1032640 > > Change-Id: Ifae3d2966d4ca908982cec37c5d88f786bf07367 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067558 > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Commit-Queue: Dana Fried <dfried@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#743826} > > TBR=rkaplow@chromium.org,dfried@chromium.org > > Change-Id: I27fbe4d67b42a42d63757e78427d86d31e045592 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1032640 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069275 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743839} TBR=rkaplow@chromium.org,lanwei@chromium.org,dfried@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032640 Change-Id: I13c1920b2e3d0a721af5475df789b15cf0794904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091933 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#747931}
-
Lindsay Pasricha authored
This reverts commit dfe67264. Reason for revert: This breaks on device runs for xcodebuild_runner. This revert will land after the revert of crrev/c/2076765. Original change's description: > [iOS][code coverage]Move raw coverage data to isolated output in test runner scripts. > > - Added function of moving raw coverage data in a new utility file and > corresponding tests. > - Added "use_clang_coverage" arg to run.py and all simulator test > runner classes. > - Added check of the arg and call to the function in TestRunners after > running unit tests and EG tests. > > Bug: 943883 > Change-Id: I5f16c152a38f7a8a3d988aac9e73964d890219b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048851 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744470} Bug: 943883,1058257 Change-Id: I4ae784f831c60bf621c8135af490bdeffa3c004e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089404 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#747930}
-
Anna Malova authored
Bug: 1007815 Change-Id: I2eef21c585df6441715e188fcc816735b125b828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091532 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#747929}
-
Reilly Grant authored
Now that test_runner.set_permission() is available these Wake Lock API tests can be upstreamed to Web Platform Tests. Bug: 1015327 Change-Id: I7bb1c7cbc458c8b7b05c0c2361fbe5ea50444e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089968Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#747928}
-
S. Ganesh authored
Also added a log statement and a cleanup of a value in the unit test. Bug: 1058506 Change-Id: I6e43df059f11d7fdba8c430458a1d1f298a56905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090916 Commit-Queue: S. Ganesh <ganesh@chromium.org> Auto-Submit: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#747927}
-
Matthew Mourgos authored
This change swaps the order of the back and overview pages on the gesture navigation screen. The new order for the gesture navigation screen is as follows: (Intro Page) -> (Home Page) -> (Overview Page) -> (Back Page) Bug: 976949 Change-Id: Ic621c8c5a69b3b8a5c1e2822605944a94c68d8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090356Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747926}
-
Eugene But authored
Used by Breadcrumbs feature that attaches steps to reproduce to crashlogs. These actions duplicate some histograms, but Breadcrumbs can't observe histogram logs. Bug: 1046223 Change-Id: I2043a9cceee6639f4404906e8ea11f7e26648695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090978 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#747925}
-
Gabriel Charette authored
ConditionVariable by default emits a trace event from Wait(). Message pump like code needs to explicitly disable this to avoid emitting trace events while sleeping that make the thread incorrectly look busy. R=pwnall@chromium.org Bug: 899897 Change-Id: I5c7078db3e4889ae3e946e045a4e626fcd7ee8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090505 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#747924}
-
Adrienne Walker authored
These includes will not be valid when idb moves to the storage service. Additionally, the size is not used as in the web ui so it is safe to save it as a double instead of a formatted string. (base::Value does not support int64_t.) It could also be potentially removed in the future. Bug: 1015214 Change-Id: I943fe6f89672560097b99f6883f7999d2a811495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091710 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#747923}
-
Min Qin authored
BUG=1059201 Change-Id: Ia2a6f4dd477bc52ec607d7d989e03875140d058d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091944Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747922}
-
edchin authored
We are adopting Chrome Flag Ownership in iOS. go/chrome-flags-ios More about flag ownership here: https://chromium.googlesource.com/chromium/src/+/master/docs/flag_ownership.md This CL creates a util file of data structures and functions that are shared by: //chrome/browser/about_flags_unittest.cc and //ios/chrome/browser/flags/about_flags_unittest.mm This CL migrates 5 tests to iOS. However, the main test that ensures that flags in iOS have a corresponding metadata entry is disabled. This will be enabled when the metadata file is filled out with iOS flags. Additional followup CLs will add entries to the metadata files, enable tests, and modify documentation. bug: 1058614 Change-Id: I8c94183a47d2065c2fc4441e4fc7d9682d17da55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088034 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747921}
-
Alex Danilo authored
Add a new left pointing arrow SVG asset for use as file path separator in RTL layouts. The left pointing arrow asset was produced by hand flipping the points in the existing right pointing arrow asset. Changes the p:before separator for the files-ng bread crumbs to use SVG assets instead of a text character pulled out from the current font. Bug: 1035691 Change-Id: I61549e16a85ba2c709016fbd4272a860d2d2054c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090553 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747920}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bd9927b. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 1aeefa88 "[UA client hints] Align implementation with PR#46, #48 & #70" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I25ff300c5b0d4950eb1b2b20d3c9ab286a25e6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089410Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747919}
-
Joe Downing authored
I noticed this while looking at the exit codes, basically the comment references a non-existent file. I fixed it to point to the correct file. Change-Id: I5d172c1023fd28705c1957d176b37a9be6a5d32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091654 Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#747918}
-
Steven Bingler authored
The error logic for DnsOverHttpsMode policy's secure mode is no longer needed. Remove the logic from the policy handler and update tests to match the new behavior. Also, correct the handler's header comment. Bug: 955454 Change-Id: I6c471116c27f8c25c2f8222b58d4767ab1ef3b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020606 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#747917}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6b79fee5ae98..ea6e1f04de4d git log 6b79fee5ae98..ea6e1f04de4d --date=short --first-parent --format='%ad %ae %s' 2020-03-06 primiano@google.com Merge "probes: Make the type id less error prone" Created with: gclient setdep -r src/third_party/perfetto@ea6e1f04de4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I25ad297d521b892b48fc8eda22bc93eabee651a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091680Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747916}
-
evliu authored
This CL creates a sandboxed service that hosts the Speech On-Device API (SODA). It contains the components required to launch the service from the renderer process, but the implementation of the service itself is stubbed out. The design document for the feature is located at: go/chrome-live-captions. Bug: 1045043 Change-Id: I2411865457e1b7864f1b4a327d776932caf3132c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017563 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#747915}
-
Ehimare Okoyomon authored
Rotating the screen could cause UI issues with cookie controls card if the screen is big enough for resizing. Set the width dynamically based on this. Bug: 1040091 Change-Id: Ieaf39b55662953db7dbeb05c954b8a32e148e1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089904Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#747914}
-
Ben Joyce authored
Bug: 1052460 Change-Id: Id3d82593c2cd0a54f6f5df5a9cea65838f14fd8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089981Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#747913}
-
Filip Gorski authored
Bug: 1054072 Change-Id: I0a22eb181959ad7df708119df282643c536f3098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082020Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#747912}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7e46b14d8494..24a8e9e170f7 git log 7e46b14d8494..24a8e9e170f7 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 robertphillips@google.com Reland "Update skpbench's DDL timing" 2020-03-06 robertphillips@google.com Remove bot to record DDL creation time 2020-03-06 jvanverth@google.com Remove invalid assert 2020-03-06 robertphillips@google.com Allow a non-FBO0 surface to be matched with an FBO0 rendertarget proxy 2020-03-06 dmazzoni@chromium.org Add marked-content ID to PDF images 2020-03-06 martin@mainframe.co.uk set lib_switch to empty for the msvc toolchain 2020-03-06 robertphillips@google.com Revert "Update skpbench's DDL timing" 2020-03-06 borenet@google.com [recipes] Minor import cleanup 2020-03-06 reed@google.com Land a testable raster backend for per-vertex-data vertices. 2020-03-06 jvanverth@google.com Add GrD3DResource. 2020-03-06 mtklein@google.com disable command buffer on iOS g3 builds 2020-03-06 egdaniel@google.com Remove SkImage getTexture call. 2020-03-06 scroggo@google.com Split building encoding from decoding 2020-03-06 robertphillips@google.com Update skpbench's DDL timing 2020-03-06 martin@mainframe.co.uk fix print functions for python3 gn scripts Created with: gclient setdep -r src/third_party/skia@24a8e9e170f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:607777 Tbr: herb@google.com Change-Id: Ice3918309707345d484612994ac488f59c1b128e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092081Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747911}
-
Dan Harrington authored
Feed and Zine share two prefs, but these pref strings are currently duplicated. This CL makes the pref sharing explicit. I'm making this change now because I want a feed/core test to use these prefs. Bug: 1044139 Change-Id: I9917863385cf0c521ad10e2d6d3913b94f107354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025638Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#747910}
-
Daniel Cheng authored
This can be useful if a bit of data serialized at the end is optional; instead of having to encode an explicit boolean flag, the deserializer can simply consult ReachedEnd(). Bug: 1055911 Change-Id: Id92bfa5ffbdd0c309367417ed12444eff2d94cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091715 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#747909}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e8883562ef57..1a5c7a16ba71 git log e8883562ef57..1a5c7a16ba71 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 tobine@google.com Reland "Vulkan:Include precision qualifier in GLSL" 2020-03-06 julien.isorce@chromium.org Instantiate rx::DisplayEGL when device type EGL is selected 2020-03-06 geofflang@google.com Fix GN warning about unused variable when angle_enable_commit_id=false 2020-03-06 ianelliott@google.com Generate new compiler errors for array-of-arrays Created with: gclient setdep -r src/third_party/angle@1a5c7a16ba71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Ibc5d9905bceddc0ecac4b9439be58fa2e8470b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091684Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747908}
-
Allen Bauer authored
Bug: 1044687 Change-Id: I1161682a841c05fd5854f77e4b0db127356ae037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087956Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#747907}
-
Xianzhu Wang authored
They were to evaluate paint performance with the cost of GraphicsContext or DisplayItem constructor excluded. They were meaningful when we developed the early versions of display-item-based painting (Slimming Paint V1), but seem to provide little value nowadays. Change-Id: I7b2ebf90364c51cf65ed1b65cd376e0eafdd7df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090760 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747906}
-
Yuwei Huang authored
This CL adds a RemoteCommand field to HeartbeatResponse and make the host restart with a REMOTE_RESTART_HOST offline reason when a RESTART command is received. Some refactoring has been done to make code more readable. Bug: 1058988 Change-Id: I1dec66fd718176fb6cfe6257f86d8d2a3db1fe02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090876Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#747905}
-
Jarryd authored
This change updates QuotaTemporaryStorageEvictor::time_of_end_of_last_round_ so that the above mentioned metric can be logged. Bug: 994911 Change-Id: Ic191592615018381738c2e64709855828677e7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088640Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#747904}
-
sandromaggi authored
Launch bug: crbug/1011334 Bug: none Change-Id: I764fea997d4296b228826df49c8773bcb7675988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089778Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#747903}
-
Nate Fischer authored
This adds support for giving flags a predetermined value. This won't have any noticeable effect yet because the only flags with values are finch-related, which are queried either: - early in startup, before dev UI applis flags (https://crbug.com/1059131), or - in the :webview_service process, which the flag UI doesn't currently support (https://crbug.com/1058189) This does not support applying parameters to base::Features, since this isn't supported through the basic base::Feature API (it's Finch-specific functionality). Bug: 1047493 Test: run_android_webview_junit_tests -f *FlagOverrideHelperTest#* Change-Id: I773014bea72b4b7156d9e094b431f4fc1e7d0257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090882 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747902}
-
Piotr Bialecki authored
Latest spec: https://immersive-web.github.io/anchors/ - remove last changed time from anchor object - anchor space is not nullable on anchor object now - anchor objects are not created in zombie state anymore - when anchor creation promise resolves, it should receive a fully built object - XRAnchor got simplified due to the above - XRFrameProvider needs to make sure that JS promises can run between presentation frame update and rAF callbacks so that the app has a chance to see newly created anchors before they are delivered to it via XRFrame.trackedAnchors Changes: Change-Id: If582552907274d472097f7d7b119bb7ee216736e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085701 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#747901}
-
Caleb Rouleau authored
These csv files were prone to causing merge conflicts. As the bug link shows, these have been replaced by a Google Apps Scripts solution that writes the data directly to Google Sheets. See go/chrome-benchmarking-sheet to see the replacement. Bug: 1054000 Change-Id: If43f4b9f38d17adca57d9ed4db7f1ec4aa59483e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092060 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#747900}
-
Josh Karlin authored
What: Some callers to IsAdScriptInStack know the ExecutionContext that triggered the event. Those callers should pass the context in to IsAdScriptInStack as there is a small cost to looking it up. Why: Some callers (such as core_probes) call frequently and looking up the ExecutionContext when it's already known only slows things down. Bug: 851531 Change-Id: Id8eadfc9855cdda0d18df34a4829dd47e31ac64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090232 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747899}
-
Marijn Kruisselbrink authored
Instead have a separate nataive_file_system_dialogs.h file for these methods. Bug: none Change-Id: I3c752c604cd29d4f7703503673b9b8530a04cd20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091724Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#747898}
-
Karan Bhatia authored
Add rule limits for regex rules. Initially we are going with a limit of 1000 rules applied separately to the extension's static and dynamic ruleset. BUG=974391 Change-Id: Ifdeca957ebf5fb85310fff64d96e545c1deb9e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016201 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#747897}
-
Connie Wan authored
This is similar to crrev.com/c/2040060. I still don't have a repro for this crash, but the stack trace indicates that it's receiving an index that is out of bounds. Similar to in crrev.com/c/2040060, the change at line 2727 is to match previous behavior from before the crash: https://chromium-review.googlesource.com/c/chromium/src/+/1999088/10/chrome/browser/ui/views/tabs/tab_strip.cc#b1081 The addition at line 2742 is to catch any other possible -1s, since I don't have a repro. Bug: 1049240 Change-Id: I86baec38039cfac7b4d96815ffbbe14f01efa555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091594Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#747896}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/c3316f30c075..a66f68433ddd $ git log c3316f30c..a66f68433 --date=short --no-merges --format='%ad %ae %s' 2020-03-06 fayang gfe-relnote: In QUIC, let GetMinAckFrameSize use actual ack_frame instead of passed in largest_observed_length. Protected by gfe2_reloadable_flag_quic_use_ack_frame_to_get_min_size. 2020-03-05 danzh gfe-relnote: move stop/start accepting new connection feature from GfeQuicDispatcher to QuicDispatcher. Protected by --gfe2_restart_flag_quic_should_accept_new_connection. 2020-03-05 dschinazi Add --quic_versions to QuicToyServer and improve version parsing Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I8d3bf48892dcfb8e8ffce8c62f4d7f244bd7067f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091221 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#747895}
-
Eugene But authored
This CL adds user Actions for closing or tapping "Restore". These actions are helpful for Breadcrumbs feature that attaches steps to reproduce to crash reports. Bug: 1046231 Change-Id: I536c0de815a0bc0e4b14afe3c35ff06bc14474ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089860 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#747894}
-
Domenic Denicola authored
This plumbs the origin policy IDs from the net-side OriginPolicyContents through to the renderer, where they get exposed on Window. This does not yet tackle WorkerGlobalScope, but it does add idlharness tests for it, which fail for now. Bug: 1057123 Change-Id: Ie611f03bab99ccdaa6221733d9305cf2323a129e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089994 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#747893}
-
Becca Hughes authored
Media History needs to support incognito for Media Feeds. For an OTR profile we allow reads from the original profile but no writes. BUG=1051239 Change-Id: I03d152d6701ef034d4ce05d9970c64c720b22011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091592Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#747892}
-