- 24 Sep, 2018 40 commits
-
-
Thomas Tangl authored
This is a follow up to https://chromium-review.googlesource.com/1238499. The update of the sync settings during migration can happen at the same time as updating the sync settings because of a sync state change. To resolve inconsistencies in the configuration updates, the update method UpdateSyncSettingsIfPossible now takes different parameters. Bug: 886912, 887706 Change-Id: I27555172164b99332cdce101f79564e58cc05eff Reviewed-on: https://chromium-review.googlesource.com/1238572 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#593518}
-
Vaclav Brozek authored
The histograms PasswordManager.Android.PasswordCredentialEntry.Password and PasswordManager.Android.PasswordCredentialEntry.Username do have defined corresponding enums, but the histograms.xml file has a copy-paste mistake linking those to a wrong enum. This leads in wrong labels in the UMA dashboard. This CL corrects the association to the enum. It also replaces melandory@ with vabr@ as the owner of histograms for this area, because melandory@ changed teams last year. Bug: 885245 Change-Id: I0e53feb7c17ebbd63d9537bafa05fbd26138e728 Reviewed-on: https://chromium-review.googlesource.com/1236001Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593517}
-
Koji Ishii authored
Following bot results are included. 9879 9883 9888 9891 9892 9895 9904 9910 9914 9919 9924 9927 9935 9938 9949 9956 9960 9961 9962 9963 9965 9966 9967 9968 9969 9970 9973 9974 0 lines were removed and 3 lines were deflaked by consecutive results since 9960. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icc3b2264bc3de4cad3233357e76849fe8b4e14be Reviewed-on: https://chromium-review.googlesource.com/1235361 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#593516}
-
Thomas Tangl authored
The revoke reason kUserSignedOut should only be recorded when the user opted into unified consent before. This CL fixes this. Bug: 868892 Change-Id: I746ca040a554ec78599f16871e831acc11c7afcf Reviewed-on: https://chromium-review.googlesource.com/1238583Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#593515}
-
Nico Weber authored
Bug: 832676 Change-Id: I7b1fbbbc4cf83d470b81874e12fbda2b7a6a9194 Reviewed-on: https://chromium-review.googlesource.com/1240157Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593514}
-
François Beaufort authored
This CL makes sure we never show play/pause and scrim controls when there is no video in Picture-in-Picture window. Bug: 879529 Change-Id: I8d9ee5dcde24e9dc1b3e89af091c3385d338b046 Reviewed-on: https://chromium-review.googlesource.com/1235580 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#593513}
-
David Roger authored
The DCHECK was comparing emails by doing a simple string comparison. This is incorrect, because emails have to be normalized first. In particular emails are case insensitive. Bug: 882362 Change-Id: I1b0009bb1f6b77114638db250252d79126f2267d Reviewed-on: https://chromium-review.googlesource.com/1240295Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#593512}
-
Mikel Astiz authored
We no longer get crash reports so let's revert the changes introduced recently in: https://chromium-review.googlesource.com/1226602 https://chromium-review.googlesource.com/1230733 https://chromium-review.googlesource.com/1233707 It's not a strict revert because we leave some extra DCHECKs compared to prior state of affairs. Bug: 885019 Change-Id: I32c2fef753097a61f2c1471729b7fba20be251ed Reviewed-on: https://chromium-review.googlesource.com/1240298Reviewed-by:
-
Rune Lillesveen authored
Nested removes confuses the style traversal roots. Make this a general workaround for UA shadow removals. Bug: 888236, 888448 Change-Id: Ia0165e7478c96282900a8191eeac18ae34586a2c Reviewed-on: https://chromium-review.googlesource.com/1238728Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#593510}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/45ed33924d94..868fbbf41b33 git log 45ed33924d94..868fbbf41b33 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 perezju@chromium.org [pinpoint_cli] Add api.NewJob method Created with: gclient setdep -r src/third_party/catapult@868fbbf41b33 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: Ie764616faea478a10fa0a8ac199bfa63270ea01a Reviewed-on: https://chromium-review.googlesource.com/1239486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593509}
-
Philip Jägenstedt authored
A UUID is part of the failure message, so baselines cannot be added. TBR=jochen@chromium.org,estark@chromium.org Bug: 888470 Change-Id: I763f290fc4e13c485ed773d39985d2f0c454c896 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1240121Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#593508}
-
David Jean authored
This allows sign on promo to be dismissed properly wether BHVC or BHVC::searchController is presenting. Bug: 886548 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I19eace830c9021fdfc6d5f713d361aef0c7d912c Reviewed-on: https://chromium-review.googlesource.com/1238335 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#593507}
-
Olivier Robin authored
Tbr: mahmadi@chromium.org Bug: 881364 Change-Id: I763f982645697fb35a2691e96159904154030d08 Reviewed-on: https://chromium-review.googlesource.com/1238548Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593506}
-
Thomas Tangl authored
Bug: 811351 Change-Id: Id46b66bef4483cf2e34a42771fca6838109673ef Reviewed-on: https://chromium-review.googlesource.com/1225987 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#593505}
-
Thomas Tangl authored
Instead of synchronously invoking SyncService::OnUserChoseDatatypes in the UnifiedConsentService, a task is posted in the following cases: - When called through |SyncServiceObserver::OnStateChanged| - During Migration - During Rollback This fixes - A crash in SingleClientWalletSyncTest.DownloadAccountStorage_Card when UnifiedConsent is enabled. - Issues on the settings page for custom passphrase users (the page didn't refresh to visibly turn off the unified consent toggle). Bug: 886912, 887706 Change-Id: I4b97c9b862c7495a04e329f4b9f791e21fee693a Reviewed-on: https://chromium-review.googlesource.com/1238499 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Adds an async GC call to GCController which is used from asyncGC() during layout tests. Currently the async GC calls a regular V8 GC which schedules a precise Oilpan GC as followup. In a unified GC world a V8 GC runs both, V8's GC and Oilpan, with the difference that it has to conservatively scan the stack as Oilpan is not run from the event loop. This is fixed by posting a task and calling a V8 GC indicating that there's no relevant stack present. Bug: chromium:843903 Change-Id: I411d63df4aa61b51928aded86d998ad78af35a1e Reviewed-on: https://chromium-review.googlesource.com/1236074 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#593503}
-
Stephane Zermatten authored
This change forwards parameters taken from the Intent to SupportsSite and the initial GetAction requests. Ownership of parameters moves up to the controller, so it's available at the points where the requests for these RPCs are built. Bug: 806868 Change-Id: Id93c5d7d43997ba61fff10558bc010f9d859bbfd Reviewed-on: https://chromium-review.googlesource.com/1233534 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593502}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2f22d111..26fc9ad8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I51ff74af788ea8bd0a6ddd65a1d7876c9f0d1426 Reviewed-on: https://chromium-review.googlesource.com/1240179Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593501}
-
David Roger authored
Bug: 870912 Change-Id: Ic01425317b2c363a27e2edf9b98ae8f67684cb22 Reviewed-on: https://chromium-review.googlesource.com/1230738 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593500}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0ad0c27a0bce..645512ba5966 git log 0ad0c27a0bce..645512ba5966 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 asapersson@webrtc.org Add field trial to allow always using max layers. 2018-09-21 oprypin@webrtc.org Make Python-based performance tests output an empty result output.json 2018-09-21 oprypin@webrtc.org Make webrtc_perf_tests output an empty result output.json 2018-09-21 yvesg@webrtc.org Output 0 instead of NaN in perftest-output.json 2018-09-20 borenet@google.com Add extra logging to roll_deps.py Created with: gclient setdep -r src/third_party/webrtc@645512ba5966 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:885194 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I703605d9450e1e3ed49b3d68e57d67757612db54 Reviewed-on: https://chromium-review.googlesource.com/1239484Reviewed-by:
-
Uladzimir Miniailau authored
Bug: 456119 Change-Id: Ica459262d97b98832d1534000f70f38f47e1aac5 Reviewed-on: https://chromium-review.googlesource.com/1221228Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Cr-Commit-Position: refs/heads/master@{#593498}
-
Colin Blundell authored
This infrastructure is no longer used after https://chromium-review.googlesource.com/c/chromium/src/+/1228197. Bug: 883722 Change-Id: I9871ce8297ab42a8b173e61880570e076ae9277c Reviewed-on: https://chromium-review.googlesource.com/1235575 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=raymes@chromium.org Bug: v8:7295 v8:8015 Change-Id: Id9a5334b9e85e6f37200d4a89eb7b80eec444958 Reviewed-on: https://chromium-review.googlesource.com/1238156Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#593496}
-
Patrik Höglund authored
We only want to build targets related to WebRTC. Building all is troublesome because very few Chromium bots do that, and some peripheral targets become prone to breaking as a result. We don't have to specify binaries for bots with testers, in that case the builder will simply build what the tester requests. If there is no associated tester, the builder builds all targets by default, so override this default. Bug: 877018 Change-Id: Ie393d7d4390d2cd33f6ff7aec132f24047189c44 Reviewed-on: https://chromium-review.googlesource.com/1230014 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593495}
-
Philip Jägenstedt authored
TBR=fwang@igalia.com Bug: 888443 Change-Id: Ifdb189face0391bf54c63477aedc7c1bb7f78a22 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1240293Reviewed-by:
-
Dominik Röttsches authored
In https://chromium-review.googlesource.com/c/chromium/src/+/756213 PaintTypeface was introduced as one possible serialization approach for sending Typefaces over to the GPU process. This approach has been abandonded in favor of a new mechanism for serializing SkTypefaces over to the GPU process. Revert the PaintTypeface abstraction and introduce a SkTypeface_Factory class in Blink to centralize SkTypeface instantiation. No functional changes. Bug: 816445 Tbr: vmpstr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieb8843fb1888050f4c0d4bef3e99c6d4ffc85380 Reviewed-on: https://chromium-review.googlesource.com/1238540 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#593493}
-
Rune Lillesveen authored
Two of the MediaValues calculations ignored ScreenInfo when called from out-of-process iframes. There is no reason to do that. Just skip that check. Bug: 876760 Change-Id: I6d5139f9bcbaaac45c7fcaa764d84b41151a93a9 Reviewed-on: https://chromium-review.googlesource.com/1238542Reviewed-by:
-
Mihai Sardarescu authored
It looks like people_handler sets signinAllowed to false for guest profiles and sets it to true for regular profiles. This CL removes the comment as it was stale. Bug: 870239 Change-Id: Icb14df6d4ccfa916faeea3ddd30898e6dd1589ba Reviewed-on: https://chromium-review.googlesource.com/1238336Reviewed-by:
-
David 'Digit' Turner authored
This CL contains a few changes necessary for a future CL that will try to solve the dangling pointer issues associated with delayed RDebug list updates (see bug for details). + Make MemoryMapping own the corresponding memory mapping. This gets rid of ScopedMemoryMapping which is the only thing really used by the rest of the code. More importantly, this adds move semantics to MemoryMapping, which is used to pass ownership of a given mapping between different objects. + Simplify the ElfLoad::LoadAt() method used to map an ELF object in memory. Allow it to return a result object instead, that transfers ownership of the reserved address space range to the caller (instead of the hidden assumptions from the original code). + Modify SharedLibrary to use a MemoryMapping instance to hold the mapping of reserved address space, and add a ReleaseMapping() method which will be used in a future CL to transfer the mapping to a pending RDebug task object (this will ensure the mapping is only deallocated after the corresponding link_map_t entry is removed from the global list). + Bonus: Make ElfView use C++11 default initializers. BUG=831403 R=pasko@chromium.org, agrieve@chromium.org, rmcilroy@chromium.org Change-Id: I03e2447b81ad7f532b5c660f62a5958b00934b75 Reviewed-on: https://chromium-review.googlesource.com/1238897 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#593490}
-
Brian Salomon authored
These were initially set to 30s. However, memory usage on perf bots was not reduced to the previous values from before the GrContext flush count mechanism was removed. Bug: 883507 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iccf8c622f1aa3c2592e0f3f147a772878d7f8e72 Reviewed-on: https://chromium-review.googlesource.com/1236175Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#593489}
-
Peter E Conn authored
Now that Trusted Web Activities have moved over to be based on CustomTabActivity, we can remove some the code from the webapp classes. Bug: 871266 Change-Id: If2cc69b27e58bb83c14e682a9231df9f3c78d25d Reviewed-on: https://chromium-review.googlesource.com/1224116Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#593488}
-
Ben Wells authored
This adds two new fields: "create_shortcuts" and "launch_container". "create_shortcuts" is an optional boolean which controls whether OS level shortcuts are created. On Chrome OS this controls whether the app is pinned to the shelf. "launch_container" is a required string which can be "window" or "tab" and controls what sort of container the web app is launched in. The existing parameter was also renamed to remove the redundant "web_app" prefix and renamed to "app_url" to reflect that it can be any URL within the scope of the app that has a link to the manifest. The unused manifest URL parameter was also removed. Bug: 855281 Change-Id: Iff99e06cbd63334d2745fc587939fc15136586f6 Reviewed-on: https://chromium-review.googlesource.com/1237757Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#593487}
-
Zhongyi Shi authored
Change the HttpStreamFactory::JobController to mark alternative service broken until default network changes. Change the HttpStreamFactory::JobController to mark alternative service broken until default network changes iff TCP succeeds, QUIC fails on the defaut network but succeeds on the alternate network. The HttpServerProperties will clear the brokenness until default network changes. Bug: 790547 Change-Id: Ib33def42b474898879bf9e39567632ed273c5ca2 Reviewed-on: https://chromium-review.googlesource.com/1212142 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#593486}
-
Ned Nguyen authored
** PERF SHERIFF: this CL may cause perf graphs to regress but it's expected ** Includes shard's timing prediction help making debugging the sharding algorithm's performance easier. This CL also regenerate the shards to include the shards' predicted timing. Bug: 863768 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I084891d1d0fe05a555b88f692a65966bc31b740b No-Try: true # ios simulator flake Reviewed-on: https://chromium-review.googlesource.com/1214805 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#593485}
-
Marc Treib authored
When Sync switches from transport mode to feature mode, PersonalDataManager should switch from ephemeral to persistent storage for server credit cards. This adds a first integration test for that. Bug: 885211 Change-Id: I0ba6cbceb192b4e024d7c286e48a430ee9da2125 Reviewed-on: https://chromium-review.googlesource.com/1238334Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#593484}
-
Vaclav Brozek authored
This CL collects typos encountered during some work on the new PasswordForm parser. Bug: 883633 Change-Id: I7243aca6afa66d65039d1f049a16e6ee04cc4f53 Reviewed-on: https://chromium-review.googlesource.com/1236335Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593483}
-
Sergei Datsenko authored
Implement autocomplete, shared-with-me and available-offline queries based on the API provided by the DriveFS system service. BUG=chromium:854481 Change-Id: I0645bc57754fb7ad1663777647d1ff9ad21e79c4 Reviewed-on: https://chromium-review.googlesource.com/1235458 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#593482}
-
Ramin Halavati authored
kMediaEngagementSchemaVersion is removed from the list of preferences that are persieted if modified in incognito mode. Bug: 861722 Change-Id: Idb74a3d2013d74c5c7158a10aca1fb88b926c6db Reviewed-on: https://chromium-review.googlesource.com/1237974Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#593481}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae967aa5c481..c955a1645148 git log ae967aa5c481..c955a1645148 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 55e57f96fbf8..77db6f4af19f (1 commits) Created with: gclient setdep -r src/third_party/skia@c955a1645148 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I24592f5edbaf6fb4029d16d1f0523244084fae1e Reviewed-on: https://chromium-review.googlesource.com/1239482Reviewed-by:
-
David Grogan authored
When entering NG from legacy, we hadn't been marking the entry point's ConstraintSpace as an OrthogonalWritingModeRoot even when it was. The flag's absence was causing PercentageResolutionInlineSizeForParentWritingMode() to return incorrect values. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id2b24d7c4bb5e8303c70faa18dd696568203ec5a Reviewed-on: https://chromium-review.googlesource.com/1235121 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#593479}
-
