GitLab

BUG=142677
TEST=Re-ran tests to see passing result.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10830317
Patch from Kaitlin Renaud <krenaud@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151561 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yutak@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10825347

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151560 0039d316-1c4b-4281-b951-d872f2087c98

Looking at callers, it's safe to make the callback parameter mandatory
for GetEntryInfoByResourceId(), GetEntryInfoByPath(),
ReadDirectoryByPath(), as well as helper functions that implement these.
After all these functions are used to get information asynchronously,
hence it does not make sense to call them without the callback parameter.

BUG=126634
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10827326

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151558 0039d316-1c4b-4281-b951-d872f2087c98

This is effectively a partial revert of http://codereview.chromium.org/10542072/ for Lumpy devices, all other models remain unaffected because they don't have both the serial_number and Product_S/N keys in VPD.

Background: The serial_number VPD key (which would be the right source in an ideal world) returns a checksum-suffixed serial number on Lumpy devices that includes a trailing checksum character. That unfortunately causes trouble with the server side, which uses the non-suffixed serial number.

BUG=chromium:142681, chromium-os:31652
TEST=Check serial number reported on enterprise enrollment and used for auto-enrollment on Lumpy.

Review URL: https://chromiumcodereview.appspot.com/10830316

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/10826306

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151556 0039d316-1c4b-4281-b951-d872f2087c98

Don't try compensate for scrolling on the rect position.
This doesn't work anyway, and should be handled properly in WebCore.

BUG=141097


Review URL: https://chromiumcodereview.appspot.com/10832243

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142416
TEST=Verify that a canary build will re-check the version after an update check failure (usually error 12).

Review URL: https://chromiumcodereview.appspot.com/10830295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151553 0039d316-1c4b-4281-b951-d872f2087c98

I suggested here (crbug.com/132729#c8) a similar solution, where 'type' is one of 'extension',
'app', or 'theme', and then 'appType' is either 'hosted', 'packaged', or 'platform'.
I thought maybe this would save developers from having to write their own replacement of 'isApp'

BUG=132729

Review URL: https://chromiumcodereview.appspot.com/10825310

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151552 0039d316-1c4b-4281-b951-d872f2087c98

Also add some review nits (from crrev.com/151117).

BUG=138846

Review URL: https://chromiumcodereview.appspot.com/10831303

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141873
TEST=Try to disable or hide extension buttons, should not crash.


Review URL: https://chromiumcodereview.appspot.com/10826262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151550 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10828308

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151549 0039d316-1c4b-4281-b951-d872f2087c98

This CL reland CL http://codereview.chromium.org/10827284/. Previous CL was failed on some
interactive ui tests.

" When user signs out and transit to the login screen, the wallpaper fade in from a white screen.
  Described in 141563, this Cl fixed it.
  Also, after user login, or switch users at login screen. when wallpaper change, the new wallpaper
  should fade in nicely. There is a regression in recent builds. This fix fixed the regression as well. "

BUG=141563, 141676, 142042
TBR=nkostylev, sky

Review URL: https://chromiumcodereview.appspot.com/10834308

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151548 0039d316-1c4b-4281-b951-d872f2087c98

This CL upstreams two minor changes of crypto for iOS:
* nss_util.cc: On iOS, the default NSS root certificates need to be initialized when no persistent database is used.
* symmetric_key_unittest.cc: Turn off an OS X-specific code path for iOS.

Review URL: https://chromiumcodereview.appspot.com/10831307

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151545 0039d316-1c4b-4281-b951-d872f2087c98

Those darn .svn folders got me again.

TBR=kalman@chromium.org
BUG=142529

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151537

Review URL: https://chromiumcodereview.appspot.com/10832298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151544 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127748
TEST=manual and on bot


Review URL: https://chromiumcodereview.appspot.com/10834309

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151543 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140891


Review URL: https://chromiumcodereview.appspot.com/10830292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151542 0039d316-1c4b-4281-b951-d872f2087c98

Disable the permissions check for dev interfaces in the PPAPI proxy. We don't
currently use this check for anything, and it's breaking integrated Flash. We
will need to work on getting the permissions correct.

BUG=138902

Review URL: https://chromiumcodereview.appspot.com/10855152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151541 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141322


Review URL: https://chromiumcodereview.appspot.com/10836222

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151539 0039d316-1c4b-4281-b951-d872f2087c98

We should re-calculate the display layouts on the visibility change timing, since
it depends on the frame size which would be empty when invisible.

BUG=142055


Review URL: https://chromiumcodereview.appspot.com/10827317

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151538 0039d316-1c4b-4281-b951-d872f2087c98

Those darn .svn folders got me again.

TBR=kalman@chromium.org
BUG=142529


Review URL: https://chromiumcodereview.appspot.com/10832298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126224
TEST=tests pass under ASAN locally and on try bots


Review URL: https://chromiumcodereview.appspot.com/10837234

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151536 0039d316-1c4b-4281-b951-d872f2087c98

Since these classes are small, they can be all be moved in one cl without it
becoming overly large.

This one moves:
- ExtensionDataDeleter (now extensions::DataDeleter)
- ExtensionNavigationObserver (now extensions::NavigationObserver)
- PackExtensionJob
- PlatformAppBrowsertest
- ShellWindowRegistry
- ExtensionStartupUtil (see note in file)

BUG=117261
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151535 0039d316-1c4b-4281-b951-d872f2087c98

Added public LoadUrlExtraParams struct to hold all extra parameters to the
family of LoadURL functions, were extra means not in the definition of LoadURL.

Added LoadURLWithExtraParams and removed all other load functions except
LoadURL. Updated all call sites to use the new method.

Removed NavigationControllerWebView.

BUG=


Review URL: https://chromiumcodereview.appspot.com/10830144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151534 0039d316-1c4b-4281-b951-d872f2087c98

state. Specifically on a release they would cache MouseEvent::flags(),
which includes the buttons that were released. I've plumbed through
the ability to identify the button that was pressed/released.

I'll implement windows in a separate patch.

BUG=140102
TEST=none
R=ben@chromium.org, sadrul@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10830293

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151533 0039d316-1c4b-4281-b951-d872f2087c98

Now, to build with goma, you must:
1) Set $GOMA_DIR
2) Specify Goma in the path such as:
PATH=$GOMA_DIR/android/:$PATH ninja -j250 -C out/Release base_unittests_apk

"2)" above is necessary temporarily until the *_target variables are removed from build/android/envsetup.sh 

Review URL: https://chromiumcodereview.appspot.com/10834296

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151532 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10830308

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151531 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10826227

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151530 0039d316-1c4b-4281-b951-d872f2087c98

These files are not used on Android but were unnecessarily compiled.
They didn't affect binary size because they were removed during linker GC,
but excluding them may save build time, and help future modular exclusion.

BUG=none
TBR=ben,kbr,brettw,jar  (An Android only change to gyps)


Review URL: https://chromiumcodereview.appspot.com/10823291

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137351
TEST=none

TBR=oshima@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825349

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127323
TEST=Enabled tests for refactored panels on Linux


Review URL: https://chromiumcodereview.appspot.com/10831226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151526 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151525 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10829316

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151524 0039d316-1c4b-4281-b951-d872f2087c98

Move the corresponding cc files from content\test to be alongside their headers in content\public\test, now that DEPS supports fine-grained exceptions.

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/10826311

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151523 0039d316-1c4b-4281-b951-d872f2087c98

As PerformanceMonitor gets larger, it's appropriate to have an easy way of
turning it on in a build. This adds a commandline switch,
--run-performance-monitor.

BUG=130212


Review URL: https://chromiumcodereview.appspot.com/10827290

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151522 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142517


Review URL: https://chromiumcodereview.appspot.com/10829309

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151519 0039d316-1c4b-4281-b951-d872f2087c98

This also:
* Sends notification removal requests instead of directly removing notifications for removal by source
* Fixes a bug where clicking on a menu item outside the bubble would close the buble and not trigger the menu event

BUG=139697
For chrome/browser/ui/views/ash/balloon_collection_impl_ash.cc:
TBR=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10855113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151518 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r151502.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151517 0039d316-1c4b-4281-b951-d872f2087c98

The link for the page you are on will now be hightlighted in the left nav bar.

BUG=142008

Review URL: https://chromiumcodereview.appspot.com/10827304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151516 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151515 0039d316-1c4b-4281-b951-d872f2087c98