- 20 Sep, 2019 40 commits
-
-
Eric Karl authored
VerifyFitsInBytesInternal would return false if a size/format combo had a size in *bits* that overflowed the requested type, even if the final size in *bytes* fit. Updated the logic to handle this. Additionally, Maybe(Width|Size)InBytes would crash if width overflowed, also fixed and test added. Bug: 1002855 Change-Id: I1fde167f17fdddfbcf4f9269e8a681a062d9ff05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803831 Commit-Queue: Eric Karl <ericrk@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#698592}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a4592ef724c8..e63bdb69ecd3 Created with: gclient setdep -r src-internal@e63bdb69ecd3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1003454 Change-Id: I3775930d909c9d12036c0c141f1076ca2eab72fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816981Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698591}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9a9841178078..2ab109212f0f git log 9a9841178078..2ab109212f0f --date=short --no-merges --format='%ad %ae %s' 2019-09-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-20 brianosman@google.com added support for user-defined functions to GrSKSLFP 2019-09-20 robertphillips@google.com Remove a usage of GrPixelConfig in SkGpuBlurUtils::GaussianBlur (take 2) 2019-09-20 ethannicholas@google.com Revert "added support for SkSL unpremul function" 2019-09-20 vasilyt@chromium.org Added missed ETC2 case to GrVkFormatColorTypePairIsValid 2019-09-20 reed@google.com call Graphics Init() to get faster asm 2019-09-20 brianosman@google.com Reland "Use saveLayer-determined CT in SkGpuDevice::onCreateDevice" 2019-09-20 ethannicholas@google.com regenerated fragment processors to make bot happy 2019-09-20 brianosman@google.com Revert "Use saveLayer-determined CT in SkGpuDevice::onCreateDevice" 2019-09-20 nifong@google.com Added functions supporting a resource view for images in the debugger. 2019-09-20 brianosman@google.com Use saveLayer-determined CT in SkGpuDevice::onCreateDevice 2019-09-20 brianosman@google.com Run gn format 2019-09-20 brianosman@google.com Use 64 bit shift to make MSVC happy 2019-09-20 ethannicholas@google.com added support for SkSL unpremul function Created with: gclient setdep -r src/third_party/skia@2ab109212f0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I773939d19cb941a0cac502736d7d617051095013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815696Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698590}
-
Nick Burris authored
Dismiss the text fragment anchor highlighting on a click/tap, as long as any of the highlights are in view, to reduce the chance of an accidental dismissal. Bug: 995381 Change-Id: Ic06ecc38842bdbd6a084141a186d4bdc8b783dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809511Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#698589}
-
Tarun Bansal authored
This histogram is no longer in use. Change-Id: I0ceb27f32bc8036fa5308420c6f07daba1992fc7 Bug: 984242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815720Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#698588}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I6036e618f71cffc9af53f1876c73919b2d169f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808074 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698587}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ib99bb44747bdc233ab6dfae6cf95ad50446e4a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808225Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698586}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ief888af8c4fb5f6f9aa97cdf0dcd051733bf8e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815990 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#698585}
-
John Lee authored
Bug: 989131 Change-Id: Ia551767693a7ebcda664bb6bff5cf6755379a02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807655 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#698584}
-
Min Qin authored
For incognito, we need to ensure the DownloadOfflineContentProvider is up when incognito profile is created. BUG=1006126, 1006128 Change-Id: I48e1717210b42e16031bd42eccf6f4d1c1f17fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816958 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#698583}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ib8ef0708f821c93d9ad32c9d4134f7bd598e8ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815996 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#698582}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef83cc5458bf..03bbef5e1f40 git log ef83cc5458bf..03bbef5e1f40 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 kron@webrtc.org Fix accidental change of transport time metric 2019-09-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 303c57cf..230cc8f7 (698351:698466) 2019-09-20 asapersson@webrtc.org Remove obsolete todo comment in simulcast.h 2019-09-20 nisse@webrtc.org Delete isac GetBandwidthInfo/SetBandwidthInfo Created with: gclient setdep -r src/third_party/webrtc@03bbef5e1f40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:none Change-Id: I3a57f8e349eda6fba4f32a85a1d611128a490195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816977Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698581}
-
Toby Huang authored
Currently in the Add Supervision dialog, ChromeVox narrates Add Supervision which isn't very clear about what the dialog is intended for. This CL changes the name of the window title to Set Up Parental Controls so that screen reader users can better understand what the dialog is about. Bug: 1005303 Change-Id: I00592e08f7ed42efb88fec9478fcc74f851552da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811875 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#698580}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ibd7c49482e715668fc996257cd8eb727612b68d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808306Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698579}
-
Ted Choc authored
TBR=dtrainor@chromium.org BUG= Change-Id: Ic1d7893984612cc8d5a7ffb4ca40ce6879c4cd86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816189Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#698578}
-
Yuta Kasai authored
This just fixes typo in the test. Bug: 678905 Change-Id: I21a323edeb0691759bbbc940c583bb537b66f258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815924 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#698577}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2425b4f2..7edc2d63 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2ff8111c82ff46e08c83b500c804c4ed37084900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816786Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698576}
-
Charlene Yan authored
Bug: 1005618 Change-Id: I379360ea93312f7d6a3b0d9005b2b6895ac22b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816717Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#698575}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b762286def9..e0aac4191fbd git log 8b762286def9..e0aac4191fbd --date=short --no-merges --format='%ad %ae %s' 2019-09-20 lamontjones@chromium.org OWNERS.ci: add lamontjones@ Created with: gclient setdep -r src/third_party/chromite@e0aac4191fbd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1f3b93ca838456aa2d9ee477e14484cee79e6375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815692Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698574}
-
benjamin joyce authored
This reverts commit b5af1d8d. Reason for revert: instrumentation registry isn't working on other builders. https://ci.chromium.org/p/chromium/builders/ci/Mojo%20Android/19484 Original change's description: > Update test filters to androidx. > > Bug: 1005891 > Change-Id: If459301ac9a4b419cdbd487222754d19767f24ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814691 > Reviewed-by: Yuwei Huang <yuweih@chromium.org> > Commit-Queue: benjamin joyce <bjoyce@google.com> > Cr-Commit-Position: refs/heads/master@{#698246} TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,garykac@chromium.org,joedow@chromium.org,yuweih@chromium.org,bjoyce@google.com Change-Id: Ib8b6bdb9e1b98973ab1e7f2cc2f5b34336097cbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1005891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816361Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#698573}
-
Anubha Mathur authored
Add aria labels for the dialog and the prompt https://imgur.com/a/UsQs5lG Bug: 963183 Change-Id: I4bcdf4e1c9fb6fc853fe345ecd77ba2adc255f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718606 Commit-Queue: Anubha Mathur <anubmat@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#698572}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: If61a2791abc8654628acb5ed45185394256db72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808170Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#698571}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d7f28aae3d89..dd4a00a06d01 git log d7f28aae3d89..dd4a00a06d01 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 jmadill@chromium.org Vulkan: Track resource usage via counter. Created with: gclient setdep -r src/third_party/angle@dd4a00a06d01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: I641dfb982da51d2fc8f50cd97e2568d22ae3a341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815691Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698570}
-
Peter Kasting authored
WS_EX_TRANSPARENT only seems to mean "pass events to the underlying window" when the windows in question is also WS_EX_LAYERED. Bug: 1004721 Change-Id: Ia2618ddfa9c16a49fd8eb156ab0c7793736bce0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816745 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698569}
-
Ryan Daum authored
* Original CL was missing a single and critical line. * This CL also adds unit tests to verify. Bug: internal b/138446155 Bug: internal b/141369532 Test: manual and unit test Change-Id: I99707882c716fc371aa28aa29700f85eecb26638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816534Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#698568}
-
Sammie Quon authored
Tablet mode has a performance feature which takes a screenshot to fully occlude all windows while the top window is animating. This CL adds a test suite to test the feature, including a regression test for a recently found regression. Test: added tests Bug: 1002735 Change-Id: I712ecdb3778f720fa55b6cbcf34773caca0c1f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815229Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#698567}
-
Miguel Casas authored
This CL restricts //media/gpu:image_processor and :video_frame_mapper to ChromeOS and ChromeCast, since they are only implemented for these platforms. Same for image_processor_test. video_frame_file_writer.cc sandwiched some uses of |video_frame_mapper_| in an OS_LINUX and left others unprotected, which confused OS_WIN builds. This CL changes those to if defined(OS_CHROMEOS), since I don't think this file is meant to be compiled nor run on OS_LINUX. Change-Id: I8098d55859c50a752b40a63955684e558db3582a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787467 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#698566}
-
Peter Kasting authored
Bug: 82078 Change-Id: Iede861b1cf4680d52f3dc1f298ca5f6ec8f398f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815574 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#698565}
-
Ken Rockot authored
This reverts commit 749dcc3b. Reason for revert: Inexplicable Fuchsia failures https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8901777180770604000/+/steps/content_unittests/0/logs/Deterministic_failure:_SessionStorageContextMojoTest.Scavenging__status_FAILURE_/0 Original change's description: > Move File Service off Service Manager > > This is a first step towards eliminating the File Service and migrating > DOM Storage code into the Storage Service. > > File Service and its only clients (DOM storage objects) are moved off of > Service Manager APIs. LocalStorageContextMojo and > SessionStorageContextMojo are changed to own their own FileService > instance, now constructed directly over a directory path. > > No functional changes intended in this CL. > > Bug: 994911,977637 > Change-Id: I2ffd0bef670304a0dc3c103981139603521a14ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778801 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698487} TBR=avi@chromium.org,rockot@google.com,mek@chromium.org,rsesek@chromium.org Change-Id: I62995f899ebb399f929b1a95d415a79d675480e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 994911, 977637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815727Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#698564}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I30a06cf2cfc7c4a835c1d4094be4a598ab354714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808458 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#698563}
-
Tiancong Wang authored
We want to move AFDO bits from Chrome OS into Chromium. Chrome OS currently chooses default AFDO profile from different profiles for different architectures, so we need to add a new GN arg to support it. By default, Chrome OS is not using AFDO. Bug: chromium:1001227 Test: Chrome builds without AFDO, without new flags Test: Chrome builds with silvermont AFDO with clang_use_default_sample_profile=True Test: Chrome builds with broadwell AFDO with clang_use_default_sample_profile=True and chromeos_select_default_profile_from_platforms="broadwell" Change-Id: I08d1fa88e5737453b320093dd410e3a6488e17ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814319Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tiancong Wang <tcwang@google.com> Cr-Commit-Position: refs/heads/master@{#698562}
-
Bettina authored
Creating an experiment to allow sending sample pings of allowlist domains to Safe Browsing. Also updating the request proto to specify if it's a full or sample ping. Bug: 953106 Change-Id: Iedf4ec390fca9697c2d57c001e7f46a5e8fa4b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814957 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#698561}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ib9f751d6eea63492d15b317c9c4551da8c3fb78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816531Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#698560}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ic8de8a1fa2a2b84d09b0eb96590bf59cd475c3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808408 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#698559}
-
Fredrik Söderquist authored
First eliminate the |equals_minimum_ok| variable, and always pass true when searching the 'begin' instance list. Since currently the only way to set this to false is for the first interval, and for that interval we always start searching for the first instance time greater than Earliest(), we can make it always be true without problem. We also recognize zero-length intervals are not of any interest, as indicated by the: first && temp_begin == temp_end... and !first && temp_end == interval_.end clauses (note that |begin_after| == |interval_.end| when !first, and thus if |temp_begin| ends up being equal to |interval_.end| this is essentially checking that the interval isn't zero-length). Thus we can always look for an 'end' instance that is greater than |temp_begin| directly rather than checking for one that is potentially equal. This should also mean that any newly found end time (as we loop) will never equal the previous end that we got - allowing us to drop the |last_interval_temp_end| construct. Because we should no longer get zero-length intervals, we can drop the special case for temp_begin == 0 and temp_end == 0 (zero-length first interval that starts [and ends] at t=0). Bug: 998526 Change-Id: I4d27372b50d24879af91bd35d7156c5bf9a1271d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816547Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#698558}
-
Dana Fried authored
Was originally a bunch of per-file but I've written half the folder at this point, so... Change-Id: I0b2c5e4315a93133ca4294d831503ab1a1bb3e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815666Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#698557}
-
Eric Stevenson authored
This CL was partially generated by //base/android/jni_generator/jni_refactorer.py. Two classes converted in this CL: * UrlUtilities.java * DevUiModuleProvider.java The tests were manually refactored to not use robolectric shadows for UrlUtilities native methods. Bug: 929661 Change-Id: Id3fbe2f7e53f3c0aa454aa51e1e94a2a6f0f1cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815344Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#698556}
-
Ken MacKay authored
* Get rid of MixerServiceConnectionFactory * Factor out code common to all (future) types of connections into MixerConnection, and rename MixerServiceConnection to OutputStreamConnection (which is based on MixerConnection). * Move common message-handling code out of OutputStreamConnection into MixerSocket. * Move type conversion code into a common file. Bug: internal b/127963522 Test: on device Merge-With: eureka-internal/313198 Change-Id: I7fa02b1d077a4eb7347728b4673cdea83e4597fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804681 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#698555}
-
Abhishek Bhardwaj authored
This change adds a hard timeout to the class that performs the update check. This is done to keep the logic running in case update engine dies or is stuck waiting for network or any other event. BUG=924762 TEST=Unit tests. Change-Id: I673dee89fbfef46568741fe82bda76ed9e1c1543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759518Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#698554}
-
Steven Bennetts authored
This CL: * Makes |type| a required member of ConfigProperties and fixes the existing calls to SetProperties. * Fixes SetProperties to support setting of EAP properties. Includes calling CreateConfiguration instead of SetProperties when necessary. This will fix issue 983890. * Introduces ConfigureNetwork to cros_network_config.mojom using the same ConfigProperties dictionary as SetProperties. Migrating the network configuration WebUI to use ConfigureNetwork will be done in a follow-up. For chromeos/user_manager deps addition (indirect dependencies exist): TBR=xiyuan@chromium.org Bug: 1001598, 983890 Change-Id: Ib02f6a40dd01ae90db57574d7bbf83e21666541f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808085Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#698553}
-