GitLab

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6541014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75457 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59945, 59946
TEST=trybots

Review URL: http://codereview.chromium.org/6538053

TBR=tfarina@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75456 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6542031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75455 0039d316-1c4b-4281-b951-d872f2087c98

Regression was introduced in CL  http://codereview.chromium.org/6334101  

BUG=73353
TEST=None

Review URL: http://codereview.chromium.org/6544020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59945, 59946
TEST=trybots

Review URL: http://codereview.chromium.org/6538053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75453 0039d316-1c4b-4281-b951-d872f2087c98

Previously tests had to manually call MockFFmpeg::set() during test setup and teardown.  Now that operation is handled automatically via scoping.

BUG=72933
TEST=media_unittests
Review URL: http://codereview.chromium.org/6539021

TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/6541037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75448 0039d316-1c4b-4281-b951-d872f2087c98

This avoids abusing a histogram to keep both counts and times (this histogram stores only times) and lets us see the full distribution.

BUG=71256
TEST=

Review URL: http://codereview.chromium.org/6547001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75447 0039d316-1c4b-4281-b951-d872f2087c98

weakserverkey.patch have been upstreamed.  SSL_ERROR_WEAK_SERVER_KEY
has been renamed SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY.  Pick up
fixes for two bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=586697
- https://bugzilla.mozilla.org/show_bug.cgi?id=588698

R=agl
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6487026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75446 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r75443.

TBR=akalin

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75445 0039d316-1c4b-4281-b951-d872f2087c98

Previously tests had to manually call MockFFmpeg::set() during test setup and teardown.  Now that operation is handled automatically via scoping.

BUG=72933
TEST=media_unittests
Review URL: http://codereview.chromium.org/6539021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75444 0039d316-1c4b-4281-b951-d872f2087c98

We can re-inline later if it starts being an issue.

BUG=none
TEST=unit-tests

Review URL: http://codereview.chromium.org/6542026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75443 0039d316-1c4b-4281-b951-d872f2087c98

ChromeDriver. The args parameter should be a ListValue, not a string.
Also, the args parameter is not optional; if no args are
provided in the request, an error should be returned (the handler was
defaulting to an empty list).
Patch by jleyba@chromium.org.
Original review at http://codereview.chromium.org/6544003
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6542025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75442 0039d316-1c4b-4281-b951-d872f2087c98

Log the number of objects in a Pack when it is deleted in debug builds to help JS app developers find leaks.

TEST=used it in a JS app to help identify a leak
BUG=none
Review URL: http://codereview.chromium.org/6542028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6538060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75439 0039d316-1c4b-4281-b951-d872f2087c98

The AccessLog class was something we added to track down a crash,
which is no longer happening after that change. Reverting piece by
piece and waiting for the next canary build before doing the next
part.

Note that the use of the AccessLog class could have introduced slight
serialization to the method
URLRequestThrottlerManager::RegisterRequestUrl as it would call the
AccessLog::Add method which synchronized on a lock. So removing is not
100% safe; I will watch for crashes in the canary builds after this.

BUG=71721
TEST=none

Review URL: http://codereview.chromium.org/6538061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75438 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73100
TEST=trybots

Review URL: http://codereview.chromium.org/6538008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75434 0039d316-1c4b-4281-b951-d872f2087c98

Creates a new internal page for listing recent reported crashes, to make it easier for users to report crashes, or get crash IDs when asked in bug reports.

Won't yet display any crashes on Windows, since the breakpad side is not yet done on Windows.

BUG=41106
TEST=Visit chrome://crashes; depending on the build type, platform, and metric pref state, it should display crashes or an informative message.

Review URL: http://codereview.chromium.org/6545001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75433 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/73137
TEST=see bug
TBR=sky


Review URL: http://codereview.chromium.org/6525055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75432 0039d316-1c4b-4281-b951-d872f2087c98

This results in some code duplication right now but this will be mitigated once all platforms use WidgetImpl.

http://crbug.com/72040
TEST=existing tests

Review URL: http://codereview.chromium.org/6507028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75431 0039d316-1c4b-4281-b951-d872f2087c98

their CPU consumption.

The new interval is 1000 ms, or once per second. We can easily adjust
this value up or down, but this seems like a reasonable value to judge
the compatibility impact of this change.

BUG=66078
TEST=none (tested manually with minimal test case)

Review URL: http://codereview.chromium.org/6546021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75430 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73357
TEST=Get an infobar to show. Open Tab Overview/Tabpose. Everything looks correct.

Review URL: http://codereview.chromium.org/6543012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75429 0039d316-1c4b-4281-b951-d872f2087c98

The bookmark folder menus look bad when squeezed up against the bottom of a screen. 
Detect this case and automatically switch to showing the menu above the button in this case. 
BUG=69996
TEST=bookmark_bar_folder_controller_unittest.mm

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75342
Review URL: http://codereview.chromium.org/6469044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75428 0039d316-1c4b-4281-b951-d872f2087c98

fixes parts of bug http://code.google.com/p/chromium/issues/detail?id=55764

On IE9 a border is still drawn around all mshtml windows, which does not happen with ChromeFrame.
This needs more investigation.

BUG=55764
TEST=Launch IE9 and navigate to a ChromeFrame enabled page. The ChromeFrame page should not
     have a client edge border.

Review URL: http://codereview.chromium.org/6531022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75427 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75421 0039d316-1c4b-4281-b951-d872f2087c98

This allows JAWS to fully support text editing.

BUG=none
TEST=manual testing with JAWS screenreader

Review URL: http://codereview.chromium.org/6469037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=chromoting UI manual tests

Review URL: http://codereview.chromium.org/6518013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75417 0039d316-1c4b-4281-b951-d872f2087c98

children of text fields from the renderer to the browser. The child containing
the text appeared to be redundant anyway.

BUG=none
TEST=updated unit test, manual testing with screen readers

Review URL: http://codereview.chromium.org/6469038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75416 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6544016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75415 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/6286092/

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6349101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75414 0039d316-1c4b-4281-b951-d872f2087c98

Disabling Autofill test, autofill.AutoFillTest.testFilterMalformedEmailAddresses, as it's failing on Windows pyauto bots. 

BUG=73439
TEST=none

Review URL: http://codereview.chromium.org/6469058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75413 0039d316-1c4b-4281-b951-d872f2087c98

Add product-specific flags to the rename command in the registry.  This fixes a regression that prevented in-place upgrades of Chrome Frame from working.

BUG=73329
TEST=Follow the steps in the bug.  Between steps 4 and 5, check that the "cmd" registry value in HKLM\Software\Google\Update\Clients\{8BA986DA-5100-405E-AA35-86F34A02ACBF} contains "--chrome-frame".

Review URL: http://codereview.chromium.org/6541029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75412 0039d316-1c4b-4281-b951-d872f2087c98

Fix breakpad compilation on ubuntu 10.10.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6546023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75411 0039d316-1c4b-4281-b951-d872f2087c98

Revert 75405 - Register Application Restart with Windows Restart Manager on browser_main startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring.

BUG=70824
TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments.

Review URL: http://codereview.chromium.org/6462024

TBR=msw@chromium.org
Review URL: http://codereview.chromium.org/6538059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75410 0039d316-1c4b-4281-b951-d872f2087c98

Revert 75399 - Revert 75371 - Try to fix the Win Builder (dbg)(shared) build break by adding a dependency from content_browser to WebKit.gyp (TabContents uses WebView's zoom constants and helper functions).

TBR=avi
Review URL: http://codereview.chromium.org/6546013

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/6538058

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/6541028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75406 0039d316-1c4b-4281-b951-d872f2087c98

Register Application Restart with Windows Restart Manager on browser_main startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring.

BUG=70824
TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments.

Review URL: http://codereview.chromium.org/6462024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75405 0039d316-1c4b-4281-b951-d872f2087c98

tabs are brought to the foreground and sent to the background.

This CL does not actually increase the background timer interval. That
will be done separately, so that it can easily be reverted without
removing all of the associated code.

BUG=66078
TEST=none (tested manually with minimal test case)

Review URL: http://codereview.chromium.org/6532012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75404 0039d316-1c4b-4281-b951-d872f2087c98

Refactor WebResourceService class, making it more generic.  Move all the promo-related code into a new PromoResourceService class that inherits WebResourceService.

This refactoring will allow us to re-use WebResourceService class for GPU Blacklist updates purpose.

This CL tries to minimize the code change and adds no new logic.

BUG=68802
TEST=unittest,promo functions working fine as before.

Review URL: http://codereview.chromium.org/6542003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75403 0039d316-1c4b-4281-b951-d872f2087c98

Enable two histograms for measurement:
    - measure PLT differences
    - measure SSL_Connect_Latency conditioned on the test.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6544004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75402 0039d316-1c4b-4281-b951-d872f2087c98

Fix a regression when switching the options pane to use Dom UI: when a user clicks the "Make Chrome my default browser" button, we should reset the browser.check_default_browser to true.

BUG=73208
TEST=Follow steps listed in bug, observe that the infobar again shows up.

Review URL: http://codereview.chromium.org/6542018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75401 0039d316-1c4b-4281-b951-d872f2087c98

Instead, DownloadFileManager puts the DownloadFile in a new map when it has the final name.

This is a step towards moving the 'final rename' determination happen in the UI thread.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6480079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75400 0039d316-1c4b-4281-b951-d872f2087c98