- 03 Apr, 2019 31 commits
-
-
Dominic Mazzoni authored
Promote katie to an owner of nearly all accessibility code. She's always free to delegate or decline if she's not the best reviewer. Add jamescook as an owner of the aura and views accessibility code, because we need an additional reviewer for mash accessibility work who's familiar with both mash and accessibility. Bug: none Change-Id: I1f820bf186538a5a3eb92d05603497f21bb53bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549883Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#647070}
-
Rakib M. Hasan authored
Bug: chromium:698902 Change-Id: I26642411cc6ff1ac879188cc5fe6b4b61374c923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549617Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#647069}
-
Karan Bhatia authored
r609787 changed the web request API to require host permissions to the initiator and added the Extensions.WebRequest.InitiatorAccess2 histogram. The change landed in M72 and the histogram values look as expected - in only around 0.77% cases the extension doesn't have access to the request's initiator given it has access to the request url. Deprecate the histogram since it should no longer be needed. BUG=948330 Change-Id: I0ae27db39dc4d6e05c36d360a4213ff407eaac03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548598Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#647068}
-
James Darpinian authored
This fixes WebGL conformance test: incompatible-texture-type-for-sampler.html ES 3 implementations don't like us specifying unsized formats GL_RED/GL_RG as the internalformat for 3D and ARRAY textures. We need to specify sized formats such as GL_R8 or GL_RG16F instead. Bug: 947236 Change-Id: I628d79e8ceb4262ef42d5eed9f031e457cab78aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545512 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
-
Azeem Arshad authored
The "Get Data Connection" toggle in the Mobile Data settings section toggles Instant Tethering. Clicking the label seems to be working but clicking the toggle button directly is broken since the toggle component stops propagation of click events from it. This CL fixes this by adding an on-change listener for the toggle as well. Bug: 947300 Change-Id: I1bafe1573722c12c874b402e4fd6c5e9a9beee6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549747Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#647066}
-
Andrey Kosyakov authored
This explicitly disables DevTools interception for data: URLs to maintain the existing behavior for DevTools clients following other kinds of interception being enabled for data: URL navigation by https://chromium-review.googlesource.com/c/chromium/src/+/1541086 Change-Id: I93c7eb76236f00128688629c1aec3429b0000659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549884 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#647065}
-
Xianzhu Wang authored
Because of floating point errors, the fast path and slow path can't always create the same result. Previously we tolerated non-empty cases, now also tolerate empty cases. Bug: 947803 Change-Id: I3b444ea1bb58ede0daa4546be6d161a65d6b4907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548546Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#647064}
-
Tarun Bansal authored
The two fields are custom_proxy_use_alternate_proxy_list and alternate_rules. These fields were added to support proxying different types of requests through different types of Data Reduction Proxies (DRP). e.g., only some of the DRP proxies supported video compression. However, these specific proxying rules are not required anymore. Change-Id: If4d1d8eff11013b979d882590a3d498434b834dd Bug: 945364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546641 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#647063}
-
James Darpinian authored
Looks like all video tests are potentially flaky on Android. Luckily, flakes are relatively rare. TBR: kbr@chromium.org Bug: 948894 Change-Id: I988321c905799630df018596ea01d54629d3a785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549889Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#647062}
-
Xiaohui Chen authored
Remove use of IdentityManager::GetPrimaryAccountInfoDeprecated(). Now check the email address instead of hosted domain. Bug: None Test: locally build and run Change-Id: I3cf55fdebfb8a8104686ff32e4388a3ef21391d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549891Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#647061}
-
Scott Chen authored
Bug: None Change-Id: I2ae4e095e0ed7ec8c0f18712570e576315970778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549694Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#647060}
-
Yuly Novikov authored
conformance/extensions/oes-vertex-array-object.html conformance2/vertex_arrays/vertex-array-object.html Fixed by https://chromium-review.googlesource.com/c/angle/angle/+/1545009 Bug: 920033, 920265 Change-Id: Idb3f5706dff468ecfe593e95c2d9689d90755435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546681 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Raymes Khoury authored
This feature has been enabled by default for several milestones. Change-Id: Iafafde408d3163bc5f09b13e08079e780369d6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531890 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#647058}
-
Alex Moshchuk authored
NOTRY=True TBR=cmp@chromium.org Bug: 947667 Change-Id: I8b6ea8ffb34d56305e78ab3c657ba66a8fe3eb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549989Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#647057}
-
danakj authored
These tests already fail with the legacy codepath that was bitrotting and deleted, they timeout now. But can be fixed when/if android layout tests get prioritized. TBR=piman@chromium.org Bug: 947542 Change-Id: I2758ffb8ff281b12e97a89071c103af72d04b57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545168Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#647056}
-
Tarun Bansal authored
Clean up the code around: 1. Probing aka Connection robustness 2. Not bypass on missing via headers This does not do the full cleanup. So, there are still some places that can be cleaned up. Change-Id: I3f49ae2b9b0a547470a031ba302879bb23200ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547067Reviewed-by:
-
Lan Wei authored
In test_driver actions API, for mouse clicks, if the two clicks' time interval and two click location range is small enough, we will set the click count to 2 and generate double click event. This CL fixes these tests: webdriver/tests/perform_actions/pointer_pause_dblclick.py webdriver/tests/perform_actions/pointer_dblclick.py Bug: chromedriver:1897 Change-Id: Id147cbb83cb7e39b8240ce126e87fd217e25d263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549561 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#647054}
-
Min Qin authored
The test fails because we call DownloadManager::GetAllDownloads() too fast. Change the ordering for the dangerous download to start first, then call DownloadManager::GetAllDownloads(). BUG=948223 Change-Id: I60a73eb138598fc90afaed9fc991e634b30f52dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546065Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#647053}
-
Lukasz Anforowicz authored
Bug: 948434 Bug: 948433 Bug: 948702 Change-Id: I69b9cb6295d553b61a0044064d62388999bd12cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549890 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
rbpotter authored
Some interactive_ui_tests were disabled on all platforms, but are in fact only flaky on Windows due to https://crbug.com/711256. Re-enable these tests on other platforms. Other Web UI tests are still enabled but continuing to flake on Windows for the same reason; disable these tests on Windows also. Modification to original: Keep CrExtensionsOptionsPageTest.All disabled on all platforms, since it appears to still be flaky. Note: If tests begin flaking after this CL lands, please disable only the flaky tests if possible, rather than reverting the entire CL, so that the test coverage being restored by this CL can be retained. Bug: 711256, 945630 Change-Id: I6a3026a9f152d29515c39a94fafe4c526096909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547958 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
David Bertoni authored
Bug: 946604 Change-Id: Ie2afed378e47f366fd6e48c12a46966f75a38e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545501 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#647050}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I0626f90d9803af20c2d6c6fc1367ac76267af70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549568Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#647049}
-
Nate Fischer authored
This CL includes miscellaneous fixes/improvements to remove_preinstalled_webview.py. First, this modifies the remove_preinstalled_webview.py script to provide actionable error output when using it on an emulator (these have the special requirement that they're started with the '-writeable-system' flag). This adds logic to catch the case where the script fails (for whatever reason) to uninstall a WebView APK. This also fixes a bug where we didn't correctly uninstall app updates, since we would return early if 'com.android.webview' was not either not updated or not installed, rather than continuing forward to uninstall 'com.google.android.webview'. This fixes another bug, where the script specifies directory paths for preinstalled APKs, but actually needed full paths (including the APK's filename at the end). This also updates the script to use a new Devil API (device_utils.SetWebViewFallbackLogic()) and uses common logging configuration. Bug: 922228, 929892 Test: Manual Change-Id: I074cd4b53b0dc57e214489aba54fd63d1c54a73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545684Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#647048}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/66ae531590ae..1af744b57c87 git log 66ae531590ae..1af744b57c87 --date=short --no-merges --format='%ad %ae %s' 2019-04-02 jgilbert@mozilla.com Windows SDK includes need to be lowercase for MinGW builds. 2019-04-02 syoussefi@chromium.org Vulkan: glClearBuffer* implementation 2019-04-02 jonahr@google.com Ignore flaky dEQP failures on Windows Created with: gclient setdep -r src/third_party/angle@1af744b57c87 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ib48d5a4316d367d77de366ef6b71cfa8bd6989c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549349Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647047}
-
rbpotter authored
The plugin was made non tab focusable due to https://crbug.com/455552. This bug no longer exists even with a tab focusable plugin in the new Print Preview, since the overlays are now modal cr-dialogs, and keyboard users currently cannot access the zoom/fit to page fab buttons in the PDF viewer in Print Preview. Make the plugin tab focusable to fix this issue. Also ensure that fab button strip becomes visible when focused. Bug: 892675 Change-Id: Id2860a48c9c9eb64a591d8318c4f1e0390554099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548146Reviewed-by:
-
Jason Chase authored
When the HTML imports feature is only enabled by origin trial (i.e. the the runtime flag is disabled), import links are processed correctly in the main document. However, import links inside an imported document were not processed. This CL addresses a number of issues: - In HTMLLinkElement::LinkResourceToProcess(), rel=import would actually be handled as CSS, if HTML imports was not enabled. - In HTMLLinkElement::LinkResourceToProcess(), the OriginTrialContext was not yet created in imported documents, so enabled checks would always fail. - Imported documents are not expected to have trial tokens, so the features would not be enabled. Bug: 939465 Change-Id: Ibf6985ffba7311bf90f7449ff9a065e7b84fdc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546420Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#647045}
-
Ian Wells authored
This change adds new fields to the pages and thumbnails tables. Bug: 841516 Change-Id: I79144f0debb3d4ffdc067ee9299b5bb6af4bfe9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549687 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#647044}
-
Fabrice de Gans-Riberi authored
* Implements the fuchsia.web.MessagePort API in MessagePortImpl. * Adds LegacyMessagePortBridge to bridge with the legacy chromium.web.MessagePort API. * Minor cleanups in MessagePortImpl. Bug: 946732 Change-Id: I64e16902ebcc4a913e0591c7131a57eaaeff188a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546521 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#647043}
-
David Bokan authored
Event Sender doesn't support being run from within remote frames for some operations (e.g. drag and drop) . In these cases it is a legacy test hook. Add a documented DCHECK so this results in clearer output rather than mystery nullptr crashes further along in execution. Bug: 945077 Change-Id: I0487731074ebe10580cb80db0091fb52ff46a47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546635Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#647042}
-
Jessica Tallon authored
Bug: 918438 Change-Id: Ia0ff8a57743e29db384198c350446d2e7ff36ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1486351 Commit-Queue: Jessica Tallon <jtallon@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#647041}
-
James Cook authored
Make the system tray "gear" settings icon open a blank settings window when the feature is enabled. PRD: go/cros-settings-2019 TODO: New chrome://os-settings/ URL and host. TODO: Sub-page support. Bug: 948298 Change-Id: I81a812f605f403f043022779eee349cbab147da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549198 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#647040}
-
- 02 Apr, 2019 9 commits
-
-
siyua authored
Two experiments involved: AutofillCreditCardLocalCardMigration, AutofillLocalCardMigrationShowFeedback Bug: 897998 Change-Id: I83d9e785de47d679393fa5ede09ddd7592d26e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530828Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#647039}
-
manuk authored
This is the 4th refactoring CL aimed at reducing duplication and inconsistency for classifying omnibox results. The search and shortcut providers use AutocompleteProvider::ClassifyAllMatchesInString to classify their suggestions. Specifically: a) Search results from the search provider classify their contents using ClassifyAllMatchesInString; their descriptions (e.g. ‘Google Search’) are always classified as DIM regardless of user input. b) 'nav-suggest' results from the search provider have unique classification logic at NavigationResult::CalculateAndClassifyMatchContents which delegates to ClassifyLocationInString. c) Both search and navigation results from the shortcut provider call ClassifyAllMatchesInString with the parameter 'text_is_search_query' set accordingly. ClassifyAllMatchesInString is a bit redundant and a bit inconsistent with other providers' classification code. Therefore, this CL: 1) Adds FindTermMatches to autocomplete_match_classification. It is responsible for creating TermMatches from the user text and suggest text. Similar methods exist, but this one is meant to be generic and replace the duplicates. For now, it only replaces ClassifyAllMatchesInString. 2) Replace ClassifyAllMatchesInString unique classification code with a few function calls. 3) Removes the no longer used methods CreateWordMapForString, GetOrCreateWordMapForInputText, and GetWordMapCache. These methods were used to split a string to words and create a map from the first letter of each word to all words starting with that letter, sorted shortest first. This was useful for the previous ClassifyAllMatchesInString implementation. These changes modify the search and shortcut providers classification behavior: a) Search results from the search provider previously did not match word break on symbols (e.g. 'fast.' would not match 'fast espn', 'fast com' would not match 'fast.com', and '//fast.com' would not match 'https //fast.com'). With this CL, search results will break on symbols. Also, search results lowercased suggest text but not user text (e.g. 'Fast' would match neither 'fast' nor 'Fast'). With this CL, both strings are lowercased for comparing (displayed text is unaffected). b) Classification behavior for 'nav-suggest's are unchanged, since they don't delegate to ClassifyAllMatchesInString. c) The shortcut provider was the only provider to allow mid-word matching in non-URLs (e.g. 'ello' matched 'h[ello]'). With this CL, this is no longer allowed. Bug: 366623 Change-Id: I5cda160d1a8c8a66a6c841d91a8e05461d12e33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544886 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#647038}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/83f899ce0f61..7a292fcdb49f git log 83f899ce0f61..7a292fcdb49f --date=short --no-merges --format='%ad %ae %s' 2019-04-02 bgoodwin@google.com Promote Littlejoe and viking boards to important, since they've shown themselves stable. 2019-04-02 zamorzaev@chromium.org Revert "chromeos_config: Enable Skylab for CTS qual tests" 2019-04-02 mikenichols@chromium.org repository: Allow fetch-all to fail silently 2019-04-02 mikenichols@chromium.org chromeos_config: Migrate release builders back to Prod bot group 2019-04-02 yueherngl@google.com nami: add builder for firmware-nami-10775.108.B branch 2019-04-02 zamorzaev@chromium.org chromeos_config: Enable Skylab for CTS qual tests Created with: gclient setdep -r src/third_party/chromite@7a292fcdb49f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I02666cd40d4bfc1ba31cb585bb6e9872fba2c86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549780Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e30d05137000..422c432dd25d git log e30d05137000..422c432dd25d --date=short --no-merges --format='%ad %ae %s' 2019-04-02 jmadill@chromium.org Add ANGLE revision to gclient config. 2019-04-02 nodir@google.com [bot_update] Set output commit of the build 2019-04-02 tandrii@chromium.org Revert "git cl status: differentiate "dry-run" from generic "commit"." Created with: gclient setdep -r src/third_party/depot_tools@422c432dd25d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:940214 TBR=agable@chromium.org Change-Id: If9f7824e7136f41d0e7bf17b0c2e9a868ae53c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549351Reviewed-by:
-
Natalie Chouinard authored
The Asset and Offline Page Downloads suggestions are no longer used on the Simplified NTP. A follow-up CL will mark the DOWNLOADS category as deprecated. Bug: 947080, 947082 Change-Id: I665f6b67a96d6206a4d1e203d6275b171c1346e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544613 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#647035}
-
Jia authored
We will soon use finch flags to run experiments. This cl removes the "special" treatment to atlas, so that it will enabled/disabled from finch. Bug: 881215 Change-Id: Ib45eb0c40aea0ad993df0c5cb2a430ab52047a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546792 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#647034}
-
Anastasia Helfinstein authored
Bug: 914658 Change-Id: I34859660184fd3d1ac4d97cd1febf899665927b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548600Reviewed-by:
-
Jimmy Gong authored
- Moves the existing user provided PPD file name to its input field for consistency. - Deletes text that displays the currently selected PPD file in edit dialog. Bug: 947748 Change-Id: I94f4e747c9f8131138503fde18d3970a23b9c8a8 Tests: end to end Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546773Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#647032}
-
Tommy C. Li authored
These two calls to GetSecurityLevel(false /* ignore_editing */) can be harmlessly flipped to GetSecurityLevel(true /* ignore_editing */). In both code contexts, it's already established that the user is NOT editing the omnibox contents: - iOS View has an if-statement that does that. - CustomTabBarView is read-only, so cannot be edited. We are flipping them to GetSecurityLevel(true), because in the future, LocationBarModel will always ignore edits, and this call will not take any parameters. This is part of a larger plan to make LocationBarModel no longer track the user's edit state, but instead always return the secure display information for the current navigation state. Bug: 912722 Change-Id: I79850334430edb5497aca6033001f8b4c02e5065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549618 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#647031}
-
