- 29 Jan, 2020 40 commits
-
-
Yi Gu authored
Test is flaky on Linux and Windows: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWQsSBUZsYWtlIk5jaHJvbWl1bUB1bml0X3Rlc3RzQE1lZGlhTm90aWZpY2F0aW9uU2VydmljZUNhc3RUZXN0LkNvdW50Q2FzdFNlc3Npb25zQXNBY3RpdmUM TBR=takumif@chromium.org Bug: 1034406 Change-Id: I5403d8163546553597490123dce4aec167601cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028265Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736509}
-
Daniel Rubery authored
We currently only report DLP bypasses if they are opened within Chrome (by clicking on the download shelf item, or selecting "Open" from the download item dropdown, for example). We should be reporting any time a user recovers a file that showed a DLP warning. This CL adds code to do that. Bug: 1046527 Change-Id: I2ecf6704d4040ee3bdb39d8e40b49f021eb0ddb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025931Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#736508}
-
Yi Gu authored
This test is flaky on Linux: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXQsSBUZsYWtlIlJjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BQb2ludGVyTG9ja0Jyb3dzZXJUZXN0V2l0aE9wdGlvbnMuVW5hZGp1c3RlZE1vdmVtZW50DA TBR=mustaq@chromium.org Bug: 1043985 Change-Id: I9c9cd3ade09dab3b601895ad0b8e8f4896745f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028728Reviewed-by:
-
behdad authored
The metric was added in an update before to track the time begin main frame sent to start: https://chromium-review.googlesource.com/c/chromium/src/+/2013461 Bug: chromium:976030 Change-Id: Ib575aef2feb3ed94c6e2cff2b83f2ecc4543c347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028109Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#736506}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8354717302ce..37e7b36a3dc2 git log 8354717302ce..37e7b36a3dc2 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 bsalomon@google.com Make cache RRect blur masks with exact fit textures. 2020-01-29 reed@google.com tweak textbox to use subpixel 2020-01-29 csmartdalton@google.com Preserve triangle winding in GrTessellator 2020-01-29 jlavrova@google.com Memory leak in cache Created with: gclient setdep -r src/third_party/skia@37e7b36a3dc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1044017 Tbr: reed@google.com Change-Id: I30c50d93c275a0c6ec0dd1c6116661c21ceec318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027905Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736505}
-
Scott Haseley authored
This CL adds the necessary wiring to make devtools aware of postTask to show async callstacks, similar to setTimeout and requestIdleCallback. Bug: 979017 Change-Id: I960b13d1c13f171dbc033b8e79bff3768e65c347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025870Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#736504}
-
David Tseng authored
The Clsoure compiler (which gets run on upload PRESUBMIT) is now flagging many errors in ChromeVox. This is due to the recent work to move us to ES6 styled classes. The errors themselves were mostly there previously and uncaught because Closure is fairly loose in flagging errors given a slightly different js structure. Test: git cl presubmit -u --force Change-Id: I4c09adf0a5fd6e3894f7316dc4d5a9c4bf9a825d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026760Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#736503}
-
Ahmed Fakhry authored
Make the Night Light animation which triggers when the automatic transition happens due to a set schedule run at 15 FPS, and last for a minute. BUG=1044344 TEST=Manual Change-Id: If76477be8674c4e276dfa508f0fda4fe2deb64a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024448 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#736502}
-
Nazih Almalki authored
FinishPaintCurrentFrame and EndWriteSkia (SkiaOutputDeviceBufferQueue) both do a flush right after each other. The CL combines the flush from both, and get it done in FinishPaintCurrentFrame. The FinishPaintCurrentFrame, calls GetEndPaintSemaphore, that is combined with the FinishPaintCurrentFrame, and flushed. EndWriteSkia, Checks if the semaphore has been flushed, if not, it will flush it. Bug: 1043114 Change-Id: I541f0a9b5c31e7bfaee7b83a6be99d98323f0f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024919Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Nazih Almalki <nalmalki@google.com> Cr-Commit-Position: refs/heads/master@{#736501}
-
Kevin Marshall authored
Adds a GN arg "fuchsia_release_channel" which modifies how some released packages are named. This will allow official builders to produce packages named "web_engine_canary", "web_runner_beta", and so on., a necessary step toward running stable and canary releases on Fuchsia side-by-side. Adds test function "ConnectContextProvider()" for sourcing the ContextProvider service directly from a release channel-specific package. Bug: 1029184,1046615 Change-Id: I23845e64d909c9e7665ce3df15458c26e1f27ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006189 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
James Robinson <jamesr@chromium.org> Cr-Commit-Position: refs/heads/master@{#736500}
-
Dominik Röttsches authored
Change-Id: I157f3ca744e16cd13ca3138bd1b5ec69f2324a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027530 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#736499}
-
Daniele Castagna authored
Originally we remapped temperatures to a range [5700, 7500) and then computed RGB scale factors using linear functions. The table that remaps temperatures has been updated with crrev.com/c/2001254 but we didn't update the code to accept the new range [4500, 7500). This CL updates the accepted range and also recomputes GB coefficients used for the linear regression in the interval [4500, 6500]. Bug: 1045647 Test: ash_unittests --gtest_filter=AmbientTemperature.AmbientTemperatureToRGBScaleFactors Change-Id: Ifa19820cd8d6b076dbf6c85841f126bca7ea4585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022246Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#736498}
-
Ionel Popescu authored
As part of https://chromium-review.googlesource.com/c/chromium/src/+/2023361, the default behavior of the color picker was changed to start with the color selection ring focused. This CL updates the test results that were incorrectly changed in that CL. Bug: 1041708 Change-Id: If8af59e69229d39ff5129c10ead7ed8936339f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028294Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736497}
-
Julian Pastarmov authored
Before the API would return an error now it returns no error and an empty blob instead. BUG=1046705 TEST=uni_tests Change-Id: Id15fa397d9db5dcded5db40caac9a719bc9312ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026971Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#736496}
-
Jarryd authored
Add a method that storage backends can call to let QuotaManager know that a write error will be or has been thrown. This will be used as a hint that the disk storing the user's profile might be full. In combination with Quota's knowledge of disk usage, this function can be used to trigger any actions that the content embedder deems appropriate for storage pressure state, such as notifying the user. Logic for calling this function will be in child CLs. Bug: 997258 Change-Id: Iae7f77f546778f426e13b936f6bfeb6284cab3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969235 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#736495}
-
rbpotter authored
Split out from https://chromium-review.googlesource.com/c/chromium/src/+/1848495 by dpapad@, since we need to handle <if expr> in imports in order to autogenerate Polymer 3 versions of files that are shared between the browser and OS settings. Bug: 1026426 Change-Id: I3bdaca4c64104232d72b993a4dc82ee18f92676f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025837 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736494}
-
Xiaocheng Hu authored
This patch caches the pseudo style of custom scrollbar parts on the ComputedStyle of the originating element, so that it's easier to inspect these pseudo styles. Before: Element -> LayoutObject -> PaintLayer -> ScrollableArea -> CustomScrollbar -> ComputedStyle After: Element -> ComputedStyle This is preparation for crrev.com/c/1952189 Bug: 441925 Change-Id: Ibbb4876d4e01af7c37db9b390937af76a217855e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026694Reviewed-by:Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#736493}
-
Lorne Mitchell authored
DevTools: Modified LayerTree.compositingReasons to include a new property named compositing_reason_ids. This change modifies the LayerTree.compositingReasons method [1] to include an additional return property named compositing_reason_ids. This new property provides an ID that can be used by CDP clients (such as the DevTools) to localize the compositing reasons. The design was reviewed here in [2]. A separate CL will follow for the DevTools frontend to consume compositing_reason_ids and map them to strings that are localized in the frontend. [1] https://chromedevtools.github.io/devtools-protocol/tot/LayerTree#method-compositingReasons [2] https://docs.google.com/document/d/1ZbCiXbVJZJaYqKZkQ_Y5RNpUqQd1JzO17PqFJZk2Ne8 Bug: 946860 Change-Id: Ie924a8dc65fe224e418e4d8b75c07433d2050645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015551Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736492}
-
Jenny Zhang authored
Bug:1044699 Change-Id: I64c307b4b14043454d332f13df41c63f0c582607 TBR=holte@chromium.org Change-Id: I64c307b4b14043454d332f13df41c63f0c582607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026422Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736491}
-
Yi Gu authored
The test is flaky on all platforms. See bug for details. TBR=fs@opera.com Bug: 1041847 Change-Id: I52584019457809bcf7a3ae9297ca44b41c604bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028648Reviewed-by:
-
Khushal authored
We may fail to create an SkImage from the AcceleratedStaticBitmapImage's mailbox so ensure a null check is done before use. R=fserb@chromium.org Bug: 1043493 Change-Id: I4a9d4ad22b2ceb868aeb3b3288637f306983b4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026928 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#736489}
-
Eric Robinson authored
Update field trial testing to include frame backgrounding in preparation for Beta release. Bug: 1020306 Change-Id: I4ba4ab8109cae7cdc2c7773650f5eb2f4d738a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014123Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#736488}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/a27a3c96909f..278efaec3531 $ git log a27a3c969..278efaec3 --date=short --no-merges --format='%ad %ae %s' 2020-01-28 dschinazi Add support for retry integrity tag 2020-01-28 wub gfe-relnote: Change QuicSentPacketManager::SetSendAlgorithm(CongestionControlType) to a no-op if the current and the requested cc_type are the same. Protected by --gfe2_reloadable_flag_quic_set_send_algorithm_noop_if_cc_type_unchanged. 2020-01-28 fayang gfe-relnote: In QUIC, make PTO per packet number space. This only affects QUIC versions with TLS handshake. Protected by disabled gfe2_reloadable_flag_quic_enable_version_t* flags. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I12ba74ce03523bb67b187360b50c27ae1e18c203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028293Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#736487}
-
Fredrik Söderquist authored
When changing the 'clip-path' property on an (SVG) element we need to recompute the visual rect since it includes contributions from the clip bounds (as well as the mask and filter bounds). This wasn't happening, which meant that the element wouldn't repaint properly if the old bounds were smaller than the new bounds. Add some detection of bounds-affecting changes to SVGResourcesCache and Make use of that in SVGResourcesCache::ClientStyleChanged() to mark the element for layout if needed so that its bounds are updated properly. Fixed: 1045915 Change-Id: Ia08904945b26c382e0b9c90c15b7cc45d40434cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023561Reviewed-by:
-
Raphael Kubo da Costa authored
This should allow FindIt to set the right component when filing bugs for flaky tests, and setting WPT-NOTIFY to true in OWNERS also automatically files new bugs if a test starts failing after a WPT import. The code in blinkpy handling WPT-NOTIFY only parses a subset of the syntax of an OWNERS file that does not include file:// entries, so manually add a few people rather than pointing to content/browser/native_file_system/OWNERS. Change-Id: I539040bf18648981da0fd2c56ff4032633ac2349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027448 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#736485}
-
chrome://autofill-internals/Christoph Schwering authored
This commit adds checkboxes to filter the types of log events displayed in chrome://autofill-internals/, an auto-scrolling mechanism, and visual markers in order to aid with visually processing the logs. NOTRY=true To skip android-binary-size bot due to a bug (crbug.com/1045024). Other try-bots have passed. Change-Id: I64db7aa5055757ef80f1981a659be76d7fa37291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017354 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#736484}
-
Fabrice de Gans-Riberi authored
It is now necessary to parse the 'archive' entry from images.json, since some of the images listed are not built. Bug: fuchsia:44352 Change-Id: I849d389df4ef032acf724a9948ed3d975dae5f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028115Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
-
Tricia Crichton authored
Python tests show increased flakiness caused by command timeouts after reducing the timeout to 10 seconds. Increasing to 30 seconds to reduce timeouts Bug: 1045241 Change-Id: I0f564f564155c294ac3e041518096b88a705f94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028174Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#736482}
-
haozhe authored
The current code doesn't catch the case where non_interpolatable_value is null for the interpolation_list. This patch add a protection for this situation. Bug: 1039733 Change-Id: I442a56e4984285dfe524dcd669fae9f4da0a7f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011167 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#736481}
-
Charlie Reis authored
This is no longer necessary now that we track RenderFrameProxyHosts. This CL also cleans up many other references to "swapped out." Bug: 1015882 Change-Id: Ib5391d360460540945891232c5eca0701fce138f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022350 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736480}
-
Sadrul Habib Chowdhury authored
BUG=none R=xidachen@chromium.org Change-Id: I821d77ecb5c79405ddbbb2a020f5a90214fef3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028113Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/99d6d8115b37..740ed473dcba git log 99d6d8115b37..740ed473dcba --date=short --first-parent --format='%ad %ae %s' 2020-01-29 jianj@google.com Add 444 support for vp9 decoder wrapper. 2020-01-29 mbonadei@webrtc.org Revert "Adds trial to use correct overhead calculation in pacer." Created with: gclient setdep -r src/third_party/webrtc@740ed473dcba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7ab8a7c14ca2d5e478060c924d76ca6a77cf09d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028018Reviewed-by:
-
jongdeok.kim authored
This CL makes not to perform heavyweight theme change on full screen mode on Windows. On full screen mode, HWNDMessageHandler does not try to update views by calling PerformDwmTransition(). Bug: 1002480 Change-Id: I8d40bd47dca0f1247cb77b4354ead4b9e44848a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016769 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#736477}
-
Tobias Sargeant authored
PlatformServiceBridge.java is compiled twice into two jars for internal builds, and combining the jars is smart enough to remove the duplicate, but cannot do the same for any inner classes. Therefore we must introduce an explicit adapter class to perform the same function. Bug: 1046782 Change-Id: I2a933ced5fa051271f42571eaffea8671a6fb094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027810Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736476}
-
Yi Gu authored
This test is flaky on Linux and Win as well: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUwsSBUZsYWtlIkhjaHJvbWl1bUB1bml0X3Rlc3RzQFRvb2xiYXJBY3Rpb25WaWV3VW5pdFRlc3QuQmFzaWNUb29sYmFyQWN0aW9uVmlld1Rlc3QM TBR=rdevlin.cronin@chromium.org Bug: 1042220 Change-Id: Ia414f828e4f172c1e7cc03cb8fe8af034b172870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028119Reviewed-by:
-
Yi Gu authored
This test is currently flaky on Mac: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZmFzdC9jYW52YXMvY2FudmFzLWZpbHRlci1vcmlnaW4tY2xlYW4uaHRtbAw TBR=fs@opera.com Bug: 1041846 Change-Id: I4940f68657c834d525b5a8f24ce7dbfa5ae9ee22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027904Reviewed-by:
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityManager::GetPrimaryAccount() assumes the user has consented to browser sync. Switch to using the "unconsented" primary account, which exists whether or not the user has consented to browser sync. See go/cros-primary-account for details. Bug: 1042400 Test: updated existing unit_tests Test: cancelling ARC setup in OS settings still works Change-Id: I39ecf4f800071e79624bd624bcdf5272e6ad448b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023988 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Cr-Commit-Position: refs/heads/master@{#736473}
-
Michael Thiessen authored
In order to migrate java.net.URI to GURL the junit tests that rely on java.net.URI need to be moved to a test apk that supports the native library. This change moves the StatusMediatorUnitTest unittests from junit to unit_tests (Android only). These tests should be just as fast as they were as junit tests (and much faster than chrome_test_apk unit tests). Bug: 783819 Change-Id: I1f19eb766c627e1fe44c15775957e20ed7a75c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015348 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#736472}
-
David Van Cleve authored
This CL eases interacting with string-to-proto tables via sqlite_proto by adding a new TableManager override, ProtoTableManager, which handles table initialization for the string-to-proto case. Now, clients just need to construct and initialize one pair of KeyValueTable<T>/ KeyValueData<T> per table. Bug: 1036494 Change-Id: I4e512cd328f21faaecb57d0ef6c70f00355f6213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997659 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736471}
-
Nick Harper authored
Change-Id: Ic43d1ab8d2b3905b1771ed922cb30040b50dbdb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023508 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#736470}
-
