Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 30 Oct, 2011 4 commits
    • chrome-release@google.com's avatar
      Updating trunk VERSION from 923.0 to 924.0 · 791e38f3
      chrome-release@google.com authored 
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107897 0039d316-1c4b-4281-b951-d872f2087c98
      791e38f3
    • jar@chromium.org's avatar
      Fully enable about:tracking by default · f0ab5bae
      jar@chromium.org authored 
      This is a re-land of:
http://codereview.chromium.org/8391019/
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107793

Original landing had trouble with message_loop_x.h, due to header
include ordering.  I pulled out the structure that was really needed by
tracked_objects.h into a new file tracked_info.*.  This allows tracked_objects
to inlude this tracked_info, but not have to include the message_loop.h
totality.  I also removed a DCHECK that that was triggering on a test,
and added yet one more file (browser_main.cc) where I removed a #ifdef
for TRACKING_ALL_OBJECTS.  The changes were minor, and I'm hoping to get
clear perf runs with tihs landing, so I'm going to TBR it and reland
early in the morning.



Comments from original landing:

Support is now controlled by the flag:
--enable-tracking
and the default is always on. To turn it off, use:
--enable-tracking=0

All profiler code is compiled now in release and official
builds (in addition to debug, where it was already active),
but most entry points can be disabled (turned into no-ops) 
by a single const bool setting atop tracked_objects.cc (in 
case folks want to revert the perf-impact of this change).

Transition to faster Now() service on Windows for the 
profiler use only.
The TimeTicks::Now() function on Window uses locking
to get a 64 bit time value. This CL transitions 
times used for profiling to more directly use a
32 bit Time interface, which is actually what drives the
64 bit TimeTicks. By using the smaller value, we avoid 
the need for locks, or even atomic operations for the most
part in the tracking system. On linux, we just down-sample
the standard TimeTicks to 32 bits for consistency (clean
ability to snapshot asyncronously without atomics...
but I should verify that such is helpful to performance).

I've also put in yet more cleanup and refactoring.

tbr=rtenneti
bug=101856
Review URL: http://codereview.chromium.org/8414036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107895 0039d316-1c4b-4281-b951-d872f2087c98
      f0ab5bae
    • qghc36@motorola.com's avatar
      Options: Disable the delete button when no profile is selected in personal settings. · 0bc27162
      qghc36@motorola.com authored 
      According to this change, Delete button will be disabled when there are multiple profiles and none of the profiles is selected. If profile list is hidden i.e if there is only one default profile then Delete Button is also disabled.

BUG=100625
TEST='Delete...' button should be disabled when no profile is selected in chrome://settings/personal page.


Review URL: http://codereview.chromium.org/8339014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107894 0039d316-1c4b-4281-b951-d872f2087c98
      0bc27162
    • mrossetti@chromium.org's avatar
      Create Private Data for InMemoryURLIndex (in Preparation for SQLite Cache) · 0c33bf8d
      mrossetti@chromium.org authored 
      1. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData (found in in_memory_url_index_types.h).
2. Move most of the support types, including the new URLIndexPrivateData class, into in_memory_url_index_types.h. 
3. Correctly handle the adding and removing of page title words when a URL change is detected. 
4. Replace static class member functions with non-friend, non-class functions for better flexibility. 
5. Move convenience types out from InMemoryURLIndex class up into history namespace. 
6. Rename convenience types to generalize their intent. 

BUG=92718
TEST=Enhanced unit tests.
Review URL: http://codereview.chromium.org/8359019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107893 0039d316-1c4b-4281-b951-d872f2087c98
      0c33bf8d
  3. 29 Oct, 2011 36 commits