GitLab

CommandBufferService should not accept put == num_entries, the client must
wraparound to 0 (CommandBufferHelper does).
CommandParser wraps to 0 and never sets get_ == num_entries, so
CommandParser::IsEmpty would never become true.

A test should have caught that but unfortunately it confused buffer size and
number of entries. This fixes it.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2304813002
Cr-Commit-Position: refs/heads/master@{#417211}

This implements the Chrome side support for Service Discovery Protocol.
- Retrieve SDP records from a remote device
- Create/remove a SDP record for the local device
- Convert service record/attribute between Chrome and Mojo

BUG=b:29314637
TEST=None (The manual test is blocked on chromium:627907.)

Review-Url: https://codereview.chromium.org/2149713002
Cr-Commit-Position: refs/heads/master@{#417210}

Change the timing of event dispatching and <script> execution in Node::appendChild, insertBefore, and replaceChild.

When we insert a DocumentFragment including multiple children into another node,

* WebKit and Blink: DOMNodeInserted is dispatched just after each of
  DocumentFragment children was inserted.

* Firefox and Edge: DOMNodeInserted is dispatched after all of DocumentFragment
  children were inserted.

<script> execution and <iframe> load event have the same incompatibility.

This CL makes Blink same as Firefox and Edge in order to improve interoperability
and avoid additional hierarchy check for crbug.com/523157.

Implementation:
Fold updateTreeAfterInsertion() and notifyNodeInserted() into insertNodeVector(),
and move childrenChange(), didNotifySubtreeInsertionsToDocument(), and
dispatchChildInsertionEvents() out from the loop.

Test changes:
* fast/dom/MutationObserver/removed-out-of-order.html
  DOMNodeInserted timing change.  New result matches to Firefox and Edge.

BUG=523157

Review-Url: https://codereview.chromium.org/2306323002
Cr-Commit-Position: refs/heads/master@{#417209}

This patch converts "fast/dom/Range/deleteData-replaceData-count-overflow.html"
to use w3c test harness to simplify test case and make this test script
independent from selection behavior, since this test script verifies methods
of |Range| object, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2321863002
Cr-Commit-Position: refs/heads/master@{#417208}

While deserializing, make a note of all changed nodes via id before performing any tree changes/removals.

While removing (non-atomically), reference the changed list to ensure we notify delegates of nodes that will actually be deleted and not just deleted then re-created as part of bookkeeping to enforce the "non-reparenting" invariant inside of AXTree::CreateChildVector.

BUG=642799
TEST=for each of the reproductions in the bug, ensure the automation api (as a client) does not destroy then re-create js objects; rather, ensure it re-uses them for reparented trees.

Review-Url: https://codereview.chromium.org/2080573003
Cr-Commit-Position: refs/heads/master@{#417207}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/cb19e3cfb00ef7f6732073bcf0c8ed1d8bd1d531 WebRTC: Promote Linux 32-bit bots to main waterfall again. (kjellander@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=644167

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2319413002
Cr-Commit-Position: refs/heads/master@{#417206}

Replace dbus::FileDescriptor with base::ScopedFD.

BUG=621841

Review-Url: https://codereview.chromium.org/2317593002
Cr-Commit-Position: refs/heads/master@{#417205}

All tabs created by TabDelegate.createNewTab() are treated as from external
apps.
However, if the tab was created from Chrome's own UI, we shouldn't do
this.
Otherwise, clicking the back button will dismiss the Chrome app.
This change also passes the header String when creating a new tab.
This allows Chrome UI to create tabs with correct header Strings.

BUG=637239

Review-Url: https://codereview.chromium.org/2319143004
Cr-Commit-Position: refs/heads/master@{#417204}

Draw main frame custom scrollbars in root layer scrolling mode. On RLS custom
scrollbars are picked from CompositedLayerMapping, Non-RLS  custom scrollbars
are picked from PaintLayerCompositor.

BUG=623853

Review-Url: https://codereview.chromium.org/2198853002
Cr-Commit-Position: refs/heads/master@{#417203}

BUG=644154
TEST=Go through notification list in message center with ChromeVox,
     then ChromeVox read ARC custom notifications

Review-Url: https://codereview.chromium.org/2318463002
Cr-Commit-Position: refs/heads/master@{#417202}

BUG=636723, 640847

Review-Url: https://codereview.chromium.org/2281913002
Cr-Commit-Position: refs/heads/master@{#417201}

This patch contains blink-side infrastructure of the Generic Sensors Framework, i.e. implementation of 'Sensor' and 'SensorReading' classes.

Also it introduces 'SensorPollingStrategy' interface that should provide different polling behaviour depending on
the sensor reporting mode (implementation will be added in the following CLs).

Specification: https://w3c.github.io/sensors

BUG=606766

Review-Url: https://codereview.chromium.org/2317743002
Cr-Commit-Position: refs/heads/master@{#417200}

This patch fixes disposing of:
- DefaultScriptmapping
- ResourceScriptMapping
- CompilerScriptMapping

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2301023003
Cr-Commit-Position: refs/heads/master@{#417199}

This catches new ALLOW exceptions added via the broken puzzle piece
in the Omnibox and via the Website Settings dropdown.

It doesn't catch ALLOW exceptions added manually via the
chrome://settings Content Settings area. It's not obvious it's a good
idea to convert the wildcard-patterns within that to RAPPOR domains.

BUG=639503

Review-Url: https://codereview.chromium.org/2308933002
Cr-Commit-Position: refs/heads/master@{#417198}

Each Callback instance had its own polymorphic_invoke, that doubles the
size of Callback, and its initialization gains 40kB of the stripped
binary size of Chrome on Linux.

This CL moves polymorphic_invoke_ into BindStateBase to share it among
Callback.

Review-Url: https://codereview.chromium.org/2317563002
Cr-Commit-Position: refs/heads/master@{#417197}

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in InputMethodController::setCompositionFromExistingText

BUG=590369

Review-Url: https://codereview.chromium.org/2316963003
Cr-Commit-Position: refs/heads/master@{#417196}

BUG=None
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2321803002
Cr-Commit-Position: refs/heads/master@{#417195}

Original issue: http://crrev.com/2299673002
Second attempt: http://crrev.com/2299283002

Fix the flakiness by not trying to toggle accessibility off and on between the
two runs of the same page within each test.

Code leftover from the pre-OOPIF days was causing us to exit early from
the RenderAccessibilityImpl constructor for some child frames that were
already loaded. Everything worked fine if accessibility was already enabled
when loading the frame, but if the frame was already loaded and then
accessibility was enabled, this could cause it to fail to create an
accessibility tree.

The code in RenderAccessibilityImpl is no longer needed because now we
have exactly one accessibility tree per frame.

This wasn't caught by tests because we didn't cover both scenarios, we
always enabled accessibility first.

Added two variants of existing tests that load the page first and then
enable accessibility.

BUG=640231
TBR=dtseng@chromium.org

Review-Url: https://codereview.chromium.org/2317323002
Cr-Commit-Position: refs/heads/master@{#417194}

This patch:
- makes StylesSourceMapping listen to styleSheetAdded/styleSheetRemoved
  events by itself. SASSSourceMapping doesn't need to - it relies on
  SourceMapAttached event.
- disposes CSSWorkspaceBindings.TargetInfo properly, by disposing
  CSS mappings.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2298373002
Cr-Commit-Position: refs/heads/master@{#417193}

https://chromium.googlesource.com/skia.git/+log/828ed1777da7..5e3a63075397

$ git log 828ed1777..5e3a63075 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 mtklein GN: default to -O1
2016-09-07 msarett Rename SkColorSpace::GammaNamed to SkColorSpace::RenderTargetGamma
2016-09-07 msarett Revert of Add color xform support to SkWebpCodec (patchset #2 id:80001 of https://codereview.chromium.org/2294993002/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2319553004
Cr-Commit-Position: refs/heads/master@{#417192}

New feature in 2.8:
- block assignment
  {% set var_name %} content {% endset %}

Manually edited files:
  README.chromium
  get_jinja2.sh

BUG=

Review-Url: https://codereview.chromium.org/2316103002
Cr-Commit-Position: refs/heads/master@{#417191}

This refactors the favicon decode+downscaling+reencode logic into a
utility method and calls it on the history thread instead of
janking the UI thread.  (I left in a call in the original site as a
fallback path, but it will typically early-return as the work was
already done.)

I also added TRACE_EVENTs to help diagnose future performance issues.

BUG=644573

Review-Url: https://codereview.chromium.org/2313563002
Cr-Commit-Position: refs/heads/master@{#417190}

Using input language instead of the application locale to determine the Omnibox's text input type on Windows.

This cl contains a small refactoring of:
1) Changes GetInputLocale() to IsInputLocaleCJK(), so that the function would less likely to be abused.
2) Makes InputMethodBase to have empty implementations for OnInputLocaleChanged/IsInputLocaleCJK.

BUG=344834

Review-Url: https://codereview.chromium.org/2298123003
Cr-Commit-Position: refs/heads/master@{#417189}

There are known bugs affecting this test and it's failing
intermittently on linux_optional_gpu_tests_rel.

BUG=644572
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2320033002
Cr-Commit-Position: refs/heads/master@{#417188}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/80c86caa50d1..e385b94f6be7

$ git log 80c86caa5..e385b94f6 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 jbudorick [devil] Add experimental keyboard script.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2317423002
Cr-Commit-Position: refs/heads/master@{#417187}

TBR=fmalita@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2322853002
Cr-Commit-Position: refs/heads/master@{#417186}

The share intent is started with a delay because of screenshot capturing
and compressing. But, lot of times the other activity never uses the
screenshot. The screenshot capture, compress to jpeg and write to file
can be done in background when the user is selecting the app shared to.

This CL introduces a BlockingFileProvider that provides an empty file
uri without any contents and shares an intent. While sending the intent
it also triggers the screenshot capture. When the file is actually
requested by the other app, the file provider will wait till the capture
is done and the file is written. The blocking practically never happens
because the user takes some time to click on the app, before which the
capture is finished.
The BlockingFileProvider is made default file provider and the
CompatibilityFileProvider logic is added to it.

BUG=615229

Review-Url: https://codereview.chromium.org/2143133002
Cr-Commit-Position: refs/heads/master@{#417185}

This allows V8 to indirectly throw a DOMException, as is required to handle
certain kinds of errors encountered during serialization.

BUG=chromium:148757

Review-Url: https://codereview.chromium.org/2316763002
Cr-Commit-Position: refs/heads/master@{#417184}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/49f9a08dca7722a11e339291bb6e252c4056a1a5 Remove ignored bot_update "force" parameter. (iannucci@chromium.org)

R=iannucci@chromium.org
BUG=643885

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2321563003
Cr-Commit-Position: refs/heads/master@{#417183}

Add properties for getting the session type and the playstore status to
chromeosInfoPrivate. This CL also whitelists the GetHelp and the Demo
apps to be able to use the API.

R=rdevlin.cronin@chromium.org, xiyuan@chromium.org
BUG=644432,644446

Review-Url: https://codereview.chromium.org/2314313002
Cr-Commit-Position: refs/heads/master@{#417182}

BUG=539723

Review-Url: https://codereview.chromium.org/2321433002
Cr-Commit-Position: refs/heads/master@{#417181}

This CL implements experimental feature to skip 'Sign In' button
in OptIn flow. Currently it is implemented as 'sandbox' on server
side and this is available only for internal IP addresses. It is
optional and can be activated in chrome://flags.

BUG=b/28987931
TEST=Manually on device in both modes.

Review-Url: https://codereview.chromium.org/2320813002
Cr-Commit-Position: refs/heads/master@{#417180}

Current deps diffs shows lots of files differs only first certain bytes on Windows.  They are COFF timestamp difference, and we do not usually need to check.  Let me skip showing them.

BUG=314403

Review-Url: https://codereview.chromium.org/2303063003
Cr-Commit-Position: refs/heads/master@{#417179}

This is in preparation for deploying the Mac ASAN bot, which will spawn
jobs on multiple GPU types.

Add "can_use_on_swarming_builders" flag for non-swarmed
tab_capture_end2end_tests.

This CL is a no-op with regard to the generated JSON files. The next CL
will add the new builder/tester.

BUG=644920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=dpranke@chromium.org,maruel@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2325533002
Cr-Commit-Position: refs/heads/master@{#417178}

Bezier swatches will complement color swatches.

BUG=642782

Review-Url: https://codereview.chromium.org/2297873004
Cr-Commit-Position: refs/heads/master@{#417177}

This CL removes the MediaQueryListener from HTMLSourceElement that their
media attribute was removed.

BUG=643972

Review-Url: https://codereview.chromium.org/2307353002
Cr-Commit-Position: refs/heads/master@{#417176}

Document::attach/detachLayoutTree is confusing. It's indeed attaching/detaching
layout trees but doing more things than that. In particular, Document::detachLayoutTree
does a bunch of disruptive operations unlike other Node::detachLayoutTree.

It's better to rename Document::attach/detachLayoutTree to Document::initialize/shutdown
and make it clear that they can be called only once when the Document gets
initialized/shut down.

BUG=610176

Review-Url: https://codereview.chromium.org/2318913002
Cr-Commit-Position: refs/heads/master@{#417175}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/dd201d4c3af933224a9563515766f3eff245f688 Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. (kbr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=644920

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2320723004
Cr-Commit-Position: refs/heads/master@{#417174}

BUG=639095

Review-Url: https://codereview.chromium.org/2320563003
Cr-Commit-Position: refs/heads/master@{#417173}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7381c2dc..697e77ea

$ git log 7381c2dc..697e77ea --date=short --no-merges --format='%ad %ae %s'
2016-09-06 yyanagisawa@chromium.org cros_chrome_sdk: a flag to skip starting goma in cros_chrome_sdk.
2016-08-31 yunlian@chromium.org chromite: add peppy to the chromiumos-sdk bot

BUG=639432

Review-Url: https://codereview.chromium.org/2319513002
Cr-Commit-Position: refs/heads/master@{#417172}