GitLab

If the transfer buffer is resized, pointers returned by GetResultAs are
invalidated. This changes GetResultAs to return a smart pointer class
that allows us to detect if a result pointer is still in use when the
buffer is resized and safely crash.

Bug: 905889, 905890
Change-Id: I67b243a779f1a2996e7c13740c5ebdcfda16d0d3
Reviewed-on: https://chromium-review.googlesource.com/c/1336753
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608856}

This patch changes Range::expand() to call VP-free version of word and
sentence start/end functions, by hoisting the creation of VP from
the functions into itself. In this way we reduce the usage of functions
relying on VP.

Bug: 657237
Change-Id: I56ea3cb88972144887eba7701cfdc3628bdbf67b
Reviewed-on: https://chromium-review.googlesource.com/c/1338719
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608855}

This patch changes DocumentMarkerController to use VisiblePosition-
free versions of Start/EndOfWord, to reduce usage of VisiblePosition.

Bug: 657237
Change-Id: I344c98c9163ddc06f338e309a6b3e372d5fc2dda
Reviewed-on: https://chromium-review.googlesource.com/c/1330747
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608854}

Please first check the attached bug for context.

The fix is to listen on AccountTrackerService and not AccountManager
for account removals.

We cannot listen on AccountTrackerService for account updates because
AccountTrackerService does not notify its observers when an account's
LST changes.

Bug: 904978
Test: browser_tests --gtest_filter="ArcAuthServiceTest.AccountRemovalsArePropagated"
Change-Id: I75aeda8dd280734e58e509f5a34a4b1e27b09498
Reviewed-on: https://chromium-review.googlesource.com/c/1334368Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608853}

One lives in ash, the other in the browser. The one in ash is responsible
for the actual window management and animations, the one in the browser for
forwarding to the one in ash and caching state. I'm happy to rename these
classes in the future.

BUG=756085,875111
TEST=covered by test

Change-Id: Ida90f51a6b7efff82021a29e8a0185949a3e494a
Reviewed-on: https://chromium-review.googlesource.com/c/1338161Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608852}

WebappActivity#getActivityDirectory() never returns null.

Change-Id: Ie6b131677e6a69a49b8c72713235dc0891f5dbe2
Reviewed-on: https://chromium-review.googlesource.com/c/1340371Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608851}

This patch stops EndOfSentence from crossing block boundaries, since
block boundaries are also sentence boundaries.

Bug: 778507
Change-Id: I19ec97de1bbaac50db4c55b38ffb158339003993
Reviewed-on: https://chromium-review.googlesource.com/c/1337432Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608850}

This patch stops the two functions from using VisiblePosition by switch
to the VP-free versions of Start/EndOfSentence(). Hence, this patch
reduces the usage of legacy VisiblePosition.

Bug: 657237
Change-Id: I933a020f9bd6643ba1b2cd5111b8be18b2f49086
Reviewed-on: https://chromium-review.googlesource.com/c/1337816Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608849}

The draw-webgl-to-canvas-2d-repeatedly.html WebGL test is failing on
Linux/Amd/Passthrough. Suppress this.

BUG=906066
TBR=kbr@chromium.org
NOTRY=true

Change-Id: I93d75e75ecfac5bc94b272a6c0089c486122ef23
Reviewed-on: https://chromium-review.googlesource.com/c/1340367
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608848}

Change-Id: I05f3f73c8337bd2bfc07e420cdafccaf1bb04370
Reviewed-on: https://chromium-review.googlesource.com/c/1338408Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608847}

There is no logic change.

By refactoring the offset change into a separate class, we can make it
much easier to reason about and add new tests. For example,
https://chromium-review.googlesource.com/c/chromium/src/+/980513
can use this test.

Bug: 825858
Change-Id: I3465057c8b7fed637f61a2a02a03d5048be8c387
Reviewed-on: https://chromium-review.googlesource.com/c/1335273
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608846}

BUG=905919

Change-Id: I6024a41113845bd6e6b50d829a0ea2b4ab3e5efb
Reviewed-on: https://chromium-review.googlesource.com/c/1336527Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608845}

This CL creates an UI integration test that tests that the
page info view gets automatically dismissed on device rotation.

Change-Id: I02611cc2fab5a214b74af01d15cd8d12e19eff6e
Reviewed-on: https://chromium-review.googlesource.com/c/1338561
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608844}

In preparation for enabling an errorprone check that would
prohibit context#getApplicationContext in favour of
ContextUtils#getApplicationContext this CL suppresses
existing usages in WebView.

See https://bugs.chromium.org/p/chromium/issues/detail?id=560466
for context.

Bug: 846456
Change-Id: I9f046f1fa64d562cc9efb7d66a65bfe793b04bfb
Reviewed-on: https://chromium-review.googlesource.com/c/1340375Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#608843}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=emircan@chromium.org

Bug: 903957
Change-Id: Icb47a6a89a0c8e3c1a2871064dbb5b105db0ba2f
Reviewed-on: https://chromium-review.googlesource.com/c/1338412Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608842}

Currently when scroll timeline has unresolved current time, e.g. the
scroll source is not scrollable, we set WorkletAnimation::start_time_ to
base::TimeDelta::FromSecondsD(NaN) which is incorrect.

Other changes in the patch:
1. By spec [1], unresolved time values are represented by null. Update
tests to match that.
2. For WorkletAnimation with ScrollTimeline, it's legit not to set
start_time_. Update DCHECKs for this behavior.

[1] https://drafts.csswg.org/web-animations/#time-values-in-the-programming-interface

Bug: 905358
Change-Id: Ifde3890a6a4ad9e27dda8d4a78c5b6dcbf24ef54
Reviewed-on: https://chromium-review.googlesource.com/c/1336055
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608841}

We use this flag on OSS-Fuzz and trigger various asserts with fuzzing:
https://bugs.chromium.org/p/oss-fuzz/issues/list?can=1&q=label%3AProj-sqlite3&colspec=ID+Type+Component+Status+Proj+Reported+Owner+Summary&cells=ids


R=palmer@chromium.org, pwnall@chromium.org

Bug: 900910
Change-Id: I223ad95a9626e016c99ed5cecbf6f084cba8f331
Reviewed-on: https://chromium-review.googlesource.com/c/1315959
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608840}

Bug: V8:8405
Change-Id: I150f74bf5de8c0a2cd784e6d1399c1c702c2936e
Reviewed-on: https://chromium-review.googlesource.com/c/1339961Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Dan Elphick <delphick@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608839}

Use dot notations to get properties on Objects in find_in_page.js. This
is a preparation work for fix the bug(crbug.com/228585).

Bug: 228585
Change-Id: Ia0b371b914842f515589011b7182e7f8b121c924
Reviewed-on: https://chromium-review.googlesource.com/c/1339799
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608838}

TBR=vmpstr

Bug: skia:2664
Change-Id: I736158e11434fdf561328e20fee6bef01ba43ae9
Reviewed-on: https://chromium-review.googlesource.com/c/1337827
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608837}

Bug: chromedriver:2663
Change-Id: I62c16df01d2f775cff86a26ef1e9acc5e95a09ce
Reviewed-on: https://chromium-review.googlesource.com/c/1338573Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608836}

This reverts commit c5612605.

Reason for revert: Breaking 11 autorollers into Chromium. See https://bugs.chromium.org/p/chromium/issues/detail?id=906114

Original change's description:
> Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234
> 
> Bug: 875037
> Change-Id: Ia4a6393237602b88bb0130d9f916972e930d95b3
> Reviewed-on: https://chromium-review.googlesource.com/c/1339339
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608783}

TBR=thakis@chromium.org,hans@chromium.org,martiniss@chromium.org,ehmaldonado@chromium.org

Change-Id: Ib8984eb1b295f9695758fc9700024927ba75d9ed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 875037
Reviewed-on: https://chromium-review.googlesource.com/c/1340521Reviewed-by: Ravi Mistry <rmistry@chromium.org>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608835}

This CL fixes IdentityService#getRuntimeHostBrowserPackageName(). In some
scenarios (like the default browser supporting WebAPKs for an unbound WebAPK),
calling HostBrowserUtils#getHostBrowserPackageName() updates the host browser
in shared preferences. This CL changes the call so that when the
IdentityService changes the host browser in Shared Preferences the identity
service also clears that WebAPK's shared preferences and data directory.

This CL:
- Splits HostBrowserUtils#getHostBrowserPackageName() into 2 functions:
  HostBrowserUtils#getCachedHostBrowserPackage()
    which returns the host browser cached in shared preferences if it is still
    installed. HostBrowserUtils#getCachedHostBrowserPackage() does not update any
    state.
  HostBrowserUtils#computeHostBrowserPackageClearCachedDataOnChange()
    which computes the new host browser. If the computed host browser is
    different than the cached host browser in shared preferences, the WebAPK's
    shared preferences and data directory are cleared.
- Reduces the number of functions with hidden calls to
  HostBrowserUtils#getHostBrowserPackageName().
  HostBrowserUtils#getHostBrowserContext() and
  HostBrowserUtils#getHostBrowserUid() are changed to take a package name
  parameter and are moved to WebApkUtils.

BUG=900464
TEST=HostBrowserUtilsTest.*

Change-Id: Ie6dea7de5eaca770d8a1261c2742308bc1165419
Reviewed-on: https://chromium-review.googlesource.com/c/1310569
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608834}

https://webrtc.googlesource.com/src.git/+log/7dbb7c311f00..645a3afceae0


git log 7dbb7c311f00..645a3afceae0 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 solenberg@webrtc.org Remove unused/unnecessary things from ChannelSend.
2018-11-16 nisse@webrtc.org Add default values for PlayoutDelay in RTPVideoHeader.


Created with:
  gclient setdep -r src/third_party/webrtc@645a3afceae0

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:none,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I9184912693bd50867ad728f46ada7b5ec16f15c3
Reviewed-on: https://chromium-review.googlesource.com/c/1340380Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608833}

To help the server team distinguish better the traffic coming from
Chrome this CL adds a "Chromium" prefix to all Gaia sources in Chrome.
A lot of sources already had this prefix, but some did not.

This CL also removes the source parameter from ListAccounts calls.
This source was not consistently used (because ListAccounts often
returns a cached response), and was not really meaningful.
ListAccounts now always use the generic GaiaSource::kChrome.

TBR=treib, xiyuan, isherman, poromov, eugenebut

Bug: 895010
Change-Id: I8b3837d6ddf1d04cae252f382c2dee7b99f93c75
Reviewed-on: https://chromium-review.googlesource.com/c/1329971
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608832}

This change:
* removes COLOR_TAB_TEXT_INACTIVE and instead simply alpha-blends
  COLOR_TAB_TEXT
* removes disabled unit test that uses COLOR_TAB_TEXT_INACTIVE
* uses COLOR_BACKGROUND_TAB_TEXT_INACTIVE directly if a theme
  provides it

Bug: 901610, 859243
Change-Id: I7db13a7719284ac3e27ec3bfc122d6381430df26
Reviewed-on: https://chromium-review.googlesource.com/c/1334419
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608831}

This is a reland of 04f43afb

Original change's description:
> [Autofill Assistant] Displays the difference in Details if there is any.
>
> If there is a difference between current and new details it's
> highlighted and two chips are displayed; to allow move forward or
> go back (which closes CCT).
>
> Screenshot: https://screenshot.googleplex.com/kOoC3B1frUp
>
> Bug: 806868
> Change-Id: I95ff09c379398d5a5858aa3947d4c578f39b14c9
> Reviewed-on: https://chromium-review.googlesource.com/c/1335941
> Commit-Queue: Lukasz Suder <lsuder@chromium.org>
> Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608759}

Bug: 806868
Change-Id: I419ac2bb513f6fdd496fba40162c92b839952df9
Reviewed-on: https://chromium-review.googlesource.com/c/1340329Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Lukasz Suder <lsuder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608830}

post_task.h is now preferred over using dedicated base::Threads.

Furthermore, this code is preventing PlatformThread::Join() called by
Thread::Stop()) from being marked as a blocking operation in
https://chromium-review.googlesource.com/c/chromium/src/+/1324370.

This code was really only spinning up a thread to run a single task in
an MTA environment. All threads in the TaskScheduler (in the browser
process) are in an MTA.

R=grt@chromium.org

Bug: 707362
Change-Id: I5defbaeefc291f4b417c142cda60918a4cfd471d
Reviewed-on: https://chromium-review.googlesource.com/c/1338221
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608829}

Visually this doesn't change anything and makes autofill_assisant Chrome
UI style compliant.

Bug: 903508
Change-Id: I42cd48c8be5994aa2a3da877ba023a9228ad0eec
Reviewed-on: https://chromium-review.googlesource.com/c/1340160Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608828}

FileUtilTest.ReadFileToStringWithNamedPipe has been flaking since
http://crrev.com/c/1298024 landed.

I believe FileUtilTest.ReadFileToStringWithNamedPipe was failing because
it creates 6 processes one after another. We only have 5 test processes,
so in some cases one was not available to be reused for the 6th process.
Doubling the number of test processes to 10 should fix this.

Bug: 902674
Change-Id: I7e6204b5fda28155de8d501ccb5e0e5d2754849e
Reviewed-on: https://chromium-review.googlesource.com/c/1338393Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608827}

We don't need it and it doesn't work. It's probably been ok up
until now because we have never had more than one S file per
build target.

See errors at
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Jumbo%20Win%20x64/22538

R=fs@opera.com

Change-Id: Idde99aba83e01c0111e5a50590e319993e0effaa
Reviewed-on: https://chromium-review.googlesource.com/c/1340312
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#608826}

- Remove redundant |web_contents_|.
- Initialize them in the header when possible.
- Mark them const when possible.

Change-Id: Id7d709c128762e69e56b729a59e5481aaa8b44e1
Reviewed-on: https://chromium-review.googlesource.com/c/1339464Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608825}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=avi@chromium.org

Bug: 903957
Change-Id: I86f204337a4137c79f85eb73e5601b9a02fe578a
Reviewed-on: https://chromium-review.googlesource.com/c/1338489Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608824}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=sadrul@chromium.org

Bug: 903957
Change-Id: I350657e7c0760b9ce1e4ff33a74a0e8e007d5e21
Reviewed-on: https://chromium-review.googlesource.com/c/1338409Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608823}

Currently linux-jumbo-rel, the CQ bot, builds with the default
jumbo chunk size, and since it uses goma that is 8. Building
with relatively small chunks (8) means that it doesn't notice
symbol clashes that happen with larger chunks so it's better to
build with the non-goma default, 50.

This will slightly reduce parallelism of builds, and might trigger
more files to be recompiled for changes, but it will also bring
along with it the benefits of larger jumbo chunks (less CPU cycles
spent per compiled cc file, faster linking) so it's not obvious
how it will affect performance, if at all.

Bug: 905588
Change-Id: I950ef63093f60580e98891aa0f556fa57b5d6628
Reviewed-on: https://chromium-review.googlesource.com/c/1337496Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#608822}

This is no longer used.

R=tbarzic@chromium.org

Bug: 904892
Test: none
Change-Id: Iac3088bdc2b198d0d5b37ab9cf18fba5c4c704c8
Reviewed-on: https://chromium-review.googlesource.com/c/1334331Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608821}

Migrate HandoffCollectionViewController from CollectionViewController to ChromeTableViewControllerStyleWithAppBar.

This CL migrates the HandoffCollectionViewController from
CollectionViewController, which is based on MDCCollectionViewController,
to ChromeTableViewController, which is based on UITableViewController.

Bug: 894791
Change-Id: I4b6e25e3729ad2150fbc49fd6c71c54229f76f31
Reviewed-on: https://chromium-review.googlesource.com/c/1340326Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608820}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7893fd8c43b1..fe9b104421c3


Created with:
  gclient setdep -r src-internal@fe9b104421c3

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Iddf93095c8a8ca2e453cbe7fddf71c2cba38b400
Reviewed-on: https://chromium-review.googlesource.com/c/1340147Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608819}

Chrome can see multiple hints from the server that a field is a
new-password field. This happens, in particular, if two fields
have the same name and hence the same signature -- because server
hints are keyed by the signature, there is no way to specify two
different types for two fields with the same name.

If there is no other explicitly hinted confirmation field, then it
is likely that in reality one of the new-password fields was supposed
to be a confirmation field.


Knowing which field is the confirmation field will be useful for
Chrome to understand where to copy the generated password to.

Therefore, this CL makes sure that the second hinted same-signature
new-password field is marked as a confirmation field, unless the server
also explicitly hints that some field is a confirmation field.

This is analogous to what the parser already does in case of two
fields with the autocomplete="new-password" attribute.

Bug: 902700
Change-Id: I06e75a6d1059976c68d04903351d9bd207de2ee9
Reviewed-on: https://chromium-review.googlesource.com/c/1326511
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608818}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowBaseSyncPrimitives in non-test files
 * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=rmcilroy@chromium.org

Bug: 766678
Change-Id: Ibed489dd8ea6d845199f91081f3e986f3014cf67
Reviewed-on: https://chromium-review.googlesource.com/c/1325196
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608817}