- 06 Nov, 2018 40 commits
-
-
Mohsen Izadi authored
This reverts commit 8dff7904. Reason for revert: Apparently causes crashes on Windows: http://crbug/ 902279. Original change's description: > Change the order of handling inkdrop and dispatch event. > > InkDrop is handled before View::OnMouseEvent() in OnMouseEvent(). > So, If I want to override the functions associated with InkDrop(ex : CreateInkDropHighlight()), > there is a problem with not getting the something appropriate(ex. Button::STATE) > > Bug: none > Change-Id: I8543a1354197a42478075b941671e5c0e59fc0b7 > Reviewed-on: https://chromium-review.googlesource.com/c/1309561 > Reviewed-by: Mohsen Izadi <mohsen@chromium.org> > Commit-Queue: Mohsen Izadi <mohsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605254} TBR=tapted@chromium.org,mohsen@chromium.org,sangseok.jang@navercorp.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: I6ac4f8911c946fd600f74570f4ec3c0e00558297 Reviewed-on: https://chromium-review.googlesource.com/c/1319857Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605715}
-
Manu Cornet authored
Extend the shelf hover area to the edges of the screen. Bug: 899007 Change-Id: I344e80c9c2272ec70d5c638646bd9d5f0086f87a Reviewed-on: https://chromium-review.googlesource.com/c/1318799Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#605714}
-
Mike Frysinger authored
None of these Python modules are executable (lack main funcs), so it doesn't make sense to have +x perms on them. Bug: 747171 Change-Id: I393d7210f4885dc3db506d94ce50ac736e3fe22e Reviewed-on: https://chromium-review.googlesource.com/c/1319170Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#605713}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/9a227bed7a0f..749d64c35e09 $ git log 9a227bed7..749d64c35 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 junyer Optimise the check for large substrings. 2018-11-05 junyer Fix the check for large substrings. 2018-10-31 junyer Improve the "MATCHING WITH SUBSTRING EXTRACTION" comment. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 902131 Change-Id: Ic281b472f8c68e64c33d026859ed8e3429c015f5 Reviewed-on: https://chromium-review.googlesource.com/c/1319341Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605712}
-
Max Moroz authored
Integration fuzzer for appcache, focusing on logical behavior, not parsing. Bug: 888926 Change-Id: I5871940f39d191f0b75fad49952961bd312d8a0b Reviewed-on: https://chromium-review.googlesource.com/c/1302101 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
-
Philip Rogers authored
This change enables PaintTouchActionRects by default. This is a new implementation of how the blink->cc logic works for the css touch-action feature. The big idea behind PaintTouchActionRects is to compute touch-action rects during paint, in paint order, as part of the background paint phase. With this change we expect better performance (primarily a drop in ScrollingCoordinator time: Blink.ScrollingCoordinator.UpdateTime) as well as observable bug fixes (e.g., https://crbug.com/826746). This patch has several small parts: 1) runtime_enabled_features.json5 makes PaintTouchActionRects as stable. 2) The paint-touchaction-rects expectations have been made the default. 3) The paint-touchaction-rects virtual test suite has been removed. 4) 6 tests have been marked as passing (fixed with this feature). Bug: 836905 Change-Id: I2bc12b335e8762eafde882bc475982df7e74a7d1 Reviewed-on: https://chromium-review.googlesource.com/c/1313051Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Xianda Sun <sunxd@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#605710}
-
Kush Sinha authored
Add functionality to fetch auth codes for Secondary Accounts in Chrome OS Account Manager. Design doc and sequence diagrams are linked in the bug id. Bug: 871690 Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" Change-Id: I4c317ccce0d22e1cf55728726cdc8dc55f2a49a1 Reviewed-on: https://chromium-review.googlesource.com/c/1228124 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605709}
-
Friedrich Horschig authored
For unknown reasons, the filling integration tests are failing on clank bots. The flakiness dashboard [1] shows little to no flakiness on all regular bots. This is one attempt to fix it: ensure the feature is enabled on all integration tests. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=chrome_public_test_apk&tests=ManualFillingIntegrationTest Bug: 896210 Change-Id: I2d6c56ab6c59c186ed61777aa9b694bcf640a9fd Reviewed-on: https://chromium-review.googlesource.com/c/1318921Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#605708}
-
Boris Sazonov authored
This CL adds subclasses of AppCompatImageView and AppCompatImageButton to work around an issue when ImageView doesn't invalidate the drawable after the state has changed. This CL also replaces all instances of AppCompatImageView and AppCompatImageButton with newly added ChromeImageView and ChromeImageButton. Bug: 894770 Change-Id: I897e157e44c5eddd9602bd97137e0d1592b11c2b Reviewed-on: https://chromium-review.googlesource.com/c/1310273 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#605707}
-
Artem Titarenko authored
Bug: 901324 Change-Id: Ib7efaefaecc54f72dc1a81559e195b20009fb0c1 Reviewed-on: https://chromium-review.googlesource.com/c/1314591 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#605706}
-
Rayan Kanso authored
The test has been consistently failing for the past few runs. More details in the bug. TBR=bsheedy@chromium.org Bug: 902319 Change-Id: I9dbd161610a7bb3d9010e7b7a0e6fed802c74cc9 Reviewed-on: https://chromium-review.googlesource.com/c/1318920Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#605705}
-
Charlie Harrison authored
Right now popups have a strange relationship with TabSpecificContentSettings. Right now: the infobar is opened if: - A global NOTIFICATION_WEB_CONTENT_SETTINGS_CHANGED is received - !IsBlockageIndicated(POPUPS) in TSCS - There are blocked popups At first glance this seems reasonable. However, popups do not abide by the typical TSCS notion of blockage being indicated. On Android, we create a new infobar for every new popup blocked. On Desktop, these new popups do not trigger another animation of the blocked image. So, TSCS has android specific logic which resets the "indicated" bit every time popups are marked as blocked. This CL simplifies this complex interaction by removing it completely. The PopupBlockerTabHelper is now responsible for the straightforward creation of the infobar. This CL has no (%comment) intended behavior change. Bug: 900645 Change-Id: I440b9b3b6f8d160f1b4d34f8fb7f566dc7dfb72d Reviewed-on: https://chromium-review.googlesource.com/c/1308635 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605704}
-
Alex Clarke authored
This wasn't previously possible but the timing of the callback was changed by patch https://chromium-review.googlesource.com/c/chromium/src/+/1317629 Bug: 902277 Change-Id: I351872539b4ff2ebcb944a6ea76bd2021249f8ae Reviewed-on: https://chromium-review.googlesource.com/c/1319613Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#605703}
-
Karolina Soltys authored
In preparation for removing MessageLoop, we are making ThreadMain invoke SetTimerSlack on the SequenceManager as well as the MessageLoop. Bug: 891670 Change-Id: I5e4fc8af654a62d543e3965603ee15c206a31d93 Reviewed-on: https://chromium-review.googlesource.com/c/1310433Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#605702}
-
Dianna Hu authored
This CL lands server change 214662680 by bnc. BUG=488484 Change-Id: I09b53752fb3c49082ace4297a89dc331a9abe457 Reviewed-on: https://chromium-review.googlesource.com/c/1289331 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#605701}
-
Rayan Kanso authored
- testDeepLink - testMainIntent - testSourcePropagated - testTargetShareActivityPreserved More details in the bug. TBR=hanxi@chromium.org Bug: 902325 Change-Id: Id290535e5e067bfa5abda7d86a179e08d4296991 Reviewed-on: https://chromium-review.googlesource.com/c/1319676Reviewed-by:
-
Hans Wennborg authored
The purpose of these asserts is to check that the options structs are aligned sufficiently that an int64_t (or similar) could be added to them. The asserts were added in https://codereview.chromium.org/295383012 However, the alignment of int64_t on 32-bit x86 is actually 4 bytes, not 8. So how did this ever work? Before Clang r345419, the alignof() operator (which is what MOJO_ALIGNOF maps to) would return the *preferred alignment* of a type, not the *ABI alignment*. That's not what the C and C++ standards specify, so the bug was fixed and the asserts started firing. (See also https://llvm.org/pr26547) To fix the build, change the asserts to check that int64_t requires 8 bytes alignment *or less*. Bug: 900406 Change-Id: Icf80cea80ac31082423faab8c192420d0b98d515 Reviewed-on: https://chromium-review.googlesource.com/c/1318971 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e4a55fc6dd08..5b640e3d331b git log e4a55fc6dd08..5b640e3d331b --date=short --no-merges --format='%ad %ae %s' 2018-11-06 lalitm@google.com Merge "trace_processor: fix passing partition column constraints to child tables" Created with: gclient setdep -r src/third_party/perfetto@5b640e3d331b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib81eb02c8d8b70b18f743af328b79d48460e1eac Reviewed-on: https://chromium-review.googlesource.com/c/1319386Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605698}
-
Bence Béky authored
This CL lands internal change 219482008 by mpw and 220269504 by bnc. Bug: 488484 Change-Id: Ib007d57d277d0b7c21f10e0c6ce4c9f34c42652d Reviewed-on: https://chromium-review.googlesource.com/c/1318853Reviewed-by:
Dianna Hu <diannahu@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605697}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e6bab3a..5597b278 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I52482cd98a2c3afeee390a001016a74e37ca4c90 Reviewed-on: https://chromium-review.googlesource.com/c/1319633Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605696}
-
Guido Urdaneta authored
This CL sends the chrome::NOTIFICATION_WEB_CONTENT_SETTINGS_CHANGED when a device is removed. This fixes a bug that occurs when a navigation occurs on a tab that is capturing audio or video. In this case, it is possible that the navigation will complete before the device has been completely stopped, and the new page will show an icon with the device capture permission corresponding to the previous page on the omnibar. To remove that icon, it is necessary to let the tab know that content settings might have changed. If the navigation completes after the device stops, the bug does not reproduce because completing the navigation sends the notification about the change in content settings. This bug becomes much more frequent when Site Isolation is enabled. Bug: 896211 Change-Id: I6e9d7197d549b00b458ffc84d155487cb3db2fe6 Reviewed-on: https://chromium-review.googlesource.com/c/1319595Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605695}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01ed846cb1db..04f1c7dac0fd Created with: gclient setdep -r src-internal@04f1c7dac0fd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9bd80081a5698a061b429a936af6e5b639890a88 Reviewed-on: https://chromium-review.googlesource.com/c/1319385Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605694}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e70c6b13dd55..00b29398901e git log e70c6b13dd55..00b29398901e --date=short --no-merges --format='%ad %ae %s' 2018-11-06 brianosman@google.com Remove some more GrColor references Created with: gclient setdep -r src/third_party/skia@00b29398901e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Iec16d6b8eab8b11499cf79f25958ae69940a4734 Reviewed-on: https://chromium-review.googlesource.com/c/1319809Reviewed-by:
-
Jonathan Metzman authored
TBR=mmoroz@chromium.org Change-Id: Ie786c64a581e76fa5737265bbac195597b01cb0d Reviewed-on: https://chromium-review.googlesource.com/c/1319853Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
-
Sam Maier authored
Bug: 898251 Change-Id: Iaaffb966d4cd3da6563bcc321b7db201b124292c Reviewed-on: https://chromium-review.googlesource.com/c/1312341 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/254d3db59ad9..a8f54617c08d git log 254d3db59ad9..a8f54617c08d --date=short --no-merges --format='%ad %ae %s' 2018-11-06 eladalon@webrtc.org nit: Use make_unique in rtp_video_stream_receiver.cc 2018-11-06 nisse@webrtc.org Simplify use of events in TestAudioDevice 2018-11-06 magjed@webrtc.org Android: Add option to set presentation timestamp in EglRenderer 2018-11-06 jonaso@webrtc.org Add audio level to CSRC class 2018-11-06 sprang@webrtc.org Update FakeEncoder to use EncoderInfo Created with: gclient setdep -r src/third_party/webrtc@a8f54617c08d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:b/119004693 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2a1e0f6dd7a1ecf74d426af22b07397dcd78d7c2 Reviewed-on: https://chromium-review.googlesource.com/c/1319384Reviewed-by:
-
Ben Kelly authored
As a step towards removing WebDataConsumerHandle stop using the type in DataPipeAndDataBytesConsumer. Instead this code can instead use DataPipeBytesConsumer to read the mojo::DataPipe. Bug: 894819 Change-Id: Ie9cad46dfa9d67998d23bf0efd6300870428f3cb Reviewed-on: https://chromium-review.googlesource.com/c/1313389Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#605689}
-
David 'Digit' Turner authored
Ensure that compile_resources.py will put temporary resource directories under $ANDROID_DEBUG_TEM_RESOURCES_DIR/<target_name>/ This makes it easier to distinguish between temp resources of different packages, as discussed in a previous CL [1], which was merged too soon by mistake (it was supposed to include this change). [1] https://chromium-review.googlesource.com/c/chromium/src/+/1288436/ BUG=879228 R=agrieve@chromium.org, estevenson@chromium.org, yfriedman@chromium.org Change-Id: I0cc7e2f675e70ddc5cb23c270a801a5c2655e023 Reviewed-on: https://chromium-review.googlesource.com/c/1318912Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#605688}
-
gogerald authored
For example, Interstitial page is shown if it is blocked by safe browsing, like bad ssl. Bug: 806868 Change-Id: I2f5f0ddfcc0b4efae6174772108b98697a383121 Reviewed-on: https://chromium-review.googlesource.com/c/1315707Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#605687}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9a5dbc6f4454..6ba6af1e543b git log 9a5dbc6f4454..6ba6af1e543b --date=short --no-merges --format='%ad %ae %s' 2018-11-06 nednguyen@google.com Disable testSuccessfullyStartBrowserWithSystemCacheClearOptions on win10 Created with: gclient setdep -r src/third_party/catapult@6ba6af1e543b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:902268 TBR=sullivan@chromium.org Change-Id: I276b3d0931fe789e59d6d653857695421b46908e Reviewed-on: https://chromium-review.googlesource.com/c/1319383Reviewed-by:
-
Dave Tapuska authored
Use appropriate types in fetch code. BUG=879657 Change-Id: I7f26d8a6651abafbb185193cc2670bcdb5eff05e Reviewed-on: https://chromium-review.googlesource.com/c/1298329Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#605685}
-
Jonathan Metzman authored
Fix link to reproduce tool. Include note about using powershell. Remove "> " from command. Mention that document is for libFuzzer explicitly. Be more consistent about capitalization of "libFuzzer". TBR=mmoroz@chromium.org Bug: 901836 Change-Id: I9a91be5d01c2707366b1d8100cb0823c221aa82e Reviewed-on: https://chromium-review.googlesource.com/c/1318918 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
-
Karolina Soltys authored
In preparation for removing MessageLoop, we are making ThreadQueue responsible for recording queue times of tasks depending on the setting in SequenceManager. The same functionally in MessageLoopTaskRunner is still preserved, to be removed at a later date. Bug: 891670 Change-Id: I89a197c0d7bf0878841ae241406f1528698a4ee8 Reviewed-on: https://chromium-review.googlesource.com/c/1299154Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#605683}
-
Gauthier Ambard authored
This CL refactors the NTP header, changing the name of the variables to have something more understandable. It also changes the creation of the subviews of the fake omnibox, moving it to the view. Bug: 893522 Change-Id: Ib03f6e25a303016fdb6296011f05153667cfa2c3 Reviewed-on: https://chromium-review.googlesource.com/c/1309836 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605682}
-
Hans Wennborg authored
TBR=vitaliii Bug: 902297 Change-Id: I4663a2a70f13494b0bb3656eafb5e219efa955dc Reviewed-on: https://chromium-review.googlesource.com/c/1318916Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#605681}
-
David 'Digit' Turner authored
This was previously disabled because the GVR APK was loading its library with the system dlopen(), then passing the handle to code in libchrome.so, which happened to call the crazy linker dlsym() wrapper with it. This resulted in runtime crashes until a work-around was added in [1]. The Java check was never removed though, so this CL does it. [1] https://chromium-review.googlesource.com/885763 BUG=895194 R=agrieve@chromium.org, pasko@chromium.org Change-Id: If742399452336d349eb763a76357a38a72f6707e Reviewed-on: https://chromium-review.googlesource.com/c/1319589Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#605680}
-
Findit authored
Revert "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look." This reverts commit cc75805c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 605652 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NjNzU4MDVjMWYzMmNhZDY2MDFmNzVjZjRjYWRmYmVlMjM0NDYzN2QM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/12757 Sample Failed Step: net_unittests Original change's description: > Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look. > > Change-Id: I9fd9486172a13cd8924dd622aa6984285e07ac6c > Reviewed-on: https://chromium-review.googlesource.com/c/1315961 > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Bin Wu <wub@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605652} Change-Id: I4f8a4dea97f700bf98c8a244f9a505f083eb53b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1319850 Cr-Commit-Position: refs/heads/master@{#605679}
-
Henrik Boström authored
With the changes, the test should pass regardless of if the Chrome or Firefox behavior is used for what to do when no MSIDs are signaled. Follow-up work is needed to test both the case of "a=msid:-" and no "a=msid" line whatsoever, awaiting spec issue to be resolved: https://github.com/w3c/webrtc-pc/issues/2027 // Relying on fippo's approval to land. TBR=hta@chromium.org Bug: 901711 Change-Id: Icaf089d206413510aadad54a0c10b2674450385a Reviewed-on: https://chromium-review.googlesource.com/c/1319612Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605678}
-
Luna Lu authored
After research, tentatively updating the unoptimized-images policy as: no using more than 0.5 byte per pixel of image data with approximate header size (1KB) removed. Bug: 901925 Change-Id: Ibc5b2e2e6ccaba7a273c63440d48d4e0d154cc2e Reviewed-on: https://chromium-review.googlesource.com/c/1318372Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#605677}
-
barkerd authored
Bug: 898840 Change-Id: Ib60cc54ed76911a42a637e6d859c7eb459f3e11d Reviewed-on: https://chromium-review.googlesource.com/c/1317850 Commit-Queue: David Barker <barkerd@google.com> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#605676}
-
