- 12 Feb, 2020 40 commits
-
-
Piotr Bialecki authored
Updates the Anchors API to align with changes proposed in the immersive-web CG repository: https://github.com/immersive-web/anchors/pull/29 Change-Id: I1ebc332c1f4b00c8912bf132f924ffa3f383dfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051394Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#740830}
-
Yusuf Sengul authored
Bug: 1048927 Change-Id: I03aa5f9db7b09278581989f53cecb79bd9bac07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036487 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#740829}
-
Sajjad Mirza authored
Bug: 1049421 Change-Id: I3cdcac516547d7e81d30aeb05e280d708d063255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040313 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740828}
-
Danyao Wang authored
PaymentApp::IsValidForCanMakePayment() is only used to compute hasEnrolledInstrument(). Update this name to HasEnrolledInstrument() to more accurately reflect the behavior. Bug: 915907 Change-Id: Ib6281ef0856f1acc6a8d67bbc8ff7b06a69a8684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052190 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740827}
-
Tina Wang authored
Add the component to build file and fix the importing and depending errors that occurred. Remove the inheritance of the TextBubble since we are no longer using a pop-up dialog as a profile card container. Bug: 1051208, 1051537 Change-Id: I23b71bc4f2f5d2fd9e8034cd0d35a1e4da2c6d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047460 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#740826}
-
Tricia Crichton authored
ChromeDriver does not check the status after calling GET_SIZE, this can lead to a crash if the page is modified during the command execution. Bug: chromedriver:3240 Change-Id: I083503fa32e659512e460209d006609b5e4048af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051736Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#740825}
-
Xianzhu Wang authored
Previously if a filter has empty content, the bounds of the SaveLayerOp was left unset, causing bad performance in pdf renderer. Now set the bounds to an empty rect. Bug: 918240, 1050694 Change-Id: I7d39336c9525a32af88dac29dc2eb0dc38cd067f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047380Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740824}
-
Becca Hughes authored
Make data table generic so we can reuse it and then adds a playbacks tab. BUG=1024353 Change-Id: I19acb277bb874576e39951d8dda567c2c7e29484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048288Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#740823}
-
Sammie Quon authored
Applies the following to a bunch of buttons: - Change texture ink drop highlight to use solid color layer - Remove masks and use api which takes advantage of clipping Applies to all cros buttons except the ones in: ash/system as those have quite a bit of customization. Test: manual Bug: 1042303 Change-Id: Ibdbf334a397f1b91d5e867ab5d2ca4e96780deb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048040 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#740822}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d9bd62fafb66..0844b9a3b625 git log d9bd62fafb66..0844b9a3b625 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 thestig@chromium.org Prevent destruction of CXFA_FFWidget across FWL events. 2020-02-12 tsepez@chromium.org Add test case for PDF password annotations 2020-02-12 aadhir@microsoft.com Sending focused annotation update to the host Created with: gclient setdep -r src/third_party/pdfium@0844b9a3b625 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003501,chromium:1039629,chromium:989027 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I769609126ada35d6238d4f6d756ea4b5a126c5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052095Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740821}
-
Rayan Kanso authored
Bug: 1051209 Change-Id: Id6b15f35f6db717162beb601147bbcf3f5ff35b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051104Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#740820}
-
Nico Weber authored
Bug: 1022385 Change-Id: I63b21f0c2d082bdc2befc5cb7dc3deff4095ae43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051534Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740819}
-
Meilin Wang authored
|Service| stores the current account info and later registered as a session activation observer for this account, so that it can enable listening when the session becomes active. Previously when the login account was a fake gaia account, e.g. in Tast tests, we did not update the stored account info with the latest primary account when requesting access token. In this way, |Service| couldn't receive any session active signals because it was not observing a valid account. Bug: b/147442943 Test: run the service in signed-out mode and manually verified. Change-Id: Iaaef86303686291b419754505ead9b14cca0adbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033642 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#740818}
-
Meilin Wang authored
This CL adds a new test case to ensure we update the supported action list stored in |AssistantManagerServiceImpl| when ambient mode state has changed. Bug: b/149237062 Test: run the new unit test added in this change. Change-Id: Idc3c538e023cb59e76fb6c71219e4846da6d9c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969777 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#740817}
-
Karan Bhatia authored
EstimateMemoryUsage() should return the dynamcially allocated memory for an object, however this is not spelled out explicitly in the header. Do so. BUG=None. Change-Id: I13b7abf31c76c6ba56f9b094f28f43de4e8a429a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043093 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#740816}
-
Yilong Yao authored
Bug: 32486634 Test: CQ Change-Id: I1418d910625d32ac67d33624c002ca630b1de37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048407 Commit-Queue: Yilong Yao <yilongyao@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#740815}
-
Yue Li authored
Open app queries do not trigger text/html response. We need to handle the case to make it valid for the private API. Bug: 982538 Test: Test with the newly added Assistant Tast test Change-Id: Ib78b6534f973a46b413fd998c0e60ccdd8fd2f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050581Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#740814}
-
Dave Tapuska authored
In preparation for removing the gfx::Size<->blink::WebSize typemapping change WebMediaPlayer to use gfx::Size. This also fixes an issue in change http://crrev.com/e65cabb75f that transposed width and height in the webmediaplayer_ms.cc Change-Id: Ide6243df9ba82043cabb5d69f1d6fd79c832f059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052266Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#740813}
-
Lan Wei authored
There are two ways to trigger fullscreen, either by user activation or by a user generated orientation change. When we enter the fullscreen mode, we should not consume the user activation in the browser side when the fullscreen is triggered by a user generated orientation change, so we need to set the orientation change flag in the browser side when we are calling the mock function setMockScreenOrientation through a mojo message. The CL that consumes the user activation on both the browser and renderer sides when entering fullscreen: https://chromium-review.googlesource.com/c/chromium/src/+/1903675 Bug: 1046933 Change-Id: I1eb86205bc82ac237bc12d63bbdb0c8985c06090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026170Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#740812}
-
Mark Yacoub authored
If the device supports KMS Atomic APIs, Enable CRTC using Atomic Modeset Commit instead of legacy SetCRTC. BUG=987274 TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps HardwareDisplayPlaneManagerAtomicTest.CheckPropsAfterModeset Change-Id: I116a2caf8602aa6470c9cf17a65fa12c045f8d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039752 Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#740811}
-
Su Hong Koo authored
Add ash::features::kCornerShortcuts flag to toggle corner shortcuts feature. Bug: 660748 Change-Id: I9d93a8412bc2238fb5bdb49501120b5603976b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044635 Commit-Queue: Su Hong Koo <sukoo@google.com> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#740810}
-
Chris Blume authored
CheckerImageTracker::ShouldCheckerImage() has the equivalent of: bool thing = true; if (thing) { thing = should_do_thing(); The branch is always taken and thus doesn't need to be a branch. This CL removes the branch. Change-Id: Ib73170ed3064bfe6ad690fc4377e741e4f595831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047379Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#740809}
-
Alex Newcomer authored
Add the metrics reporter to the hotseat widget for all layer animations, but this time initialize the reporters state. TBR=mpearson@chromium.org Bug: 1049385 Change-Id: Ia48ca639aa3a317adf395ba6822b70cfb3008d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047604Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#740808}
-
Jamie Madill authored
conformance/extensions/webgl-compressed-texture-size-limit.html Bug: 1051576 Tbr: ynovikov@chromium.org Change-Id: I697655db44c0111c618f20deafe7e92386305420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051530Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#740807}
-
Mike Wittman authored
Now that per-sample timestamps are provided to the ProfileBuilder we can set the actual profile start time -- the time the first sample is taken -- rather than using the prior approximation of when the CallStackProfileBuilder class was created. This will be used when applying retrospective metadata, to ignore requests on time ranges prior to the profile start time. Bug: 1034758 Change-Id: Idf51c4e40dd853408d5f7baee6e9f657d18aa061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015724 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#740806}
-
Manu Cornet authored
Change-Id: I5bf1f77fc99deb35dfd473aa03689ab023b419eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052221Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#740805}
-
Tom Anderson authored
At least with Intel drivers, deepcolor visuals may be of BGR format isntead of RGB like on Nvidia. Skia recently added support for 30bpp BGR formats [1], so use this new format to support this configuration. [1] https://skia.googlesource.com/skia/+/f7eb0544a8853eb087e20a0e5e7bc3597de02074 R=mtklein Bug: 1016383 Change-Id: I22ffd649f7cfd7c6ed132250dee35c7960210fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052206 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#740804}
-
kylechar authored
The UMA has expired and hasn't been used lately. Remove it and associated plumbing. The UMA was set across processes so this involves mojo IPC. Also change where the SurfaceSynchronizationEvent traces are collected. Record a trace for all synchronization events, they might be useful and are pretty low volume, with the corresponding SurfaceId. This allows simplification of SurfaceObserver by not plumbing |duration| around. Bug: 1036988 Change-Id: I5661fe56a7c9129de458faf37f1cad6a1c13c6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047451Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#740803}
-
Regan Hsu authored
* Remove dup of syncAdvancedPageTitle * Move strings out of shared string provider to browser and OS, since browser version has a chromeOS browser version and a DICE enabled version of sync sign out dialog strings Bug: 967888 Change-Id: Ia9fbec3d8c26727857ccd083a7d65f25abe01f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048663 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#740802}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/378c0f1b0817..56690232104c git log 378c0f1b0817..56690232104c --date=short --first-parent --format='%ad %ae %s' 2020-02-12 tvanderlippe@chromium.org Migrate coverage/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Add javascript source formatting e2etest 2020-02-12 tvanderlippe@chromium.org Migrate formatter_worker/ to import cross-module 2020-02-12 jacktfranklin@chromium.org Prefer eslint-mocha for linting `.only` in tests 2020-02-12 aerotwist@chromium.org Enable colored output from test subprocesses 2020-02-12 tvanderlippe@chromium.org Migrate performance_monitor/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Migrate perf_ui/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Migrate screencast/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@56690232104c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1ab6a43b774bb622d6bde1e4efc789c529fae022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052100Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740801}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGImage> and DynamicTo<SVGImage> as new downcast helper 2. Use IsA<SVGImage>(element) in place of IsSVGImage(element) Bug: 891908 Change-Id: I1d64a5726953fa0d637ce352985ae7f466361b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032450Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#740800}
-
Olle Liljenzin authored
Adds a dedicated fuzzer for LookupStringInFixedSet() as the function is no longer tested by the GetDomainAndRegistry fuzzer. The fuzzer is using a forward generated DAFSA based on the public suffix list and reuses the dictionary from the GetDomainAndRegistry fuzzer. BUG=1048702 Change-Id: If123985c60efab57faddaa934e6674042dd4d07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050498Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Olle Liljenzin <ollel@opera.com> Cr-Commit-Position: refs/heads/master@{#740799}
-
Sigurdur Asgeirsson authored
There is no safe way to allocate a crashpad::Annotation other than in global or static storage. This CL fixes the UAF that occurs if the ActivityTrackerAnnotationTest::RegistersOnFirstSet runs before any other test that calls crash_reporter::ResetCrashKeysForTesting. Bug: 2051194 Change-Id: I140ee80bac6379e181664d9b7db3db3b76854636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051533Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#740798}
-
Yicheng Li authored
This change implements the MakeCredential operation in ChromeOS authenticator. The authenticator data is extracted from the dbus response returned by ChromeOS platform daemons. Bug: b:144861739 Change-Id: I4332a973e75aa900e348658bd639c7a78335caa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986976Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#740797}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-4028.0-1580727432-benchmark-81.0.4044.4-r1 to 82-4028.0-1580727110-benchmark-81.0.4044.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifcc2b0c383c85e8e89e18535c6a58febe6fa4e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740796}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/6b138fb083cf..4ab0c36c448d git log 6b138fb083cf..4ab0c36c448d --date=short --first-parent --format='%ad %ae %s' 2020-02-12 jophba@chromium.org Add command line argument to enable trace logging Created with: gclient setdep -r src/third_party/openscreen/src@4ab0c36c448d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I8c2b7dd422b28723140bf80cca5cec6b78300da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051721Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740795}
-
Kristi Park authored
This reverts commit ad16c6ff. Reason for revert: Suspected cause of recent flakes for __main__.ChromeDriverSecureContextTest.testAddCredentialBase64Errors https://ci.chromium.org/p/chromium/builders/try/mac-rel/301082 Original change's description: > [ChromeDriver] After test timeout, trigger crash > > After a test times out during a ChromeDriver command, trigger a Chrome > crash and a minidump collection for troubleshooting. This is not > available on tests connecting to a remote browser, or when running on > Android. > > > Bug: 1045241 > Change-Id: I3cb82d95875d0f58a4acee69d249a92801b8024b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032238 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Tricia Crichton <triciac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740311} TBR=johnchen@chromium.org,triciac@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045241, 1051383 Change-Id: I851c1b636f7ae43a6c23e01f00f3d093b58cc235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050676Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740794}
-
Etienne Bergeron authored
Adding the SQL category to chase bugs from crbug/1051180. R=etiennep@chromium.org, oysteine@chromium.org Bug: 1051180 Change-Id: Ibc6c125bb49c27060fec139fbe53d9fcb89a510c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050751Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#740793}
-
Hiroshige Hayashizaki authored
This CL adds HTTPS->HTTP direct cases for mixed-content tests. The requests are rejected not in initial requests, but during redirect handling. The added tests expose the following issues on Chromium: Issue 1048619: - gen/top.http-rp/opt-in/sharedworker-import-data/cross-https.swap-scheme.https.html - gen/top.http-rp/opt-in/sharedworker-import-data/same-https.swap-scheme.https.html Issue 1050826: Requests are blocked as expected but no events are fired, causing test timeout. - gen/top.http-rp/opt-in/object-tag/cross-https.swap-scheme.https.html - gen/top.http-rp/opt-in/object-tag/same-https.swap-scheme.https.html Bug: 1048619, 1050826, 906850 Change-Id: I0aaa88788a28a20cd95b3dbfb078481c20786bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047823Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#740792}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16cb8948..f4ae4cac Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2ce695d88e7c5dbd782768c2bd0524f9fe8cfe5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051199Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740791}
-