- 25 Nov, 2019 40 commits
-
-
Ramin Halavati authored
Size 25 is added to incognito icons (formerly 24 and 20) for better support of scale factor 125%. Bug: 997054 Change-Id: Ia1028f2262490d4aa6d78e69fa0e90638f993b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886330 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#718544}
-
Adam Rice authored
Error the stream if the input to DecompressionStream is truncated, or there is junk after the end of the stream. This will help avoid accidental loss of data. Also add a thorough test of the behaviour when various fields of a compressed stream are corrupted. Also test that errors are correctly issued when the stream is truncated or has trailing junk. BUG=1014422 Change-Id: I8aceeafd279b75d4fea76d7edca19024856417c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928428Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#718543}
-
Yutaka Hirano authored
Files I'm familar with have been moved to /services/network, so I am no longer a good reviewer for changes on this directory. NOTRY=true Bug: None Change-Id: I8e4439486735dd319a2ef2ed63b316b997509f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933857Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#718542}
-
Emircan Uysaler authored
This CL would allow us to enable work that are behind feature flags. Bug: 1026011 Change-Id: Ifaa69e184811ffe0062cc10389b31e54fc8a76db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931657 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718541}
-
Peter Kasting authored
This is a regression fix from https://chromium-review.googlesource.com/c/chromium/src/+/1920433 , where labels with STYLE_SECONDARY changed from "secondary" to "primary" foreground color. Make use of this in a few places where people were using LabelDisabledColor to mean "hint/secondary" instead of "disabled". Bug: 1024091 Change-Id: I9917995edbadf596a57f192ef1b8b8044b815aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931505 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#718540}
-
Adam Rice authored
The CHECKs added in https://chromium-review.googlesource.com/c/chromium/src/+/1837445 indicate that |consumer_| is being cleared in the BodyStreamBuffer constructor during the call to ReadableStream::CreateWithCountQueueingStrategy(). There's no apparent way this can happen. Add new temporary CHECKs to the places where |consumer_| is cleared to verify that we are not inside the call to ReadableStream::CreateWithCountQueueingStrategy(). These should result in a stack trace at the point where the problem occurs. BUG=1007162 Change-Id: I571214597ff714f34b2cfb63d2c42f42d53733d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928513Reviewed-by:
-
Noel Gordon authored
Fix test after CL:1933859, now the background color is transparent. No-try: true No-presubmit: true Bug: 742944 Change-Id: Ib9af5c847f5453394d8f2062f3bd97f9d2a1c901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933864Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#718538}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves |controller_| and relevant functions from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I5071af71eaa5e75ef70142d2a06b8c962a938a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933854Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
Remove some service_worker_{database,storage}.h includes which aren't required. Bug: N/A Change-Id: Ia54a2ac5b18fd74676275f164a076cc08078f7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933667Reviewed-by:Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#718536}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e4fe6876. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0d027cf9728dfcd6b8f5c918907a1049f8300395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933472Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718535}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/59327542f41b..4ec3efef499f git log 59327542f41b..4ec3efef499f --date=short --no-merges --format='%ad %ae %s' 2019-11-25 abennetts@google.com Add origin-trial tokens to pinpoint's index.html for prod and local dev (localhost:8080). Created with: gclient setdep -r src/third_party/catapult@4ec3efef499f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026356 Tbr: crouleau@chromium.org Change-Id: Ie27a6caf7436423ede16ab2bfacff02dccc7d877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718534}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e43b53126600..2ad66eccb5d5 git log e43b53126600..2ad66eccb5d5 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 126f20ed..0ec8ef3c (718412:718517) 2019-11-23 mbonadei@webrtc.org Revert "Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium."" 2019-11-23 mbonadei@webrtc.org Reland "Make webrtc_fuzzer_main depend on webrtc_component in Chromium." 2019-11-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 53149b64..126f20ed (718304:718412) 2019-11-23 peah@webrtc.org Changed the digital AGC1 gain to properly support multichannel 2019-11-23 mbonadei@webrtc.org Revert "Make webrtc_fuzzer_main depend on webrtc_component in Chromium." 2019-11-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5395db8b..53149b64 (718200:718304) 2019-11-22 peah@webrtc.org AGC: Removing unnneccessary copying and changing to using const 2019-11-22 jonaso@webrtc.org Make IceController injectable 2019-11-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 022da7ca..5395db8b (716991:718200) 2019-11-22 saza@webrtc.org Add multi-channel support to AECM 2019-11-22 mellem@webrtc.org Add TimeController to api/test/ and add a CreateTimeController API. 2019-11-22 peah@webrtc.org Making the Analog AGC properly support multi-channel 2019-11-22 peah@webrtc.org Adding VoIP specific channel adjustments 2019-11-22 jonaso@webrtc.org Move IceFieldTrials into own .h-file 2019-11-22 mbonadei@webrtc.org Make webrtc_fuzzer_main depend on webrtc_component in Chromium. 2019-11-22 henrika@webrtc.org Improves device enumeration in ADM2 for Windows. Created with: gclient setdep -r src/third_party/webrtc@2ad66eccb5d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None,chromium:896154,chromium:896154,chromium:None,chromium:896154,chromium:None,chromium:1024965,chromium:None,chromium:1027117,chromium:896154 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ba939153caa74ee66136c256a2b608b635701c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933636Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes |LayoutInline::InvalidateDisplayItemClients()| to utilize |NGInlineCursor| for preparation of migrating to |NGFragmentItem|. Bug: 982194 Change-Id: I95b2e8669eb2ede4724cad72275f9ffd98e7af7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930287 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718532}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/61ad456558ce..d8bfc516141d git log 61ad456558ce..d8bfc516141d --date=short --no-merges --format='%ad %ae %s' 2019-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 137e8082..0ec8ef3c (1040 commits) Created with: gclient setdep -r src/third_party/skia@d8bfc516141d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bungeman@google.com Change-Id: Ic7a1424a46f90a843250b0082425340029f0225b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933635Reviewed-by:
-
Dominic Farolino authored
R=kinuko@chromium.org Change-Id: Ieb2b39c2156521d93ed3cd4a1eb0d8ebb46f2536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931161Reviewed-by:
-
Noel Gordon authored
CL:720656 injected CSS into the QuickView <webview> for PDF/Text. PDF does not inject CSS after CL:1933850 and moreover, keeps the <webview> transparent. We can use that fact to fix the text file rendering issue introduced by CL:720656. From https://bugs.chromium.org/p/chromium/issues/detail?id=742944#c37, using webview.insertCSS() sometimes works, and sometimes does not, due to <webview> permissions check races. And the result is different text renderings of the same text file, depending on race results. The cause is calling insertCSS in the loadstart event i.e., too early. Delay it until contentload fires; that avoids the permissions race. Bug: 742944 No-try: true Change-Id: I0c637d5366ee6cf3448c65035b2932a62f925d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933859Reviewed-by:
-
David Lei authored
Remove chromeos/resources/media_app_resources.grdp from WATCHLISTS as we are now using a grd file that we own. No functional change. Bug: 996088 Change-Id: Ia10f0f326127653589ce8141bfea26d1aa1eff8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933835Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#718528}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=edman@chromium.org Bug: 1023677 Change-Id: I62e49b6a82c96b1268889793d777f85a8be29341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926917 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Edman Anjos <edman@chromium.org> Commit-Queue: Edman Anjos <edman@chromium.org> Cr-Commit-Position: refs/heads/master@{#718527}
-
Adam Rice authored
Previously, invalid URLs passed to the QuicTransport constructor would result in an exception message that was missing the URL that was passed. Pass the original input string to QuicTransport::Init so that it can be used in exception messages even if it is not a valid URL. BUG=1011392 Change-Id: I8423e357d32054b58fbf067ff132167934c06fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919520Reviewed-by:
-
Noel Gordon authored
The MimeHandlerViewInCrossProcessFrame feature has shipped in ChromeOS and the QuickView PDF tests should no longer crash on the MSAN bots as a result. Re-enable these tests on MSAN. Tbr: slangley Bug: 768070 Change-Id: I77d195ffec0ea620c8681d3c3dc64406832b7674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933834Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c4c685b2b8b..61ad456558ce git log 6c4c685b2b8b..61ad456558ce --date=short --no-merges --format='%ad %ae %s' 2019-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c8d4d4254ca1..d44d61514749 (4 commits) Created with: gclient setdep -r src/third_party/skia@61ad456558ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bungeman@google.com Change-Id: I8ce2ea4592c792575a38da3dd9e03d2f4342de2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933929Reviewed-by:
-
Reilly Grant authored
Bug: 1007786, 1007635 Change-Id: I9ad54b444749ccb93d7c16422b64a8ff39bfc618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931150 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#718523}
-
Reilly Grant authored
Bug: 1007656 Change-Id: Ie20d3f1931a279fa1c6a2bd5d40d64848f6f37eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929394 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#718522}
-
Noel Gordon authored
QuickView renders PDF/Text content in a <webview>. Change the style of of that <webview> to be fully transparent. And, in the case of the PDF viewer, do not inject any CSS into the viewer at all, so the viewer is in complete control of when/what things draw inside the <webview>. Thus, if there is any color flashing / FOUC during <webview> rendering in Files app QuickView, then the PDF/Text rendering JS/C++ sub-systems are to blame. Bug: 1001034 No-try: true Change-Id: I7d6c4ea178548a97777d81651087ceb8fad6bb45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933850 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#718521}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves |frame_tree_node_id_|, |fetch_request_window_id_|, and |web_contents_getter| from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: Ia95c3dbc70d3e8d55727dfbb65905beb674ca3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930366 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5459c3891e2c..59327542f41b git log 5459c3891e2c..59327542f41b --date=short --no-merges --format='%ad %ae %s' 2019-11-25 abennetts@google.com Fix `./bin/dev_server pinpoint.yaml`. Created with: gclient setdep -r src/third_party/catapult@59327542f41b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: crouleau@chromium.org Change-Id: I3e16e25e09ba1ba3fae8657fd217cd4d4ac27987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933372Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I8845a4b6dd9c88b2e5d47fe023567c77b13c39b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932338Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718518}
-
Antonio Gomes authored
... and use WTF::String instead. BUG=787254 R=guidou@chromium.org Change-Id: I90c3275bf9aa00a6e62a28369b5fab0c3f2c6b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930854 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#718517}
-
Melissa Zhang authored
BUG=1019549 Change-Id: Icf40f16be92256fef4cd27a730e48b54ac10ec2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933679Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718516}
-
Austin Tankiang authored
Bug: 988923 Change-Id: I497d468796c1301a4dd8d7e825962022de97e585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923212Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/856c2a69d235..4fae2545ff9e Created with: gclient setdep -r src-internal@4fae2545ff9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I7d5af0195746a06b8911724b53965ef83c572afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933747Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718514}
-
George Burgess IV authored
In the CR for r638591, it seemed like people liked the idea of delivering clang-tidy as a part of our regular toolchain packaging process. Skimming the comments, my understanding is that this wasn't done at the time in part because we weren't working with the monorepo. Now that we're on the monorepo, it seems there aren't other blockers. This is its own package instead of being part of the regular compiler package, since it's assumed that: - not all users will care about clang-tidy - if a new bug is introduced in clang-tidy, we'd want to roll clang-tidy back without rolling clang back This package is named generically, since it looks like we have a vague want for other clang-tools-extra tools (clangd, clangd-indexer). Going forward, the intent is to make clang_tidy_tool.py sync this clang-tidy package by default, instead of syncing and building its own LLVM tree to extract clang-tidy from. Bug: 633856 Change-Id: Ied51b0d73c23a991d2545aabc06533432a3a31b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749646 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#718513}
-
Alexey Baskakov authored
This is a preparation CL to implement WasExternalAppUninstalledByUser in WebAppInstallFinalizer. Bug: 891172 Change-Id: I3cfaf1e96c72cd1970e8cd49d2d53f0a3c268401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930283 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#718512}
-
David Munro authored
Bug: chromium:848127 Test: Build and unit tests Cq-Depend: chromium:1930355 Change-Id: If9b39882bdae9ba91fc65523f9788e4213e33ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925835 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718511}
-
Chih-Yu Huang authored
VDA doesn't need to dismiss all the old buffers before requesting new buffers by calling VDA::Client::ProvidePictureBuffers(). This CL removes the check in the VDA tests. Bug: b:136716838 Test: pass video_decode_accelerator_tests on Kevin and Eve Change-Id: I33b62ffa007ea58dc1256ad43d0a7ac22144a737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930247Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718510}
-
Anand K. Mistry authored
When an item is selected using up/down->enter, the dropdown is closed. The only way to re-open it is to tab away and back. Allowing the user to re-open by pressing enter follows the behaviour of the select element. Bug: 851427 Change-Id: I8418b9cdbbcf48873844709d1b0453657dc0d3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921023Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#718509}
-
Evan Stade authored
Set ACCEPT_LANGUAGES based on the entire locale list, rather than just the top locale. It also updates ACCEPT_LANGUAGES when the list changes, rather than just once at startup. Navigator.language and .languages are likewise updated. The ResourceBundle now loads new strings as well, although WebLayer only packs English strings at the moment. Bug: 1025064 Change-Id: I18997eb20c883a976edf624c0a5f45b5f012aff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924722 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#718508}
-
Wei Wang authored
This patch implements ServiceWorkerContainer.onmessageerror and writes WPT test for it. chromestatus: https://chromestatus.com/feature/5699031592337408 Bug: 926102 Change-Id: I60e73dcb69de4a2876cc966dfa1809a30510b5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864409Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#718507}
-
Luciano Pacheco authored
Add test that checks that "src" attribute is cleared when closing the quick view, if the "src" isn't cleared the video continues to play, while it's hidden, but the audio is still audible. Bug: 970192, 1005556 Change-Id: I73d628d7d424b7f795622108eb7a1f0c7b7bcc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933671 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
Bug: 1007832 Change-Id: Ie5d38ff2973de77790c12c5ed2664f070704d19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930246Reviewed-by:
-
