GitLab

Rename variables to be clearer in their intention, use a switch
statement instead of an if/else if/else blocks and wrap the whole thing
as a step function to properly catch failing asserts.

Bug: 
Change-Id: I89c92d7a5071728bfdd8c9827f08ae3af94377db
Reviewed-on: https://chromium-review.googlesource.com/809425Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522076}

Bug: 598854
Change-Id: Icb9b7586a8b14772dded0b4c1c323a3668dba371
Reviewed-on: https://chromium-review.googlesource.com/804350Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522075}

Also rearrange parameter ordering in AIDI::Create. Both of these
changes are to simplify callback binding for the new factory in
https://chromium-review.googlesource.com/c/chromium/src/+/771196.

Bug: 653871
Change-Id: I825b519e664c0e4cafecff85f199d3bc145c8fda
Reviewed-on: https://chromium-review.googlesource.com/795970
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522074}

https://chromium.googlesource.com/catapult.git/+log/a9cf2fa54a33..307c9f954dc5

$ git log a9cf2fa54..307c9f954 --date=short --no-merges --format='%ad %ae %s'
2017-12-06 perezju [Telemetry] Cleanup android_forwarder code

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I49d420746ee0dcba3eb77afd52d0427dafb322c4
Reviewed-on: https://chromium-review.googlesource.com/809721
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522073}

in preparation for using it in more tests (UI tests in particular).
Also contains some other minor cleanups.

Bug: 791066
Change-Id: I5bd2c7e3e99655e3ff453fc447c69f1484ce3d5b
Reviewed-on: https://chromium-review.googlesource.com/808764Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522072}

Make the trailingAnchor of the stackView inside bookmarkTableCell always
equals to contentView's trailingAnchor.  This can prevent
crbug.com/778231 where the stackView's width doesn't grow as expected
when editing folder name on iOS 10.

Bug: 791976
Change-Id: I71fac7e335561fe7f54beb1062602976b0b2a280
Reviewed-on: https://chromium-review.googlesource.com/809988Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522071}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/5c4b603461a7..e494ee7de6e2

$ git log 5c4b60346..e494ee7de --date=short --no-merges --format='%ad %ae %s'
2017-12-01 ljusten authpolicy: Add GetUserStatusRequest and OU errors

R=ljusten@chromium.org

Created with:
  roll-dep src/third_party/cros_system_api

BUG=chromium:782695

Change-Id: I14032dae5bcbd811fb9afa0561b2e6d4173167df
Reviewed-on: https://chromium-review.googlesource.com/809112
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522070}

This is in preparation for ReplaceTrack. When we have ReplaceTrack, the
WebRTCRtpSender is modifiable. Having an internal ref counted class
ensures that if one WebRTCRtpSender is modified, this is reflected in
all shallow copies of the class.

In other words, this CL enables content::RTCRtpSender having internal
modifiable states separate from the webrtc::RtpSenderInterface.

Made some misc fly-by changes like renaming "webrtc_rtp_sender"
variables/methods to "webrtc_sender" and making
WebRTCRtpSender::Track() return by value instead of pointer (since
there is a "null" value).

Bug: 790007
Change-Id: I3f11b2af7457b6c3b9e6de5d97c32085bf050280
Reviewed-on: https://chromium-review.googlesource.com/806161Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522069}

Add a tool to generate preload data in DAFSA format and
add a MediaEngagementPreloadedList class to read it.

BUG=787464

TBR=dpranke@chromium.org

Change-Id: If0d99a2e1091d0b23699f2173d8146582173ee54
Reviewed-on: https://chromium-review.googlesource.com/803994
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522068}

This relands crrev.com/c/691663 which confirms that nostate prefetch
sets cookies on all fetches. In the interim a test for cross-domain
fetches has been added.

The original CL was reverted due to flakes on windows. I could not
reliably reproduce the flakes, but in addition to the usual CQ, I've
run this several times on the windows bots, and it is no longer
flaking. Perhaps commit e23356c2 which moved browser_test_utils to
mojo access of cookies removed whatever race existed, or perhaps using
PostDelayedTask instead of sleeping fixed it.

Bug: 
Change-Id: I71ef3053c71da53e21093dc57d977e3992d279ef
Reviewed-on: https://chromium-review.googlesource.com/695221
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522067}

Bug: 788289
Change-Id: I20634f6dc7ad2ef0e7313c647da746e745c29f79
Reviewed-on: https://chromium-review.googlesource.com/788862Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522066}

- Add a call on ThreadHeap for manual calls
- Emit function call after fast flag checks in Member

Bug: chromium:757440
Change-Id: I8d019d0e9d1bae5a23bf6ed5e8f6a1d818c713b6
Reviewed-on: https://chromium-review.googlesource.com/808244
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522065}

This includes making SharedMemory::GetReadOnlyHandle() const.
Getting a handle with write permissions is currently const, so it makes
no sense at all that getting a handle with read only permissions is not
const :).

Bug: 653871
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie98fde38535f5ffe0ae51949ae043c38c9791eb8
Reviewed-on: https://chromium-review.googlesource.com/806655
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522064}

The stack view button is only needed on iPhone. The iPad have the tab
switcher button.

Bug: 791456
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie2f0044d59218d27f8253b3b44bea1c5fbc7ef19
Reviewed-on: https://chromium-review.googlesource.com/808864Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522063}

This CL adds a warning to be displayed before the user can export
their passwords.

Mocks:
https://docs.google.com/presentation/d/1nIm5OmaOnb85ZAwMZPSVqHT0vkFbsRYZhOzbmznWU_c/edit#slide=id.g289b1efcd8_0_21

Note: the mock shows slightly different styling, but with the UX
designer we settled on using a standard dialog style already existing
in Chromium and checking separately whether that style needs fixing,
rather than introducing inconsistent styling among Chrome's dialogs.

Design: go chrome-pwd-export

Screenshot: https://crbug.com/788701#c7

Bug: 788701
Change-Id: I3a2dbdc24429c5662fdc2b178630a8e45ba603a1
Reviewed-on: https://chromium-review.googlesource.com/803955
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522062}

Mocks: go chrome-pwd-export-mocks-android (Google-internal only)

Screencast after the change: https://crbug.com/788701#c3

The CL adds a reauthentication step before the user can trigger
exporting passwords.

In addition to that, the CL also wraps the check for screen lock
availability in ReauthenticationManager.isScreenLockSetUp, to
make it possible to override for testing.

Also, this CL adds two tests for viewing passwords, because one
of earlier iterations of this CL broke something for the viewing
passwords feature and such tests would have caught it.

Bug: 788701
Change-Id: Ibfa37192e26bc5797236ba9378aa1eb0f17f79cc
Reviewed-on: https://chromium-review.googlesource.com/797453
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522061}

The clean toolbar buttons should have the same size and positioning
as the current toolbar.
This CL ensures this is happening.

Before: https://drive.google.com/file/d/1vorlHlUZvIZMV94iplEcPWdIPigV5Hgs/view
After: https://drive.google.com/file/d/1E1s8PKtyWILCvaO-fy8OX8-UJi_BoAK1/view

Bug: 791978
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie46f44c8eec3cb4fc194127d3092d8ea9328bd69
Reviewed-on: https://chromium-review.googlesource.com/809105
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522060}

Tests are needed for viewing passwords in settings. Those tests need
an easy way to mock PasswordUIView, which communicates with C++ in the
production version.

Therefore this CL does:
(1) Define an interface, PasswordManagerHandler, for the public methods of
    PasswordUIView to be mocked in the tests (coming in
    https://crrev.com/c/797453).
(2) Create PasswordManagerHandlerProvider which encapsulates the logic
    for managing observers, life-time and test-replacement of the
    PasswordManagerHandler implementations.
(3) Lift SavedPasswordEntry to top level for reasons explained in its
    class comment.

This CL should not change any functionality, so current test coverage
is assumed to be sufficient for the new code.
The new tests are postponed until https://crrev.com/c/797453, which
also introduces other test utilities to make writing them less of a
pain.

Bug: 788701
Change-Id: I2b90a613065df50cad85de85ffa620a88df61a6e
Reviewed-on: https://chromium-review.googlesource.com/806155
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522059}

1. Upstream crossorigin.html to wpt
2. Remove tests from [1] infavor of the web platform tests in [2]
[1]: media/track/opera/interfaces/HTMLElement/HTMLMediaElement/
[2]: external/wpt/html/semantics/embedded-content/media-elements
	/interfaces/HTMLElement/HTMLMediaElement

Bug: 782555
Change-Id: I9f5ce13d2782ab2313b6026307e0e031485b177d
Reviewed-on: https://chromium-review.googlesource.com/807757Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#522058}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id605c1ab97e273ae9e783e3925457e5ca87daf5c
Reviewed-on: https://chromium-review.googlesource.com/809126
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522057}

This reverts commit c47b4d11.

BUG=chromium:791131
TEST=video_ChromeRTCHWDecodeUsed on peach_pit
Reason for revert: This CL breaks video_ChromeRTCHWDecodeUsed

Original change's description:
> WebRTC: Migrate completely to new video codec factories API
> 
> This CL makes the Chromium HW video factories implement the new
> interfaces directly. It also adds SW codecs, simulcast, and SW fallback
> codecs manually, instead of relying on WebRTC to do this. This will
> give Chromium more flexibility in the future, and will allow us to
> simplify the WebRTC code, since it's only Chromium that uses some of
> these features.
> 
> Bug: webrtc:7925
> Change-Id: I2bbd8b9a8c52bfe963d601f34188faf47d59e67e
> Reviewed-on: https://chromium-review.googlesource.com/788410
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Commit-Queue: Magnus Jedvert <magjed@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520062}

TBR=haraken@chromium.org,emircan@chromium.org,magjed@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:7925
Change-Id: I081f9f5d961707924fe6eed4a97ead9c9f5ed12c
Reviewed-on: https://chromium-review.googlesource.com/810429Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522056}

This is a second reland attempt for
07edac9e after a fix for the
underlying issue has landed:
https://chromium-review.googlesource.com/c/chromium/src/+/807664

Original change's description:
> Migrate away from deprecated RunLoop API
>
> Instead, we keep around an instance of base::RunLoop and pass it
> explicitly for Quit(), which makes sure the code quits the intended loop
> and not a nested one.
>
> Bug: 783774
> Change-Id: I3ea5092699bbae127f581e5c955cb27904d98f0a
> Reviewed-on: https://chromium-review.googlesource.com/784790
> Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519664}

TBR=pavely@chromium.org

Bug: 783774
Change-Id: I615b4a92ff59a8f4cf871d63327bb8ba063d1cfc
Reviewed-on: https://chromium-review.googlesource.com/803314Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522055}

Bug: NONE
Change-Id: I5e79a366942948f8361f25db0d2cae68a412c016
Reviewed-on: https://chromium-review.googlesource.com/809107
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522054}

TBR=chrome-os-gardeners@google.com

Change-Id: I95aacbb926d1b3923e51160be0a40a004bc93a67
Reviewed-on: https://chromium-review.googlesource.com/809823Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522053}

First create an EGLImage from a given gl texture.
Then export the EGLImage as dmabuf.

In addition to the new unit test included in this CL,
this will be useful for the subsequent CL,
https://chromium-review.googlesource.com/c/chromium/src/+/766787
which will enable existing VaapiDrmPicture when passing --use-gl=egl.
While existing VaapiTFPPicture(X11) will be left for --use-gl=desktop.

Added unit test ui/gl/gl_image_native_pixmap_unittest.cc
The test is enabled on non-ozone but should work on ozone too.
If any of the pre-conditions fail then the test is skipped.
Specifically it requires the extension EGL_MESA_image_dma_buf_export.
So it works on Intel, AMDGPU and nouveau drivers but skipped on NVIDIA.

Bug: 785201
Test: gl_unittests --gtest_filter=*NativePixmap*

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id9b4e56aaaaf5fd9994f4b144ce74a234d848253
Reviewed-on: https://chromium-review.googlesource.com/766687
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522052}

We have not supported valgrind for some time (it was never ported to
the GN build IIUC, and has been obsoleted by ASan/MSan/TSan).

BUG=791518

Change-Id: I9d6f5125de817b9334b295a8a78589004bb08294
Reviewed-on: https://chromium-review.googlesource.com/809132
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522051}

Service Factory does not own the service. BrowserStates owns it. Service
Factory only creates that service.

This CL updates the comments where appropriate.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icaf33df99b1c27f7c9be4a098e1ca25d86bd0687
Reviewed-on: https://chromium-review.googlesource.com/809816
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522050}

We are adding network traffic annotation to all data send requests in
Chrome to provide transparency and audibility.
This CL is the first step in adding this argument to sockets data send.
In this CL the argument is added to "Write" function of
"net/socket/socket.h", and all files affected by this change are
minimally updated to compile. The added argument to all functions
has a default value to minimize code change. Once all callers have been
updated to pass a traffic annotation, the default will be removed.

Bug: 656607
Change-Id: Ib3bef20ffa8d58d9b2fedc8b6970ff0cf66f844b
Reviewed-on: https://chromium-review.googlesource.com/806219
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522049}

After we remove LayoutBoxModelObject::SetSelectionState() implementation,
LayoutObject::SetSelectionState() is no longer needed to be virtual
since there are no other calls.
Thus, we can remove |virtual| from LayoutObject::SetSelectionState().

Bug: 739062
Change-Id: I49b1426f9fc89586d1e818b10385c18c5223399e
Reviewed-on: https://chromium-review.googlesource.com/802603
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522048}

Directory components/signin/core/common was removed but still mentioned
in several DEPS files.

Bug: 
Change-Id: Ie1ab30ed38463e84953a8f98108e7ac7e19041cb
Reviewed-on: https://chromium-review.googlesource.com/807904Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#522047}

::slotted rules are treated as a separate set of style rules
for Shadow DOM V1 fast path, but once V0 shadow root is created
anywhere in the document, the set has to be merged into
tree boundary crossing rule sets.

This is a regression when V1 fast path for ::slotted rules was
introduced at https://crrev.com/492282.

To trigger this bug, the following conditions have to be met:
1. V1 shadow root is added to the document and
   stylesheet including ::slotted() rules is added and resolved
   (the style is applied to some part)
2. V0 shadow root is added to the same document
3. style for the element which ::slotted() rule would apply is
   recalculated
   (Expected: ::slotted() rule still applies, Actual: it does not)

If V0 shadow root is created at the same time or before the
style sheet including ::slotted() rules is added to the document,
this bug doesn't occur.

Bug: 791400
Change-Id: I11bd028cf8020f11a5ab42cb680a4c8c18e47c2d
Reviewed-on: https://chromium-review.googlesource.com/807968
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522046}

We have not supported valgrind for some time (it was never ported to
the GN build IIUC, and has been obsoleted by ASan/MSan/TSan).

BUG=791518

Change-Id: Id24289347d0811ed51a0b9ac036c746ef18bf75f
Reviewed-on: https://chromium-review.googlesource.com/809426Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#522045}

This patch asserts that we clear the NonAttachedStyle at the end of
attaching LayoutTree. This ensures correctness of
https://chromium-review.googlesource.com/c/chromium/src/+/765097

Bug: 792080
Change-Id: Ia3a1d376bddb84fb4c8751739144ef07e3bd18ae
Reviewed-on: https://chromium-review.googlesource.com/809989Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522044}

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
with other appropriate task runners in the renderer.

Bug: 786332
Change-Id: Ie55366522fb749fb895806b0ec423a22e9842330
Reviewed-on: https://chromium-review.googlesource.com/808093
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522043}

We have not supported valgrind for some time (it was never ported to
the GN build IIUC, and has been obsoleted by ASan/MSan/TSan).

BUG=791518

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0948b46f523be2a28894306b9377646d111c22a8
Reviewed-on: https://chromium-review.googlesource.com/809131Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#522042}

These tests were added/changed in r522016.
-SiteIsolationStatsGathererBrowserTest/SiteIsolationStatsGathererBrowserTest.CrossSiteDocumentBlockingForMimeType/0
-SiteIsolationStatsGathererBrowserTest/SiteIsolationStatsGathererBrowserTest.CrossSiteDocumentBlockingForMimeType/1
-CrossSiteDocumentBlockingTest.BlockDocuments
-CrossSiteDocumentBlockingIsolatedOriginTest.BlockDocumentsFromIsolatedOrigin
-CrossSiteDocumentBlockingTest.RangeRequest

Most failures (even the non-StatsGatherer ones) seem to be about histograms.

Bug: 786505, 729848
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2302d55d5de41c904c38c675fc57122316ceec15
NOTRY: true
TBR: jam
Reviewed-on: https://chromium-review.googlesource.com/810247Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522041}

This patch implements serialization of CSSUnparsedValue correctly.
There was a previous implementation, but stuff like 'var(--A)'
serialized to '--A', not 'var(--A)'.

Spec: https://drafts.css-houdini.org/css-typed-om-1/#unparsedvalue-serialization

Bug: 782103
Change-Id: Ieaecddb2f1a271b023e4fb7a720077e5ffcfc01f
Reviewed-on: https://chromium-review.googlesource.com/805176
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522040}

The tests changed names in r521963:
DeclarativeNetRequestResourceTypeBrowserTest.Test1/0
DeclarativeNetRequestResourceTypeBrowserTest.Test1/1
DeclarativeNetRequestResourceTypeBrowserTest.Test2/1
DeclarativeNetRequestResourceTypeBrowserTest.Test2/0

Bug: 721414
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I9979c953d34305968f6a2eacc3873eadc2faae32
NOTRY: true
TBR: jam
Reviewed-on: https://chromium-review.googlesource.com/810445Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522039}

InstallableManager caches the data it fetches as part of the
installability check. This means that sites which change their manifest,
or inject a manifest after the check is run are incorrectly classified.

This CL makes InstallableManager listen to the
WebContentsObserver::DidUpdateWebManifestURL() method, and invalidates
its internal state when the method fires. This addresses the issue by
making InstallableManager refetch data when we know that the manifest
URL is different.

Tests are added to ensure the correct behaviour.

BUG=792299

Change-Id: If73128b7b86bd741c16235c8a8e7ec5f0caeb165
Reviewed-on: https://chromium-review.googlesource.com/809994
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522038}

This CL adds a new method of the profiling_service mojom interface which
asynchronously returns the list of profiled processes. This is used in two places:
  * By the chrome://memory-internals to determine whether a process is being
  profiled. This also allows chrome://memory-internals to expose a "start
  profiling" button for non-profiled processes.
  * By the background profiling triggers, since traces should only be triggered
  if a profiled process exceeds the thresholds.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I44da48eb1203b82f9cef8907fc7c2ab0fdcfdfce
Reviewed-on: https://chromium-review.googlesource.com/809505
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522037}