GitLab

A fairly recent change introduced a history of page_ids for each RenderView, to validate that Navigation's go to legitimate pages.

In the prerender and instant cases, the history of page_id's was not accurate, because it was not offset to reflect the point in time when the page was swapped in. For example, if the history for the tab looks like

about:blank
http://www.launchprerender.com/
http://www.prerendered_page.com/first_page.html
http://www.prerendered_page.com/second_page.html

The history of page_id's in the prerender-page RenderView should look like

[-1, -1, 13, 14] - with the first two entries being -1 since they are not captured in this render view.

Before this fix, it would look like

[13, 14] - and when the back navigation was attempted, the length was not as long as expected.

BUG=89798
TEST=Go to prerender_test.appspot.com, do a prerender on dev.chromium.org, click on a link within dev.chromium.org, press back and see that it works instead of spinning forever. Also, browser_tests --gtest_filter=*BackToPrerenderedPage, which fails without the change.

Review URL: http://codereview.chromium.org/7491096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96109 0039d316-1c4b-4281-b951-d872f2087c98

GTTF: Use a fresh TestingBrowserProcess for each test, part #5

For a detailed description see part #1, http://codereview.chromium.org/6478005/

This CL fixes the bug fully on Windows. More platforms will follow.

BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/7601006

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7552029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Unittests.

Review URL: http://codereview.chromium.org/7508044

TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/7604021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7604014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91371
TEST=none

Review URL: http://codereview.chromium.org/7605014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96104 0039d316-1c4b-4281-b951-d872f2087c98

A gyp file that generates a Visual studio solution for only certain targets and their transitive dependencies.

Review URL: http://codereview.chromium.org/7528011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=ncbray@google.com
Review URL: http://codereview.chromium.org/7552027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96101 0039d316-1c4b-4281-b951-d872f2087c98

standalone tarballs for V8.

This will be useful for Linux distributions packaging
shared library packages for V8.

BUG=none

Review URL: http://codereview.chromium.org/7600011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96099 0039d316-1c4b-4281-b951-d872f2087c98

For a detailed description see part #1, http://codereview.chromium.org/6478005/

This CL fixes the bug fully on Windows. More platforms will follow.

BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/7601006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96098 0039d316-1c4b-4281-b951-d872f2087c98

We've been seeing in the histograms that for some users, page feature
extraction is taking much longer than we would like, up to 200ms between
stops. This could possibly contribute to jankiness in the UI. These are some
timings from my desktop for how long it takes to extract features before and
after these changes. Obviously this is on much better hardware than the use case
we are worried about, but hopefully the increase is speed is proportional.

           Before  After
CNN        19       7.5    
ESPN       22       9.5
Google     12       4
Salon      40       12

BUG=
TEST=Ran associated unit tests.


Review URL: http://codereview.chromium.org/7549003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96097 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90214
TEST=PipelineImplTest.*

Review URL: http://codereview.chromium.org/7484054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96096 0039d316-1c4b-4281-b951-d872f2087c98

we don't need to rely on system SQLite being compiled
with specific flags.

BUG=22208

Review URL: http://codereview.chromium.org/7552022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96095 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the var tracking in the proxy with the var tracking in the
shared_impl that's used by the implementation. It adds a new ProxyObjectVar
to be the proxied plugin analog of NPObjectVar in the impl. This new object
just keeps track of the host data.

The tricky part is to make the var tracker able to do all the crazy messaging.
This adds some virtual functions to the shared var tracker that we override
in the plugin in PluginVarTracker.

This removes the calls to the GetLiveObjectsForInstance in the var deprecated
test. It turns out this function really can't be implemented properly in the
proxy, and I don't know why it even worked before. A Release() call posts a
non-nestable task so the object isn't released until later. So to implement
the proxy for GetLiveObjectsForInstance we would also need to post a
non-nestable task. But when the test runs we're getting called from within
the plugin, so blocking on a non-nestable task deadlocks. So I just gave up
and deleted the parts of the test that uses it.

TEST=included
BUG=none
Review URL: http://codereview.chromium.org/7578001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7529047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68657
TEST=ExtensionServiceTest.ClearExtensionData

Review URL: http://codereview.chromium.org/7550020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96092 0039d316-1c4b-4281-b951-d872f2087c98

Trimmed some #includes and cleaned up some comments as well, but avoided functional changes.

Review URL: http://codereview.chromium.org/7493030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7584013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Unittests.

Review URL: http://codereview.chromium.org/7508044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96089 0039d316-1c4b-4281-b951-d872f2087c98

This gets set by ResourceDispatcherHost on URLRequest objects created
soon after a user gesture is detected.

Bypass anti-DDoS throttling on this load flag, with option to bypass
on other load flags in the future (e.g. possibly LOAD_BYPASS_CACHE).

BUG=83775
TEST=net_unittests. Also confirmed manually that the LOAD_MAYBE_USER_GESTURE load flag gets applied appropriately.

Review URL: http://codereview.chromium.org/7582004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96088 0039d316-1c4b-4281-b951-d872f2087c98

remove the pty import

BUG=the import pty makes Windows crash but it is not even used
TEST=no pty is imported


Review URL: http://codereview.chromium.org/7607001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96087 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7307037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96083 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7565017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96082 0039d316-1c4b-4281-b951-d872f2087c98

tests to fix flakiness.

BUG=91715
TEST=no
TBR=jochen

Original Review URL: http://codereview.chromium.org/7607003

Review URL: http://codereview.chromium.org/7606010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96081 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Compiles
BUG=None.

Review URL: http://codereview.chromium.org/7551034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96079 0039d316-1c4b-4281-b951-d872f2087c98

This is nearly identical to the reverted r96013, with the modification that
std::map::insert isn't used.  Its invocation was complex (such that
it worked in some compilers but not in others) and the performance gain is
negligible in any use case I've seen in Chromium.

BUG=91589

Review URL: http://codereview.chromium.org/7604006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96076 0039d316-1c4b-4281-b951-d872f2087c98

fix flakiness.

BUG=91715
TEST=no

Review URL: http://codereview.chromium.org/7607003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90807

Review URL: http://codereview.chromium.org/7584018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83242
TEST=Chromoting can connect using relay servers.

Review URL: http://codereview.chromium.org/7529039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7601014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96071 0039d316-1c4b-4281-b951-d872f2087c98

UIPI blocks keystate across process boundaries in certain situations. To be safe we maintain our own key state and intercept calls to GetKeyState. 

BUG=86895
TEST=Adobe has test coverage.
Review URL: http://codereview.chromium.org/7529041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96069 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a case where GpuInfoCollector may call a glX function without initializing the bindings.

BUG=fixes NOTREACHED on touchui build in accelerated_surface_container_touch.cc
TEST=none

Review URL: http://codereview.chromium.org/7607004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92105
Review URL: http://codereview.chromium.org/7608003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96066 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18876
TEST=See issue.

Review URL: http://codereview.chromium.org/7528016

TBR=stevenjb@google.com
Review URL: http://codereview.chromium.org/7607009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83242
TEST=NAT traversal works

Review URL: http://codereview.chromium.org/7598004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96060 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96059 0039d316-1c4b-4281-b951-d872f2087c98

This makes sure all the text sizes and baselines are correct. Roll GTM DEPS
r452:453 to pick up a fix for sizeToFit on rounded texture buttons.

BUG=86410
TEST=Anal polish.

Review URL: http://codereview.chromium.org/7601028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96058 0039d316-1c4b-4281-b951-d872f2087c98

Note that if the Instant experiment has already been enabled, and *then* the
user opts out of UMA, this won't disable the experiment immediately (since the
global field trial state doesn't change). Instead, it will be disabled at
browser restart. I think this is acceptable since, if the user is fiddling with
preferences after Instant has been enabled, they can already click the Instant
checkbox to turn it off.

In addition:
+ Fix a typo in the "Omnibox.QueryTime.*" histogram.
+ Update the comment in the .h file so it flows better.

BUG=91820
TEST=Disable UMA reporting (as is default in a Chromium build), and verify that the Instant experiment doesn't get enabled.


Review URL: http://codereview.chromium.org/7583012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96057 0039d316-1c4b-4281-b951-d872f2087c98

- Removes a DCHECK() in the InstantLoader that fired incorrectly in presentation
  mode.  In presentation mode, the omnibox is entirely enclosed by the web
  contents, so one part of the DCHECK() was incorrect.

- Mark popups and panels as auxiliary fullscreen windows.  This allows them to
  share a space with a fullscreen window, but not to become a fullscreen window.

- Force a relayout in windowDidFailToExitFullScreen.  Despite the name of the
  delegate method, when a window fails to exit fullscreen mode, it actually does
  exit fullscreen mode.  Forcing a relayout gets the window to draw correctly in
  this "failure" case.

- Fixes a DCHECK() when pressing escape in fullscreen mode.

- Pressing escape when the omnibox is focused (in non-presentation fullscreen
  mode) will now drop the window out of fullscreen mode.

BUG=74065
TEST=None

Review URL: http://codereview.chromium.org/7599029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96056 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18876
TEST=See issue.

Review URL: http://codereview.chromium.org/7528016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96054 0039d316-1c4b-4281-b951-d872f2087c98