- 13 Feb, 2020 40 commits
-
-
Yutaka Hirano authored
After crbug.com/957373 is fixed, <embed> and <object> elements should be loaded using the navigation code path. The special case logic in CanHandleDataURLRequestLocally was introduced at [1] to support them, but now they should be supported by some logic in the navigation code, not by this logic. 1: https://codereview.chromium.org/1091253004 Change-Id: I240cf868923c766391f2dab906ba07919030edcd Bug: 1049618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545313 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#740975}
-
Eric Willigers authored
LaunchService now has static methods to read the app id from tab helpers, and so set the app id on tab helpers. These methods support both web apps and Chrome platform apps. Web app uninstall tests now run for each configuration of the web app feature flags (DesktopPWAsWithoutExtensions and kDesktopPWAsUnifiedUiController). For example, we test that when a web app is open in a browser window tab (as opposed to an app window), and the app is uninstalled, the tab is not closed. Bug: 1049906 Change-Id: I1b0af85cec9e4908c9d1d18817ca7d671f07b78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044261 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#740974}
-
Alan Cutter authored
The distinction between a web app being installed from the install icon and "Create shortcut" was lost in https://chromium-review.googlesource.com/c/chromium/src/+/1950367. Previously we relied on the web app's scope being populated to indicate how the web app was installed by the user. This is no longer a reliable signal. This CL is removing the misleading data in the interest of removing an invalid dependency on web app scope being optional as part of making PWAs and "shortcut apps" behaviourally equivalent. Bug: 910016 Change-Id: Ida8a094897bfc9c51c3de8310c4ff66ea1996a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049007 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#740973}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b064c40a632..974547616075 Created with: gclient setdep -r src-internal@974547616075 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic51316cf04f28318a8e0b124c0dd7e7fe26fc574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053374Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740972}
-
Kenichi Ishibashi authored
This method was introduced to make response writer creation async but this isn't needed any more. The plan has changed to expose async version of GetNewResourceId() instead of making response writer creation async. Bug: 1046335 Change-Id: I4644aa2cd61ad61290ab64584ecc27a0fe3417cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051876Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#740971}
-
Keita Suzuki authored
This commit updates websocket handlers in net/data/websocket to support python 3 compatibility. Change-Id: I2f2bae4938c8abdfe2964e4973aecef6776d58d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051903Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Keita Suzuki <suzukikeita@google.com> Cr-Commit-Position: refs/heads/master@{#740970}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6029cbd560b7..1a733b5b760a git log 6029cbd560b7..1a733b5b760a --date=short --first-parent --format='%ad %ae %s' 2020-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b4a3bf71..07e508f1 (402 commits) Created with: gclient setdep -r src/third_party/skia@1a733b5b760a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I9e9111da739a36912b59ace1ab23a9e344b4e978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053615Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740969}
-
Trent Apted authored
This will hold the CIPD package coming in crrev.com/i/2543523 It's not possible to directly replace the git DEPS path without exploding the build for everyone. Bug: 1051776 Change-Id: Ibe1f631fd32711aba4c56030da04363f1167d0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053486Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#740968}
-
Alex Danilo authored
Bug: 992823 Change-Id: I8aa0e374431882c4c3bf90720006405416e2689d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053229Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#740967}
-
Regan Hsu authored
Bug: 1049830 Change-Id: Iee409159c737ec2c833374b7a0b7da583a61b23e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051038 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#740966}
-
Chris Harrelson authored
Bug: 1043628 Change-Id: Ib5c73b0099f54b339a790bdc8b6e0abd63f721dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044667 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740965}
-
Yu Han authored
Prior to this fix, when a select element's popup is open, a script in the background can modify the page's DOM that changes the position of select element on the screen. However, select popup remains stationary thus appearing disconnect from the select element. The select popup also doesn't update to the correct size if the script adds an new option with a long text. The reason is that select element doesn't check to see if the position or size of the select element popup relative to the document changed. For example, after the popup is displayed, a script could modify the document that changes the position of the select element. It doesn't notify its popup, thus makes them appear as disconnected. The fix is to update the select popup, its position and size, at the end of frame's life-cycle phase. This will guarantee that all elements in the frame have been styled and layout correctly. At this point, we can update the popup if its owner's position and size has been changed. The fix also removes the PostTask as a performance and simplicity optimization. An alternative proposal, use intersection observer on the owner element, was discussed. However, it still has the draw backs of post task. Plus, it may not capture all cases. In addition, I also considered and tried using PostTask within the UpdateLifecycle method. However, that's not optimal since within the popup's update method, it requires another call to UpdateStyleAndLayout because the layout could have been dirtied since the time PostTask was added into the queue. InternalPopupMenu::Update() also updates the select element's internal state, options. I saw some intermittent failures in couple of tests that validate options index. These tests use SetTimeout(), which may partly be aggravate by PostTask. I didn't investigate further as this is not the approach to take. This fix works for both Linux and Windows. I updated test popup-menu-resize-after-open to reflect that. In addition, I removed the (TODO) in listPicker.js. This fixes select popup when placed inside an iframe. For platforms that use external_popup_menu, mac and android, will be migrated to use internal_popup_menu when forms-refresh is rolled out to those platforms in M83. One of the biggest problem I encountered when doing this fix is that popup content doesn't updated when the popup is moved only. This is the same issue as crbug.com/633140. This review, https://codereview.chromium.org/2228093003, goes into more details on popup bounds synchronization between browser and renderer. Regardless, I had to make a similar fix in web_page_popup_impl.cc, calling SetWindowRect() when force_update is true. Bug: 137495 Change-Id: I7ef4c09a6d3d7bee3ef8988c815e07efa72d4a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013470 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#740964}
-
Lukasz Anforowicz authored
Bug: 1051674 Change-Id: I2fdb3e015b0bc7648dc433afd21b358a17887adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050757 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#740963}
-
Joey Scarr authored
Fixed: 1007827 Change-Id: Ieb75e6fe3241f2ed1d9f97db5e1f67a8f8c05e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050408 Commit-Queue: Joey Scarr <jsca@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#740962}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fd442ed0588..6b064c40a632 Created with: gclient setdep -r src-internal@6b064c40a632 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia8019ac085828502169bce67b227937dbb6bb6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053437Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/021ee4d7bbcf..dd239e7b7edc git log 021ee4d7bbcf..dd239e7b7edc --date=short --first-parent --format='%ad %ae %s' 2020-02-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@dd239e7b7edc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I507a8979be26ac89e77bcb691ea00022e3370a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053371Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9102c86a81ad..6029cbd560b7 git log 9102c86a81ad..6029cbd560b7 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@6029cbd560b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I450a81355fb3fc13de5d43b73b41efd2a8745019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053432Reviewed-by:
-
Christopher Cameron authored
Update viz::GLOutputSurfaceBufferQueue::texture_target_ from being determined at initialization to being determined at the time of viz::BufferQueue::Reshape. Fix viz::BufferQueue::Reshape to return true only if it really frees buffers (not if it just might), because we would end up using the now-uninitialized viz::GLOutputSurfaceBufferQueue::texture_target_. Bug: 1049334 Change-Id: Ic680ccfbc2d720cf57cc3fd3eb80017c866d5ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052211Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#740958}
-
Darwin Huang authored
Mechanical find/replace from "Trace(blink::Visitor*" to "Trace(Visitor*". Refactoring change only. No functional changes intended. Bug: 1051193 Change-Id: Ib26696312ee53cd872854c6193a51ced473cc60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052584Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#740957}
-
Joey Scarr authored
Fixed: 1007825 Change-Id: I9d5676db46e5669c144dd6fe6763f9969ab507a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050212 Commit-Queue: Joey Scarr <jsca@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0e950fb2be4e..2d81e7897a7e git log 0e950fb2be4e..2d81e7897a7e --date=short --first-parent --format='%ad %ae %s' 2020-02-13 fancl@chromium.org Revert "Remove the Sheriff model and related infra" Created with: gclient setdep -r src/third_party/catapult@2d81e7897a7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050891 Tbr: oysteine@google.com Change-Id: I5c6de0617fa950f7381a43a6176f163744f4f828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053435Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I95616a86c0b82b5f40527d90d33f7be46134c26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053723Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740954}
-
Lan Wei authored
This is a reland of a4cdec69 Original change's description: > Fix orientation change test full-screen-orientation-change.html > > There are two ways to trigger fullscreen, either by user activation or by > a user generated orientation change. When we enter the fullscreen mode, > we should not consume the user activation in the browser side when the > fullscreen is triggered by a user generated orientation change, so we > need to set the orientation change flag in the browser side when we are > calling the mock function setMockScreenOrientation through a mojo > message. > > The CL that consumes the user activation on both the browser and > renderer sides when entering fullscreen: > https://chromium-review.googlesource.com/c/chromium/src/+/1903675 > > > Bug: 1046933 > Change-Id: I1eb86205bc82ac237bc12d63bbdb0c8985c06090 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026170 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740812} TBR=kenrb@chromium.org,alexmos@chromium.org,lanwei@chromium.org Bug: 1046933 Change-Id: I93da4a368add521558ce49a8ef6d41022a5e5040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053511 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#740953}
-
Yingbing Wu authored
Adds "ImeMozcProto" flag. It will enable MOZC ime to use protobuf as interactive message format between decoder and JS client. Change-Id: I38be7452f310eaf108b390d853d4b3a7fee181bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051472 Commit-Queue: Yingbing Wu <wuyingbing@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#740952}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/3c647c956113..7ed8a344d043 git log 3c647c956113..7ed8a344d043 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 rwkeane@google.com mDNS: NSEC support in Querier 2020-02-13 btolsch@chromium.org Fix SenderSocketFactory integration issues 2020-02-13 btolsch@chromium.org Remove copy from NSEC reading Created with: gclient setdep -r src/third_party/openscreen/src@7ed8a344d043 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I969b0b8550bbae6c1fbad58471426afcf3fbdb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053369Reviewed-by:
-
Joshua Pawlicki authored
Bug: None Change-Id: I1d3e39758940a70d2734317c591b0b393beeda79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051541 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#740950}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Idbbec4740bc7b2ded6d2149206f70740a9acb2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050298Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#740949}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/da8eec5db306..0c4a5eb705f5 git log da8eec5db306..0c4a5eb705f5 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 sque@google.com roll out new goma client binary (VERSION=190) 2020-02-13 ehmaldonado@google.com git-cl: Use scm.GIT.FetchUpstreamTuple. 2020-02-13 ehmaldonado@google.com git-cl: Use mock.patch instead of custom mock. Created with: gclient setdep -r src/third_party/depot_tools@0c4a5eb705f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051631 Tbr: agable@chromium.org Change-Id: I0660adca1687516c3f72c4aa46ace8c068f891e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053368Reviewed-by:
-
Joshua Pawlicki authored
This is a reland of 0a5b7ba8 Original change's description: > Add updater service skeleton. > > Bug: 1048653 > Change-Id: I2fe5b3ef1c39cbaaca3b935b6646aea9de6ba1eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047447 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740699} Bug: 1048653 Change-Id: I1958707e99d40507588068d8ee5cda22ec8987f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053106Reviewed-by:
-
Dmitry Torokhov authored
We will be relying more on UDEV tagging devices for the purpose of identifying them (as external generic keyboards vs external Chrome OS branded keyboards, for example), and thus we will need a fake UDEV in our unit tests to be able to sully necessary data/properties. This teaches device_keyboard_handler_unittest to set to fake udev instance and instantiate fake udev devices with specified name, syspaths, attributes and properties, that would match real devices. Bug: b/144367328 Test: unit_tests Change-Id: Ida6b54e6f1fbcc9c92227263398c2edb02e8672f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051208Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#740946}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/add7c005351d..2fd442ed0588 Created with: gclient setdep -r src-internal@2fd442ed0588 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1051703 Tbr: jbudorick@google.com Change-Id: I86e5198adb48f72f1c7014d22bf2400eab956940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053367Reviewed-by:
-
Joey Scarr authored
Fixed: 1007828 Change-Id: I944e6aa42ce3bb6183fd1a685bc9104f59666489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049003Reviewed-by:
-
Joey Scarr authored
Fixed: 1007822 Change-Id: I9d102a066893f5917b14a63952de1092230c4182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050049Reviewed-by:
-
Alexey Baskakov authored
This reverts commit 41647287. Fails tests of bots https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3099 Original change's description: > Instantiate missing hosted_app_browsertests > > This CL fixes the following warnings thrown by browser_tests: > [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<HostedAppTestWithAutoupgradesDisabled> > [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<HostedAppPWAOnlyTestWithAutoupgradesDisabled> > > Change-Id: Iebf53094d7909a16ccd07e9e6150d600203ba5c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053225 > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740919} TBR=alancutter@chromium.org,ortuno@chromium.org Change-Id: I455ac1cc187166d53d111ebbf19e7bbf7798f7ed No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053629Reviewed-by:
-
David Van Cleve authored
This CL adds the top-frame origin of subresource requests from frames (including worker script fetches and subresource requests from dedicated workers) to URLLoaderFactoryParams, to be accessed in the network service by the frames' requests' URLLoaderFactories and URLLoaders. The initial scope of when this field is populated is deliberately small to simplify the change (and since the first downstream consumer, Trust Tokens, only cares about the field being populated in these cases). Bug: 1042962 Test: Adds a content browsertest to check that the field is correctly populated on subresource requests from main and (cross-origin) nested frames. Change-Id: Id8be16c7b35c5d691ee79e25479104aeb398a24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047445Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL continues the process of separating the personalization option strings into shared settings strings. This effort was started in parent 2042733 Bug: 967883 Change-Id: I942a995ebc52c56b9bdd8313b84376d0d0a3feaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042307 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/886e8500a9f2..9102c86a81ad git log 886e8500a9f2..9102c86a81ad --date=short --first-parent --format='%ad %ae %s' 2020-02-12 herb@google.com Refcount SkStrikeCache Nodes Created with: gclient setdep -r src/third_party/skia@9102c86a81ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I683204fa8c93e3ec24286fca1dad06827a7e4891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053033Reviewed-by:
-
Kristi Park authored
This reverts commit 386a0e0f. Reason for revert: Suspect for failing fullscreen interactive_ui_tests and browser_tests in linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17008 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17009 Original change's description: > [Reland] cros: Add hotseat metrics reporter > > Add the metrics reporter to the hotseat widget for all layer animations, > but this time initialize the reporters state. > > TBR=mpearson@chromium.org > > Bug: 1049385 > Change-Id: Ia48ca639aa3a317adf395ba6822b70cfb3008d63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047604 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Auto-Submit: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740808} TBR=mpearson@chromium.org,newcomer@chromium.org,manucornet@chromium.org Change-Id: I53df98923a81a9c8907fe7bc61820550f26c1588 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053290Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740938}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b0b4bb3063d8..3c647c956113 git log b0b4bb3063d8..3c647c956113 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 btolsch@chromium.org Change CastSocket to use signed ID Created with: gclient setdep -r src/third_party/openscreen/src@3c647c956113 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ibf636901195418d2e125588710057ca33e113d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053366Reviewed-by:
-
Rohit Rao authored
BUG=1027249 Change-Id: Iee08cbee3e9cca088de384b8961d5cb96dbdb385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050013 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#740936}
-
