GitLab

Previously, classic inline script's source_text to be evaluated is taken
from the element's child text content at the time of evaluation.
However, according to the spec, this should be the element's
child text content at the time of #prepare-a-script.

This CL fixes this by taking the element's child text content in
ClassicPendingScript's constructor, which is called inside PrepareScript().

This affects the behavior if parser-inserted classic inline <script>'s
innerText is modified by JavaScript after <script> is inserted into DOM
before its evaluation, and I expect this is extremely rare and doesn't
have legitimate use cases.

Bug: 686281
Change-Id: I0ef67dd8b71403a7862f24d02394f89c6e916bfd
Reviewed-on: https://chromium-review.googlesource.com/1091912Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567348}

Added all video pixel formats from media::VideoPixelFormat to
media::mojom::VideoCapturePixelFormat.

Updated Mojo typemapping to have a 1:1 mapping between the two.


A recent CL https://chromium-review.googlesource.com/c/chromium/src/+/1026795
caused a regression by introducing a new mojo enum VideoCapturePixelType and
typemapping it to media::VideoPixelFormat, see crbug/839742.

A quick mitigation fix was landed and merged into M68. However, the fix is
specific to a particular single format. The current state still has the danger
of having produced similar regressions occurring for other formats, which may
simply not yet have surfaced.


Using TBR since this has been reviewed previously at
https://chromium-review.googlesource.com/c/chromium/src/+/1050489

TBR=xhwang@chromium.org,rockot@chromium.org,sandersd@chromium.org,rsesek@chromium.org,chfremer@chromium.org,lasoren@chromium.org

Bug: 852096
Change-Id: I6f6d3add996d3557f33fbd42084ad2a9844b5957
Reviewed-on: https://chromium-review.googlesource.com/1098143
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567347}

Uses SmbUrl to parse the path passed to Mount and resolve the URL using
SmbShareFinder

Bug: 757625
Change-Id: I4d5ca6aa0fbc6c59728c650804b189b275faaf30
Reviewed-on: https://chromium-review.googlesource.com/1097710
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567346}

We need to update device_settings_update's device id and type.
We update them when the assistant service starts.

Bug: b/110094434
Test: manual. Can see updated id and type in log.
Change-Id: I1c85828482be49fb0e879cb233160236d0a676e1
Reviewed-on: https://chromium-review.googlesource.com/1099965Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567345}

display:inline-block with text children gets painted as AtomicInline.

NGBoxFragmentPainter::PaintAllPhasesAtomically was setting overflow
clip for all painting phases, cutting off anything outside content box.
It also was not painting scrollbars.

Bug: 841587
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iff05c8ba1bed18ae53d679a5b5e81c7f6d409276
Reviewed-on: https://chromium-review.googlesource.com/1099998
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567344}

This test seems to crash on our bots before it reaches the test fixture
code. I assume that is failing somewhere in SetUp, but there is no stack
trace to confirm that. I'm speculatively disabling some code when this
feature flag is set. We'll see if that greens our bots.

Also, remove the OFFICIAL_BUILD ifdef check. This code is only compiled
when is_chrome_branded is true.

NOTRY=True
TBR=chrisha@chromium.org, mhosen@chromium.org, mohsen@chromium.org
BUG=850517

Change-Id: I9f7e1fc8d826e830fc3e5284bff7e9cd6344fd7b
Reviewed-on: https://chromium-review.googlesource.com/1101408Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567343}

We're looking to remove the Skia-specific SK_MaxSizeT and replace it
with its standard exact equivalent, SIZE_MAX.  Landing this here first
will make this transition a little smoother.

(For what it's worth, there's nothing at all wrong with the way this
code is written today... it's using public Skia types and checking the
documented error condition perfectly.  We just want to slightly tweak
those docs to say SIZE_MAX instead of Sk_MaxSizeT.)

Change-Id: Ieaffdedb8c33f1226cef4990cf0e2ce68eb7d294
Reviewed-on: https://chromium-review.googlesource.com/1101238Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567342}

This makes sure Picture-in-Picture is disabled on Android Webview as
there is no UI implemented.

Bug: 852449
Change-Id: I526e02b0c2210fb5d71883f9db4ab05d76c56d2c
Reviewed-on: https://chromium-review.googlesource.com/1100464Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#567341}

The values of the enum was updated in the spec[1].

[1] https://github.com/immersive-web/webxr/pull/370

Bug: 852520
Change-Id: I916943bee355936e7430aa4e36d0eeb6b76607d5
Reviewed-on: https://chromium-review.googlesource.com/1101118Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#567340}

Currently ash and ui are bundled together by way of process groups. Process
groups make it hard to have an explicit construction ordering. For OopAsh we
need Ash to control creation of the UI Service. This patch removes
progress-groups and instead uses ServiceFactory.

Ash has two distinct ways to provide the 'Ash' service, which necessitates
the change in two places. WindowManagerService will go away soon, and we
will only have one way.

BUG=837686
TEST=covered by tests

Change-Id: Id871fe56331f99fcfb6225f4ebf59378a533600a
Reviewed-on: https://chromium-review.googlesource.com/1098233Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567339}

TBR=fukino@chromium.org

Bug: 852788
Change-Id: Ia8593011abcce487248bb8c394c0b431d31afec1
Reviewed-on: https://chromium-review.googlesource.com/1101063
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567338}

  In order to roll GN 84176d72..a3bcd204 (r564007:r567268) and pick up
  the following changes:

  3105b4b4 gn: Swap the order of two declarations.
  44054a1e Fix quoting when writing defines on Windows.

TBR=brettw@chromium.org

Change-Id: I95798c4c5e45c8faaf249b162d7d5c8ef47e7be1
Reviewed-on: https://chromium-review.googlesource.com/1101164Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567337}

The 'launchpad' package has been removed from the Fuchsia SDK, with its
functionality replaced by fdio_spawn(). The lingering definition will
e.g. block Chromium dependency rolls into V8, so we need to remove it
ASAP.

TBR: jam
Bug: 848028
Change-Id: Iac4ed84b65e9c077c9fe97d75c636f19ff597e74
Reviewed-on: https://chromium-review.googlesource.com/1098675
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567336}

Switches all heap_profiling code to new public Mojo APIs which
are replacing their EDK equivalents. No functional changes.

This also includes appropriate DEPS and GN deps cleanup.

Bug: 844763
Change-Id: Ica8969ae83d884e582025ddf92bf1f0104eb910e
Reviewed-on: https://chromium-review.googlesource.com/1100077
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567335}

Replaces all EDK usage for ARC-related components with public Mojo
API calls. No functional changes.

Also cleans up relevant DEPS and GN deps.

Bug: 844763
Change-Id: I1cab5ed08bcb08049b4648e3fb4c28664fb04bf7
TBR: jcliang@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1100041
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567334}

Additionally, this CL adds new functionality to FakeBleScanner
and FakeBleAdvertiser for providing access to their stored
scan/advertisement requests.

Bug: 824568, 752273
Change-Id: I0407021b62605e6feea745ce51ed4136013bce6d
Reviewed-on: https://chromium-review.googlesource.com/1100479
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567333}

This test was added when we found Mac produces rare
ShapeResult, by constructing the same run/glyph data
artificially.

During tweaking the tests, a character was added to runs,
but forgot to update the NumCharacters(), which made
Start/EndIndexForResult() incorrect.

This patch fixes that, and also add CheckConsistency() and
two new EXPECT() to ensure the aritificially built
ShapeResult is good.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iea0189f370f9e3d4546f33582f6ad363929511cc
Reviewed-on: https://chromium-review.googlesource.com/1100599Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567332}

chrome://dino modes

Bug: 846473
Change-Id: I739b7e40e735da10cc7d7cd75cf808e770bf817e
Reviewed-on: https://chromium-review.googlesource.com/1100455
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567331}

Migrates Mac app shim support and security key remoting code away
from internal EDK APIs and over to newer, functionally equivalent
public APIs.

No functional changes here, just swapping out old types for new ones
and updating dependencies appropriately.

Note that this also duplicates some internal EDK code into the public
Mojo platform library. This code is shared by a few unrelated
parts of Chrome and really has nothing to do with Mojo, but there's
not a better home for it yet.

Bug: 844763
Change-Id: I40e7ff08f01d513fb046dc636ba3e4b1db1dbad2
Reviewed-on: https://chromium-review.googlesource.com/1099726
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567330}

"Absolute" coordinates were a shim to ease the RLS transition. Get rid
of them in favor of "Frame" and "Document" coordinates.

BUG=823365
R=skobes@chromium.org,bokan@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id82f7908c32b2b529a2259bb5e18339a5568458a
Reviewed-on: https://chromium-review.googlesource.com/1100540
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567329}

Change-Id: I037e8144c82e3f29023ea47678a16d3680d3a103
Reviewed-on: https://chromium-review.googlesource.com/1100888Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567328}

This reverts commit 170f8510.

Reason for revert: Causing some unit_test failures on Mac 10.10
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests
starting around 33081


Original change's description:
> Add Views DesktopMediaPicker into the Overall Views Build
> 
> This moves the code into the toolkit_views source list and gates Aura
> specific code behind build flags.
> 
> BUG=726005,657883
> 
> Change-Id: I5e64ee0b16f2bfcb03da3bbc7c61486a786ee88d
> Reviewed-on: https://chromium-review.googlesource.com/1097843
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Robert Liao <robliao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566809}

TBR=ellyjones@chromium.org,robliao@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 726005, 657883
Change-Id: I4b8c6d38c1df4453ae1ee404f88a57046a908f35
Reviewed-on: https://chromium-review.googlesource.com/1101098Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567327}

Bug: 844964
Change-Id: I1b47ddad2856b8a92b4f8bd6f41b1d01b8706bac
Reviewed-on: https://chromium-review.googlesource.com/1097196Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567326}

Stores the hosts found in NetworkScanner as lower case in order to
do URL resolving

Bug: 757625
Change-Id: I791072ecb07d9afb03aa2ba75aacedffcddcd5b0
Reviewed-on: https://chromium-review.googlesource.com/1097707
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567325}

Plus some minor fixes.
1) consistently use gpu_preferences_ instead of gpu_preferences in case in the
   future we want to update gpu_preferences_ in the beginning.
2) change ShouldEnableSwiftShader() to EnableSwiftShaderIfNeeded().

I don't think this is the root cause why SwiftShader fails to fall back as
reported in the bug, but still, it's good to fix this issue.

BUG=852537
TEST=about:gpu
R=piman@chromium.org
TBR=rsesek@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I17ab4d26b4eea079bcd9f732e6689c76f002d584
Reviewed-on: https://chromium-review.googlesource.com/1100123Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567324}

Introduces a public IsolatedConnection helper as a replacement for the
EDK PeerConnection type. A follow-up C will convert existing uses.

Mojo multiprocess tests are converted to use the new type here,
removing the last remnants of EDK dependency from the test multiprocess
test support code.

This also deletes some dead test code and opportunistically converts a
few related uses of the internal EDK ScopedInternalPlatformHandle type
to the newer public PlatformHandle type.

Bug: 844763
Change-Id: Icad97f51d320381483e474c16077ef7844cc2b9d
Reviewed-on: https://chromium-review.googlesource.com/1099269
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567323}

Change-Id: I6b8d9d9e1aa58e4a8e6d9a1067bf24fe4d101751
Reviewed-on: https://chromium-review.googlesource.com/1100735Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567322}

We want to release to dev/canary for version 67 and 68 and to release to
all chanels since version 69.

The beta/stable release is pushed back from 68 to 69.
BUG=chromium:800120
TEST=manual test.

Change-Id: I02851521a0b9266157be3c4eb510546637b538a1
Reviewed-on: https://chromium-review.googlesource.com/1100539Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567321}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4b7910b8..7124db04

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If22570fceb3bfec7f7fb4d8692476a7d58907d1b
Reviewed-on: https://chromium-review.googlesource.com/1100973Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567320}

Part of ongoing effort to enable ChromeVox in
chromecast.  This CL brings in the chrome.tabs
api.

Bug: 73383411
Test: None
Change-Id: I4d6d666f56bcc535e30f617ac786b1f1da05a517
Reviewed-on: https://chromium-review.googlesource.com/1100970
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567319}

The flag is being used for all other configurations for a while. Looks like
we've forgotten to add it for the Debug one when it's been implemented.

Bug: 852391
Change-Id: I2f3fbd4639fdb81b304f0abdd0c8fe6f3d1dbcb3
Reviewed-on: https://chromium-review.googlesource.com/1100964Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567318}

Bug: 852521
Change-Id: Ief55e563304cb2ea8677ef7914e1eb065ea1261a
Reviewed-on: https://chromium-review.googlesource.com/1099733Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567317}

Allow users to interact with the custom backgrounds UI with
only the keyboard.

Bug: 851173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic442995e2a68d147942ad7625ea0e8a202e40137
Reviewed-on: https://chromium-review.googlesource.com/1097576
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567316}

After a recent refactor, [cmd + left arrow] would perform history navigation
instead of moving the cursor to the beginning of the Omnibox. This happens
because the processing for the hotkey [triggering history navigation] has higher
priority than the typical event handling flow.

The hotkeys [cmd + left arrow] and [cmd + right arrow] are special, and should
only trigger if the firstResponder is a WebContents, and the WebContents has
chosen not to process the event.

This CL removes handleExtraKeyboardShortcut:, which was dead code.

Bug: 852332
Change-Id: Id03f5e22337a79d9ca4abfd20d995a8cf8976b2a
Reviewed-on: https://chromium-review.googlesource.com/1099648Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567315}

Bug: 852212
Change-Id: I4ed79cc13f48aaaac4a68c33e976fdab834deb61
Reviewed-on: https://chromium-review.googlesource.com/1098467
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567314}

Preparation for
https://chromium-review.googlesource.com/c/chromium/src/+/1065061/.

Bug: 845285, 841466
Change-Id: I502d296c05ad27a8d974daae5a004fbf58f8791d
Reviewed-on: https://chromium-review.googlesource.com/1100537Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567313}

Tests affected:
PDFExtensionTest.Basic
PDFExtensionTest.Bookmark
PDFExtensionTest.Elements
PDFExtensionTest.ToolbarManager

Most of the fixes involve adding Custom Elements to be tested in the document,
otherwise their local DOM is not populated (unlike Polymer 1).

Bug: 849476
Change-Id: Id953179142174cb5922bf53bcaa139011ea76ca9
Reviewed-on: https://chromium-review.googlesource.com/1100304Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567312}

With the change to using presentation-feedback for facilitating snapshot
requests (crrev.com/c/1095562), the snapshot-specific code in gpu can
now be removed.

BUG=851504

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I25b563f879bb66c345ba541df736efc65a834f0d
Reviewed-on: https://chromium-review.googlesource.com/1096669Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567311}

When the custom bindings were removed in commit 5b84e88a ("Remove custom
bindings for CSSStyleDeclaration"), the new anonymous setter code added a
check for ScriptState::ContextIsValid() to ensure it had received a valid
|script_state|.

It turns out this check is too strict, as in addition to verifying a
ScriptState has an associated v8::Context it also asserts the ScriptState
has a valid |per_context_data_|.

This is valid in most cases, but when a node is moved across different
documents and its previous document gets removed its |per_context_data_| is
disposed of and ScriptState::ContextIsValid() fails.

Since the anonymous setter is only invoked by the bindings layer, we can
assume it is passed a ScriptState that is in a minimally usable state, so it
is possible to relax the ContextIsValid() check and only make sure we can
get a valid ExecutionContext from the ScriptState.

Bug: 852190
Change-Id: I307de0e003e5258bf1f670b26f1dc86e4dae9286
Reviewed-on: https://chromium-review.googlesource.com/1100836
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567310}

Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=852387#c4

BUG=852387

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I16227efb940473d3b7aa56d37760483c23d7b799
Reviewed-on: https://chromium-review.googlesource.com/1100158Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567309}