- 08 Apr, 2019 40 commits
-
-
Samuel Huang authored
This reverts commit b8de8c26. Reason for revert: Relanding: Looks like the problem is caused by another CL. Original change's description: > Revert "Clear inapplicable disable reasons for component extensions" > > This reverts commit 07619eb1. > > Reason for revert: Speculative revert for "Linux Chromium OS ASan LSan Tests (1)" failures in unit_tests related to extensions. > > Original change's description: > > Clear inapplicable disable reasons for component extensions > > > > This change ensures that all component extensions are allowed to be activated despite having some inapplicable disable reasons set. > > > > In particular, this fixes any specific observed on-device instances where ChromeVox or tts had a disable reason of blocked by policy which prevented it from being activated. > > > > Bug: 946839,947305 > > Test: manually. With a device enterprise enrolled, push down kiosk apps to the device from an admin console. Ensure that ChromeVox still works on all screens. > > Change-Id: I2cedafeb16d4420702188f1516825ce1bad52802 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553017 > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648464} > > TBR=dtseng@chromium.org,rdevlin.cronin@chromium.org,devlin@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 946839, 947305 > Change-Id: Icf19fe7e45c41ed559a732703844c0874c6cfdd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557734 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648573} TBR=huangs@chromium.org,dtseng@chromium.org,rdevlin.cronin@chromium.org,devlin@chromium.org Change-Id: I92b60a51aaf4883e8fcc953645b343860bb61f1e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 946839, 947305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557011Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648632}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I01bc173f2a4db6f5ffa744aedb8441667f759b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556656Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#648631}
-
Elly Fong-Jones authored
This change: 1) Removes the AffiliationBasedMatching flag 2) Removes the backing AffiliationBasedMatching feature 3) Removes support in PasswordStore for disabling password propagation to web credentials 4) Removes test coverage for (3) Bug: None Change-Id: Ied45e67ffb11893c9aa7e27c2d2625c595156b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546528 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#648630}
-
Jan Krcal authored
This CL makes sure that we do not abuse the UMA_HISTOGRAM_CUSTOM_TIMES macro by specifying max value above 24 days (which in milliseconds is around INT_MAX). Recording higher time values has to be treated differently. Bug: 949034 Change-Id: I016379bd5270e3120a21464d072b29117a71c03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549072 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#648629}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3b2feb3..ce224208 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I47780209d164b21993bbd65e25caf0ead1ada212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557542Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648628}
-
Mikel Astiz authored
Our ongoing rollouts (USS migrations) have noticeable impact on this metric and we'd like to keep it around for some more time. Bug: 928514 Change-Id: I8ed093e48c6e15c4e6ea7e5a6d2adc7102c6fc7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556783 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#648627}
-
Marc Treib authored
It's an (OAuth2) access token, so let's call it what it is. Bug: 933799 Change-Id: I02ce9c9885e95d1ea8a854c919d6ac6d75def420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556839 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#648626}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/008246e0ae51..094a55279558 git log 008246e0ae51..094a55279558 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 lalitm@google.com Merge "trace_processor: introduce API for computing metrics on trace processor" Created with: gclient setdep -r src/third_party/perfetto@094a55279558 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8c735e2f23cb263f8920a61dfe8b6eeb2d0e5e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556585Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648625}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4ba1911b2d7f..3bb94905928d git log 4ba1911b2d7f..3bb94905928d --date=short --no-merges --format='%ad %ae %s' 2019-04-08 bclayton@google.com Replace use of ASSERT(false) with UNIMPLEMENTED Created with: gclient setdep -r src/third_party/swiftshader@3bb94905928d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I06a0ffacd3ca2c931390bbfa89fb35c83f55ed71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556586Reviewed-by:
-
Ryo Hashimoto authored
BUG=b:129835848 TEST=build Change-Id: Ie074e6c67f0134d49098557071480663176b9968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549302 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#648623}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01e404997d1e..40c6e1550294 Created with: gclient setdep -r src-internal@40c6e1550294 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I1139618a079e2580ea9628e877db070b4f80cb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556341Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648622}
-
Robbie Gibson authored
This CL uses a named guide to position the popup cell's leading image and text instead of manually setting these constraints. This will help keep those aligned and should make RTL support easier. This also uses the flag value to choose which view controller to show. Bug: 945323 Change-Id: I08b1160b0b2d1dd18b062ff6921915ca0b208d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552865 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#648621}
-
Stephane Zermatten authored
This change moves the definition of the visibility check into the Selector, both internally and in the protocol. This better matches the implementation and allows looking either for an existing or a visible element in WaitForDom, but also in preconditions. This works well for WaitForDom and preconditions, but there are a few actions that only make sense on visible elements, such as click and focus. For these, the client action forces the visibility check. This change also replaces DCHECK for empty selectors in actions with code that returns INVALID_ACTION. This makes it easier to detect possible script versioning issues happening in production. Primary motivation for this change is allowing scripts to run either visibility or existence checks from WaitForDom. Change-Id: I252d5b4ce8250b863f531cecc2cacfb83da51a64 Bug: b/129666439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553549 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#648620}
-
Victor Hugo Vianna Silva authored
In this CL we first change the signature of AddMetadata to receive a unique_ptr. In a subsequent CL we will eliminate the unnecessary copy by changing the metadata_map_ key type to a unique_ptr as well. Bug: 914396 Change-Id: Ic476f6208538b299c2bba9b9eb0662b8694b1da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550466Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#648619}
-
Vadym Doroshenko authored
Bug: 946845 Change-Id: I5e261c52f4467952aaad7cd89020c3f6042b1d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556840Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#648618}
-
Marc Treib authored
The pref was read by ProfileSyncService, but never actually set. Bug: 938869 Change-Id: Ie924712e82f97c4c2459329e4830aa50e3cfc57d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556795 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#648617}
-
Mathias Carlen authored
This patch adds the ability to provide a special extra intent string with a comma separated list of experiment ids. It is owned by the controller and kept in the ClientContext provided to the service when the latter is being created. Each request to the backend will contain the experiment id string as part of the client context field. Bug: b/129302131 Change-Id: I4891e822694aebb96015d12d8b50803f7a3d8f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552835 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#648616}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/766ef6cc7749..008246e0ae51 git log 766ef6cc7749..008246e0ae51 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 fmayer@google.com Merge changes I9e70b10f,I92894610 Created with: gclient setdep -r src/third_party/perfetto@008246e0ae51 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3f7a09a21d215a4bdb731dc5b10b8e837913bda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556584Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dcaab6056568..01e404997d1e Created with: gclient setdep -r src-internal@01e404997d1e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I160c36752a427ec2dea62543a73b83acf09f3324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556741Reviewed-by:
-
Colin Blundell authored
SigninManagerBase exposes an IsSigninAllowed() method. SigninManager overrides this method with a different implementation. It turns out that the method is never called on ChromeOS, meaning that the method on the base class is unnecessary. Eliminating it helps clarify the technical relationship between SigninManagerBase and SigninManager. Bug: 814787 Change-Id: I1c496553151010257cb15e08b610eae17fe1941e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554344 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#648613}
-
Thomas Tangl authored
IsUsingDefaultAvatar() was wrongly used inside ShouldShowGenericIcon(). (It is true even if the user selected another "default" avatar icon.) Is is replaced with a check whether the icon is the *default assigned" icon which has index 0. Bug: 949023 Change-Id: Ic2e208024e0f488c914ffb40f43120a36450bc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554763Reviewed-by:
-
Dominic Battre authored
TBR=ricea@chromium.org Bug: 946701,950222,947670 Change-Id: Ic878a00b909719c3f6f4bf8efc5192ddd32153b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556797Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#648611}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I50eba0c9a7f7b54a8ed5874b8fd613f3b856105d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556740Reviewed-by:
-
Jérôme Lebel authored
The sign-in can fails (for example if the user cancel the merge accounnt dialog). The -UnifiedConsentCoordinator.settingsLinkWasTapped has to be reset. Bug: 949922 Change-Id: I18dea38fe2328c6c147640a188c51c1fee0fbebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553551Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#648609}
-
Yi Su authored
Use TemplateURLServiceObserverBridge to update the default search engine name on the "Search Engine" item in SettingsTableVC. Bug: 661915 Change-Id: I24c034c688bab086330da1e2c67ba30c2109ce9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554766 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648608}
-
Dominic Battre authored
This CL disables all TabMetricsLoggerTest.* tests on ChromeOS for their flakiness. See the bugs for details. TBR=fdoray@chromium.org Bug: 950244, 949288 Change-Id: Ic5c724237e6f6c7ab26e2bb7f37045d109c14e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557016Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5559f9fc. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296 "Revise tests for datachannel ID handling" 80389713 "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" 30c91944 "Change XRRigidTransform inverse method to attrib" 421cce6c "Fix a lot of RTCDataChannel parameter checks" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" c27a874c "[WPT] Fix JSON decoding errors in referrer-policy on Safari" fcd2c80d "Parse values in feature policy declarations." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I50491acbdd17d308b5386837256573b6a34e4e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556447Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648606}
-
Sergio Villar Senin authored
This test defined FakeTimerSetter class which was overriding the time functions for a timeout related test. It turns out that the test does not really need it as it was just added for a find text operation that turns out to be synchronous. This is similar to https://crrev.com/c/1549086 Bug: 919383 Change-Id: I55d040c44cdf29d5cf1779a4d11b321f00fee18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554345Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#648605}
-
David Staessens authored
This class was introduced in an early prototype of the new video decoder tests, to manage test video files. Video test files are now managed by the Tast test framework, so this class is no longer needed. TEST=ran new VDA (perf) tests on nocturne BUG=879065 Change-Id: I6645cad5d59d9d28addffd3842c6d15f6537e80f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552385 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#648604}
-
Sergio Villar Senin authored
MediaControlTest already defines a class which uses ScopedTestingPlatformSupport in order to have a method to control the time at will. Use it instead of overriding time functions with SetTimeFunctionsForTesting. Bug: 919383 Change-Id: I7e46ed12dfdd20d46b93f8dbb24ec396d7f3c355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552803Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#648603}
-
Yi Su authored
This CL fixes the layout defect of TableViewDetailIconItem, which causes an unsmooth animation when the labels' text are updated. The solution is to use AutoLayout constraints instead of calculating width of both labels during UIView.LayoutSubviews. It's hard to prove that the constraints are correct, but it works :D Screen shot: https://drive.google.com/open?id=1UJoZ81NXE0gPQab80cGBVQFOVHqh1BBm Bug: 927682 Change-Id: I516469c7bd1bcbdfeebd7d9ddfe492fa39cd28a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554354 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Ryo Hashimoto authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/8ba4296f282c..4ebef283ecc4 $ git log 8ba4296f2..4ebef283e --date=short --no-merges --format='%ad %ae %s' 2019-04-03 hashimoto arc: Add ARC Custom Tabs experiment 2019-03-25 louiscollard u2fd: Send dbus signal when receiving WINK command Created with: roll-dep src/third_party/cros_system_api Bug: None Test: trybots Change-Id: I4431b2a9d6c8865407b6a5e659a47fcf6bcb82f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556870Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#648601}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c93072d97d4..dcaab6056568 Created with: gclient setdep -r src-internal@dcaab6056568 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@chromium.org,hajimehoshi@chromium.org Change-Id: I8c672acc33dbacce5794cf4b3d7784041eaf27df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556446Reviewed-by:
-
Henrique Ferreiro authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in third_party/blink/renderer/platform/mediastream, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbx> Bug: 939691 Change-Id: I3e86523a6f71145ba7d80cd2c8a1f4c4dcb55e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554357Reviewed-by:
-
Henrique Ferreiro authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in third_party/blink/renderer/platform/loader/fetch, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbx> Bug: 939691 Change-Id: I5f3ce00e79d24a9e9505332dcbef159ffc194e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554922 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#648598}
-
David Staessens authored
The default video can now be overwritten when running a perf test by calling: ./video_decode_accelerator_perf_tests <test_video>. TEST=ran new VDA perf tests on nocturne BUG=925714 Change-Id: If095dcb75f70df12852bdc95e2ba45e8dda7b3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550179 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/quota, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ic4efd311ff18194e6794f91ab7a7dc1d080c3c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556864Reviewed-by:
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/serial, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I8fd18e5e047eadc90fd26652bfa180fad97314c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557661Reviewed-by:
-
Noel Gordon authored
Build with -s NO_DYNAMIC_EXECUTION=1, which prevents emscripten eval() and new Function() code generation. Add a test chrome extension that <script>-adds the generated wasm code in its background page, with a strong CSP policy that includes wasm "content_security_policy": script-src 'self' 'wasm-eval'; ... Add piex.cpp main() that prints a simple salutation. In developer mode one could load the unpacked extension from this directory, and see the salutation in the console by inspecting its background page. Eventually, we should add an automated test in image_loader, or above, to test the wasm loading. Bug: 935285 Change-Id: I00b684c1bfac82da39cb0be6e15da8fafd72bc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556961 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#648594}
-
Dominic Battré authored
This reverts commit afff956d. Reason for revert: Speculative revert for MSAN failures, see crbug.com/950433 Original change's description: > [mojo-core] Support pipe splicing > > This change allows message pipes to be "spliced" into other message > pipes, unifying their message queues while retaining their logical > independence for routing of written messages. > > This is supported by adding an array of per-handle options and flags to > MojoAppendMessageDataOptions. If a handle is marked with > MOJO_APPEND_MESSAGE_DATA_HANDLE_FLAG_SPLICE when appended to a message, > sending that message will effectively cause the handle and its peer to > be spliced into the sending pipe. > > See bug for design doc link. > > Bug: 941809 > Change-Id: I191fb4df4c1586bcee91a3ccf595d76869451e7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548145 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648579} TBR=rockot@google.com,oksamyt@chromium.org Change-Id: I8fe5e72cd831dbb60d3898a623068f87c77fccdc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 941809,950433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557015Reviewed-by:
-
