- 27 Jan, 2018 40 commits
-
-
Lei Zhang authored
Otherwise, it is too easy to accidentally change the enum value and make it go out of sync. In fact, that is the current state. Update enums.xml so the values line up again. Also add a comment to remind readers to keep the enum values constant, and mark a chrome::ResultCode enum as unused. BUG=805754 Change-Id: I66efe023d5b8f5caa9f279641aea0f52a667ab0f Reviewed-on: https://chromium-review.googlesource.com/885090Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532203}
-
Yixin Wang authored
Change-Id: If94561f453bbc56b86238918d374baf8c2254646 Reviewed-on: https://chromium-review.googlesource.com/887970Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#532202}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/8d63750dfb6f..82f653f9a44e $ git log 8d63750df..82f653f9a --date=short --no-merges --format='%ad %ae %s' 2018-01-26 dtu [pinpoint] Add --webview-embedder-apk flag for webview bots. 2018-01-25 dtu [pinpoint] Increase max attempt count from 40 to 50. 2018-01-26 simonhatch Dashboard - If updating bug fails, retry without setting owner. 2018-01-25 prasadv Add Chromiumdash Client ID for api authentication 2018-01-26 perezju [Telemetry] Migrate CrOS browser and profile directories 2018-01-25 simonhatch Pinpoint - Store trace urls keyed by the filename. 2018-01-25 simonhatch Dashboard - Cleanup old perf-try code. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5b6e3d3ef67cad1937ca680a74857f4b546ee0d6 Reviewed-on: https://chromium-review.googlesource.com/890342 Commit-Queue: <catapult-deps-roller@chromium.org> Reviewed-by: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532201}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/b9ec0b31a932..6e8a3e62e171 $ git log b9ec0b31a..6e8a3e62e --date=short --no-merges --format='%ad %ae %s' 2018-01-26 xlou Code cleanup - create a new function GetPageNumbers 2018-01-26 thestig Fix a wrong variable check in CFX_BilinearMatrix. 2018-01-26 thestig Pass nullptr to ParseContentWithParams() instead of 0. 2018-01-26 rharrison Clean up construction of CFX_Barcode 2018-01-26 hnakashima Fix crash in palette loading with Pattern colorspace. 2018-01-26 thestig Change CPDF_RenderStatus::ProcessPathPattern() to pass by pointer. 2018-01-26 thestig Mark some fxge class members as const. 2018-01-26 thestig Fix potential memory leak in CCodec_JpegModule::Start(). 2018-01-25 hnakashima Add timeout when downloading gold json. 2018-01-25 hnakashima Make private some methods in CPDF_DIBSource. 2018-01-25 dsinclair Remove empty FF classes Created with: roll-dep src/third_party/pdfium BUG=805881,805881 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibaba86271a00d1311dbaabadb5e07683f63db4e3 Reviewed-on: https://chromium-review.googlesource.com/890340 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532200}
-
src-internal-roller@chromium.org authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c4fd243124b..3594628af090 $ git log 9c4fd2431..3594628af --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I997128f5b2737d85c68cf93bb6cf183667b4213e Reviewed-on: https://chromium-review.googlesource.com/890341 Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org> Reviewed-by:
src-internal-roller . <src-internal-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532199}
-
Lei Zhang authored
- Mark some SpellcheckHunspellDictionary code non-Android. - Use base::StringPiece a little more. - Fix nits / style. Change-Id: Ibe2e7bf14678f7fbfc976d42964091afa138bbec Reviewed-on: https://chromium-review.googlesource.com/838370Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532198}
-
Donna Wu authored
This is a preparation work for MTP servicification. BUG=769630 Change-Id: Id1cf84e96270004efcfba0d3584ea6a2b01867bb Reviewed-on: https://chromium-review.googlesource.com/875562 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532197}
-
Victor Costan authored
Release notes for the new version: https://sqlite.org/releaselog/3_22_0.html The new release contains minor bugfixes and optimizations. Only trivial changes were needed while rebasing Chromium's patches. Bug: 805126 Change-Id: I35f893d7f707a805f485184cb3afe33276febae9 Reviewed-on: https://chromium-review.googlesource.com/882193 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#532196}
-
Victor Costan authored
Bug: 805814 Change-Id: Ia1cac2e6ce3da10997ff722b5d5095651c4ca586 Reviewed-on: https://chromium-review.googlesource.com/885921Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#532195}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/beabdcb49810..22da89f502ab $ git log beabdcb49..22da89f50 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I97d3e36e653c0603d2c79b5640e6bd60aca22ae5 Reviewed-on: https://chromium-review.googlesource.com/890201 Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532194}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2fce0c43..143d9c6f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4490c5d899c020b816290012298cb711d1f9f315 Reviewed-on: https://chromium-review.googlesource.com/889960Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532193}
-
Alex Moshchuk authored
This CL fixes a problem in RequestTransferURL(), where in the case of a form submission to the main frame, the FrameNavigationEntry's method was never updated. Bug: 806215 Change-Id: I1614a0e51f91b0d3346ce633bf8f027cf3609f15 Reviewed-on: https://chromium-review.googlesource.com/889646 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#532192}
-
Wenzhao Zang authored
When showing the wallpaper picker for the first time after OOBE, |saveThumbnail| may not completed, when the bottom left small thumbnail to show. In this case, initial a HTTP request to fetch the thumbnail. Bug: 792829 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3016687326156bc25d7a0e9a09c770efd1d1b4d7 Reviewed-on: https://chromium-review.googlesource.com/887963 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#532191}
-
Wenzhao Zang authored
Bug: 782632 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If7a66b80f2ab0ade5e1543886f9e5a1eeb7779b7 Reviewed-on: https://chromium-review.googlesource.com/888039Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#532190}
-
Wenzhao Zang authored
TBR=rockot@chromium.org Bug: 804986 Change-Id: I4b16892cfe7705d4a5d6dd82ccba8de176283ca2 Reviewed-on: https://chromium-review.googlesource.com/889647Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#532189}
-
Philip Jägenstedt authored
This is a functional revert of https://codereview.chromium.org/192693002. Per `git log -S CreateFunctionHandler`, this API was never used, and was only part of refactoring: https://codereview.chromium.org/671433004 https://chromium-review.googlesource.com/760376 Change-Id: Ibcbad96a7f145dbf14e87e70a59318802971ba3f Reviewed-on: https://chromium-review.googlesource.com/886442Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#532188}
-
Marijn Kruisselbrink authored
The WebBlobInfo instances already contain all the BlobDataHandles, so no reason to store both. Bug: none Change-Id: I308c790040af3cd7efea9fdd20520a4ded05a797 Reviewed-on: https://chromium-review.googlesource.com/884374 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#532187}
-
Jeremy Roman authored
This removes the custom workaround to emulate this behavior. A unit test is adjusted to reflect the fact that a previously generated API binding will continue to be returned. Bug: 653596 Change-Id: Ib158164234e111180a00750ba736cd303be391c0 Reviewed-on: https://chromium-review.googlesource.com/867517 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532186}
-
Eric Karl authored
When caching very large images in the GPU image decode cache, we don't upload to the GPU, but instead just cache the CPU side data for re-use. Unfortunately, we currently perform color conversion post upload, which means that, in the SW-only case, we end up re-converting images on every use. This patch causes SW-only cache entries to have their color conversion done at decode time, ensuring we persist it in the cache. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I26831b119dffff09f977567631dd2dc7e99e7978 Bug: 802819 Reviewed-on: https://chromium-review.googlesource.com/877106 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#532185}
-
Lei Zhang authored
The code encodes to PWG Raster Format, which is a standard from the Printer Working Group. In Chromium, it is used for Google Cloud Print, but other embedders can potentially use it for their own printing needs. Move it out of chrome/utility/cloud_print. The encoder is mostly self contained. It only depends on base/ and ui/gfx/. Change-Id: Iccfdb5af5a9e21e1fb596c292a645aeb2bca9bea Reviewed-on: https://chromium-review.googlesource.com/876981 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#532184}
-
Lei Zhang authored
Change-Id: I27d42d74889d455ac162c5701868fb5f2e837261 Reviewed-on: https://chromium-review.googlesource.com/885863Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532183}
-
Karan Bhatia authored
This CL adds move constructor and move assignment operator to URLPatternSet. A sample usage is also also added to ExternallyConnectableInfo preventing a copy. BUG=None Change-Id: Ic2de83dcdcb12e13523b78cb18deb2da2eead6a7 Reviewed-on: https://chromium-review.googlesource.com/888084Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#532182}
-
Daniel Bratell authored
In jumbo builds, many cc files share the same anonymous namespace since they are compiled in the same translation unit. Then methods that would otherwise not clash cause symbol collisions. This patch renames two identical BindConnectorRequest methods. A better fix may be to find a shared location but there is no obvious shared location between media/casting and pepper/flash. Bug: 746957 Change-Id: I80b4806140720824fefd1d0019537b6fd89683da Reviewed-on: https://chromium-review.googlesource.com/878363Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532181}
-
Nico Weber authored
This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 177475 Change-Id: I39e7b389e2bb228ca717c2029a7c34d2f32b6446 Reviewed-on: https://chromium-review.googlesource.com/890063 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#532180}
-
Lei Zhang authored
BindToBrowserConnector() should just be called on the right thread in the first place. Change-Id: Ib5ea945b34faa054e179a7d5be4c43d749bd219b Reviewed-on: https://chromium-review.googlesource.com/888143Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532179}
-
rbpotter authored
Bug: 793335 Change-Id: I910d8c2100476372cd0004edde23ecde2bd4bd58 Reviewed-on: https://chromium-review.googlesource.com/887622Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532178}
-
Ting-Yuan Huang authored
ICF is currently decided by platform/compiler/etc. We need a switch to turn it off in some cases. BUG=b:72175832 Change-Id: I9637c27cd5e663152afc3102ac6996fc9cc1f5f6 Reviewed-on: https://chromium-review.googlesource.com/876802Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Ting-Yuan Huang <laszio@chromium.org> Cr-Commit-Position: refs/heads/master@{#532177}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 638337f7. With Chromium commits locally applied on WPT: 2928474c "Revert "Add WPT tests for feature policy"" 9f32e9c0 "S13nServiceWorker: Add tests for network fallback for navigations with request bodies" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11049 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes TBR=leon.han@intel.com No-Export: true Change-Id: I10c8592ef1adacd417aa017273926f8c55abd4e4 Reviewed-on: https://chromium-review.googlesource.com/890060 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532176}
-
Kurt Horimoto authored
The previous implementation of ToolbarView had a constraint that attempted to layout the view's height by constraining its bottom anchor to kToolbarHeight away from the top layout guide provided by the BVC. This is incorrect because when the page is scrolled, fullscreen will translate the toolbar up so that its bottom edge is less than its height away from the bottom of the top safe area inset. This CL updates ToolbarView to use |intrinsicContentSize| to specify kToolbarHeight as its minimum size (enforced via implicit compression resistance constraints created by returning a custom value for |intrinsicContentSize|). The remainder of the toolbar's layout is managed by constraints created by BVC: 1. |primaryToolbarHeightConstraint|, which accounts for the top layout guide's height. 2. |primaryToolbarOffsetConstraint|, which manages the vertical positioning of the toolbar. When a fullscreen progress value is observed, BVC updates this value to move the toolbar up and down. Note that the height never changes. 3. Leading and trailing constraints that match that of BVC's view so the toolbar's width spans the entire screen. Bug: 799907, 799117, 798496 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6cf2c7e09d3a8324be4008f7be7c313231fabd43 Reviewed-on: https://chromium-review.googlesource.com/882135 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#532175}
-
George Burgess IV authored
I tripped over this, causing presubmit breakages: https://crrev.com/c/884981. In retrospect, this is sort of obvious (and would be if I looked at the comments in the source), but... Bug: None Test: Looked at the new file in gitiles Change-Id: I5aac9a0da52b34b15d8947062811779bfeeb070f Reviewed-on: https://chromium-review.googlesource.com/884988Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#532174}
-
Gyuyoung Kim authored
If updated files don't use base::WrapUnique, base/memory/ptr_util.h includes are changed to <memory>. Bug: 755727 Change-Id: Ifb9ad8d3ee41130ac5c159cf084c979a304b80ed Reviewed-on: https://chromium-review.googlesource.com/885383 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532173}
-
Daniel Bratell authored
A trailing "}" was not included in the include guard so if included multiple time, you would get "extraneous }" errors. Change-Id: I32582e928220ee9428acbefa9a4833d9d36d2eec Reviewed-on: https://chromium-review.googlesource.com/888581Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#532172}
-
Kurt Horimoto authored
Since this required that the content offset adjustment and toolbar reveal animations occur simulteneously, this animation is governed by a new animator. In order to share code, a FullscreenAnimator superclass was created. This CL also contains some small fixes: - comment update in chrome_broadcast_observer.h - update BVC to pixel-align animations Bug: 796946 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ieee50986644339c4b6d2e86c9fb6be314a416834 Reviewed-on: https://chromium-review.googlesource.com/875248 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#532171}
-
Karan Bhatia authored
This CL prevents redundant copies of URLPatternSet at certain locations by taking a const reference. BUG=None Change-Id: Ib44686f30e10bd03a4e05b925cf4f1664b30bd34 Reviewed-on: https://chromium-review.googlesource.com/890044Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#532170}
-
Karan Bhatia authored
ExtensionsClient::GetPermittedChromeSchemeHosts is only used for determining valid host permissions and is not used for determining valid scriptable hosts. Correct the function documentation to reflect the same. BUG=None Change-Id: I45b171132be5871193d73ad535e9bd6111abbd4b Reviewed-on: https://chromium-review.googlesource.com/886840Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#532169}
-
Devlin Cronin authored
ObjectBackedNativeHandlers have a RouteFunction() ability, which essentially exposes a callback to JS. Routing all these functions can be potentially expensive (at the scale we do it). Factor RouteFunction() calls into an ObjectBackedNativeHandler::Initialize() method (also exposed as NativeHandler::Initialize()), and ensure (through a DCHECK) that this is the only place that allows RouteFunction() calls (as well as potential future initialization). This will allow us to experiment with where to put this logic. For now, call near construction of each handler, which ensures that this patch does *not* introduce a behavior change. Future patches will modify this flow. This patch should have no functional effect. Bug: 805244 Change-Id: I3cd886a85e2c8e4ebb17b01d640e030df9b40700 Reviewed-on: https://chromium-review.googlesource.com/879721Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532168}
-
Hwanseung Lee authored
According to below linked issue(#514), CSSVariableReferenceValue should have a constructor. and also fallback attribute should be readonly attribute. constructor was already added in chromium. but readonly keyword was not added. so add readonly keyword for fallback attribute. (actually it is related with #513 to add readonly keyword) https://github.com/w3c/css-houdini-drafts/pull/547 https://github.com/w3c/css-houdini-drafts/issues/514 https://github.com/w3c/css-houdini-drafts/issues/513 Bug: 803687 Change-Id: I91b5d4f21b75cd5d27063bfceba0b39b30977be9 Reviewed-on: https://chromium-review.googlesource.com/881381Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#532167}
-
Pavel Feldman authored
- removes legacy code from building release modules - makes context submenus populatable via descriptors - inlines network_priorities into perf_ui - removes main -> network_log and main -> console_counters dependencies - introduces late initialization extension point and uses it for showing releaes notes - makes help module non-autostart, removes main -> help dependency - brushes up BUILD.gn - introduces ndb.json for non-browser targets Change-Id: I7790bdff293afdaa80d0882df5efc565440019d1 Reviewed-on: https://chromium-review.googlesource.com/888330 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532166}
-
Stefan Zager authored
These are tests whose non-rls expectations have changed since the flag-specific/root-layer-scrolls expectations were created. A lot of them changed in https://chromium-review.googlesource.com/872256. BUG=711468 R=skobes@chromium.org,chrishtr@chromium.org Change-Id: Icbb2cd94b89af0c91b7e8b52525fc26955034927 Reviewed-on: https://chromium-review.googlesource.com/890038Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#532165}
-
Han Leon authored
Rather than a non-null ServiceWorkerObjectInfoPtr with an invalid handle id, this CL uses a null ServiceWorkerObjectInfoPtr to indicate those non-existing service worker objects. BUG=772713 Change-Id: Ibb666ffd8bb66b1a10b112390329917b7ff61663 Reviewed-on: https://chromium-review.googlesource.com/877593Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#532164}
-