- 24 May, 2018 40 commits
-
-
Hayato Ito authored
The workaround of https://crrev.com/c/1062990 is no longer necessary because of https://crrev.com/c/1068646, which fixed ListItemOrdinal's behavior. See also http://crbug.com/845770. In general, we should avoid recalc assignment in detaching a node. Bug: 776656, 845770 Change-Id: Ia98b35dce0b6d2e16829f79dde4b88470ced0d3f Reviewed-on: https://chromium-review.googlesource.com/1070007Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#561371}
-
Dave Schuyler authored
This CL addresses some comment typos and style changes. These changes were included with 1066732, which was reverted. Separating these changes in this CL will make further CLs on these files cleaner (fewer lines changing). There are no logic changes in this CL. Bug: None Change-Id: Ic2d75bdf2f1726d9044da18caec56ec5b374100f Reviewed-on: https://chromium-review.googlesource.com/1071093 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#561370}
-
Xing Liu authored
If the user pulls out the SD card, currently the download database record will be removed and user can no longer see the download. Instead, we shouldn't erase the database records for files on SD card when checking if they are externally removed. Later we can add a timestamp to persist the time when the file is found missing for the first time, and erase the db record 30 days after this timestamp. TBR=mpearson@chromium.org Bug: 845369 Change-Id: I5b129df435119d501867cedde85ef49ec844aa38 Reviewed-on: https://chromium-review.googlesource.com/1068273 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#561369}
-
Xing Liu authored
DownloadLocationPreference directly uses native pref to persist the selection result. However the native pref may have a delay when persisting the data, and the UI may refresh the view before native pref is done, which causes double radio button selection. This CL caches the selection ID so the UI can always get fresh data. Bug: 842464,792775 Change-Id: I39bec3a61ea2c7f0e656658cfc41a62e12956560 Reviewed-on: https://chromium-review.googlesource.com/1070480 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
-
Renee Wright authored
Bug: 841060 Change-Id: I1542a8f07da2c433406c733bf0489d42e8bd69b3 Reviewed-on: https://chromium-review.googlesource.com/1068533 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#561367}
-
Donna Wu authored
BUG=769630 Change-Id: I1985c14b93872b887d14bbcd5697e431c845ba8b Reviewed-on: https://chromium-review.googlesource.com/1069983 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#561366}
-
Esmael El-Moslimany authored
Bug: 844329 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id9b00c368e32c9cea170af7c6dfaf9a5272e1301 Reviewed-on: https://chromium-review.googlesource.com/1066326Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#561365}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b0e9ddb55381..b001528ffa00 $ git log b0e9ddb55..b001528ff --date=short --no-merges --format='%ad %ae %s' 2018-05-18 courtneygo Use libnativewindow for Android builds 2018-04-27 brandon1.jones Add initial specification for EGL_ANGLE_explicit_context Extension 2018-05-23 tobine Update required Windows SDK version to 10.0.17134 Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I80eb7c606ade2e65c3df61d3b29ff1a71b6ca442 Reviewed-on: https://chromium-review.googlesource.com/1070889Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561364}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ec57b4a2. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18480 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams jsbell@chromium.org: external/wpt/encoding rego@igalia.com: external/wpt/css/css-grid timvolodine@chromium.org: external/wpt/battery-status yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=lukebjerring No-Export: true Change-Id: I00e7d6755a5e7a72365f67f5147a87fb847ddf65 Reviewed-on: https://chromium-review.googlesource.com/1070881 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#561363}
-
Donna Wu authored
BUG=769630 Change-Id: I2a4317f0ca9f9cbd1ffd1bd3c1d12a8487651c40 Reviewed-on: https://chromium-review.googlesource.com/1069982 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
-
Tom Anderson authored
BUG=767901 R=thakis CC=pcc Change-Id: Ib394126f8e729192ee41520eefd85e22531bfd65 Reviewed-on: https://chromium-review.googlesource.com/1066596 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#561361}
-
Jinsuk Kim authored
MotionEventSynthesizer class is used by Chrome (VR) and content internally. This CL splits it into public interface with create method and implementation class. Helps remove the exception rule in DEPS. Bug: 617324 Change-Id: I99fa8c01089ede078a7c2b2929897fdbbd7b40aa Reviewed-on: https://chromium-review.googlesource.com/1058873 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#561360}
-
Yoshifumi Inoue authored
This patch changes "merge-start-blockquote.html" to utilize |selection_test()| for ease of maintenance. Bug: 679977, 707656 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib8b5d63687c42e9ead5167a11f0a592e19297f84 Reviewed-on: https://chromium-review.googlesource.com/1069965Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561359}
-
Francois Doray authored
All existing callers really want to know when the LifecycleUnit was last visible, not when its visibility last changed (they are not interested in transitions between visible and hidden). Change-Id: Ie57d8c3219d69cdb5ede938544a434063ebe9e04 Reviewed-on: https://chromium-review.googlesource.com/1069451 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#561358}
-
Tarun Bansal authored
These network quality estimator histograms were deprecated earlier, but they were not correctly marked as deprecated. Bug: 843210 Change-Id: Ie852a015072a4734c02c7cd2fd6d03fb35bf5f95 Reviewed-on: https://chromium-review.googlesource.com/1063552Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#561357}
-
Oystein Eftevaag authored
* TraceWriters will no longer be destroyed when their TLS slot is cleaned up on thread shutdown as this can trigger a CommitData() call from Perfetto and cause asserts when Mojo does a TaskRunnerHandle::Get() for a PostTask; instead we leave the deletion to the taskrunner Perfetto is running on (if it's getting shut down, the task should get dropped). * Run ProducerClients on their own sequence. Bug: 844379 Change-Id: Ie45b36a4e463674122555dbec2105953a882f37c Reviewed-on: https://chromium-review.googlesource.com/1069528Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#561356}
-
Mitsuru Oshima authored
This is a regression in http://crrev.com/c/1053116. The target widget is used in DetachedTitleAreaRenderer and WideFrameView. BUG=b/33693796 TEST=covered by unittest Change-Id: I839d13113a40abde4d25d7e634ad549937dac30b Reviewed-on: https://chromium-review.googlesource.com/1067319 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#561355}
-
Xiaohan Wang authored
DecryptingAudioDecoder was added to support decrypt-and-decode of audio buffers by a CDM using the Decryptor interface. Since then CDMs have evolved and today there's no CDM supporting this path in production. Though in browser tests, this paths is still used where the Clear Key CDM can decrypt-and-decode audio. This CL changes DefaultDecoderFactory such that by default DecryptingAudioDecoder will not be created except when External Clear Key is enabled, which typically is only set in browser tests. This will save an IPC round trip during initialization when playing media with encrypted audio, and hopefully will improve start-to-play time. Note that decrypt-and-decode of audio is supported on Android, but via MojoAudioDecoder directly, not through an explicit Decryptor interface. Bug: 846064 Test: browser tests still pass Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iffcbd488e613b63d50bf077dc27b4e5c4105adc3 Reviewed-on: https://chromium-review.googlesource.com/1070554Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#561354}
-
Aaron Leventhal authored
Items in single selection containers that have accessibility focus should get the selected state. Code to mirror focus to selection exists, but the selected state must be refreshed. Bug: 846089 Change-Id: I90eb6aaec3be196b78126241ebf7e3d38ccda7c2 Reviewed-on: https://chromium-review.googlesource.com/1070520 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#561353}
-
Charles Zhao authored
(1) Update native_inference.h, native_inference.cc, example_preprocessor_config.pb to be the newest model. (2) Update tab_score_predictor_unittest.cc (3) Add amoylan as extra owner of this directory. Change-Id: Iffb2f84e5cbf65ae20d864fccc2edface051055e Reviewed-on: https://chromium-review.googlesource.com/1068952 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#561352}
-
Hiroshige Hayashizaki authored
This CL replaces ScriptLoader::Execute() with PendingScript::ExecuteScriptBlock(). To do this, this CL clears ScriptLoader::pending_script_ in ScriptLoader::PendingScriptFinished(), i.e. slightly before ScriptLoader::Execute(). Bug: 842349 Change-Id: Ia010d370ce1e139808b39e66ad4557f9151e2a47 Reviewed-on: https://chromium-review.googlesource.com/1054553 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#561351}
-
Tim Zheng authored
Bug: 824549 Change-Id: Ifd8d5c83b2c62d4cdf60cc8f0345f5a736e49a66 Reviewed-on: https://chromium-review.googlesource.com/1067681Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561350}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f1e34db090a1..1986f5a957da $ git log f1e34db09..1986f5a95 --date=short --no-merges --format='%ad %ae %s' 2018-05-21 benjhayden Change "minutes" legacy unit to timeInMsAutoFormat. 2018-05-23 benjhayden Add dashboard/v2spa.yaml and v2spa_dev.yaml. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2f8210d32f75d073b8bf9f1dab9eb778910f2257 Reviewed-on: https://chromium-review.googlesource.com/1071000Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561349}
-
Jinho Bang authored
After a long discussion, Web Payment Working Group decided to remove the `currencySystem` member[1]. The currency code should be well-formed 3-letter alphabetic code and is allowed even if that is not part of the official ISO 4217 list. [1] https://github.com/w3c/payment-request/pull/694 Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-jtNNH_Bb6c Bug: 839402 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I17ac51c93e457c4bae00db365a4c7322274c8d4f Signed-off-by:
Jinho Bang <jinho.bang@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/1042427Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#561348}
-
Sonny Sasaka authored
When Bluetooth adapter goes away, this could be caused by BlueZ crash or chip error. In any case, we should make sure to clear all discovery sessions, otherwise out-of-sync about discovery sessions can happen between Chrome and BlueZ. BUG=837656 Change-Id: Id1956039a94da32fe95a0d2c023eb97eef8d99fa Reviewed-on: https://chromium-review.googlesource.com/1069934 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#561347}
-
Michael Giuffrida authored
Tests the experimental group that enables TabRanker for ML-based tab discarding. Bug: 838030 Change-Id: I4304420f3841b2f6c189239f9aca30fc1d03f17c Reviewed-on: https://chromium-review.googlesource.com/1068205 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#561346}
-
Fredrik Hubinette authored
Bug: 836952 Change-Id: I381042fd107b954b5d47f1dae7e392e5bd3752dc Reviewed-on: https://chromium-review.googlesource.com/1069804 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#561345}
-
Esmael El-Moslimany authored
Use SELECT_EXISTING_FOLDER when choosing an unpacked extension. Disable folder creation for SELECT_EXISTING_FOLDER and SELECT_UPLOAD_FOLDER (for all desktop platforms excluding kde). For GTK when selecting a folder, show only folders. Bug: 772180 Change-Id: I0f513180ff7f10b5af91e8c518b3d9fd4b0fc8f1 Reviewed-on: https://chromium-review.googlesource.com/1019732 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
junweifu authored
We can hopefully find these conversion locations in the future if we find a better solution for Mojo-IDL intero although TypeConvert is deprecated. Use LUCI for chromium tests on Windows 10 in PRSUBMITs.py. BUG=841649 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng Change-Id: Ic235bcf98ecd53c5d873a8faf4ed72f1f60530b3 Reviewed-on: https://chromium-review.googlesource.com/1063291 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#561343}
-
Brandon Wylie authored
This composite reporter will be used to report events to as many sources as required. The first concrete use will be to implement a debugging reporter. Bug: 843251 Change-Id: Ia847715ee1da4200c644bde426e5a0daccfb65f2 Reviewed-on: https://chromium-review.googlesource.com/1056295 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#561342}
-
Saman Sami authored
This CL introduces ClientFrameSinkVideoCapturer, a client-side library that interacts with FrameSinkVideoCapturer and can handle viz crashes. This CL converts FrameSinkVideoCaptureDevice to use ClientFrameSinkVideoCapturer but the DevTools usages of FrameSinkVideoCapturer aren't converted yet. Bug: 806377 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I982ca324491fafe9331de4b660cb81f93fcc4605 Reviewed-on: https://chromium-review.googlesource.com/1066224Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#561341}
-
CJ DiMeglio authored
Currently, we are able to initiate a SubmitSingleFrame at any time. This ignores two edge cases, both of which have us accessing VideoResourceUpdater and VideoResourceProvider while they are null (which means we never intialized VideoFrameResourceProvider (VFRP)). Case one occurs when we call SubmitSingleFrame before we were able to initialize VFRP the first time. The second can occur while we are re-intializing VFRP on context loss. Because we cannot just check if we have a context_provider to prove that we are safe from these cases (it might be null because we are in software compositing mode), we instead just check for the initialization. Bug: 842471 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If3b31ed83908668ec21fbd0d2abbd7d45d454e67 Reviewed-on: https://chromium-review.googlesource.com/1069843Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#561340}
-
Joe Downing authored
There is a chance that the FullscreenControlHost work will not be ready for M68 so I am adding a feature check for the keyboard lock api feature flag to enable this control. Note that the control will not appear for mouse / touch users, only in the keyboard lock scenario where the escape key has been locked. BUG=680809 Change-Id: I4eb1fa4608f59d89d418200d1b0b88bc334be8c1 Reviewed-on: https://chromium-review.googlesource.com/1070877Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#561339}
-
Tessa Nijssen authored
Previously, after a section of text was removed and the removal was undone, the cursor was placed after the text. The desired behavior would be a selection of the re-placed text. This change saves the current selection range on delete or replace. The selection range is then restored on undo. Changed tests: - TextfieldModelTest.UndoRedo_CutCopyPasteTest - OmniboxViewTest.UndoRedo Added tests: - TextfieldModelTest.Undo_SelectionTest Bug: 615345 Change-Id: I9ce001099de7175da688a993ed3bfd29d296660c Reviewed-on: https://chromium-review.googlesource.com/1066675 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561338}
-
Sasha Morrissey authored
the console should show the recorded metrics correctly. Test: Set metrics.log = true and try and open one of each file type; Bug: 846136 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I95bc7439f79a2f8c616a4ca655938b956b5bfd59 Reviewed-on: https://chromium-review.googlesource.com/1070907Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561337}
-
Koji Ishii authored
The `style_variant_` field was originally added when we introduced NGStyleVariant[1] and extended to all fragments[2], but it was not initialized and suddenly starts failing for box fragments to have kEllipsis in some tests when '--run-layout-test' option is used. This patch initializes it to kStandard. [1] https://chromium-review.googlesource.com/956552 [2] https://chromium-review.googlesource.com/1068781 Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib7013e9c80f54550f9fc1262345ffd2fa18b3790 Reviewed-on: https://chromium-review.googlesource.com/1068793Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#561336}
-
Michael Lippautz authored
This avoids writing a pointer for each traced wrapper on dispatch. It also brings the wrapper tracing descriptor closer to the regular trace descriptor. Bug: chromium:841830 Change-Id: I6be7566a465184b12d9021926b3a61cd66934bc6 Reviewed-on: https://chromium-review.googlesource.com/1067572Reviewed-by:
-
Quentin Fiard authored
- Improve the documentation of TimeDelta::InXYZ methods to clarify that they return a truncated value (aka rounded towards zero). - Add a new InDaysFloored method to convert a TimeDelta into a floored number of days. - Fix the implementation of InMillisecondsRoundedUp for negative time deltas. Bug: 831545 Change-Id: I4afd256308f6f28ff459925772059fdfc5824995 Reviewed-on: https://chromium-review.googlesource.com/1049906Reviewed-by:
-
Vlad Tsyrklevich authored
Blacklist base::Callback as a conservative solution to crbug.com/845855 Also add two files that call dlsym() resolved functions identified by looking at functions that immediately trap (consist of only a ud2 instruction) after enabling cfi-icall. BUG=845855 Change-Id: I54a74902fd5db5d85f396f200f96f97bd8e1e463 Reviewed-on: https://chromium-review.googlesource.com/1071090Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#561333}
-
Patrick Hulce authored
- Convert dropdowns to radio/checkbox inputs - Resize icons/line height/padding - Overlay size fix - Minor typographic adjustments - Disable start audit button when on active view BUG=844331,844334,844374,844352,844324,844318 Change-Id: Ieb87ce0994031c69a260bddf83f8ad995c8ea70c Reviewed-on: https://chromium-review.googlesource.com/1066302 Commit-Queue: Patrick Hulce <phulce@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561332}
-
