GitLab

Revert of android: Increase NUM_PRIVILEGED_SERVICES to 20 (patchset #3 id:40001 of https://codereview.chromium.org/2555303004/ )

Reason for revert:
Android keeps the intent for a long time, so
randomize doesn't help at all. More details:
crbug.com/664341#c91

Original issue's description:
> android: Increase NUM_PRIVILEGED_SERVICES to 20
>
> This works in conjunction with
> https://codereview.chromium.org/2557273004/ to workaround
> crbug.com/664341. That CL ramdomizes the order of the named services to
> avoid collision, which is not actually effective unless there is a large
> number of named services to choose from.
>
> Sandboxed service already has 20 named services, so up the privileged
> (gpu) count to 20 as well.
>
> BUG=664341
>
> Committed: https://crrev.com/9b853cfcf82d8c57487cb0dd8d1eeaa5ca40260f
> Cr-Commit-Position: refs/heads/master@{#437634}

TBR=tedchoc@chromium.org,halliwell@chromium.org,sanfin@chromium.org,tsunghung@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664341

Review-Url: https://codereview.chromium.org/2574593002
Cr-Commit-Position: refs/heads/master@{#437997}

This is the version all the runtime libraries seem to
use. So, I'm matching it on the assumption the
compiler may do something smarter if appropriate.

TBR=scottmg
NOTRY=true

Review-Url: https://codereview.chromium.org/2574443002
Cr-Commit-Position: refs/heads/master@{#437996}

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |DocumentState|
type and a |documentState| accessor method (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |DocumentState| being the name of both the
type and the accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=creis@chromium.org

Review-Url: https://codereview.chromium.org/2569883002
Cr-Commit-Position: refs/heads/master@{#437995}

This CL adds a test helper header platform/testing/PaintPropertyTestHelpers.h
for common operations that are used in SPv2-related tests.

createOpacityOnlyEffect is added to create effect nodes with only opacity,
other optional effects are assigned a no-op value, and local transform space
and clip are inherited from parent.

As a side change, rootPaintChunkProperties is also moved to the helper header
and renamed to defaultPaintChunkProperties.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2565903002
Cr-Commit-Position: refs/heads/master@{#437994}

This patch adds a cache of the SVG marker transform, similar to the pattern
used in LayoutSVGViewportContainer. This should be a small perf win because
we no longer re-calculate the transform when painting each marker instance.
With this new cache logic, invalidation logic has been added which includes
a fix for paint property under-invalidation (marker-viewBox-changes.svg).

BUG=645667,600618

Review-Url: https://codereview.chromium.org/2565943002
Cr-Commit-Position: refs/heads/master@{#437993}

WebTaskRunner::Task is replaced by WTF::Closure/CrossThreadClosure,
and no longer used in the production.

Review-Url: https://codereview.chromium.org/2568063003
Cr-Commit-Position: refs/heads/master@{#437992}

This file seems to be autogenerated and currently produces ~1k eslint errors.

BUG=none
R=chenwilliam

Review-Url: https://codereview.chromium.org/2566553002
Cr-Commit-Position: refs/heads/master@{#437991}

This is preperatory work which will allow for cheaper update of the
req'd for activation/draw status in the client side scheduler work.

BUG=673434
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2564433003
Cr-Commit-Position: refs/heads/master@{#437990}

Also:
* Quick refactor of jinja2 context creation into a builder.
* Switched Attribute/Method to dicts.
* Added a bit more meat more to header template.
* Added nicer parameter handling to run-bindings-tests
* Added stub helper for unit tests.

BUG=654129
R=bashi,yukishiino,haraken

Review-Url: https://codereview.chromium.org/2568693002
Cr-Commit-Position: refs/heads/master@{#437989}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/26be2ced9076..f309edd7828e

$ git log 26be2ced9..f309edd78 --date=short --no-merges --format='%ad %ae %s'
2016-12-09 wolenetz A couple cherry picks from upstream to fix issue 670190

TBR=dalecurtis@chromium.org
BUG=670190

Review-Url: https://codereview.chromium.org/2567533003
Cr-Commit-Position: refs/heads/master@{#437988}

Patch removes preventDefault(), stopPropagation(), consume() and .type property.
This is a preparation for typed events, which will not inherit from Common.Event.

BUG=none

Review-Url: https://codereview.chromium.org/2553043003
Cr-Commit-Position: refs/heads/master@{#437987}

It doesn't seem like it's being respected. See build:
https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Win%20-%20RandomOrder/builds/382

It's getting close to Wednesday - I'd like to remove [ Win ] so we can get onto more important work and then circle back around when we have more time to find the correct prefix.

R=qyearsley@chromium.org
BUG=670843

Review-Url: https://codereview.chromium.org/2560423003
Cr-Commit-Position: refs/heads/master@{#437986}

BUG=649495

Review-Url: https://codereview.chromium.org/2507753003
Cr-Commit-Position: refs/heads/master@{#437985}

testCanPlayePlatformMediaCodecs was disabled due to flakiness. It seems
that the test is no longer flaky and can be re-enabled (since we are no
longer using WMPA, or because of some unknown changes in test
reliability).

NOTE: If ever the screen is off when the test runs, the test fails.

BUG=620890
TEST=100x run on Nexus 5 and Nexus 7

Review-Url: https://codereview.chromium.org/2570483005
Cr-Commit-Position: refs/heads/master@{#437984}

It used to be used for data/ dir removal, but it is now
integrated into ArcSessionManager.
Remove the unused class now.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2573463002
Cr-Commit-Position: refs/heads/master@{#437983}

BUG=673022

Review-Url: https://codereview.chromium.org/2565673003
Cr-Commit-Position: refs/heads/master@{#437982}

SSLClientSessionCache::DumpMemoryStats() creates one
MemoryAllocatorDump for each cache entry. To make the memory dump lighter,
this CL dumps the total size and count and does not create sub dumps.

BUG=669108

Review-Url: https://codereview.chromium.org/2574513002
Cr-Commit-Position: refs/heads/master@{#437981}

Change the HttpServerPropertiesManager::net_task_runner_ to use a TestMockTimeTaskRunner in unittests so that
we are able to verify tasks posted with delay in the future.

Now all the tests that were ExpectCacheUpdate or ExpectScheduleUpdatePrefsOnNetworkThread
will need to call net_test_task_runner_>FastForwardUntilNoTasksRemain() so that all
the tasks complete running.

BUG=670519

Review-Url: https://codereview.chromium.org/2563273002
Cr-Commit-Position: refs/heads/master@{#437980}

Provide more user-friendly experience as a welcome screen on Timeline panel.
The new UX is put behind an experiment.

BUG=570441

Review-Url: https://codereview.chromium.org/2557973002
Cr-Commit-Position: refs/heads/master@{#437979}

Add accelerator SHOW_IME_MENU_BUBBLE into table kActionsAllowedAtLoginOrLockScreen to allow using 'Alt+Shift+K' to open opt-in IME menu in login or lock screen.

BUG=668394,642423
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2566583004
Cr-Commit-Position: refs/heads/master@{#437978}

BUG=668207
TBR=rnk

Review-Url: https://codereview.chromium.org/2565173005
Cr-Commit-Position: refs/heads/master@{#437977}

This CL adds rappor metrics for recording the eTLD+1 of the top-level
frame and cross-origin iframe when the user pauses an autoplaying video.

BUG=672526

Review-Url: https://codereview.chromium.org/2563723002
Cr-Commit-Position: refs/heads/master@{#437976}

In Bug 607822, many MacOS tests were disabled because the underlying implementation not ready. We have since fixed many bugs, and notifications seem to be working fine. This patch removes all of web bluetooth TestExceptions and re-enables notifications on the MacOS

BUG=673147

Review-Url: https://codereview.chromium.org/2569593002
Cr-Commit-Position: refs/heads/master@{#437975}

Per the IndexedDB specification, a versionchange transaction is running
until the open request's transaction member is set to null, which
should happen (synchronously) after the onabort() event handler is
called. Therefore, tests can only assume that a transaction stopped
running after the onabort event handler has occurred.

BUG=657968

Review-Url: https://codereview.chromium.org/2538343002
Cr-Commit-Position: refs/heads/master@{#437974}

Ash only ships on Chrome OS, so simplify our BUILD.gn files by removing
all the is_win and is_chromeos conditionals.

This also removes a dependency from chrome/browser/ui/BUILD.gn that existed
for all use_aura builds. Aura should not require ash on Windows or Linux.

BUG=666776
TEST=bots

Review-Url: https://codereview.chromium.org/2569723003
Cr-Commit-Position: refs/heads/master@{#437973}

This switches the icons to paper-icon-button-light, using the same
styling as elsewhere on the page. This doesn't actually improve page
load time, since all of these buttons are behind dom-ifs. It does,
however, simplify the CSS and make the Grouped mode buttons match the
mocks.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2346383004
Cr-Commit-Position: refs/heads/master@{#437972}

Take the address of the ProfileImportHandler::Create routine when
adding it to the mojo interface registry.

BUG=

Review-Url: https://codereview.chromium.org/2563393002
Cr-Commit-Position: refs/heads/master@{#437971}

BUG=

Review-Url: https://codereview.chromium.org/2573643002
Cr-Commit-Position: refs/heads/master@{#437970}

See https://codereview.chromium.org/2512473004/ for additional context.

BUG=669638

Review-Url: https://codereview.chromium.org/2550263002
Cr-Commit-Position: refs/heads/master@{#437969}

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2571653002
Cr-Commit-Position: refs/heads/master@{#437968}

The last public use of it is part of the pre-MD profile switcher.

BUG=633986

Review-Url: https://codereview.chromium.org/2556833002
Cr-Commit-Position: refs/heads/master@{#437967}

Review-Url: https://codereview.chromium.org/2566983004
Cr-Commit-Position: refs/heads/master@{#437966}

The test has been flakily failing on linux today

TBR=wangxianzhu@chromium.org

BUG=673539

Review-Url: https://codereview.chromium.org/2571553004 .
Cr-Commit-Position: refs/heads/master@{#437965}

See https://codereview.chromium.org/2512473004/ for additional context.

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2555453003
Cr-Commit-Position: refs/heads/master@{#437964}

I messed up the mapping. As penance, add tests for everything and make
the Android tests less of a mess.

The failure mode here is P-521 client certificates won't quite work
right in TLS 1.3. I believe TLS 1.2 and below would not have been
affected.

BUG=672972

Review-Url: https://codereview.chromium.org/2567523003
Cr-Commit-Position: refs/heads/master@{#437963}

If VrCore exists on non-Daydream devices, WebVR Cardboard support should be enabled.

BUG=671370

Review-Url: https://codereview.chromium.org/2556093002
Cr-Commit-Position: refs/heads/master@{#437962}

The child process launcher now switches to the host executable's
path before running a new child process. That breaks mash_runner
code which launches the host executable if the host executable was
invoked by relative path.

This changes mash_runner to always reference the host executable
by absolute path when rewriting child command lines.

BUG=None
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2573593002
Cr-Commit-Position: refs/heads/master@{#437961}

Assets are yet to be added to this change.
BUG=664367

Review-Url: https://codereview.chromium.org/2531223003
Cr-Commit-Position: refs/heads/master@{#437960}

Since external experiment ids are not based on Chrome's low
entropy source, they do not have the same guarantees about
not identifying a user as Chrome's variations. As such, we
should only transmit them for signed in users, whose identity
is already known by Google so there's no risk of identifying
them through these headers.

Note: The signed-in state checking in this CL is only done for
web content area requests and not other internal requests,
like to the suggestion service, where it treats the state as
"not signed in". This is fine to do because variations service
ids are still sent, which is what the other call sites are
interested in.

BUG=672532
TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org

Review-Url: https://codereview.chromium.org/2558913003
Cr-Commit-Position: refs/heads/master@{#437959}

The browser tests for ResourcePrefetchPredictor check that the actual
request priority is equal to the expected value. But for the images the
priority cannot be precisely defined because there is a race between the
preload scanner issuing fetch requests and frame view performing layout
and promoting priorities of all visible images.

BUG=650253,673028

Review-Url: https://codereview.chromium.org/2569723002
Cr-Commit-Position: refs/heads/master@{#437958}