- 11 Feb, 2019 31 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d85a1763c27..3c7ef7a3b16e Created with: gclient setdep -r src-internal@3c7ef7a3b16e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia19c8c79338b50825eca3e8de07149eaf17fe38f Reviewed-on: https://chromium-review.googlesource.com/c/1462676Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630698}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/13b2686c57be..dbbd7b449a7f $ git log 13b2686c5..dbbd7b449 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 joelhockey system_api: add export pack stage 2019-01-31 kerrnel debugd: Implement core scheduler performance tuning. 2019-01-28 xiaochu dlcservice: migrate DLC module image path 2019-01-03 drcrash cryptohome, attestation: DBUS proto call to check attestation prep 2019-02-05 joelhockey system_api: update doc for export_path 2019-02-04 aoldemeier system_api: Add dbus constants for Start/StopVmPluginDispatcher methods. Created with: roll-dep src/third_party/cros_system_api Change-Id: Ibc92a6f0fa818ba401d0b750009eeed63bbe4829 Reviewed-on: https://chromium-review.googlesource.com/c/1460243Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#630697}
-
Alli Murray authored
removable partitions. Bug: 918795 Change-Id: I9538461a7d20d9b9d606e4d8f3462c71df018d32 Reviewed-on: https://chromium-review.googlesource.com/c/1460211 Commit-Queue: Alli Murray <alliemurray@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#630696}
-
Leo Zhang authored
Response from Mojo service is a dict with success as its key, which is defined in input_engine.mojom under chromeos/services/ime Bug: 837156 Change-Id: Ie33c5aaed27c3de8b995b8455b65074b6bbe2cba Reviewed-on: https://chromium-review.googlesource.com/c/1460656Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#630695}
-
Staphany Park authored
Bug: 611938 Change-Id: I451f543ac7d742a1eec692dfd924ed1f49d4feee Reviewed-on: https://chromium-review.googlesource.com/c/1462428 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#630694}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ef26fcb13fc6..136cd7018a99 git log ef26fcb13fc6..136cd7018a99 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@136cd7018a99 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I267feb879913c9be4bde0ba42fe4f9c30d45eb66 Reviewed-on: https://chromium-review.googlesource.com/c/1462608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630693}
-
Chih-Yu Huang authored
In MojoVDService and some unittest we duplicate a simple implementation of VideoFrame::SyncTokenClient. This CL moved it to a separate file. BUG=522298 TEST=media_unittests Change-Id: I18009712977a12b31cc8136ef79a230b34667384 Reviewed-on: https://chromium-review.googlesource.com/c/1460741 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#630692}
-
Staphany Park authored
Bug: 611938 Change-Id: I5231a54ef35fc2aee6d36e83d65b1674df58cbd0 Reviewed-on: https://chromium-review.googlesource.com/c/1462425 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
-
Cecilia Ni authored
This CL adds PWA Permission View tests that test 1) toggle status reflects permission status, and 2) click toggle will toggle the corresponding permission. Bug: 906508 Change-Id: I03f77afe2a75afc260c2d0dcdfe907e6d12dc9e8 Reviewed-on: https://chromium-review.googlesource.com/c/1445331 Auto-Submit: Cecilia Ni <ceciliani@google.com> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Cecilia Ni <ceciliani@google.com> Cr-Commit-Position: refs/heads/master@{#630690}
-
Joel Hockey authored
Change-Id: I6279cd2c62a937735a6f9b56fdbbde7d88dc53c8 Reviewed-on: https://chromium-review.googlesource.com/c/1460246 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ee1cb5959d7a..4d85a1763c27 Created with: gclient setdep -r src-internal@4d85a1763c27 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I28054cfc78edd5fe846017e2ed9ef4f56579c5f1 Reviewed-on: https://chromium-review.googlesource.com/c/1462596Reviewed-by:
-
Findit authored
This reverts commit 6d39702e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 630682 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZkMzk3MDJlNzQ4YWUzMzg0MmU1MzlhZmNmNTVlYjI2MjM1ODJkODAM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/19798 Sample Failed Step: non_single_process_mash_unit_tests Original change's description: > [Dolphin] Refactor in preparation for query-based predictions. > > - Extra methods added to RecurrenceRanker and RecurrencePredictor to accept queries. > > - Storage of targets has been moved from the RecurrenceRanker to individual > RecurrencePredictors. As a result, RecurrencePredictor must now handle targets > renames and removes themselves. Methods for this have been added to their API. > > This is necessary because query-based predictions will require a different data > structure to store target + query than zero-state predictions, which only require > a target. In order to keep the RecurrenceRanker usable for both tasks, choice of > data structure needs to moved into the RecurrencePredictors, where individual > predictors can use what's suitable. > > - The original FrecencyPredictor has been renamed ZeroStateFrecencyPredictor. > > - Some extra tests added. > > Bug: 921444 > Change-Id: I95a6dca135928726c779261ec6b1663b1023bf1f > Reviewed-on: https://chromium-review.googlesource.com/c/1459856 > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Tony Yeoman <tby@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630682} Change-Id: I9ac4e9efc7abf31d64e30cd9e3f5a1fa55bd9778 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 921444 Reviewed-on: https://chromium-review.googlesource.com/c/1462426 Cr-Commit-Position: refs/heads/master@{#630687}
-
Melissa Zhang authored
This CL implements the uninstall method in arc_apps. BUG=916380 Change-Id: I2ea78604d3eeee68f72f1c5985eb6bc71371090d Reviewed-on: https://chromium-review.googlesource.com/c/1451497 Commit-Queue: Melissa Zhang <melzhang@google.com> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#630686}
-
Alexey Baskakov authored
The backend shouldn't know anything about the frontend (UI). It still uses PWAConfirmationView and ShowPWAInstallDialog/ShowBookmarkAppDialog under the hood. Bug: 901226 Change-Id: I3a22410005efe8ded469fa094069af3132456338 Reviewed-on: https://chromium-review.googlesource.com/c/1451501 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#630685}
-
Alexander Dunaev authored
The fuzzer no longer stops the server thread during the operation. R=msisov@igalia.com, rjkroege@chromium.org Bug: 928768 Change-Id: I80c5cad47d38563f00258a5a95a109784378da12 Reviewed-on: https://chromium-review.googlesource.com/c/1458445Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#630684}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I9c503d7d12c1127af5353280d0e3fc9fb03c2f3e Reviewed-on: https://chromium-review.googlesource.com/c/1462210Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#630683}
-
tby authored
- Extra methods added to RecurrenceRanker and RecurrencePredictor to accept queries. - Storage of targets has been moved from the RecurrenceRanker to individual RecurrencePredictors. As a result, RecurrencePredictor must now handle targets renames and removes themselves. Methods for this have been added to their API. This is necessary because query-based predictions will require a different data structure to store target + query than zero-state predictions, which only require a target. In order to keep the RecurrenceRanker usable for both tasks, choice of data structure needs to moved into the RecurrencePredictors, where individual predictors can use what's suitable. - The original FrecencyPredictor has been renamed ZeroStateFrecencyPredictor. - Some extra tests added. Bug: 921444 Change-Id: I95a6dca135928726c779261ec6b1663b1023bf1f Reviewed-on: https://chromium-review.googlesource.com/c/1459856Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#630682}
-
Nico Weber authored
TBR=dvadym Bug: 926235 Change-Id: Ic78dd70b61df3c46e5fd7a56db4722fc4ebe0637 Reviewed-on: https://chromium-review.googlesource.com/c/1462206 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#630681}
-
Nico Weber authored
There's no good way to require a semicolon after this macro, so remove the semicolons after the macro instead. (Several places already had no semicolon there, so this does make things more consistent.) CL created by git grep -l DECLARE_EXTENSION_FUNCTION | xargs -n 1 perl -i -p0e 's/(DECLARE_EXTENSION_FUNCTION\([^)]+\));?/\1/g' TBR=seantopping Bug: 926235 Change-Id: Ia49fc64756ab1b50d3423f6c80ed0c2d44f4378b Reviewed-on: https://chromium-review.googlesource.com/c/1462207 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#630680}
-
Nick Diego Yamane authored
As of [1], UTF characteres are correctly composed on Ozone/wayland, taking as input raw key events from InputMethod classes. That is possible thanks to previously ChromeOS-only CharacterComposer component. This patch fixes the preedit text handling in WaylandInputMethodContext, which basically properly support HEX_MODE in CharacterComposer. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1448136 R=rjkroege@chromium.org, shuchen@chromium.org Bug: 921947 Change-Id: I7cf750df2bf43273464f52a726719d50d74075f8 Reviewed-on: https://chromium-review.googlesource.com/c/1454297Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#630679}
-
Alexey Baskakov authored
All subsystems work with a generalized web app registry, hence any activities must be started in WebAppProvider::OnRegistryReady callback. Fix ExtensionServiceTestSimple.Enabledness unit test on ChromeOS: - Two TestingProfiles with TestExtensionSystem in each of them can not co-exist because they start two conflicting ScopedTestUserManager instances for user_manager::UserManager singleton. https://cs.chromium.org/chromium/src/chrome/browser/extensions/test_extension_system.cc?rcl=2e6a3bddac0aff89c5ff415e9c1cd4da804280ef&l=54 Bug: 920062 Change-Id: I18097d84ac9e27fdda9a7b5458cae9c4f5895273 Reviewed-on: https://chromium-review.googlesource.com/c/1454058 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL adds a feature flag for the new omnibox installation button for PWAs. Bug: 907351 Change-Id: I40aabe93b0bcdfb84160a5394b826f83b4a19cbe Reviewed-on: https://chromium-review.googlesource.com/c/1460206 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#630677}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e971cc3474b7..ee1cb5959d7a Created with: gclient setdep -r src-internal@ee1cb5959d7a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3118ede841395db2d6e402d40e98f5599671f4cd Reviewed-on: https://chromium-review.googlesource.com/c/1462542Reviewed-by:
-
Reka Norman authored
This CL adds a permission view for ARC apps, which involves making the permission-related functionality of the page more generic so that it works for different app types. It also fixes a problem which prevents the toggles in the notification view from actually changing permissions. Bug: 906508 Change-Id: I180beed57a5ad6009fb64e4f180002fba1369242 Reviewed-on: https://chromium-review.googlesource.com/c/1453218 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by:
-
Jinsuk Kim authored
Extends the feature flag |kOverscrollHistoryNavigation| to be used for Android platform as well, and remove the newly added one |kGestureNavigation|. Bug: 865567 Change-Id: I580120235825966b059190779e99e4957c436578 Reviewed-on: https://chromium-review.googlesource.com/c/1424628Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#630674}
-
Josh Pratt authored
ChromeOS now hosts guest operating systems requiring USB access (e.g. Crostini, ARC++). This is a reupload of nverne's CL to prepare to support Crostini USB support (here: https://chromium-review.googlesource.com/c/chromium/src/+/1348885 ) Bug: 899568 Change-Id: I61f78d341ac029c39d6cd82465cda0b509366be3 Reviewed-on: https://chromium-review.googlesource.com/c/1382718 Commit-Queue: Josh Pratt <jopra@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#630673}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa5c2279db31..e971cc3474b7 Created with: gclient setdep -r src-internal@e971cc3474b7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iceda8df12205f3434dc75ad700cb3903c5868535 Reviewed-on: https://chromium-review.googlesource.com/c/1462512Reviewed-by:
-
Luciano Pacheco authored
Change-Id: I46fdd41bbda50add5950180a332fcef3f7e034ba Reviewed-on: https://chromium-review.googlesource.com/c/1459857Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#630671}
-
Luciano Pacheco authored
CL 4 of 4. Bug: 778674 Change-Id: Ieba51028a4c16d2b3bf1539f19f0b94f693638b8 Reviewed-on: https://chromium-review.googlesource.com/c/1459867Reviewed-by:
-
dstockwell authored
Bug: 902646 Change-Id: I8692fcdd82fa89a55048b7741e4b03c86c60a661 Reviewed-on: https://chromium-review.googlesource.com/c/1461199 Commit-Queue: dstockwell <dstockwell@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by:
-
Andrew Moylan authored
ML Service launch with its first active client is M74, so extend the expiry a couple of months past M74 stable release. Bug: 928510 Change-Id: Ib04b0d90228fc05243dc06f048f00295eeaf945f Reviewed-on: https://chromium-review.googlesource.com/c/1454204Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630668}
-
- 10 Feb, 2019 9 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5fc138c04690..ef26fcb13fc6 git log 5fc138c04690..ef26fcb13fc6 --date=short --no-merges --format='%ad %ae %s' 2019-02-10 fmalita@chromium.org [sksg] Fix image filter content inval rect tracking Created with: gclient setdep -r src/third_party/skia@ef26fcb13fc6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I09c571c6c915d3c579cf56e287b776015a923949 Reviewed-on: https://chromium-review.googlesource.com/c/1462505Reviewed-by:
-
Anand K. Mistry authored
MDnsHostLocator uses net:: code, which must be run on the IO thread. This change splits the core logic into an MDnsHostLocator::Impl class that runs on the IO thread. BUG=906182 Change-Id: Ie084cea490b91232ec45c8acc3b24097bf737877 Reviewed-on: https://chromium-review.googlesource.com/c/1460212Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#630666}
-
Matt Menke authored
Remove the HttpProxyClientSocketPool class, replacing it with TransportClientSocketPools instead. The TransportClientSocketPools that replace it function exactly as the HttpProxyClientSocketPool did - each sits on top of an SSL and transport pool. This CL leaves proxy_client_socket_pool_unittests in place, they've just been updated to use TransportClientSocketPools, to keep this CL small. I'll flatten the pools and move the tests in followup CLs. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Bug: 472729 Change-Id: Iac565e3666406ee2b9ca7a9917b267d16477c75c Reviewed-on: https://chromium-review.googlesource.com/c/1447114 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630665}
-
Joshua Peraza authored
System webview fails to launch crashpad with an unsatisifed link error because it is attempting to load 32-bit libraries in a 64-bit process. This error only occurs with system webview on 64-bit arm devices. This error doesn't occur when monochrome is the webview provider because monochrome doesn't extract native libs, so the paths within the APK are used. It doesn't occur on x86 family devices because the ABI names match the extracted directory names. Bug: 930342 Change-Id: Ib9a0597e277abd4fb7c8f3a5faf61a160292fe54 Reviewed-on: https://chromium-review.googlesource.com/c/1462418Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#630664}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/30cad267151f..59f03f30627f $ git log 30cad2671..59f03f306 --date=short --no-merges --format='%ad %ae %s' 2019-02-10 junyer Tidy up semicolons (mostly macro-related) in re2.h. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Bug: 926235 Change-Id: I327176cd4f5feec0ba64a6a5aa12542565964898 Reviewed-on: https://chromium-review.googlesource.com/c/1462155Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#630663}
-
Marc Treib authored
SyncService is the interface, ProfileSyncService is the concrete implementation. Generally no clients should need to use the conrete implementation - for one, testing will be much easier once everyone uses the interface only. Bug: 924508 Change-Id: Ia210665f8f02512053d1a60d627dea0f22758387 Reviewed-on: https://chromium-review.googlesource.com/c/1461119 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630662}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/671e5a52238a..aa5c2279db31 Created with: gclient setdep -r src-internal@aa5c2279db31 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie8012d051dd9eb10df57090bd1e452242c966c73 Reviewed-on: https://chromium-review.googlesource.com/c/1462443Reviewed-by:
-
Peter Kotwicz authored
This CL splits out the network error dialog display logic into its own class - WebApkSplashNetworkErrorObserver.java This CL also: - Renames WebappSplashScreenController#onFinishedNativeInit() to onShowWithNative() because the method is always called after show(). - Renames SameActivityWebappSplashDelegate#mOfflineDialog to #mWebApkOfflineDialog for clarity. Change-Id: I8206dbe4c39efb06444cfda75139835d26fcff3a Reviewed-on: https://chromium-review.googlesource.com/c/1405702 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f49f450..81215ad1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I08593102b0fc0228017a1ba8d55427dabbfec978 Reviewed-on: https://chromium-review.googlesource.com/c/1462416Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630659}
-
