- 08 Apr, 2019 40 commits
-
-
Rayan Kanso authored
The button is disabled if there are no events, and saves all events to a file when clicked (JSON format). Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c13 Bug: 942174 Change-Id: I2c2d3600814f19050083275f52acbe40e23b0e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552854 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648646}
-
Marc Treib authored
It's an (OAuth2) access token, so let's call it what it is. Bug: 933799 Change-Id: Ie7439bdf707991df913cf56a502f0d92143c4679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556798 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#648645}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3bb94905928d..edab510dfad8 git log 3bb94905928d..edab510dfad8 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 swiftshader.regress@gmail.com Regres: Update test lists @ 4ba1911b Created with: gclient setdep -r src/third_party/swiftshader@edab510dfad8 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ib9c30ded3e665842a4132b079436d25dc695aca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557877Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648644}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/731eaa372a59..d3c9245454ed git log 731eaa372a59..d3c9245454ed --date=short --no-merges --format='%ad %ae %s' 2019-04-08 ethannicholas@google.com Revert "Revert "Reland "GPU support for SkMixers""" Created with: gclient setdep -r src/third_party/skia@d3c9245454ed The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ie6d0f0a616192e5cb753d60b68744b881384fa6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557874Reviewed-by:
-
Mikel Astiz authored
Passwords have a few particularities when it comes to reading from the sync Directory, as reflected in the TODO now removed. This patch adds integration tests to exercise the migrator, which seems to work just fine. Bug: 949038 Change-Id: I058964587fd94873c0f86836d262adb18a2761d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557021 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#648642}
-
Henrique Ferreiro authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in third_party/blink/renderer/platform/, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbx> Bug: 939691 Change-Id: I3ae44fd631206e018f4d3daf13c6849aed8a756d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556836Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#648641}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/094a55279558..439ae2de32db git log 094a55279558..439ae2de32db --date=short --no-merges --format='%ad %ae %s' 2019-04-08 hjd@google.com Merge "perfetto-ui: Show slice wakeup info" 2019-04-08 rsavitski@google.com heapprofd_client: avoid destruction re-entrancy issues, and global destructor Created with: gclient setdep -r src/third_party/perfetto@439ae2de32db The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:129749217 TBR=perfetto-bugs@google.com Change-Id: I486093b941dac478ce25d5ff43019366a0e1453e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557878Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40c6e1550294..65611b197df1 Created with: gclient setdep -r src-internal@65611b197df1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: Idfb5c236e6b1e519783d9535518c2e03ecf893a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557876Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648639}
-
Marc Treib authored
It was used to record field trials as Sync user events, but this feature was abandoned a while ago. Bug: 934762, 934333 Change-Id: I1606d5052bda03b1db64a2c084f05fe21c5cc9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557020Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#648638}
-
Marc Treib authored
The engine itself knows whether it's initialized. This CL adds a public IsInitialized() methods which exposes that, so ProfileSyncService doesn't have to track it externally. Bug: 934239 Change-Id: Icab966baee60cc8913ff58639b2825df35fc2cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556841Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/067afa275dcb..6abc006f6760 git log 067afa275dcb..6abc006f6760 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 raul@tambre.ee Convert print statements to Python 3 style Created with: gclient setdep -r src/native_client@6abc006f6760 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:941669 TBR=mseaborn@chromium.org Change-Id: I6c698f556ae9c5eaade53b2d9ae6df899bf886ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557875Reviewed-by:
-
Ehsan Karamad authored
FramePolicy (almost always) contains to the combination of a FrameOwner's sandbox flags as well as parsed FeaturePolicy. This is a mechanical change to use FramePolicy instead of the pair of sandbox and parsed policies when possible. In summary: * GetSandboxFlagS() and ContainerPolicy() are removed from FrameOwner. * GetFramePolicy() is added to FrameOWner. * All the public and internal blink API relying on the pair of (WebSandboxFlags, ParsedFeaturePolicy) from a FrameOwner now take a FramePolicy argument. This change would make merging Sandbox and FeaturePolicy easier down the road (FeaturePolicyForSandbox). TBR=jochen@chromium.org Bug: 812381 Change-Id: I4c6f330e13e187cd8c43841955df924a7332ba46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556512Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
-
Lucas Tenório authored
The current conversion first transforms the id into a string then to a hex representation of that string. This is the wrong result since what we really want is the string representation of the id as a hex number. As a bonus I'm adding proper tests to cover this feature. Bug: 927809 Change-Id: I54b902e55e4437595857548bbb6c3775685c8528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554948Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#648634}
-
Askar Aitzhan authored
before: When managed user logs in to unenrolled device there were no managed icon in the bottom left corner near the "time" after: When managed user logs in there is an icon Bug: 940429 Change-Id: Id72cea2d7008443f53c5bbcefb1d6bac507472c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549129Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Cr-Commit-Position: refs/heads/master@{#648633}
-
Samuel Huang authored
This reverts commit b8de8c26. Reason for revert: Relanding: Looks like the problem is caused by another CL. Original change's description: > Revert "Clear inapplicable disable reasons for component extensions" > > This reverts commit 07619eb1. > > Reason for revert: Speculative revert for "Linux Chromium OS ASan LSan Tests (1)" failures in unit_tests related to extensions. > > Original change's description: > > Clear inapplicable disable reasons for component extensions > > > > This change ensures that all component extensions are allowed to be activated despite having some inapplicable disable reasons set. > > > > In particular, this fixes any specific observed on-device instances where ChromeVox or tts had a disable reason of blocked by policy which prevented it from being activated. > > > > Bug: 946839,947305 > > Test: manually. With a device enterprise enrolled, push down kiosk apps to the device from an admin console. Ensure that ChromeVox still works on all screens. > > Change-Id: I2cedafeb16d4420702188f1516825ce1bad52802 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553017 > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648464} > > TBR=dtseng@chromium.org,rdevlin.cronin@chromium.org,devlin@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 946839, 947305 > Change-Id: Icf19fe7e45c41ed559a732703844c0874c6cfdd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557734 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648573} TBR=huangs@chromium.org,dtseng@chromium.org,rdevlin.cronin@chromium.org,devlin@chromium.org Change-Id: I92b60a51aaf4883e8fcc953645b343860bb61f1e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 946839, 947305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557011Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648632}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I01bc173f2a4db6f5ffa744aedb8441667f759b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556656Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Removes the AffiliationBasedMatching flag 2) Removes the backing AffiliationBasedMatching feature 3) Removes support in PasswordStore for disabling password propagation to web credentials 4) Removes test coverage for (3) Bug: None Change-Id: Ied45e67ffb11893c9aa7e27c2d2625c595156b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546528 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#648630}
-
Jan Krcal authored
This CL makes sure that we do not abuse the UMA_HISTOGRAM_CUSTOM_TIMES macro by specifying max value above 24 days (which in milliseconds is around INT_MAX). Recording higher time values has to be treated differently. Bug: 949034 Change-Id: I016379bd5270e3120a21464d072b29117a71c03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549072 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#648629}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3b2feb3..ce224208 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I47780209d164b21993bbd65e25caf0ead1ada212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557542Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648628}
-
Mikel Astiz authored
Our ongoing rollouts (USS migrations) have noticeable impact on this metric and we'd like to keep it around for some more time. Bug: 928514 Change-Id: I8ed093e48c6e15c4e6ea7e5a6d2adc7102c6fc7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556783 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#648627}
-
Marc Treib authored
It's an (OAuth2) access token, so let's call it what it is. Bug: 933799 Change-Id: I02ce9c9885e95d1ea8a854c919d6ac6d75def420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556839 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/008246e0ae51..094a55279558 git log 008246e0ae51..094a55279558 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 lalitm@google.com Merge "trace_processor: introduce API for computing metrics on trace processor" Created with: gclient setdep -r src/third_party/perfetto@094a55279558 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8c735e2f23cb263f8920a61dfe8b6eeb2d0e5e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556585Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4ba1911b2d7f..3bb94905928d git log 4ba1911b2d7f..3bb94905928d --date=short --no-merges --format='%ad %ae %s' 2019-04-08 bclayton@google.com Replace use of ASSERT(false) with UNIMPLEMENTED Created with: gclient setdep -r src/third_party/swiftshader@3bb94905928d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I06a0ffacd3ca2c931390bbfa89fb35c83f55ed71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556586Reviewed-by:
-
Ryo Hashimoto authored
BUG=b:129835848 TEST=build Change-Id: Ie074e6c67f0134d49098557071480663176b9968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549302 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#648623}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01e404997d1e..40c6e1550294 Created with: gclient setdep -r src-internal@40c6e1550294 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I1139618a079e2580ea9628e877db070b4f80cb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556341Reviewed-by:
-
Robbie Gibson authored
This CL uses a named guide to position the popup cell's leading image and text instead of manually setting these constraints. This will help keep those aligned and should make RTL support easier. This also uses the flag value to choose which view controller to show. Bug: 945323 Change-Id: I08b1160b0b2d1dd18b062ff6921915ca0b208d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552865 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#648621}
-
Stephane Zermatten authored
This change moves the definition of the visibility check into the Selector, both internally and in the protocol. This better matches the implementation and allows looking either for an existing or a visible element in WaitForDom, but also in preconditions. This works well for WaitForDom and preconditions, but there are a few actions that only make sense on visible elements, such as click and focus. For these, the client action forces the visibility check. This change also replaces DCHECK for empty selectors in actions with code that returns INVALID_ACTION. This makes it easier to detect possible script versioning issues happening in production. Primary motivation for this change is allowing scripts to run either visibility or existence checks from WaitForDom. Change-Id: I252d5b4ce8250b863f531cecc2cacfb83da51a64 Bug: b/129666439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553549 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#648620}
-
Victor Hugo Vianna Silva authored
In this CL we first change the signature of AddMetadata to receive a unique_ptr. In a subsequent CL we will eliminate the unnecessary copy by changing the metadata_map_ key type to a unique_ptr as well. Bug: 914396 Change-Id: Ic476f6208538b299c2bba9b9eb0662b8694b1da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550466Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#648619}
-
Vadym Doroshenko authored
Bug: 946845 Change-Id: I5e261c52f4467952aaad7cd89020c3f6042b1d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556840Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#648618}
-
Marc Treib authored
The pref was read by ProfileSyncService, but never actually set. Bug: 938869 Change-Id: Ie924712e82f97c4c2459329e4830aa50e3cfc57d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556795 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Mathias Carlen authored
This patch adds the ability to provide a special extra intent string with a comma separated list of experiment ids. It is owned by the controller and kept in the ClientContext provided to the service when the latter is being created. Each request to the backend will contain the experiment id string as part of the client context field. Bug: b/129302131 Change-Id: I4891e822694aebb96015d12d8b50803f7a3d8f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552835 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#648616}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/766ef6cc7749..008246e0ae51 git log 766ef6cc7749..008246e0ae51 --date=short --no-merges --format='%ad %ae %s' 2019-04-08 fmayer@google.com Merge changes I9e70b10f,I92894610 Created with: gclient setdep -r src/third_party/perfetto@008246e0ae51 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3f7a09a21d215a4bdb731dc5b10b8e837913bda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556584Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dcaab6056568..01e404997d1e Created with: gclient setdep -r src-internal@01e404997d1e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I160c36752a427ec2dea62543a73b83acf09f3324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556741Reviewed-by:
-
Colin Blundell authored
SigninManagerBase exposes an IsSigninAllowed() method. SigninManager overrides this method with a different implementation. It turns out that the method is never called on ChromeOS, meaning that the method on the base class is unnecessary. Eliminating it helps clarify the technical relationship between SigninManagerBase and SigninManager. Bug: 814787 Change-Id: I1c496553151010257cb15e08b610eae17fe1941e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554344 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#648613}
-
Thomas Tangl authored
IsUsingDefaultAvatar() was wrongly used inside ShouldShowGenericIcon(). (It is true even if the user selected another "default" avatar icon.) Is is replaced with a check whether the icon is the *default assigned" icon which has index 0. Bug: 949023 Change-Id: Ic2e208024e0f488c914ffb40f43120a36450bc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554763Reviewed-by:
-
Dominic Battre authored
TBR=ricea@chromium.org Bug: 946701,950222,947670 Change-Id: Ic878a00b909719c3f6f4bf8efc5192ddd32153b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556797Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#648611}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I50eba0c9a7f7b54a8ed5874b8fd613f3b856105d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556740Reviewed-by:
-
Jérôme Lebel authored
The sign-in can fails (for example if the user cancel the merge accounnt dialog). The -UnifiedConsentCoordinator.settingsLinkWasTapped has to be reset. Bug: 949922 Change-Id: I18dea38fe2328c6c147640a188c51c1fee0fbebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553551Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#648609}
-
Yi Su authored
Use TemplateURLServiceObserverBridge to update the default search engine name on the "Search Engine" item in SettingsTableVC. Bug: 661915 Change-Id: I24c034c688bab086330da1e2c67ba30c2109ce9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554766 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648608}
-
Dominic Battre authored
This CL disables all TabMetricsLoggerTest.* tests on ChromeOS for their flakiness. See the bugs for details. TBR=fdoray@chromium.org Bug: 950244, 949288 Change-Id: Ic5c724237e6f6c7ab26e2bb7f37045d109c14e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557016Reviewed-by:
-
