- 21 Jul, 2014 33 commits
-
-
ch.dumez@samsung.com authored
Make manual isSVG*Element() helpers as efficient as the generated ones by introducing a DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION() macro, similarly to the DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(). This new macro is used instead of DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION() for SVG types so that the isSVG*Element() helpers leverage the faster SVGElement::hasTagName(SVGQualifiedName) when possible (i.e. when the input is an SVGElement*). This is a follow-up to: https://src.chromium.org/viewvc/blink?view=rev&revision=178540 R=pdr@chromium.org, abarth@chromium.org Review URL: https://codereview.chromium.org/403343005 git-svn-id: svn://svn.chromium.org/blink/trunk@178580 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jbroman@chromium.org authored
fitBorderToLinesIfNeeded can only be called on block flows, so it can be moved altogether. deleteLineBoxTree can have its logic moved, leaving (for now) only an ASSERT declaring that it wouldn't have done anything anyway for now. BUG=393945, 302024 Review URL: https://codereview.chromium.org/404993002 git-svn-id: svn://svn.chromium.org/blink/trunk@178577 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rtoy@chromium.org authored
Benchmark result from http://rtoy.github.io/webaudio-hacks/tests/time-convolver-short.html, running Linux on a Z620: M36: 1680 ms Opt: 1060 ms Time is now reduced by about 33%. For Windows running on a Z600: M38: 3005 ms Opt: 2280 ms A savings of about 25%. BUG=395276 TESTS=convolution-mono-mono still passes. Review URL: https://codereview.chromium.org/408563003 git-svn-id: svn://svn.chromium.org/blink/trunk@178576 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simonhatch@chromium.org authored
Thought it would be nice to keep this feature behind the experimental flag, but be able to turn it on via a finch trial from chrome. Will be followed by: https://codereview.chromium.org/389583004/ Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 BUG=370696 Review URL: https://codereview.chromium.org/386943009 git-svn-id: svn://svn.chromium.org/blink/trunk@178575 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jshin@chromium.org authored
Now that ICU was rolled to ICU 52, two layout tests marked as failure pass beause the expectation was updated in advance to prepare for ICU 52 update. Likewise, a test for shortStandAloneMonth names in ru_RU should be re-enabled. BUG=378919 TEST=1.LayoutTest: fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-* 2. webkit_unit_tests: LocaleICU* TBR=tkent@chromium.org Review URL: https://codereview.chromium.org/403393004 git-svn-id: svn://svn.chromium.org/blink/trunk@178574 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sergeyv@chromium.org authored
DevTools: Remove calls of WebInspector.timelineManager and WebInspector.cpuProfilerModel from ScreencastView BUG= Review URL: https://codereview.chromium.org/408853003 git-svn-id: svn://svn.chromium.org/blink/trunk@178572 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mkwst@chromium.org authored
Rather than using `Resource::Type` to make decisions about what CSP directive to apply to a resource request, we should be using WebURLRequest::RequestContext. This patch teaches ContentSecurityPolicy to correctly compare a URL against the right policy directive when given a 'ResourceContext', and pipes the value through 'ResourceFetcher::canRequest' to make sure its available when it needs to be. BUG=390497 Review URL: https://codereview.chromium.org/398313002 git-svn-id: svn://svn.chromium.org/blink/trunk@178571 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jchaffraix@chromium.org authored
The ASSERT checks that no flags cleared by clearPaintInvalidationState() is still set up after calling repaint-after-compositing-update. The ASSERT is skipped for SVG subtree as we have an optimization that skips them. We could reproduce the exact condition but it seems not very useful to do so. The change caught several bugs (yay!): - one in shouldCheckForPaintInvalidationAfterLayout() that made the ASSERT trip on fast/repaint/table-row.html. - one where setShouldDoFullPaintInvalidationAfterLayout didn't mark the containing block chain for invalidation. BUG=385169 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178089 Review URL: https://codereview.chromium.org/389573008 git-svn-id: svn://svn.chromium.org/blink/trunk@178569 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
Marker events are now displayed on the flame chart's timeline bar. BUG=361045 Review URL: https://codereview.chromium.org/402113002 git-svn-id: svn://svn.chromium.org/blink/trunk@178568 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sergeyv@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/397823003 git-svn-id: svn://svn.chromium.org/blink/trunk@178567 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jinho.bang@samsung.com authored
The WebKitPoint interface implemented as DOMPoint in C++ sides. Its name can conflict with a new implementation of DOMPoint. So, we should rename DOMPoint to WebKitPoint in C++ sides. We will have to remove it after a new implementation is shipped. BUG=388780 Review URL: https://codereview.chromium.org/404473004 git-svn-id: svn://svn.chromium.org/blink/trunk@178566 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
malch@chromium.org authored
Review URL: https://codereview.chromium.org/400643002 Review URL: https://codereview.chromium.org/400643002 git-svn-id: svn://svn.chromium.org/blink/trunk@178565 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
johnme@chromium.org authored
Because of https://codereview.chromium.org/401883007, webkit_tests was failing with the stacktrace[1] below. This patch attempts to fix that by adding in the extra (unused) argument to android.py (which extends driver.py), mirroring the change to driver.py [1]: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/16591 The same problem[2] happened when the patch first landed[3], until it was reverted[4]. [2]: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/16610 [3]: https://codereview.chromium.org/378113003 [4]: https://codereview.chromium.org/398543005 worker/1: TypeError('start() takes exactly 3 arguments (4 given)') raised: File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py", line 254, in run worker.handle(message.name, message.src, *message.args) File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 245, in handle device_failed = self._run_test(test_input, test_list_name) File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 288, in _run_test self._name, self._driver, test_input, stop_when_done) File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 48, in run_single_test return runner.run() File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 126, in run return self._run_compare_test() File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 139, in _run_compare_test driver_output = self._driver.run_test(self._driver_input(), self._stop_when_done) File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 154, in run_test self.start(driver_input.should_run_pixel_test, driver_input.args, stdin_deadline) TBR=abarth@chromium.org,dpranke@chromium.org,thestig@chromium.org,ivandavid@chromium.org NOTRY=true NOTREECHECKS=true BUG=388517 Review URL: https://codereview.chromium.org/401243005 git-svn-id: svn://svn.chromium.org/blink/trunk@178563 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mikhail.pozdnyakov@intel.com authored
Revert of Remove user-defined move constructor and assignment operator from WTF::String (https://codereview.chromium.org/367343003/) Reason for revert: This can be applied only when user-defined dtor is removed. Original issue's description: > Remove user-defined move constructor and assignment operator from WTF::String > > WTF::String can rely on implicit move constructor and assignment > operator as WTF::RefPtr class has them defined now (r177066). > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178541 TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/402163002 git-svn-id: svn://svn.chromium.org/blink/trunk@178561 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ppi@chromium.org authored
Performance::now() is defined[1] as number of milliseconds since navigationStart. It works correctly for renderer-initiated navigations, but for browser-initiated ones we override the navigationStart with the recording taken on the browser side and this is not represented in Performace::now(). Among other reasons to be sad about this, this bug makes Chromium's pagecyclers not represent the renderer initialization times in their plt measurements. This patch fixes this by adjusting the fields that are supposed to correspond to navigationStart when we change navigationStart from the embedder. [1] http://www.w3.org/TR/hr-time/#dom-performance-now BUG=376004 Review URL: https://codereview.chromium.org/379873002 git-svn-id: svn://svn.chromium.org/blink/trunk@178558 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
fmalita@chromium.org authored
Minor cleanup: Font::codePath() already selects ComplexPath whenever typesettingFeatures are present (our SimplePath doesn't support kerning and ligatures), so there's no need to duplicate that test in width(). R=schenney@chromium.org,jbroman@chromium.org,eae@chromium.org Review URL: https://codereview.chromium.org/401123005 git-svn-id: svn://svn.chromium.org/blink/trunk@178557 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
philipj@opera.com authored
http://whatwg.org/html#dom-iframe-allowfullscreen BUG=383813 Review URL: https://codereview.chromium.org/398843002 git-svn-id: svn://svn.chromium.org/blink/trunk@178555 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
verwaest@chromium.org authored
Otherwise http/tests/security/xss-DENIED-method-with-iframe-proto.html double-faults while trying to read those global variables that aren't declared. BUG= Review URL: https://codereview.chromium.org/405893003 git-svn-id: svn://svn.chromium.org/blink/trunk@178553 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
bw80.lee@samsung.com authored
Remove forward declaration from HTMLStyleElement.h - StyleSheet Remove header inclusions from HTMLStyleElement.cpp - ContextFeatures.h, StyleEngine.h, StyleSheetContents.h NOTRY=true Review URL: https://codereview.chromium.org/405563002 git-svn-id: svn://svn.chromium.org/blink/trunk@178552 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
apavlov@chromium.org authored
Style sheet ID is required for the live location construction, and it is always known at the point where CSSLocation instances are constructed. R=vsevik Review URL: https://codereview.chromium.org/404763002 git-svn-id: svn://svn.chromium.org/blink/trunk@178550 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
timloh@chromium.org authored
Review URL: https://codereview.chromium.org/405093002 git-svn-id: svn://svn.chromium.org/blink/trunk@178546 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vsevik@chromium.org authored
Patch by Mathias Bynens <mathiasb@opera.com>;. BUG=391289 TBR=eustas Review URL: https://codereview.chromium.org/404053003 git-svn-id: svn://svn.chromium.org/blink/trunk@178545 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
loislo@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/391413003 git-svn-id: svn://svn.chromium.org/blink/trunk@178543 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mikhail.pozdnyakov@intel.com authored
WTF::String can rely on implicit move constructor and assignment operator as WTF::RefPtr class has them defined now (r177066). Review URL: https://codereview.chromium.org/367343003 git-svn-id: svn://svn.chromium.org/blink/trunk@178541 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ch.dumez@samsung.com authored
This CL adds new hasTagName() functions that have the efficiency of hasLocalName(), but are safe. We can always use hasTagName(), and we'll get a compile time error if we try to use an SVG tag name with an HTML element. This makes the code safer and no longer requires good understanding of hasTagName() vs hasLocalName() to write efficient code. This CL drops support for hasLocalName(QualifiedName) as calling hasTagName() is now as efficient. This is based on WebKit r165699 by darin@apple.com: http://trac.webkit.org/changeset/165699 R=esprehn@chromium.org, adamk@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/406843002 git-svn-id: svn://svn.chromium.org/blink/trunk@178540 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
-Add back the dividers between failure cards. The wall of text and buttons was overwhelming. -Fix the heights of things so that the page contents isn't all overflowing out of height:0 containers. -Remove the useless divider in ct-builder-grid. -Make the buttons look like esprehn's codereview tool. -Add a new sheriff-friendly favicon. -Have the results panel consist of two overflow:auto regions. One for the menu and one for the results. -Get rid of tabs on top. Instead have a header that converts to a "go back" button when you are in the results page. -Have ct-tree-status be collapsed to 0 height when it's empty. To make this work, have the default status be the empty string so that the status attribute isn't removed when the value is open. -Fix ellipsizing CSS in ct-tree-status NOTRY=true R=abarth@chromium.org Review URL: https://codereview.chromium.org/400353006 git-svn-id: svn://svn.chromium.org/blink/trunk@178539 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
Also, fix the styling of FAIL failure types now that gtests use that instead of having FAIL masquerade as TEXT. BUG=395496 R=pdr@chromium.org Review URL: https://codereview.chromium.org/409523002 git-svn-id: svn://svn.chromium.org/blink/trunk@178538 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
This is so you can see the non-ellipsized tree status and also to have a link to the page for opening the tree. NOTRY=true Review URL: https://codereview.chromium.org/398653005 git-svn-id: svn://svn.chromium.org/blink/trunk@178537 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
This broke when I changed the results comparison to use polymer components. This isn't 100% the same as the old pixelzoomer code. I took this as an opportunity to simplify it. Also, change the 4-space indent to 2-space indent and replace endOfMicroTask calls with requestAnimationFrame to match the rest of the codebase. NOTRY=true Review URL: https://codereview.chromium.org/403983002 git-svn-id: svn://svn.chromium.org/blink/trunk@178536 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
NOTRY=true Review URL: https://codereview.chromium.org/407903002 git-svn-id: svn://svn.chromium.org/blink/trunk@178535 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
shans@chromium.org authored
The current distribution of files doesn't make sense. I have an idea for a better split that I'd like to try, but that's speculative, so first we should reset to a good state. Review URL: https://codereview.chromium.org/408443004 git-svn-id: svn://svn.chromium.org/blink/trunk@178534 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
chrishtr@chromium.org authored
BUG=391662 Review URL: https://codereview.chromium.org/408543002 git-svn-id: svn://svn.chromium.org/blink/trunk@178532 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
timloh@chromium.org authored
As per recent spec changes, the start time should no longer factor in to AnimationPlayer sort order. I've left in the SortInfo class instead of simply holding on to an unsigned sequence number since we may in the future add a mechanism for changing sort order, although this is easy to remove later if won't be adding such functionality. Review URL: https://codereview.chromium.org/399033002 git-svn-id: svn://svn.chromium.org/blink/trunk@178531 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 20 Jul, 2014 7 commits
-
-
ojan@chromium.org authored
-Make NetworkSimulator error when runTest calls are nested. -Harden NetworkSimulator against exceptions. -Fix incorrect nested runTest call in treestatus_unittests.js. -Fix network requests in ct-results-by-builder-tests.html. This exposes that some of the tests were not overriding net and thus the tests now do a ton of network requests. This will go away when https://codereview.chromium.org/402603007 lands, so it doesn't seem worth the effort to fix all the broken cases. NOTRY=true R=abarth@chromium.org Review URL: https://codereview.chromium.org/401163002 git-svn-id: svn://svn.chromium.org/blink/trunk@178529 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
-Replace some methods with sugarjs equivalents (e.g. endsWith and unique). -For methods that are only used in one place, move them to the module they're used in. These and almost all the code left in the scripts directory will all go away with https://codereview.chromium.org/402603007. NOTRY=true Review URL: https://codereview.chromium.org/400423002 git-svn-id: svn://svn.chromium.org/blink/trunk@178528 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
NOTRY=true Review URL: https://codereview.chromium.org/405853002 git-svn-id: svn://svn.chromium.org/blink/trunk@178527 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
The port to polymer is (basically) complete. Sheriff-o-matic is replacing garden-o-matic. Only functional change in this patch is to sort the scripts and imports in ct-sheriff-o-matic.html. The rest of the patch is just deleting unused files. There's more code to delete with unused functions in some of the remaining files, but that can be done in a followup. NOTRY=true Review URL: https://codereview.chromium.org/405843002 git-svn-id: svn://svn.chromium.org/blink/trunk@178526 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
Tidy up after r178426 and remove now-unused includes. R=haraken@chromium.org BUG=394828 Review URL: https://codereview.chromium.org/409433002 git-svn-id: svn://svn.chromium.org/blink/trunk@178525 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
In the spirit of sheriff-o-matic only showing problems that need solving, there's no point in showing tree open status. We might want to reconsider this in the future where we show you the actual status message, but right now the open state is hard-coded to say "Tree is open", which is not information I need to see. Also, cleaned up a couple minor polymer things: -No need to set the attributes attribute if we're using publish. -Initialize all the member variables on ct-tree-status. -Don't use setAttribute. Should basically always set element values by property. NOTRY=true R=abarth@chromium.org Review URL: https://codereview.chromium.org/403723005 git-svn-id: svn://svn.chromium.org/blink/trunk@178524 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
vivek.vg@samsung.com authored
[Blink] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py (Part-2) Blink should make use of blink_resources.grd for the inline resources for displaying XML tree view. This removes the dependency upon using xxd.py which embeds the resources as strings. BUG=312586 Review URL: https://codereview.chromium.org/391963002 git-svn-id: svn://svn.chromium.org/blink/trunk@178522 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-