GitLab

Notable changes:
 - didStartProvisionalNavigation: is no op if passed navigation is not the latest
    navigation (this way didStartProvisionalNavigation: does not mess up with
    pending item)
 - didCommitNavigation: does not commit pending entry if if passed navigation
    is not the latest navigation. Instead it changes last committed item to one
    that matches with URL, which may not be correct, but it's just a minor
    temporary inconsistency which does not have any security implications
    (last committed URL is still correct).

BUG=711465

Review-Url: https://codereview.chromium.org/2821173002
Cr-Commit-Position: refs/heads/master@{#465669}

Instead of adding traffic management headers for all update pings, only
include them for pings sent to the webstore.

BUG=647516

Review-Url: https://codereview.chromium.org/2823923002
Cr-Commit-Position: refs/heads/master@{#465668}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/24e36dadf5b1..121ef2b4a8c6

$ git log 24e36dadf..121ef2b4a --date=short --no-merges --format='%ad %ae %s'
2017-04-19 rnephew [Telemetry] Get rid of old debugging information.

Created with:
  roll-dep src/third_party/catapult
BUG=667470


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I20439992b215d7734dad275d7a9ebe0cb27b3d11
Reviewed-on: https://chromium-review.googlesource.com/481900
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#465667}

Manually convert tests to use new Audit

BUG=704967
TEST=
Oscillator/osc-low-freq.html
Oscillator/osc-negative-freq.html
Oscillator/oscillator-basic.html
Oscillator/oscillator-late-start.html

Review-Url: https://codereview.chromium.org/2804633004
Cr-Commit-Position: refs/heads/master@{#465666}

Currently on a post-crash startup with the --restore-last-session flag specified an automatic session restore occurs, and an infobar offering an additional session restore is created. Clicking "restore" on the infobar results in the session being restored twice.

This CL removes the logic that makes the flag automatically restore the session post-crash. This diminishes the power of the flag somewhat, but allows it to continue working in support of OS-specific "continue where you left of" functionality on Windows and OS X.

BUG=707998

Review-Url: https://codereview.chromium.org/2832503002
Cr-Commit-Position: refs/heads/master@{#465665}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/fd73a60..73fd432

BUG=708730, 712584, 712117, 713127, angleproject:1966

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2820113008
Cr-Commit-Position: refs/heads/master@{#465664}

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This makes the existing DeliveryAgent class self-scheduling using the
ReportingObserver interface: when reports are added to the cache, or
periodically while reports are still queued, it automatically runs the
"send reports" algorithm described in the spec.

BUG=704259

Review-Url: https://codereview.chromium.org/2785293003
Cr-Commit-Position: refs/heads/master@{#465663}

languages_page.js has a lot of platform specific code, but it was not properly
marked, so it was being included in unrelated platforms. This CLs cleans up the
code such that is only included in the platforms that it is actually used.
  - chromeos
  - chromeos or is_win
  - not is_macosx

This is a step towards deflaking/re-enabling the corresponding tests(for example
this makes it clear which platforms need a browser proxy abstraction).

BUG=692356
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2822863002
Cr-Commit-Position: refs/heads/master@{#465662}

BUG=635619

Review-Url: https://codereview.chromium.org/2823343003
Cr-Commit-Position: refs/heads/master@{#465661}

We already disable display list caching for this content. This CL
also effectively disables subsequence caching.

Also removed some now-unneeded under-invalidation code in PaintController
(unneeded since https://codereview.chromium.org/2768143002) and improved
a comment.

BUG=709846
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2820233002
Cr-Commit-Position: refs/heads/master@{#465660}

Screenshots:
https://drive.google.com/file/d/0Byo6-Nuda2jgaDNxMVYtWmEtUXc/view?usp=sharing
https://drive.google.com/file/d/0Byo6-Nuda2jgaXJEYmZ3RzdVUlU/view?usp=sharing

BUG=682880

Review-Url: https://codereview.chromium.org/2814963002
Cr-Commit-Position: refs/heads/master@{#465659}

Also adds support for finding the render tree node id, if any, for a given devtools
agent host id.

BUG=546953

Review-Url: https://codereview.chromium.org/2812253002
Cr-Commit-Position: refs/heads/master@{#465658}

BUG=712181

Review-Url: https://codereview.chromium.org/2822983002
Cr-Commit-Position: refs/heads/master@{#465657}

BUG=712753

Review-Url: https://codereview.chromium.org/2827813002
Cr-Commit-Position: refs/heads/master@{#465656}

BUG=671962

Review-Url: https://codereview.chromium.org/2828763002
Cr-Commit-Position: refs/heads/master@{#465655}

https://swiftshader.googlesource.com/SwiftShader.git/+log/30385f0..dc7759c
- Fixes ThinLTO linking.
- Fixes TSAN data race.

BUG=chromium:686980, chromium:710753

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2826133002
Cr-Commit-Position: refs/heads/master@{#465654}

This moves the windows-specific implementation into the window
OSExchangeData::Provider. Since there's no ash that code does
not need to handle both anymore.

On windows+mus we use a OSExchangeDataProviderMus in the UI
process instead, which will do the right thing (the same thing
that drag_utils used to do instead of calling to the
OSExchangeData::Provider).

Changes the return type of GetDrawImage{Offset} to be more
friendly to implementations that do not return a ref to a
member variable.

R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2792183002
Cr-Commit-Position: refs/heads/master@{#465653}

R=jochen@chromium.org, zpeng@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2794723003
Cr-Commit-Position: refs/heads/master@{#465652}

Move the definitions of the default Flush and StartPlaying* behaviors
for audio/video renderers to a common InitializeAndExpect function,
instead of repeatedly definining those behaviors in individual tests.

Review-Url: https://codereview.chromium.org/2826613002
Cr-Commit-Position: refs/heads/master@{#465651}

In the first implementation, we passed extra headers inside the body, a CR comment identified that it would be better to pass them separately, this change separates them out into a different input parameter.

BUG=706628

Review-Url: https://codereview.chromium.org/2827503002
Cr-Commit-Position: refs/heads/master@{#465650}

The existing bindings still referenced WebIDL array types that were removed
from the spec in 2015, and converting JS types to IDL sequences with an
algorithm that expected either a JS array (in which case it just iterated
over each element) or an object that adhered to an outdated protocol where a
"length" property was expected.

The current WebIDL sequence conversion steps are simpler and described in
https://heycam.github.io/webidl/#es-sequence. In short, JS objects are
converted to sequences via @@iterator and the regular iteration protocol of
calling next() and checking the returned object.

This works with arrays as well as any object that implements a valid
Symbol.iterator property. It opens the way for custom iterators, the lack of
which was causing some layout tests to fail. In other words, any iterable JS
object can now be converted into a sequence<>.

The downside is that the Blink-V8 communication required for calling
@@iterator, invoking next() and checking objects on every iteration step is
costlier than what we had before, so the "fast case" has been preserved for
JS arrays (even though it is not 100% clear if this is a valid shortcut to
take, it at least does not introduce any regression compared to the previous
code).

This is part 1: several functions in V8Binding.h that implement the old
conversion algorithm (e.g. ToMemberNativeArray(), ToImplArray(),
ToV8Sequence() and ToImplSequence()) have not been removed yet, and their
callers in the code base have not yet been changed. This will come at a
later point in the future.

BUG=690428
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2826673004
Cr-Commit-Position: refs/heads/master@{#465649}

On full width mode, the |requested_bounds| parameter passed to
SetChildBounds can have different offsets from the |new_bounds|
set to the keyboard container window, because only the height of the window
matters in full width mode. Therefore the value passed to
NotifyKeyboardBoundsChanging should be |new_bounds| instead of
|requested_bounds|. Otherwise wrong insets values are set to RWHVAs managing
overlapping aura windows and wrong viewports are calculated for those windows.

BUG=709360
TEST=manually tested the bug is fixed.

Review-Url: https://codereview.chromium.org/2830513002
Cr-Commit-Position: refs/heads/master@{#465648}

BUG=701945
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2819253002
Cr-Commit-Position: refs/heads/master@{#465647}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4f7d9852..e6777487

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2829663002
Cr-Commit-Position: refs/heads/master@{#465646}

BUG=622743

Review-Url: https://codereview.chromium.org/2810403003
Cr-Commit-Position: refs/heads/master@{#465645}

Somehow sometimes browser shutdown crashes on shutting down
the DB thread for these tests on mac.

BUG=712872

Review-Url: https://codereview.chromium.org/2820343003
Cr-Commit-Position: refs/heads/master@{#465644}

Only one target (somewhat questionably) still uses this, so just set
the include directory in that target directly.

BUG=401588
TBR=brettw

Review-Url: https://codereview.chromium.org/2826113002
Cr-Commit-Position: refs/heads/master@{#465643}

ResourcePrefetchPredictor tries to prefetch resources from a precache manifest
if there is no available prediction based on local history.
This CL also adds the check for the manifest age before save it to the database.

BUG=699115

Review-Url: https://codereview.chromium.org/2825693002
Cr-Commit-Position: refs/heads/master@{#465642}

It could happen that cryptohome service is not yet available
during login in ExistingUserController, especially for auto-launched
public sessions or ARC Kiosk. In that case mounting will fail and session
will exit.
It's safer to use CryptohomeClient::WaitForServiceToBeAvailable to ensure.

BUG=702045

Review-Url: https://codereview.chromium.org/2817933003
Cr-Commit-Position: refs/heads/master@{#465641}

We used to always create opaque DRM framebuffers.
After crrev.com/2790553002 we started allowing non-opaque fb.

GbmSurface, that was used in some tests, would allocate a BGRA
buffer and use it as primary plane. On some devices formats
with alpha are not supported on primary plane.

This CL makes sure that GbmSurface allocates RGBX buffers.

BUG=707108
TEST=video_decode_accelerator_unittest now passes.

Review-Url: https://codereview.chromium.org/2825933002
Cr-Commit-Position: refs/heads/master@{#465640}

Settings fingerprint list tests do not wait for the method to be called before procedding if the method has been called previously. Fix this by resetting the promise resolver each time the method is called, if it is called again later in the test.

TEST=browser_tests --gtest_filter="CrSettingsFingerprintListTest.*"
BUG=712880

Review-Url: https://codereview.chromium.org/2821133005
Cr-Commit-Position: refs/heads/master@{#465639}

The flake seems to be because of a race between the order of running main and impl
thread. Resources are always reclaimed after impl threads posts
DidCommitAndDrawFrame to the main thread so whether commit_count_ == 4 or 5
depends on whether we switch to main thread or keep running impl thread and
reclaim resources which triggers posting a task to the main thread to release the
mailbox. Even though the task for DidCommitAndDrawFrame is posted first, the task
for releasing mailbox is posted using a blocking task runner so it is run first.
In order to solve this issue, we decided to use
DidReceiveCompositorFrameAck instead of DidCommitAndDrawFrame because
all the resources are released before DidReceiveCompositorFrameAck is
called so the race between releasing resources and starting next commit
doesn't happen. In single-thread mode we used to call
DidReceiveCompositorFrameAck directly instead of PostTasking which
caused different behaviour from multi-thread mode. We decided to also
use PostTask for DidReceiveCompositorFrameAck in single thread mode and
use weak pointers to discard the ack if CompositorFrameSink is released
before ack is processed.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
BUG=702868

Review-Url: https://codereview.chromium.org/2757373002
Cr-Commit-Position: refs/heads/master@{#465638}

BUG=702356

Review-Url: https://codereview.chromium.org/2832563002
Cr-Commit-Position: refs/heads/master@{#465637}

BUG=713138

Review-Url: https://codereview.chromium.org/2826713004
Cr-Commit-Position: refs/heads/master@{#465636}

Added INSETS_BUBBLE_TITLE metric to distinguish from INSETS_DIALOG_TITLE

BUG=711012
BUG=705907

Review-Url: https://codereview.chromium.org/2819633002
Cr-Commit-Position: refs/heads/master@{#465635}

For consistency, remove trailing dots from those captions that have
them.

BUG=none

Review-Url: https://codereview.chromium.org/2830443007
Cr-Commit-Position: refs/heads/master@{#465634}

Review-Url: https://codereview.chromium.org/2830563002
Cr-Commit-Position: refs/heads/master@{#465633}

This is a mechanical change.

This refactoring is needed for future work and it resolves an
issue with the UpdateClientTest::SendUninstallPing, where the test
is missing the RunThreads() call at the end.

This change makes the UpdateClient API consistent, since all
non-blocking APIs now take a callback parameter.

Review-Url: https://codereview.chromium.org/2831473002
Cr-Commit-Position: refs/heads/master@{#465632}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0bcfc3331d11..24e36dadf5b1

$ git log 0bcfc3331..24e36dadf --date=short --no-merges --format='%ad %ae %s'
2017-04-19 stani Fix error when running map_traces

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I6f83224ce6fc1728c45143420d6468b1b1e2aa1d
Reviewed-on: https://chromium-review.googlesource.com/481114
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#465631}

Test with  --force-tablet-mode=touch_view

BUG=712901

Review-Url: https://codereview.chromium.org/2832523002
Cr-Commit-Position: refs/heads/master@{#465630}