GitLab

AccessibilityTreeFormatter::Create has been returning a raw pointer even though
it's a factory function. Like other factory functions, it would be good if it also
returns a smart pointer.

Bug: None.
Change-Id: I35fc4aa6fcf3d0f7adbeacd916e00efaff517f4d
Reviewed-on: https://chromium-review.googlesource.com/c/1273177Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599231}

Using wpt-import in Chromium c12ec9ee.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25975

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: Iacc4a934ed55a03a6fa514f65852e07165f4417c
Reviewed-on: https://chromium-review.googlesource.com/c/1277604
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599230}

https://webrtc.googlesource.com/src.git/+log/c34cf71d6017..62b1345c850d


git log c34cf71d6017..62b1345c850d --date=short --no-merges --format='%ad %ae %s'
2018-10-12 kthelgason@webrtc.org Get rid of thread_darwin file.


Created with:
  gclient setdep -r src/third_party/webrtc@62b1345c850d

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2f00dbafda8810f87003f9f01763accd5d4d46d5
Reviewed-on: https://chromium-review.googlesource.com/c/1278716Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599229}

Before this change, ElementExists was failing if more than one element
matched the selector.

After this change, ElementExists succeeds even if more than one element
matched the selector.

Bug: 806868
Change-Id: Icedb29c5c51a949fc6086211693723aa071689c1
Reviewed-on: https://chromium-review.googlesource.com/c/1275946
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599228}

This patch is attempting to fix an issue that is causing the overflow
menu to appear offscreen on certain HTC devices on Android N by
increasing the margin between the bottom of the menu and the bottom
of the screen. The thought is that the menu is originally positioned
slightly offscreen and Android tries to reposition the menu; on some
devices this is broken and positions the menu so it is mostly
invisible.

Bug: 894555
Change-Id: Idbb0b4b96e20586a4e15a876f485208504ce72c4
Reviewed-on: https://chromium-review.googlesource.com/c/1278289Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599227}

Currently, a web page receives synthetic wheel events for touchpad pinch
so that it may prevent the browser from changing the page scale and instead
implement custom zoom behaviour. On Mac, in addition to the pinch gesture,
a double-tap with two fingers on a touchpad causes a scale change. There is
currently no way for a page to prevent this.

Now, before applying a scale change from a touchpad double-tap, we offer
a synthetic wheel to the page which it may cancel.

Bug: 802369
Change-Id: Idc68c7d0992fa7bd2bdf29bf3357085276821434
Reviewed-on: https://chromium-review.googlesource.com/c/1237234Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599226}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2cecd6e79600..9f8930395748


Created with:
  gclient setdep -r src-internal@9f8930395748

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I40083f597c320371c0bb843de2bf70c57d1f42ae
Reviewed-on: https://chromium-review.googlesource.com/c/1278719Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599225}

With SurfaceRanges, clients will soon no longer need FirstSurfaceActivation
messages in order to update fallbacks.

The ultimate end state of this work is to save an IPC on scroll on Android
when showing/hiding top bar controls. This should allow for a smoother
scroll experience (yay!).

This CL introduces a new parameter to RegisterFrameSinkId that allows
the client to decide whether or not it's interested in FirstSurfaceActivation.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6a085f4ed910ef6997af67f63e47e85a05b41dd6
Bug: 893850
Reviewed-on: https://chromium-review.googlesource.com/c/1277375Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599224}

This CL enables several multi-device flags by default. This resulted in
lots of broken tests, so this CL also fixes those broken tests.

Instant Tethering is enabled via Finch flags; however, Finch does not
immediately enable/disable features. Instead, when a user logs in, a
Finch configuration is downloaded and is applied the next time the user
logs in. Thus, to ensure that these features are available during OOBE,
this CL overrides multi-device feature experiments during the first
run. On subsequent logins, the Finch feature list will be applied.

Bug: 884066
Change-Id: Ie12f3c62e766457456fd8a35e13168e6b35331ec
Reviewed-on: https://chromium-review.googlesource.com/c/1260491
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599223}

exposed only to ServiceWorker context.

Bug: 894448
Change-Id: Iebc55a247b519d573d8cd8c9bdc384b496614fb9
Reviewed-on: https://chromium-review.googlesource.com/c/1276848Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599222}

Before this patch, we unsuccessfully converted the date as a timestamp
in native before transfering it to Java side.

This patch directly pass the different values of the date instead.

Bug: 806868
Change-Id: I99b4aa6903bc36168a68a41d641ed0d0000f4ff2
Reviewed-on: https://chromium-review.googlesource.com/c/1277655
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599221}

Adds a new policy, AllowWakeLocks, that can be used to disable wake
locks entirely.

The existing AllowScreenWakeLocks policy merely demotes screen wake
locks to system wake locks. If AllowWakeLocks is set to false, all wake
locks should be disabled.

Note that AllowScreenWakeLocks will now be ignored when AllowWakeLocks
is set to false.

Bug: 894645
Change-Id: I3d153801dcd9ed1f6fbf7339cdd4e7173552338c
Reviewed-on: https://chromium-review.googlesource.com/c/1278347Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Rahul Chaturvedi <rkc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599220}

Use wtf_size_t when dealing with WTF types.

BUG=879657

Change-Id: I1dd426d03ac459c627299b6a301c64f9e58002c3
Reviewed-on: https://chromium-review.googlesource.com/c/1274448Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599219}

Bug: 893616
Change-Id: I09d5d906c3cb2e075e142a36b3ebe9b6532eb11f
Reviewed-on: https://chromium-review.googlesource.com/c/1271001Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599218}

This replaces the specialized AfterStartupTask paradigm with a BEST_EFFORT
task on the UI thread for the RulesetService, adjusting tests as
necessary.

Bug: 887407
Change-Id: Id93a5b77e1433281b5cdd49a3599463a61b41703
Reviewed-on: https://chromium-review.googlesource.com/c/1255343Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599217}

Network is by far the largest subdirectory of chromeos.
This gives it its own BUILD.gn file.

Also added a ":chromeos_implementation" config.
Better to use a single config than a define each time, less chance for
undetected spelling errors.

Bug: 446937
Change-Id: I2f26cf3f9f15c4b4db364d7d2bc6cf5cc7e57887
Reviewed-on: https://chromium-review.googlesource.com/c/1276568
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599216}

TBR=mmoroz@chromium.org

Change-Id: Ic807cb7245d1093bf78cb9bb1c81e08520c1fd55
Reviewed-on: https://chromium-review.googlesource.com/c/1277911Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599215}

Bug: 840371
Change-Id: Ia606c6a773b202be623fc31d9dcb542a4e483d7f
Reviewed-on: https://chromium-review.googlesource.com/c/1277186
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599214}

Bug: 878390
Change-Id: Ic2b7bbf2221e91a81802be040c1bc41a5230c13c
Reviewed-on: https://chromium-review.googlesource.com/c/1273270Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599213}

DMServer dropped support for iOS recently and also
IOS_BROWSER is removed from registration types.

Change-Id: Iaa8e5619a1f85110d8d76744a711999f09fb0580
Reviewed-on: https://chromium-review.googlesource.com/c/1273070Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599212}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1c128aa9efd9..e5455648879b


git log 1c128aa9efd9..e5455648879b --date=short --no-merges --format='%ad %ae %s'
2018-10-12 greg@lunarg.com Consider atomics that load when analyzing live stores in ADCE (#1956) (#1958)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@e5455648879b

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Id920e27775336e02f65b2bad6b75329008923664
Reviewed-on: https://chromium-review.googlesource.com/c/1278714Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599211}

This CL uses ScopedBlockingCall to mark blocking calls in /components/metrics.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

Bug: 874080
Change-Id: Ifa1cba993d25114f81984771e50d4734ef66a954
Reviewed-on: https://chromium-review.googlesource.com/c/1191325Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599210}

This reverts commit 04cab8f6.

Reason for revert: The data logged here shows we are very likely not creating a bunch of HistoryAddPageArgs that aren't getting written. The highest count created was 3 (the majority are 0), which implies this isn't an issue. See bug for more details.

Original change's description:
> history: adds minimal memory dump information for history
> 
> Before I add more exhaustive information I want to make sure I'm on the right
> track. This adds the count of the number of outstanding requests to add a
> page (url and other information) that haven't been processed yet.
> 
> BUG=807009
> TEST=none
> 
> Change-Id: Ieb18fe74e9e91fe4f99eb1a791b04367c60cfd0d
> Reviewed-on: https://chromium-review.googlesource.com/1234240
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592916}

TBR=sky@chromium.org,erikchen@chromium.org,ssid@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 807009
Change-Id: Ic0c01697bced51123b71f059905d98f9945eaa2f
Reviewed-on: https://chromium-review.googlesource.com/c/1276945Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599209}

This reverts commit 1c6c9d1b.

Reason for revert: Breaks tests when combined with https://chromium-review.googlesource.com/c/chromium/src/+/1260491. Doesn't properly wait for devicesync service to be ready before querying the list of devices.

Original change's description:
> Make Instant Tethering work with legacy hosts before hosts update.
> 
> The phone side flags and enrollment will be slower than the ChromeOS
> rollout. In order to avoid breaking Instant Tethering in the meantime,
> look for cases where:
> 
> 1) There are no host devices reporting BETTER_TOGETHER_HOST support.
> 2) There is at least one host device reporting INSTANT_TETHER_HOST
> support.
> 
> In this scenario, the only possiblity is that this host device has not
> reenrolled yet after receiving the new flags.
> 
> Bug: 893769
> Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d
> Reviewed-on: https://chromium-review.googlesource.com/c/1277272
> Commit-Queue: Jeremy Klein <jlklein@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599058}

TBR=khorimoto@chromium.org,jlklein@chromium.org

Change-Id: Iee7a71e551e875764f38cdf72391378cdacc80bc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893769
Reviewed-on: https://chromium-review.googlesource.com/c/1278541Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599208}

The histogram that counts token state transitions was not correctly
tracking the cases when Chrome fails to load a token for the primary
account. This CL adds this entry to the histogram. This should allow us
to understand to what extent Chrome fails to load tokens from disk.

Bug: NONE
Change-Id: I6237d5090984e0244a6203d60f2c319072b73555
Reviewed-on: https://chromium-review.googlesource.com/c/1278731
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599207}

* The service shouldn't unregister from the topics, when handler
the Handler is unregistering from topic (as stated in the documentation
for for UnregisterHandler).
* Sync shouldn't unregister on browser shutdown

TBR=gab@chromium.org, pavely@chromium.org

Bug: 894752, 801985
Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76
Reviewed-on: https://chromium-review.googlesource.com/c/1277908Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599206}

This CL is adding trace events to look closer on some slow cases
happening in the browser process. Traces will be collected via
slow-reports and an investigation will be continued based on results of
these events.

R=fdoray@chromium.org, ccameron@chromium.org

Bug: 894459
Change-Id: I2e3c37e9a42ceef9ca9aea5ec94a125db247aa77
Reviewed-on: https://chromium-review.googlesource.com/c/1277825
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599205}

In CL 1171374 'lazyload' feature policy was introduced as a new
policy-controlled feature which would modify (restrict) the usage of the
lazyload attribute. The implementation only applied the feature to frame
owner elements. This CL extends the policy's coverage to images as well.

Bug: 869492
Change-Id: I9a2bd309ac366b75308b657d3ea129a7717ad23f
Reviewed-on: https://chromium-review.googlesource.com/c/1251024
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599204}

Nothing prevents CookieMonsterChangeDispatcher::Subscription to
outlive CookieMonsterChangeDispatcher.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifa2cd0c8def9ae1c63a0a3d37bd469bbbc78e5ca
Reviewed-on: https://chromium-review.googlesource.com/c/1242460
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599203}

Bug: NONE
Change-Id: I18d05d59ba0be38d7598396fab2cef8b44647fcf
Reviewed-on: https://chromium-review.googlesource.com/c/1278754Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599202}

Change a CHECK to an logged warning if madvise is attempted when code
ordering has not been performed. This happens on upstream builds
including arm64 builds.

Bug: 894748
Change-Id: Icdb7ae0c94cfad5beec0215c6186e29135c1079a
Reviewed-on: https://chromium-review.googlesource.com/c/1278746Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599201}

This patch means removing the preference and functions
that reference it.
Because preference is set but never read, that is indeed obsolete.

Bug: 889908
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I22a80bed2387b08480dae9c930bb1d329dd8c45d
Reviewed-on: https://chromium-review.googlesource.com/c/1264343
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599200}

https://webrtc.googlesource.com/src.git/+log/55d1af14751a..c34cf71d6017


git log 55d1af14751a..c34cf71d6017 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 oprypin@webrtc.org Revert "Remove old video_bitrate_allocator.h"
2018-10-12 mbonadei@webrtc.org Move SdpType from/to string definition close to declaration.


Created with:
  gclient setdep -r src/third_party/webrtc@c34cf71d6017

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7014c484f5486bdc51a05adc2b602509c6c86207
Reviewed-on: https://chromium-review.googlesource.com/c/1278713Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599199}

Bug: 872904
Change-Id: I44e020b7d7d121650f4c292b71b4d2dbc45fa9f3
Reviewed-on: https://chromium-review.googlesource.com/c/1277765Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599198}

We used to have only one flag, --auto-update, which controls both
uploading and landing the import CL. This makes testing new setup of the
bot (i.e. LUCI in this case) hard.

This change adds one more flag, --auto-upload, to exercise more steps
(namely uploading and rebaselining), which will be used on the
experimental LUCI builder.

Bug: 790503
Change-Id: I4ce07fc9ddf15a34c9cb25ba4723d250cad26977
Reviewed-on: https://chromium-review.googlesource.com/c/1277587
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599197}

This was accidentaly removed as part of FrameLoadRequest cleanup.

Bug: none
Change-Id: I58bf324729d397a2f0340831fd116ab749f7a213
Reviewed-on: https://chromium-review.googlesource.com/c/1278290
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599196}

ProfileSyncService::platform_sync_allowed_provider_ was a callback that
returned whether Android's "Master Sync" toggle is enabled, and so Sync
shouldn't start up. However, PSS didn't know when the value changed, so
the callback was kinda useless, and PSS could easily get into an
inconsistent state (where there is a disable reason, but Sync is still
running). Things were working out in practice only because the Android
UI code also called RequestStart/Stop as necessary.
So, since PSS needs change notifications anyway, let's make that
explicit: This CL replaces the callback by a bool, which can be set
explicitly.

Bug: 867901
Change-Id: I5b7e9f4657d1f565d9643984eb52ec1df26b5c90
Reviewed-on: https://chromium-review.googlesource.com/c/1269870Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599195}

Change-Id: I71ed01f39d1c81c62828d8e4900091e7941e7ab1
Reviewed-on: https://chromium-review.googlesource.com/c/1278399Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599194}

Know issues:
 * Skia only draws Y plane.
 * makeYUVAPromiseTexture() will release context, even if it failed.
 * Skia doesn't accept GL_RGBA8 format for a yuva plane

Bug: 824382
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic8da2b3de574ef2a0d527c79f34d383a676a3bc0
Reviewed-on: https://chromium-review.googlesource.com/c/1262421Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599193}

This CL fixes some edge condition interactions when being loaded as
a ReadableStream.  In particular, it:

1. Properly distinguishes between the end of the DataPipe and a closed
   DataPipe with bytes left to be read.  A ReadableStream that is not
   actively draining the pipe could get closed too early.
2. Responses must support explicit completion in order to handle error
   conditions properly.  This CL makes DataPipeBytesConsumer wait
   for an explicit signal before closing.
3. Service worker navigation preload is updated to provide the explicit
   completion signals.

Bug: 894815
Change-Id: I8cff3de94aa2dcbc8deb4a9601a95c13b8ab94d9
Reviewed-on: https://chromium-review.googlesource.com/c/1272715
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599192}