- 15 Dec, 2016 40 commits
-
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ab7345371ad0..f87ce97ea1fa $ git log ab7345371..f87ce97ea --date=short --no-merges --format='%ad %ae %s' 2016-12-14 lpy [Trace Viewer] Show runtime statistics in background parsing. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2577993002 Cr-Commit-Position: refs/heads/master@{#438750}
-
gab authored
Fix coming up @ https://codereview.chromium.org/2491613004/ but suppressing race in mean time to make TSAN bot green again (issue 672860). BUG=587199 TEST=TimerTest.OneShotTimer_CustomTaskRunner no longer reported as failure by linux_chromium_tsan_rel_ng. NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.chromium.org/2576503002 Cr-Commit-Position: refs/heads/master@{#438749}
-
falken authored
The callers can have a registration id even before storage is initialized, for example if registration ids are stored in preferences. BUG=672716 Review-Url: https://codereview.chromium.org/2569353003 Cr-Commit-Position: refs/heads/master@{#438748}
-
lushnikov authored
This abstraction is not needed any more. All the clients are migrated over to the Common.FormatterWorkerPool.parseCSS method. BUG=none R=dgozman Review-Url: https://codereview.chromium.org/2572053002 Cr-Commit-Position: refs/heads/master@{#438747}
-
sashab authored
Made -webkit-box-direction property independent. Also updated independent-inheritance-fast-path.html to include webkitBoxDirection. Also updated make_computed_style_base.py to use 'name_for_methods' instead of 'upper_camel_name' so that Webkit is removed from the front of the name when generating method names. Tested using independent-inheritance-fast-path.html. BUG=628043 Review-Url: https://codereview.chromium.org/2574063002 Cr-Commit-Position: refs/heads/master@{#438746}
-
jialiul authored
class: (1) Schedule clean up stale navigation footprint (2) Backtrace navigation events up to 2 user gesture for a given download, and add this info into ClientDownloadRequest proto. (3) Add UMA metrices to track attribution results BUG=639467 Review-Url: https://codereview.chromium.org/2538483002 Cr-Commit-Position: refs/heads/master@{#438745} -
oka authored
This CL allows user to open files which are browsable on Chrome on Quick View. Browsable files include pdf and text. Screencast: https://bugs.chromium.org/p/chromium/issues/detail?id=640696#c11 BUG=642713,640696 TEST=manually tested the following: - For pdf and text, preview with 24px of vertical margin appears. - For image, video and audio, preview with 15% of vertical margin appears as before. - For .docx, 'no preview available' is shown as expected, though the file type is 'document' which is the same as pdf. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2540863004 Cr-Commit-Position: refs/heads/master@{#438744}
-
bashi authored
We are going to merge MemoryCoordinator into MemoryCoordinatorImpl as a part of preparations for adding an pure interface of MemoryCoordinator in base/. Since they are not simple classes, just merging them will create a big class which has multiple responsibilities. Before merging them, factor out state updating code from MemoryCoordinatorImpl. BUG=673216 Review-Url: https://codereview.chromium.org/2568393002 Cr-Commit-Position: refs/heads/master@{#438743}
-
sky authored
This is needed for chrome. BUG=663525 TEST=none R=erg@chromium.org Review-Url: https://codereview.chromium.org/2581503002 Cr-Commit-Position: refs/heads/master@{#438742}
-
michaeln authored
Adds a QuotaSettings datastructure and changes how the total poolsize for temporary storage is determined. This CL adds a public content API that the embedder must use to inform the quota system of the desired QuotaSettings. The old computation: [available_space + current_temp_usage] / 3 The new computation: [total_volume_size - os_overhead] / 3 The new computation is simplified to be a function of the size of the volume, and no longer takes as input how much chrome is currently using. This also reduces the time take to initialize the quota system. To defend against filling the drive, as available space gets "too low", the calculated per-host quota is clamped to the hosts current usage. This prevents the writing of new data because quota clients query GetUsageAndQuota() prior to performing a write. Also the eviction logic deletes existing data to keep |must_remain_available| disk space free. BUG=520318 Review-Url: https://codereview.chromium.org/1782053004 Cr-Commit-Position: refs/heads/master@{#438741}
-
alancutter authored
This change alters transition animation handling of length properties that happen to be stored as non-length numeric fields in ComputedStyle. Instead of treating them as AnimatableDoubles this patch treats them as AnimatableLengths which can deal with changes in page zoom correctly. Transitions may still start due to floating point & integer truncation approximations but the visual effects of the transitions will be negligible. BUG=267316 Review-Url: https://codereview.chromium.org/2562643002 Cr-Commit-Position: refs/heads/master@{#438740}
-
toyoshim authored
To check if browser side navigation is enabled, use content::IsBrowserSideNavigationEnabled() instead of checking command line directly. BUG=671545 Review-Url: https://codereview.chromium.org/2574973002 Cr-Commit-Position: refs/heads/master@{#438739}
-
michaelpg authored
Merges settings-basic-page and settings-advanced-page by into one element. This simplifies a lot of behavior (we no longer have two MainPageBehavior instances trying to scroll #mainContainter at the same time) which fixes some bugs for free. Functionality in settings-main that was specific to the settings pages has been moved into settings-basic page, simplifying settings-main. Unfortunately, settings-main still shares an annoying amount with setting-basic-page, namely inSearchMode and advancedToggleExpanded. The main bug this fixes is issue 662004: tapping a Basic page section from an Advanced page sub-page (or vice versa) would fail to scroll to the new section. Minor bugs that this fixes: * after opening a subpage, tapping a section in the nav menu closed the subpage but only jumped to the new section after an awkward delay * after loading a subpage URL, tapping the back icon button caused the page to jump to the top, then back down * navigating from a Basic subpage to an Advanced subpage, or vice versa, would have hidden one of the main pages while transitioning Note: settings-basic-page should be renamed now that "basic" is meaningless, but unfortunately every conceivable alternative name is already taken, except for settings-settings-page which is horrible for reasons too numerous to mention. BUG=662004 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2518233004 Cr-Commit-Position: refs/heads/master@{#438738} -
toyoshim authored
Now, there are two callses that use WebFrameLoadType::Reload to call WebFrame::reloadWithOverrideURL(). These callers can be modified to use WebFrameLoadType::ReloadMainResoure insteads. Also, this change removes default argument from WebFrame::reload() and WebFrame::reloadWithOverrideURL() so to encourage using a right reload type for each caller respectively. Also this will be better in terms of coding style since default argument for virtual method is not recommended in chromium. BUG=670196 Review-Url: https://codereview.chromium.org/2567983008 Cr-Commit-Position: refs/heads/master@{#438737}
-
dgozman authored
It is not used for anything meaningful. BUG=none Review-Url: https://codereview.chromium.org/2581453002 Cr-Commit-Position: refs/heads/master@{#438736}
-
alancutter authored
Refactor helper functions for https://codereview.chromium.org/2562643002. BUG=267316 Review-Url: https://codereview.chromium.org/2569913002 Cr-Commit-Position: refs/heads/master@{#438735}
-
caseq authored
This introduced a notion of tracing session to chrome.devtools.timeline API and lets API client to supply a URL of the trace data to append to the flame chart. This also includes: - exposing a check-box for each extension in Timeline toolbar to selectively enable extensions; - extracting Timeline.LoaderClient from TimelineLifecycleDelegate so that loader can be re-used outside of the panel; - create a temp file in TimelineBackingStorage lazily, only when data are actually written there; - changing TimelineController.startRecording() to accept options as a struct rather than a bunch of boolean parameters; - support for dumping a FlameChartDataProvider in tests; - a new type of events in TimelineFlameChart to support extensions; BUG=620066 Review-Url: https://codereview.chromium.org/2563383003 Cr-Commit-Position: refs/heads/master@{#438734} -
dgozman authored
BUG=664683 TBR=pfeldman Review-Url: https://codereview.chromium.org/2574843003 Cr-Commit-Position: refs/heads/master@{#438733}
-
ksakamoto authored
BUG=674396,653722 TBR=schenney@chromium.org NOTRY=TRUE Review-Url: https://codereview.chromium.org/2577893003 Cr-Commit-Position: refs/heads/master@{#438732}
-
servolk authored
BUG=672976 Review-Url: https://codereview.chromium.org/2568303002 Cr-Commit-Position: refs/heads/master@{#438731}
-
estade authored
BUG=672199 Review-Url: https://codereview.chromium.org/2558173006 Cr-Commit-Position: refs/heads/master@{#438730}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#438729} -
estade authored
They were out of date, and in some cases redundant. Remove the redundant uses completely and replace the others with references to the vector versions. BUG=673995 Review-Url: https://codereview.chromium.org/2576643002 Cr-Commit-Position: refs/heads/master@{#438728}
-
szager authored
When RLS is enabled, the compositor's root content layer is pointless, and it doesn't get its setMasksToBounds flag set based on whether it contains the root scroller. Instead, we should ensure that the LayoutView's scrolling layer gets the setMasksToBounds flag set correctly. This patch adds some spacers to make the LayoutView overflow, to ensure that it has a scrolling layer we can test. BUG=490942 R=bokan@chromium.org,skobes@chromium.org Review-Url: https://codereview.chromium.org/2576943002 Cr-Commit-Position: refs/heads/master@{#438727}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2644e367..5ba6e0d1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2581563002 Cr-Commit-Position: refs/heads/master@{#438726}
-
mcasas authored
This CL : - s/CanvasImageSource/ImageBitmapSource/ in the idl following https://wicg.github.io/shape-detection-api/#face-detection-api and https://wicg.github.io/shape-detection-api/#barcode-detection-api CanvasImageSource [1] is almost a subset of ImageBitmapSource [2] (the former can be a CSSImageValue, but we don't care much about it for this Spec), so this CL is small in that sense. - Adds support for ImageData as a source for detect()ion, and adds a LayoutTest for it. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl?q=file:%5C.idl+CanvasImagesource&sq=package:chromium&l=33&dr=C [2] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl?type=cs&q=file:%5C.idl+Imagebitmapsource&sq=package:chromium&l=38 BUG=670975 Review-Url: https://codereview.chromium.org/2550413005 Cr-Commit-Position: refs/heads/master@{#438725}
-
sanjoy.pal authored
BUG=669585 Review-Url: https://codereview.chromium.org/2545693002 Cr-Commit-Position: refs/heads/master@{#438724}
-
napper authored
Moved -webkit-print-color-adjust property to be generated, so now the getter/setter methods for print-color-adjust are generated. This means that getPrintColorAdjust() has been renamed to printColorAdjust(). Also renamed PrintColorAdjust enum to EPrintColorAdjust for consistency with other generated enums. BUG=628043 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2570463002 Cr-Commit-Position: refs/heads/master@{#438723}
-
tbansal authored
NetworkQualityEstimator::TestEffectiveConnectionTypeObserver is disabled on ios-simulator until it is clear why it is flaky. BUG=641708 Review-Url: https://codereview.chromium.org/2559373005 Cr-Commit-Position: refs/heads/master@{#438722}
-
lgarron authored
BUG=647822 ================================ TEST=Use an iPhone, not an iPad. First, enable the proper flag: -------------------------------- 1. Open the Settings app 2. Scroll to Chrome Beta/Dev/Canary and press 3. Scroll down to Experimental Settings and press 4. Scroll to EXTRA FLAGS (ONE PER LINE) 5. Toggle "Append Extra Flags" to ON 6. Set Flag1 to "--mark-non-secure-as=show-non-secure-passwords-cc-ui" (without the quotes) -------------------------------- Test 3 URLs: 1) Visit https://badssl.com/input/login/ and verify that the omnibox security has a green lock security indicator to the left of the URL. 2) Visit http://http-login.badssl.com/ and verify that the omnibox security has a grey info icon ⓘ security indicator to the left of the URL. 3) Visit http://http.badssl.com/ and verify that the omnibox does *not* have a security indicator to the left of the URL. -------------------------------- 4) Set Flag1 (see above) to "--mark-non-secure-as=neutral" (without the quotes) and check that http://http-login.badssl.com/ does *not* have a security indicator to the left of the URL. ================================ Review-Url: https://codereview.chromium.org/2466143002 Cr-Commit-Position: refs/heads/master@{#438721}
-
kinaba authored
It didn't properly detach from the input method when ARC lost focus and no other text input client took focus until shutdown. BUG=673809 TEST=ArcImeServiceTest.WindowFocusTracking Review-Url: https://codereview.chromium.org/2570623005 Cr-Commit-Position: refs/heads/master@{#438720}
-
rohitrao authored
This CL adds an early return rather than DCHECKing when the plist is missing. BUG=666375 Review-Url: https://codereview.chromium.org/2551423002 Cr-Commit-Position: refs/heads/master@{#438719}
-
yusukes authored
It is slightly weird for ArcServiceManager to handle (only) one of the ArcService instances it has in a special way with inheritance, and this CL fixes that. ArcServiceManager looks more neutral now and no longer has to #include arc_intent_helper_observer.h on the header side. This removes all virtual member functions from ArcServiceManager too. Instead, do the same thing with a pair of member variable and its getter function, which is more consistent with the existing ArcServiceManager code. All the implementation details go to the .cc side. This is a follow-up CL for https://codereview.chromium.org/2487623002/. BUG=672840 TEST=try Review-Url: https://codereview.chromium.org/2538263005 Cr-Commit-Position: refs/heads/master@{#438718}
-
tsergeant authored
This was a feature of all previous WebUI pages (as part of chrome_shared.css), but had been lost with the switch to Material design. All interactive elements still show a hand cursor, but text will show a pointer cursor instead of a text selection cursor. BUG=672764 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2577923002 Cr-Commit-Position: refs/heads/master@{#438717}
-
allada authored
This patch removes some old code that was not used any more. BUG=None R=dgozman,lushnikov Review-Url: https://codereview.chromium.org/2576203002 Cr-Commit-Position: refs/heads/master@{#438716}
-
hubbe authored
Add histograms recording color gamut information about images and screens. BUG=667431 Review-Url: https://codereview.chromium.org/2567983004 Cr-Commit-Position: refs/heads/master@{#438715}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/788644ef37e7..ab7345371ad0 $ git log 788644ef3..ab7345371 --date=short --no-merges --format='%ad %ae %s' 2016-12-14 aiolos Fix TimeDisplayModes and add a test to avoid future breakage. 2016-12-14 benjhayden Fix ChartJsonConverter handling empty list_of_scalar_values. 2016-12-14 benjhayden Rename IterationInfo to TelemetryInfo. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2577873002 Cr-Commit-Position: refs/heads/master@{#438714}
-
carlosk authored
In the development of patch to move mixed-content checks to the browser (https://crrev.com/1905033002) a few minor changes were made that are unrelated to its core purpose. So I created this change to simplify the original one. They are: - Add missing forward declaration. - Updated a comment referring to an IPC that doesn't exist anymore. - Adds newline. BUG=576270 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2576613003 Cr-Commit-Position: refs/heads/master@{#438713}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/56ff9a1c9dfd..c2ba75b50750 $ git log 56ff9a1c9..c2ba75b50 --date=short --no-merges --format='%ad %ae %s' 2016-12-14 bungeman Remove Mac 10.6 - 10.8 work arounds for fonts. 2016-12-14 bungeman Remove strange 'write' overload on SkDynamicMemoryWStream. 2016-12-14 bsalomon Some more batch->op renaming 2016-12-14 msarett Reenable 16-bit png brd decode tests 2016-12-14 bsalomon Bring sk_sp to oval GrDrawOps and rename batch->op 2016-12-14 brianosman Make picture backed images sRGB by default 2016-12-14 robertphillips Demote savePixels to save_pixels Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2580623002 Cr-Commit-Position: refs/heads/master@{#438712}
-
abhishekbh authored
BUG=665983 TEST=try Review-Url: https://codereview.chromium.org/2571143003 Cr-Commit-Position: refs/heads/master@{#438711}
-