- 10 Jan, 2020 40 commits
-
-
Meilin Wang authored
This is a temporary fix. The real fix should be to migrate off Content Service and back to WebView (tracking bug: b/146351046). Misc: fix linter warning. Bug: b/144765770 Test: manually. Change-Id: I2aafbb30878374424597db7159d1777cb4fa1c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992685Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#730057}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1f6ff4c2bb48..0319809c5c5a git log 1f6ff4c2bb48..0319809c5c5a --date=short --first-parent --format='%ad %ae %s' 2020-01-10 dberris@chromium.org Split off upload processing to a different service Created with: gclient setdep -r src/third_party/catapult@0319809c5c5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1035930 Tbr: oysteine@google.com Change-Id: If96c0595eeda8103cab839aacb1ad82cb2dd475b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994675Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730056}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e61ad0df. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I21d06d257d78753395d1682736b1f82479004758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993716Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730055}
-
Andrew Luo authored
Bug: 1019521 Change-Id: Idfc304e1f335a4d03d4cccdc9101584564236c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980997Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#730054}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a4290c4..1dacd66f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8620e75ec411b6c7916d0b9e805874b67e63dca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993761Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730053}
-
Alexandre Courbot authored
The format specifier for a int64_t argument was %ld, which works fine on 64-bit architectures but corresponds to a 32-bit long on 32-bit archs. Fix this by using the PRId64 specifier that will work on all architectures. BUG=None. TEST=Chrome builds for arm-generic. Change-Id: Iee32204df9f52fe2a6dd9ceb05edee22ff5e14f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993068 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#730052}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I0b52e6f3fd5c45ad2058503e0321679daee0e374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993905Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730051}
-
Takashi Toyoshima authored
There was no test for verifying the code to reject CORS-enabled requests that do not have |request_initiator|. This patchset adds an unit test for FileURLLoaderFactory to verify request_initiator requirements for each RequestMode. Change-Id: I27b88075f0bb07d91268c2f25aa2f94b9ec321c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989432 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#730050}
-
Simon Que authored
They were incorrectly set to goma_backend=None. Bug: None Change-Id: If4a4654749ee3074b431825af39836814dab8cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994367Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#730049}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ab81316411df..9b289b2c2973 git log ab81316411df..9b289b2c2973 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d63380b8..aa827d65 (729869:729982) Created with: gclient setdep -r src/third_party/webrtc@9b289b2c2973 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0a1cc94d3addf90ff4f4543c7907e1beefd98996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994674Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730048}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/697b2241a6c7..7a37d3acf532 git log 697b2241a6c7..7a37d3acf532 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 kbr@chromium.org Work around Intel driver bug with CopyTex{Sub}Image2D/DeleteTextures. Created with: gclient setdep -r src/third_party/angle@7a37d3acf532 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ibe751691c0f6480f97ecb98605b80cb8b2391ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730047}
-
Ahmed Fakhry authored
- The backdrop used to show immediately even if the window-needing-it is still animating, making the animation look poor. - There multiple recursive calls to UpdateBackdrop() constantly all the time, many of them are not necessary, and can be handled only by laying out the backdrop if needed. - Even the browser's status bubble used to cause multiple called to UpdateBackdrop() as the user moves their mouse hovering over links, which causes the status bubble to be created, removed, and have visibility changes. - The backdrop window itself causes calls to UpdateBackdrop as it gets shown and hidden. - The backdrops weren't showing in the desks mini_views (a regression caused by me). - WorkspaceLayoutManager and Desk were both updating the backdrops for the same event. This CL fixes the above issues. BUG=1031789 TEST=Manually, all backdrop tests should pass. Change-Id: I5e25705ae50abdf1cf69b63b01f762044587f600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974593 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#730046}
-
Tibor Goldschwendt authored
Bug: 1032327 Change-Id: I55c34b77eaffb7573ce8fb020d102b9286d945e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993624 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#730045}
-
yilkal authored
This is a reland of 73d4b9c4 Original change's description: > Update WebTimeLimit url filter > > This cl does the following: > 1. Adds PrefChangeRegistrar to AppTimeController to enable it > to be notified when user policy has changed. > 2. Enables prefs::kPerAppTimeLimitsWhitelistPolicy policy to be > used in WebtimeLimitEnforcer. > > Bug: 1015661 > Change-Id: Ifd5e0ddc3df9f564ffb018244e652c8b88586865 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946936 > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729598} Bug: 1015661 Change-Id: I641c293db66f1d0eb221a3015d1c14864512b3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993021 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#730044}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/webaudio. Bug: 1001114 Change-Id: Ifb03c0cce7d61621be8c34774ccc49c3b1debe56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986469 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#730043}
-
Demetrios Papadopoulos authored
Also stop subclassing MojoWebUIController from SettingsUI on CrOS, since it is no longer needed. Bug: 990166 Change-Id: I4966e2aac58cba46d0245025037b878f77b07397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992989Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#730042}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a7e42ba7f855..110236f3ce70 git log a7e42ba7f855..110236f3ce70 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 sugoi@google.com Enable filtering depth+stencil formats Created with: gclient setdep -r src/third_party/swiftshader@110236f3ce70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If7e2ffd07dffbbc06011a05ee606a4ca5edfe069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994400Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730041}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ce9e11f02436..1f6ff4c2bb48 git log ce9e11f02436..1f6ff4c2bb48 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 rmhasan@google.com Revert "[Telemetry] Expose ChromeOS board tags" 2020-01-10 rmhasan@google.com Reland "[Typ] Allow typ expectations parser to escape the '*' character" 2020-01-09 bsheedy@chromium.org [Telemetry] Expose ChromeOS board tags Created with: gclient setdep -r src/third_party/catapult@1f6ff4c2bb48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036130,chromium:1038726 Tbr: oysteine@google.com Change-Id: Ic932d1e9adc15925f8f41e9b4e421dcb626770f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994660Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730040}
-
Jimmy Gong authored
- Needed so that the JS layer can call on queryPrintServer. - Updates browsertests to reflect this change. Bug: 1015628 Test: browsertests Change-Id: I3bcb69b6f0e3426231ae14443378eb27bcf490d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950890 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#730039}
-
Tom Anderson authored
On some notification daemons (at least lxqt-notificationd and naughty), the icon is not downsized to a reasonable size. Rather than changing the icon size depending on which notification daemon is running, this change always uses 64x64 icons for a few reasons: * There may be more daemons that have this behavior. * There's no realistic situation to my knowledge where 256x256 is desired. * In most other situations, the daemon will downsize the icon anyway, so it's best to not needlessly waste resources for the common case. R=thestig Bug: b/146459375 Change-Id: Ib841b6cce17be9043f5e81eabb44188da3b51b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994389 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#730038}
-
Jack Lynch authored
https://chromium-review.googlesource.com/c/chromium/src/+/1636716 broke http/tests/devtools/sources/debugger-ui/click-gutter-breakpoint.js by causing a timeout. This CL adds an explicit call to JavaScriptBreakpointsSidebarPane.doUpdate() to ensure that the SourcesTestRunner.waitBreakpointSidebarPane() promise is fulfilled. Bug: 963183 Change-Id: I4cf93f08cec1d54bdb00a2b14a8adf60a2b2ac97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994417Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#730037}
-
Arthur Wang authored
R=bsheedy@chromium.org, harringtond@chromium.org Bug: 1040690 Change-Id: I817257bbb2a552c0ee33a4c89c5d01920da58754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994278 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#730036}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9a83dd729bf5..ab81316411df git log 9a83dd729bf5..ab81316411df --date=short --first-parent --format='%ad %ae %s' 2020-01-09 hta@webrtc.org Housekeeping: Declare DataChannelController immovable 2020-01-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b57c714b..d63380b8 (729764:729869) Created with: gclient setdep -r src/third_party/webrtc@ab81316411df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I998d04cfff0df5150f25be7ad57f6e2288eae22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994409Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730035}
-
Daniel Murphy authored
This patch continues to move methods from IndexedDBContext to the mojo interface IndexedDBControl. In particular, this is moving the method DeleteForOrigin. This patch also removes the now unnecessary leveldb workaround for empty directories. See tracking doc here: https://docs.google.com/document/d/18suNOOzuEJbqgRJF0MB2VqdTyYqS4cvI2PGaCpyPXSw/edit?ts=5e138c46#heading=h.23paiqht163 Bug: 1015214 Change-Id: I36bccba416c7a5b182f1f85e01a02cc3e1e40623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988811Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#730034}
-
Dan Beam authored
Previously there were technical issues regarding @typedef in a non-global (contextual?) scope. These were solved so we can return to a saner model of exporting enums and @typedefs the same way as everything else. This is in hopes of removing cr.exportPath from --chrome_pass at least. (We may forever benefit from the runtime effects.) R=dpapad@chromium.org BUG=986481 Change-Id: Ic07c7c87e3b6f6279167cee182d3c2fa0a10105e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992697 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#730033}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bd2510d9..7a4290c4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibe7a8937caae58df49acc513fbeaba6a89ae62c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993717Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730032}
-
Maggie Chen authored
Bug: 775983 Change-Id: I552424ab846568863dfc76f6f0e12e2b4e92d474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993846Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#730031}
-
Hazem Ashmawy authored
This gradle file was introduced for an effort to compile boundry_interfaces independently from androidx.webkit source code in AndroidX repo. However, we are not proceeding with this approach so this file isn't needed anymore. Bug: b/140178227 Change-Id: Ie579cd7fac0498b27b6653ad56647756fea17476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994281 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#730030}
-
Fabrice de Gans-Riberi authored
TBR=fdegans@chromium.org Bug: 838348 Change-Id: I1ee84587b252a66e63758bdfcea5e0d084cdd665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994562Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#730029}
-
Robert Sesek authored
System colors are read directly out of a read-only shared memory array, so this cache does not contribute any performance benefit. Bug: 641509 Change-Id: I1be0f02dd7ac15d0901ecfc4778ae35baf988a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992169 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#730028}
-
John Williams authored
The CL include a number of related cleanups: - Changed CastActivityRecord and MirroringActivityRecord to eliminate dependencies on MediaSinkServiceBase and CastActivityManagerBase. - Moved some logic from CastActivityManager::FindActivityForAutoJoin into CastActivityRecord::HasJoinableClient. - Moved CastActivityManager::CanJoinSession into CastActivityRecord. - Removed ActivityRecord::connected_clients() and moved the related member variable, connected_clients_, into CastActivityRecord. This variable is now referred to directly in unit tests, and no longer referred to by CastActivityManager. - Renamed SendStopSessionMessageToReceiver to SendStopSessionMessageToClients, and changed implementation to only do what the name suggests. Moved some functionality to the call site in CastActivityManager::TerminateSession, and added unit test for the remaining functionality. - Changed pure virtual methods in ActivityRecord to have no-op implementions, and removed overrides in MirroringActivityRecord: SendStopSessionMessageToClients, SendMessageToClient, SendMediaStatusToClients, ClosePresentationConnections, TerminatePresentationConnections. - Removed pure virtual methods in ActivityRecord that are only relevant to CastActivityRecord: SendAppMessageToReceiver, SendMediaRequestToReceiver, SendSetVolumeRequestToReceiver, HandleLeaveSession, AddClient, RemoveClient. Changed pointers to ActivityRecord to CastActivityRecord in numerous places (mostly in CastActivityManager) so the methods can still be called. Bug: 809249 Change-Id: I4d80cb7356b896781ba157e6e86a8070fc8104b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929085 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#730027}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9346b7c0ed1a..77141ccf844b git log 9346b7c0ed1a..77141ccf844b --date=short --first-parent --format='%ad %ae %s' 2020-01-09 tsepez@chromium.org Remove unused CXFA_FFWidgetHandler::CreateWidget(). 2020-01-09 tsepez@chromium.org Remove two impossible null-argument checks in CPDFSDK_PageView. 2020-01-09 tsepez@chromium.org Remove XFA_TRAVERSEWAY_* definitions Created with: gclient setdep -r src/third_party/pdfium@77141ccf844b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia78d6ec3e61856bb54c295626d2c27d9e40c7a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994405Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730026}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1dbb52862979..e6441b604f58 git log 1dbb52862979..e6441b604f58 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 jiawei.shao@intel.com dawn_wire: Make GetProcs() a static member function of WireClient Created with: gclient setdep -r src/third_party/dawn@e6441b604f58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:996713 Tbr: cwallez@google.com Change-Id: I0296353007a38cfb5cf680c4c24956e32abdccc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994408Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730025}
-
Ahmed Mehfooz authored
This change ensures that the message center and quick settings bubble can not be simultaneously collapsed. Also, the message center will be initially expanded and quick settings collapsed if there are notifications and restricted vertical space. Bug: 1026077, 1026271 Change-Id: If5cf58c3afd1940e69bd30f7ba28d0df93da3719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992214Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#730024}
-
Pete Williamson authored
We've added a SendFeedback menu item for the feed cards which requires syncing a protobuf format with the server. The changes have already been checked in on the server side, this changelist adds them to the client side. TGHis covers the following changes in the feed repo: https://chromium.googlesource.com/feed/+/370d27850dbcb479bf0a3f98b6761dec40ef3ff1 https://chromium.googlesource.com/feed/+/8415ae95f9d6c4b1e8f118937743c6eec95bdf20 https://chromium.googlesource.com/feed/+/38557ae96b06ffa8ca52e56540e90ad4fb9b79c1 https://chromium.googlesource.com/feed/+/ce2ad93db4d120adac692c8b53cc9e574f51dfdd https://chromium.googlesource.com/feed/+/b5279d539debbb6573592b8f28b80b292928a172 https://chromium.googlesource.com/feed/+/ebe07f69fec6980ee571771edd0d7ddf0c721880 Bug: 1040281 Change-Id: I58554c06980de3dfe500276cbc7bff2bf0bce211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993112Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#730023}
-
Manas Verma authored
If the user is opted-in, but the card they have selected is not authorized for FIDO, then we should directly show the CVC prompt without flashing the Verifying Pending Dialog. Bug: 949269 Change-Id: I5bada2553a86303d28956f29308f642cc9025ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994266 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#730022}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9ef631c223a..aed6b2e7fbd5 Created with: gclient setdep -r src-internal@aed6b2e7fbd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1015953,chromium:1023525 Tbr: jbudorick@google.com Change-Id: If9d3c24f9396fde1501282ef05a34965c191d5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994407Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730021}
-
Fabrice de Gans-Riberi authored
This reverts commit a1342aa6. Reason for revert: Broke MSAN bots: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/21649 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17229 Stack trace from crash: ==29357==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x56541d07524c in views::Label::SetBackgroundColor(unsigned int) ./../../ui/views/controls/label.cc:141:7 #1 0x5654292ce540 in IconLabelBubbleView::OnThemeChanged() ./../../chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc:308:12 #2 0x565429331693 in LocationIconView::UpdateTextVisibility(bool) ./../../chrome/browser/ui/views/location_bar/location_icon_view.cc:195:3 #3 0x56542932f4ff in LocationIconView::Update(bool) ./../../chrome/browser/ui/views/location_bar/location_icon_view.cc:214:3 #4 0x56541d29bb17 in views::View::PropagateAddNotifications(views::ViewHierarchyChangedDetails const&, bool) ./../../ui/views/view.cc:2326:5 #5 0x56541d29ba53 in views::View::PropagateAddNotifications(views::ViewHierarchyChangedDetails const&, bool) ./../../ui/views/view.cc:2322:14 #6 0x56541d2972cf in views::View::AddChildViewAtImpl(views::View*, int) ./../../ui/views/view.cc:2218:9 [...] Original change's description: > Fixed color bugs in CustomTabBarView > > Fixed CustomTabBarView to set and update its colors only once > attached to a widget, preventing the fallback to the default > NativeTheme. > > Updated CustomTabBarView to respond to theme changes. > > Removed the dependency on GetThemeProviderForProfile from > CustomTabBarView and from LocationBarView. > > Bug: None > Change-Id: If505b0bede8f112329dcef5f2a7aab9e67dcfd2e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989085 > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729904} TBR=pkasting@chromium.org,tluk@chromium.org Change-Id: I768a90892980c5522075ed7cda38e2678b797552 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994661Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#730020}
-
Olivier Li authored
This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 546640 Change-Id: I0743e2c24e68d42e962cc671139a0c17ffb127c6 Fixed: 1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991753 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#730019}
-
Olivier Li authored
This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 546640 Change-Id: I4d5d350ef28adaf572af0b94024ca4f6549a4548 Fixed: 1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993141 Commit-Queue: Oliver Li <olivierli@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#730018}
-