GitLab

Bug: 1039873
Change-Id: I114ea6f03b57911b510e449a356907207d21ac32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992163
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729507}

This patch cleans up the find request queue when the main RenderFrameHost
is removed from the FindRequestManager. This ensures that we don't try
to dispatch more requests, which causes a DCHECK.

Note that this patch only affects main frame removal, so it shouldn't
have any user-observable behavior changes.

R=creis@chromium.org

Bug: 1032576
Change-Id: I4d09ba2cf68a71213704b9d2a4a189f5ae2b5489
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988679Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729506}

Also adding new flag 'enrollToken' which allows overriding the default token

Change-Id: Idf5d5abee4b8fb885f73c046c3d1440511e35aee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988953Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Xiang Ji <jxiang@google.com>
Cr-Commit-Position: refs/heads/master@{#729505}

Using wpt-import in Chromium a498c649.
With Chromium commits locally applied on WPT:
aa30315c "Reject cookies with empty names and values."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
garykac@chromium.org, pwnall@chromium.org, jsbell@chromium.org:
  external/wpt/clipboard-apis

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Iced7a4074188879783a38305c2a5d7988a5ce196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992281Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729504}

Webviews will be explicitly sized. No need to size them by parent size.
This will allow the embedding window to be sized based on the viewport
such that it allows us to clip contents.

Bug: b/143612326
Test: Manual
Change-Id: Ie3382c094e11b31b3515c7ef3ee76e55169b7a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962980Reviewed-by: Albert Chaulk <achaulk@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729503}

If Tabswitcher is shown, we switch to HomePage which owns fakebox.

Bug: 1039467
Change-Id: I9a59c9dba89acc9a2644a12663fafaba054d0d95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989867Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Mia Glaese <glamia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729502}

The present CL moves the comment "Attempt to move a window to a
different desk" because the code "item_->SetOpacity(original_opacity_);"
is equally relevant to just dropping the window back into overview.

Bug: None
Change-Id: I9fe75292dbb85280ba89c6fdeee55982524edad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991982Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729501}

This is fairly straightforward.

Bug: 1011446
Change-Id: I75ce7abc27d51e32028c27354fa621de98d05470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990126Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729500}

Set `"shard size": 20` value in tests-config,
expecting to have 2 swarming tasks as
there are 31 test classes in ios_chrome_ui_eg2tests_module.app

Bug: 1033541
Change-Id: I2a3dba9f53bc58d8b9cc7124d795be807c93a6e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962636Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729499}

This fixes pinned extensions becoming visible and their widgets anchoring correctly when the extension is not visible because of extensions container size constraints. The effect of this change is that non-visible pinned extensions will pop in as the furthest left icon in the container and all other non-visible extensions will pop up on the right (just left of the extensions button). Once the anchored widget is dismissed, any previously non-visible icon will then disappear and the container would return to its previous state.

Bug: 995448
Change-Id: I42d9a710dc89a82706e5b8014f823cbb3ee01a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977390
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729498}

Stores in Member constructors are initializing, which means:
1) for Dikstra barrier: the source object is white and the tri-color
invariant is preserved;
2) for generational barrier: the target is older than the source and
doesn't have to be remembered.

This reduces number of executed barriers from 115M to 78M (31%) on
speedometer.

Design doc summarizing results: https://bit.ly/2QTmOly.

Bug: 1021889
Change-Id: I975afeb42eef53f583ce9bb45faf410a0914d264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991622
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729497}

This applies the CSP of the context document to any doc created by calling
DOMParser.parseFromString. The original implementation, as it returned a
pointer to the CSP instance of the context document, which (in some
circumstances) could mean that the CSP of the context document itself was
modified. This makes a copy of the context document's CSP, before assigning it
to the newly created document.

This re-reverts / re-lands
  1975710: Revert CSP application to `DOMParser.parseFromString`.
  1917532: [Trusted Types] Fix Trusted Types for other document types

Bug: 1030830, 951536
Change-Id: I33adff8c376a6f37788c9aee0ef7ca0c3441785f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980183
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729496}

Currently if user puts their mouse cursor on the top of the screen and
press F11 to enter fullscreen mode, the Exit Fullscreen X button and the
"Press [ESC] to exit fullscreen" prompt will overlap (see bug for demo).

This CL fixes this by putting the fullscreen control X button in
cooldown mode if the exit prompt is still in showing-animation. In this
case the user will need to withdraw the cursor from the top buffer area
then move it back to the top of the screen to trigger the X button.
Screen cast: https://screencast.googleplex.com/cast/NjU1MTk3NDQzMjQ3MzA4OHwzNTUxNWRmYi1kZA

A simpler alternative design would be just to suppress the X button
whenever the prompt is showing, and never bother with the cooldown mode,
but that would end up having the X button immediately pop up even if the
user just moves the cursor a little bit after the prompt is fully shown.

Bug: 1038026
Change-Id: If42517c7e87e8b9ab240ac5635f8f7cd33991447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986307Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729495}

AppCache stores cache data on and reads data from disk using async
functions across multiple interfaces.  This makes accessing the cached
data for tests cumbersome.

This CL adds an AppCacheCacheTestHelper class along with a unit test
to simplify the write and read stages of cache info and data on disk.

AppCacheCacheTestHelper will be used by a later CL that modifies
AppCacheUpdateJobTest to verify that, after a 304 request, cached
headers are correctly updated to match the server's response.  Both
the response info and the data has to be verified because our plan
is to create a new cache entry for the updated headers and we'll
want to verify that the data itself is also correctly saved in the
new AppCache cache entry.

Bug: 989611
Change-Id: Ic38880bc17e6fc2dcdbed048e2453649cde0e5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988380
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729494}

BUG=none
TEST=none

Change-Id: I42fa1f35cc3d23d6799a3edfbb9e2bfef9554abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992266
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729493}

Bug: 1039009
Change-Id: Iac72405436958fd43a0ccdc8940fca5754454bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988728Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729492}

More fields have been added to a FIDL Semantic Node. This CL adds
support for those new fields.

Test: Updated existing unit tests.

Bug: fuchsia:41000
Bug: 973095
Change-Id: I7e397875206362ebf68e65b7466f6890255322da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988160
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729491}

R=chrisha@chromium.org

Fixed: 1039223
Change-Id: I314aaaf0682dea7cb962cd247fb1430b4d7e7267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989980
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729490}

Instead, use the explicit setter on DialogDelegate. Thankfully
IDS_APP_CANCEL is already the default for ui::DIALOG_BUTTON_CANCEL :)

Bug: 1011446
Change-Id: Ifc67f637732c07137c2b65b54fbba64f2f0c77d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992189Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729489}

The test flakes regularly on both debug and release bots.

TBR=fdegans@chromium.org

Bug: 1040202
Change-Id: I0b6c822351d0646ba748fc1ce4b4809d0b1ac174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992305Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729488}

This reverts commit 8b4578d6.

Reason for revert:
This change breaks running any tests on macOS systems that do *not* already have MAC_CHROMIUM_TMPDIR set; the generated value for it if it is unset is far too long (eg on my system it is "/var/folders/yd/p_tdv3gs24904_gjb44140tc003h8w/T/.org.chromium.Chromium.VHPP1z/0"), which hits the DCHECK here: https://cs.chromium.org/chromium/src/base/files/file_util_mac.mm?type=cs&q=MAC_CHROMIUM_TMPDIR&sq=package:chromium&g=0&l=35

To repro that failure:
1) build at trunk
2) $outdir/browser_tests

Original change's description:
> Improve temp dir handling for child procs on Windows and macOS.
> 
> Tests may leak files/directories in temp due to ScopedTempDir lifetime
> issues (see linked bug) or as a result of crashes. This CL augments the
> TestLauncher to handle such leaks a bit better. When launching a child
> proc on Windows and macOS, the TestLauncher now directs that child to
> its own dedicated temporary directory. Upon child exit, the launcher
> checks for leaked files/directories in that dir and deletes the dir. On
> test iteration completion, the launcher will emit a list of the tests
> that produced leaks when run with --test-launcher-print-temp-leaks that
> looks a lot like this:
> 
> ERROR: 2 files and/or directories were left behind in the temporary directory by one or more of these tests: PaymentManagerTest.ClearPaymentInstruments:PermissionControllerImplTest.ResettingOverridesForwardsReset:PermissionControllerImplTest.SettingOverridesForwardsUpdates:PermissionControllerImplTest.RequestPermissionsDelegatesIffMissingOverrides:PermissionControllerImplTest.GetPermissionStatusDelegatesIffNoOverrides:PermissionControllerImplTest.GetPermissionStatusForFrameDelegatesIffNoOverrides:PermissionControllerImplTest.NotifyChangedSubscriptionsCallsOnChangeOnly:PermissionControllerImplTest.PermissionsCannotBeOverriddenIfNotOverridable:PermissionControllerImplTest.GrantPermissionsReturnsStatusesBeingSetIfOverridable:PictureInPictureServiceImplTest.EnterPictureInPicture
> 
> Curious developers can binary search in that short list of tests to find
> the one(s) that are leaking and clean them up.
> 
> BUG=546640
> TBR=sky@chromium.org
> 
> Change-Id: If3be7034094827979c225d2eb2beba2d92e6e7ce
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978679
> Commit-Queue: Greg Thompson <grt@chromium.org>
> Auto-Submit: Greg Thompson <grt@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#728475}

TBR=sky@chromium.org,erikchen@chromium.org,grt@chromium.org,isamsonov@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 546640
Change-Id: Ic1d52021e5505508d271f2b1932f00c3e77377be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991933Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729487}

https://webrtc.googlesource.com/src.git/+log/bd5874accf0f..28209b43f4a1

git log bd5874accf0f..28209b43f4a1 --date=short --first-parent --format='%ad %ae %s'
2020-01-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 086dd4c4..4bca0ab4 (729202:729323)
2020-01-08 jakobi@webrtc.org Remove extra delay field trial.
2020-01-08 srte@webrtc.org Moving FakeNetworkSocket to fake_network_socket_server.h
2020-01-08 srte@webrtc.org Cleanup: Removes redundant includes on message_queue.h

Created with:
  gclient setdep -r src/third_party/webrtc@28209b43f4a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ic1a5708f42e66997b8358c94c283daab743bc526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991781Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729486}

https://chromium.googlesource.com/angle/angle.git/+log/b84cdffeec6c..99c274baf503

git log b84cdffeec6c..99c274baf503 --date=short --first-parent --format='%ad %ae %s'
2020-01-08 tobine@google.com Vulkan:Roll volk

Created with:
  gclient setdep -r src/third_party/angle@99c274baf503

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I01608361bb3aeb55c2dd38ecf0335fb800ab2f3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992111Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729485}

This reverts commit 11d5c38e.

Reason for revert: Several virtual/controls-refresh/ webkit layout tests failing on Mac 10.10 More details at crbug.com/1040231

Bug: 1040231

Original change's description:
> Color control popup UI improvements
> 
> This CL updates the <input type="color"> popup UI in three related aspects per design feedback:
> 
> 1) The in-page control now updates immediately as the selected color is changed in the popup,
> instead of waiting for the popup to be dismissed.  The page can watch for these 'live' changes
> via the input event.
> 2) The UI is simplified by removal of the submit and cancel buttons.  The popup is now
> dismissed only by clicking outside of it or with the Enter or Escape keys.
> 3) A 'double-escape' model is introduced in which if a user has opened the popup and changed the
> value, hitting Escape once will reset the value back to what it was when the popup was opened.
> Hitting Escape once more, when the popup value matches the value when opened, will dismiss the
> popup.
> 
> Bug: 1001571
> Change-Id: Ifb918d5479efedb0e2fbe571d4239bc15cbcc723
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978252
> Reviewed-by: Sanket Joshi <sajos@microsoft.com>
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Commit-Queue: Dan Clark <daniec@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#729387}

TBR=hwi@chromium.org,masonfreed@chromium.org,daniec@microsoft.com,sajos@microsoft.com

Change-Id: Iebd75210a136360cf51647bf36b0d04e4a2643e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1001571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992560Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729484}

Dark mode versions are coming later

Bug: 1014143
Change-Id: I59bdbaa7c0faa7bca59507f45ea0ae9d0b7e6776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978738Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729483}

https://swiftshader.googlesource.com/SwiftShader.git/+log/7d0ce41d01de..c45e066fba2d

git log 7d0ce41d01de..c45e066fba2d --date=short --first-parent --format='%ad %ae %s'
2020-01-08 bclayton@google.com Vulkan/Debug: Add Reference value type.
2020-01-08 chrisforbes@google.com Add storage image support for R16G16_{UINT,SINT,SFLOAT}

Created with:
  gclient setdep -r src/third_party/swiftshader@c45e066fba2d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I0fdc96bf39da9109a2bd721bbb4e58aa6d42152b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992114Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729482}

Previously, it was possible to open the Assistant Web UI container and
then disable Assistant in the background which would cause our
container to persist when it should actually be destroyed.

Bug: b:147344165
Change-Id: Ia65070fb4d108efb967232f767628e91454d9f8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992312Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#729481}

https://chromium.googlesource.com/catapult.git/+log/9506caf2ea1f..a47e1e9794a7

git log 9506caf2ea1f..a47e1e9794a7 --date=short --first-parent --format='%ad %ae %s'
2020-01-08 jbudorick@chromium.org devil: add more logging on failure to kill host_forwarder.

Created with:
  gclient setdep -r src/third_party/catapult@a47e1e9794a7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1038789
Tbr: oysteine@google.com
Change-Id: I55d2f71354fa401b547ab5ddcb27ba276ec99ad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992401Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729480}

Bug: 1033962
Change-Id: Idbc5d1108a43d6de1637f40caddadfa42be005fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990334Reviewed-by: Charlene Yan <cyan@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729479}

https://skia.googlesource.com/skia.git/+log/403c80797189..5c660e0cd868

git log 403c80797189..5c660e0cd868 --date=short --first-parent --format='%ad %ae %s'
2020-01-08 mtklein@google.com Streamline skvm bilerp.
2020-01-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-08 egdaniel@google.com Reland "Move makeDeferredRenderTargetContext calls to factory on RTC."
2020-01-08 jvanverth@google.com Add method to delay drawable acquisition from MTKView
2020-01-08 rmistry@google.com Revert "Prevent de-duplication of Housekeeper-PerCommit-BuildTaskDrivers"
2020-01-08 kjlubick@google.com [canvaskit] Add webp support
2020-01-08 egdaniel@google.com Add debug gpu abandon bots and fix yuv crash.
2020-01-08 halcanary@google.com Reland "GrGLMakeNativeInterface_{iOS,mac,win}: clean up"
2020-01-08 mtklein@google.com add Brian's fiddle as gm/bicubic

Created with:
  gclient setdep -r src/third_party/skia@5c660e0cd868

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jvanverth@google.com
Change-Id: I833376a237a65446bb89e6c507ca560be9fee952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992116Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729478}

The tests use an HttpServer run over a Mojo connection, but they don't
ensure that the HttpServer has started listening for connections before
trying to establish a connection to the server over a client socket
(also used over Mojo). The tests seem to be passing, but it sometimes
times out on Fuchsia, when the HttpServer tries to accept a second
socket. This seems likely due to some other bug (possibly in the
Fuchsia socket layer), but regardless of the underlying cause, having
the test fixture wait for the server to start listening seems to make
the test consistently pass, and is something the tests should be doing
anyways.

Bug: 1032620
Change-Id: I48b57e99923189496d4e405f84a22767ca42a68a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992205Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729477}

This is just a re-organization of the expectations for
crbug/com/1035582, to make it easier to rebaseline without
merge conflicts.

TBR=schenney@chromium.org

Bug: 1035582
Change-Id: I46ac7b5fc496654cc08e9020b6b327bfbc606896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991734Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729476}

OOPIF RenderWidgets had no way to see that their RenderView was created
with a flag saying that the RenderWidget would never be visible. So we
store that flag on RenderViewImpl and give it to each RenderWidget
created thereafter. This allows RenderWidgets other than an initial
main frame one to see this flag.

Also, OOPIF child frame RenderWidgets were not being given the display
mode during creation, unlike other RenderWidgets. Make this consistent
and give the display mode.

R=dcheng@chromium.org

Bug: 419087
Change-Id: I44a25a13855c567516b813c90d195c836d90ebd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989239
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729475}

The remaining PerformanceManager.SiteInstance* metrics will end up being
identical to the various PerformanceManager.Agent* once site instance =
agent, which is part of ongoing site instance and blink isolate work. One
variant of those metrics can then be removed at that point.

Fixed:995541,1038476

Change-Id: I0a6eca14a5a857ebc2de082165cb60055269d71c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989686
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729474}

https://android.googlesource.com/platform/external/perfetto.git/+log/cce82035ba5b..7f86589d1522

git log cce82035ba5b..7f86589d1522 --date=short --first-parent --format='%ad %ae %s'
2020-01-08 fmayer@google.com Do not use recursion for walking heap graphs.

Created with:
  gclient setdep -r src/third_party/perfetto@7f86589d1522

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:147125938
Tbr: perfetto-bugs@google.com
Change-Id: I72a1c85025a5f970553eca402cf58c708aa82fcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992100Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729473}

We do not support them for now.

Screenshot:
https://drive.google.com/a/google.com/file/d/1K9s8sgchCHchh0Xv3XuXVB-9Von_DbuP/view?usp=sharing

Bug: 1028524
Change-Id: I2d83e0e93297950024d9d327132e3e1a8a8a8ba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980285Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729472}

Remove ExtensionBrowserTest::WaitForExtensionInstallError() and
ChromeExtensionTestNotificationObserver::WaitForExtensionInstallError().
The latter was only called by the former, which in turn was only called
in a single place.

Inline the (short) implementation directly into the single test that
called it. In addition to removing cruft from the (very large)
ExtensionBrowserTest interface, this also fixes a potential issue:
the proper pattern for these types of observers is:
<instantiate test observer>
<trigger behavior>
<wait with test observer>

Here, it was:
<trigger behavior>
<instantiate and wait with test observer>

This is can be racy or incorrect depending on the triggering behavior,
since it may already finish before the observer is instantiated.

Bug: None
Change-Id: If35c9faff6ac60e86b476c5064ad0d0d1dd7f739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981050
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729471}

This reverts commit eba0ee5c.

Reason for revert: Test failures on Linux CFI related to Dav1d tests. More details at crbug.com/1040107

Original change's description:
> Roll src/third_party/dav1d/libdav1d/ 940eee483..115fe773f (26 commits)
> 
> https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/940eee483a85..115fe773fe0e
> 
> $ git log 940eee483..115fe773f --date=short --no-merges --format='%ad %ae %s'
> 2020-01-07 dalecurtis Fix missing include for limits.h
> 2020-01-05 martin arm64: msac: Avoid 32 bit intermediates in symbol_adapt
> 2020-01-02 martin arm64: itx: Use sqrdmulh in the preexisting identity transform functions
> 2020-01-01 martin arm64: itx: Specialcase transforms with identity in the first pass with downshift
> 2020-01-02 martin arm64: itx: Adjust .irp in the 4x16/16x4/8x16/16x8 functions
> 2019-12-31 rsbultje Don't interleave the skip mode index finding loops
> 2020-01-01 rsbultje Prevent shift by >= 32
> 2019-12-31 rsbultje Take lossless into account when assigning loopfilter strength
> 2019-12-31 rsbultje Deal with chroma coefficients that are exactly 0x100000
> 2019-12-31 gramner x86: Fix inverse (flip)adst 8x4 clipping
> 2019-12-31 gramner Fix C inverse ADST clipping
> 2019-12-28 rsbultje av1: use chroma txtp inference over default DCT_DCT if qidx=0
> 2019-12-28 rsbultje av1: skip super-resolution upscaling if width < 16
> 2019-12-28 rsbultje av1: do C inverse transforms in int32_t precision
> 2019-12-28 mjbshaw Allow skip mode
> 2019-12-28 mjbshaw Disable warping on scaled references
> 2019-12-23 rsbultje Check skip flag before setting tx context to TX_4X4 in lossless frames
> 2019-12-18 martin Don't assume dlsym exists on linux
> 2019-12-12 gramner Linux: Add a workaround for a glibc stack size issue
> 2019-12-14 gramner x86: Disable AVX-512 by default
> 2019-12-14 gramner Fix potential race condition in dav1d_get_cpu_flags()
> 2019-12-14 gramner x86: Remove unused cpu flags
> 2019-12-14 e.m.terhoeven Add support for Ice Lake AVX-512 cpu flags
> 2019-12-13 rzumer Correct the edge buffer documentation
> 2019-12-05 ltrudeau Move lvl variable in cdef_brow to outer loop
> 2019-11-03 rsbultje Simplify shifting in generate_grain_y/uv AVX2
> 
> Created with:
>   roll-dep src/third_party/dav1d/libdav1d
> 
> Change-Id: I19174ac159addacbe3b63016ce46a30425abd4f3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989729
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#729186}

TBR=dalecurtis@chromium.org,tguilbert@chromium.org

Change-Id: I815a01f90db85775d1695de8c4feb3bdb059b4b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992212Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729470}

Extend the lifetime of the histogram until M90.

Bug: 1037001
Change-Id: I5c167a4e89187d284b1da142ec771184cf2b75e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989074Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729469}

This allows DOM Distiller's JS code to be more consistent with other
Chromium code.

Bug: 1027612
Change-Id: I837f00e68eada2b5ff0f3026b725497ac8c44a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954705
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Auto-Submit: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729468}