GitLab

These parts are not used ATM, this CL removes them until further notice.

> Add still image capture interface for VideoCaptureDevice.
>
> BUG=413086
> TEST=Run the media_unittests on peach_pit.
>
> Committed: https://crrev.com/fd5bdd2688768683e30b27941f181597a849656d
> Cr-Commit-Position: refs/heads/master@{#298009}

TBR=posciak@chromium.org, perkj@chromium.org, tommi@chromium.org

BUG=413086, 440843

Review URL: https://codereview.chromium.org/921683004

Cr-Commit-Position: refs/heads/master@{#318183}

The CL dumps event logs for devices that run with the CrOS
gesture library. It is designed to be backward-compatible
with the X11 behaviour.

Contributed by sheckylin@chromium.org

BUG=450159
TEST=samus ChromeOS build

Review URL: https://codereview.chromium.org/893753002

Cr-Commit-Position: refs/heads/master@{#318182}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1175397..ef73ddc

TBR=arv@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/960013003

Cr-Commit-Position: refs/heads/master@{#318181}

This should get most of NaCl and the PPAPI stuff needed
for NaCl building and linking. There is more work to be
done to get some of the test binaries working (and
probably fill out parts of the NaCl SDK) and possibly
some pnacl support work remaining as well.

NaCl is still disabled by default (set enable_nacl=true
to change). Enabling nacl is still mostly untested and
likely doesn't work at all :).

R=ncbray@chromium.org, brettw@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/877553008

Cr-Commit-Position: refs/heads/master@{#318180}

BUG=459693
TEST=manually tested

Review URL: https://codereview.chromium.org/954113004

Cr-Commit-Position: refs/heads/master@{#318179}

This removes NOTIFICATION_PROFILE_CACHED_INFO_CHANGED and
NOTIFICATION_PROFILE_CACHE_PICTURE_SAVED notifications from all the
things.

This is part of the long process of killing the NotificationService with fire. In
particular, this ProfileInfoCache notification is terrible because it's incredibly
generic, gets shouted out any time *anything* happens to *any* profile, and
a bunch of things in Chrome listen to it, when in fact they care about very
specific profile notifications (i.e. has a name been changed, has a user been
added)

BUG=454845
TEST=All tests should pass. Chrome shouldn't behave weirdly. Everyone should
get a pony.

Review URL: https://codereview.chromium.org/895803003

Cr-Commit-Position: refs/heads/master@{#318178}

This test was disabled on Windows due to flakiness. I ran it locally & on the try jobs, and neither gave any flakes, therefore, this CL re-enables the test.

BUG=375538

Review URL: https://codereview.chromium.org/948733002

Cr-Commit-Position: refs/heads/master@{#318177}

Revert of Unload the ScopedGaiaAuthExtension asynchronously. (patchset #2 id:20001 of https://codereview.chromium.org/961443003/)

Reason for revert:
Broke BookmarkSyncPromoControllerTest.SignInLink on Mac ASan 64: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/7363

Original issue's description:
> Unload the ScopedGaiaAuthExtension asynchronously.
>
> If we don't do this, then we have a race condition between unloading
> this extension, and trying to use it because we have manually
> navigated to it.
>
> BUG=460431
>
> Committed: https://crrev.com/1805c4c5c4b5292cca51a54f379cde498db7238b
> Cr-Commit-Position: refs/heads/master@{#318140}

TBR=xiyuan@chromium.org,noms@google.com,noms@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460431

Review URL: https://codereview.chromium.org/944923007

Cr-Commit-Position: refs/heads/master@{#318176}

Revert of [Telemetry] Pass test_runner environment in local args instead of a global variable (patchset #9 id:160001 of https://codereview.chromium.org/942663002/)

Reason for revert:
crbug.com/462063

Original issue's description:
> [Telemetry] Pass test_runner environment in local args instead of a global variable
>
> Also adds more fields to environment to narrow the scope of
> benchmark and user story set discovery. This should avoid problems
> with adding Python files to unrelated directories, and hides PageTests
> from external Telemetry benchmark runners like run_gpu_tests.py and
> chrome_proxy's run_benchmark.
>
> R=dtu,nednguyen,sullivan,kbr@chromium.org,bolian
> BUG=460181
> TEST=tools/perf/run_benchmark; content/test/gpu/run_gpu_tests.py; tools/chrome_proxy/run_benchmark  # All return a full and correct test list.
>
> Committed: https://crrev.com/1da5f7f70ea6dc7dd0667ea78637802c76305f5a
> Cr-Commit-Position: refs/heads/master@{#318149}

TBR=bolian@chromium.org,dtu@chromium.org,kbr@chromium.org,nednguyen@google.com,sullivan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460181

Review URL: https://codereview.chromium.org/955183003

Cr-Commit-Position: refs/heads/master@{#318175}

GPUTiming is our abstraction layer for various GL timing extensions. It
makes more sense for this abstraction layer to be owned by GLContext
instead. Clients that want to do GPU Timing calls (GPUTracer, eventual
support of WebGL tracer calls).

One of the main reasons for this differentiation is to support disjoint
queries across multiple virtual contexts. The actual support of this
will be completed in another CL.

BUG=451211
TEST=trybots

Review URL: https://codereview.chromium.org/937263006

Cr-Commit-Position: refs/heads/master@{#318174}

BUG=462044

Review URL: https://codereview.chromium.org/956623010

Cr-Commit-Position: refs/heads/master@{#318173}

On Mac, interpreting a tab keypress into an action message calls
[NSResponder insertTab]. [RenderWidgetHostViewCocoa
doCommandBySelector:] has for a long time had a check that skips
converting any action message whose selector starts with "insert" into
an editing command, and just treats it as a regular keypress instead.

This approach also works well for UI in MacViews, so do the same.

Theoretically a user could remap a different key or key combination to
the 'insertTab' action message, but that's unlikely.

Updates TextfieldTest.FocusTraversalTest with cross-platform checks to
test for this case. Also tested manually with views_examples.

For the test to work with the approach in this CL, the event simulator
needs to provide an answer for -[NSApplication currentEvent], so that's
done too.

BUG=454353

Review URL: https://codereview.chromium.org/951433002

Cr-Commit-Position: refs/heads/master@{#318172}

BUG=461504

Review URL: https://codereview.chromium.org/952213006

Cr-Commit-Position: refs/heads/master@{#318171}

Modifies pepper_hash_for_uma to sort the output by hash, so it's
easier to compare against the histogram.xml file when searching
for missing hashes.

I used the following script to get an API list from src/ppapi:

grep -r "PPB_" ppapi/c | grep -o "\".*;[0-9]\.[0-9]*\"" | tr '\n' ' '

BUG=
R=asvitkine@chromium.org, dmichael@chromium.org

Review URL: https://codereview.chromium.org/938283004

Cr-Commit-Position: refs/heads/master@{#318170}

BUG=457659,454416

Review URL: https://codereview.chromium.org/926193005

Cr-Commit-Position: refs/heads/master@{#318169}

The OnSessionRestore callback has been changed to accept the number
of tabs as an argument.

BUG=chromium:455482
TEST=Add logging to make sure the correct number of tabs is being
passed to perf provider during session restore
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/902613003

Cr-Commit-Position: refs/heads/master@{#318168}

R=maruel@chromium.org
TBR=jam@chromium.org
BUG=98637

Review URL: https://codereview.chromium.org/958733002

Cr-Commit-Position: refs/heads/master@{#318167}

This can happen temporarily on compositor creation, so ensure a surface is created before attempting to use it.

BUG=461569,461491

Review URL: https://codereview.chromium.org/949413002

Cr-Commit-Position: refs/heads/master@{#318166}

TODO: I think my plan for masked cards is to rank them just below the worst ranked unmasked card, but not above any local card that's been used at least 5 times. That way they'll start near the top, but eventually filter down to the bottom (unless you unlock them), while staying above cards you've used zero times.

For wallet addresses, perhaps stick them just below the worst ranked "complete" local address. A "complete" address is defined by addressinput::HasAllRequiredFields.

BUG=342426

Review URL: https://codereview.chromium.org/947693002

Cr-Commit-Position: refs/heads/master@{#318165}

This will allow us to use ChromeNativeAppWindowViews as a base
for ChromeNativeAppWindowViewsMac.

BUG=459877

Review URL: https://codereview.chromium.org/947343003

Cr-Commit-Position: refs/heads/master@{#318164}

This brings the context menu options closer to what is in the App
Launcher, and hides the webstore link in cases where it shouldn't be
shown to the user. This change is ignored on Mac.

BUG=449095

Review URL: https://codereview.chromium.org/899173002

Cr-Commit-Position: refs/heads/master@{#318163}

Currently type WiMAX fails ONC validation so any property
changes from Settings are ignored.

This also fixes the Cellular translation and adds both Cellular and WiMAX to the validation tests.

BUG=460829

Review URL: https://codereview.chromium.org/949783003

Cr-Commit-Position: refs/heads/master@{#318162}

Review URL: https://codereview.chromium.org/959863004

Cr-Commit-Position: refs/heads/master@{#318161}

Testing shows that this change is correct, but there was no evidence supporting the other change. Will manually run the x64 dbg test try bot for this change.

TBR=thakis@chromium.org,jvoung@chromium.org
BUG=458690,460563

Review URL: https://codereview.chromium.org/942003008

Cr-Commit-Position: refs/heads/master@{#318160}

BUG=none

Review URL: https://codereview.chromium.org/953163002

Cr-Commit-Position: refs/heads/master@{#318159}

See https://codereview.chromium.org/958693004

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/955183002

Cr-Commit-Position: refs/heads/master@{#318158}

Host:port can be resolved from service name.
Still old method is useful when client already know them.

BUG=461504

Review URL: https://codereview.chromium.org/948283005

Cr-Commit-Position: refs/heads/master@{#318157}

Cast will use NetworkChangeNotifierLinux. This commit also fixes a
some logging messages and tear down in ConnectivityChecker.

R=gunsch@chromium.org
BUG=391064

Review URL: https://codereview.chromium.org/960693002

Cr-Commit-Position: refs/heads/master@{#318156}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bacacfe..1175397

TBR=arv@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/957863002

Cr-Commit-Position: refs/heads/master@{#318155}

In order to prepare for future changes where additional metrics
will be added to the TBM module, I have also preemptively added a
filter function which filters out values relating to gpu_times.

R=nednguyen@chromium.org
BUG=455292, 453131

Review URL: https://codereview.chromium.org/959983002

Cr-Commit-Position: refs/heads/master@{#318154}

BUG=266140

Review URL: https://codereview.chromium.org/880083004

Cr-Commit-Position: refs/heads/master@{#318153}

With the brand new Compositing display items, we no longer need these
transparency methods. This patch depends on a blink-side patch:
https://codereview.chromium.org/953143003.

Review URL: https://codereview.chromium.org/956813002

Cr-Commit-Position: refs/heads/master@{#318152}

This CL mainly converts from using positional parameters to a single
struct, but there are various other changes as well.

The functions corresponding to different HTTP methods have been
eliminated, and the "doMethod" function has been renamed "start".
Saving one parameter at each call site seemed like a poor tradeoff for
having four functions that differ only in the HTTP method they use.

The core logic of creating an XHR and arranging for the onDone
function to be called has been factored out into a separate function,
startInternal_.

The "parameters" argument has been replaced by separate urlParams and
content arguments.  This eliminates the need to heuristically decide
what to do with the parmameters based on the HTTP method, and it
allows URL parameters and body content to be included in the same
call, a case which occurs in practice in host_controller.js.

There are now three parameters for sepecifying different types of body
content: textContent, formContent, and jsonContent.  They have
different data types, and the formContent and jsonContent parameters
implicitly set the Content-type header to the correct value.

A new parameter, oauthToken, is a convenience for adding a
correctly-formatted Authorization header.  This formatting was
previously duplicated at five seperate call sites.

The string "OAuth" in Authorization headers has been replaced with
"Bearer". The OAuth 2 spec supports the use of "Bearer" but not
"OAuth".

There are no longer any instances where headers are specified
explicitly, but the ability to do so still exists in the API.

Finally, headers and urlParameters with the value null are accepted
but not included in the HTTP request.  This simplifies the logic of
the doRegisterHost function in host_controller.js.

BUG=

Review URL: https://codereview.chromium.org/945033002

Cr-Commit-Position: refs/heads/master@{#318151}

Drivers may establish minimum sizes for the modesetting buffers. Since
cursor buffers are treated differently by the DRM API, they do not
require to be registered. Registering them on drivers with tight lower
bounds will fail since cursor buffers tend to be small.

BUG=none

Review URL: https://codereview.chromium.org/959953002

Cr-Commit-Position: refs/heads/master@{#318150}

Also adds more fields to environment to narrow the scope of
benchmark and user story set discovery. This should avoid problems
with adding Python files to unrelated directories, and hides PageTests
from external Telemetry benchmark runners like run_gpu_tests.py and
chrome_proxy's run_benchmark.

R=dtu,nednguyen,sullivan,kbr@chromium.org,bolian
BUG=460181
TEST=tools/perf/run_benchmark; content/test/gpu/run_gpu_tests.py; tools/chrome_proxy/run_benchmark  # All return a full and correct test list.

Review URL: https://codereview.chromium.org/942663002

Cr-Commit-Position: refs/heads/master@{#318149}

BUG=460741

Review URL: https://codereview.chromium.org/954053004

Cr-Commit-Position: refs/heads/master@{#318148}

As we're planning to intercept the _heap_init and _heap_term function to control which heap gets used by the crt we need to make sure that libcmt doesn't get patched.

R=chrisha@chromium.org
BUG=

Review URL: https://codereview.chromium.org/952183003

Cr-Commit-Position: refs/heads/master@{#318147}

Both args are not neccecary as state, so they don't need to be in the
constructor.

BUG=461504

Review URL: https://codereview.chromium.org/948413006

Cr-Commit-Position: refs/heads/master@{#318146}

Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/b180ee9..09bdb2a

BUG=none

Review URL: https://codereview.chromium.org/952293002

Cr-Commit-Position: refs/heads/master@{#318145}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/63d0024..37a6107

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/956903004

Cr-Commit-Position: refs/heads/master@{#318144}